slither/tests/expected_json/reentrancy.reentrancy-eth.txt

[91m
Reentrancy in Reentrancy.withdrawBalance() (tests/reentrancy.sol#14-21):
	External calls:
	- ! (msg.sender.call.value(userBalance[msg.sender])()) (tests/reentrancy.sol#17)
	State variables written after the call(s):
	- userBalance[msg.sender] = 0 (tests/reentrancy.sol#20)
Reentrancy in Reentrancy.withdrawBalance_nested() (tests/reentrancy.sol#64-70):
	External calls:
	- msg.sender.call.value(amount / 2)() (tests/reentrancy.sol#67)
	State variables written after the call(s):
	- userBalance[msg.sender] = 0 (tests/reentrancy.sol#68)
Reference: https://github.com/crytic/slither/wiki/Detector-Documentation#reentrancy-vulnerabilities[0m
tests/reentrancy.sol analyzed (3 contracts with 1 detectors), 2 result(s) found
[94mUse https://crytic.io/ to get access to additional detectors and Github integration[0m
-												API break: generate_json_result takes a list as input, instead of a str

The list can contains str, or any elements that can be converted to a str with source mapping
Ex: Variable, Contract, Event, Function, ..
generate_json_result will automatically add the elements to the json.
As a result, detectors only need to add the elements to the info list, and do not need to add the element
to the json.

AbstractDetectors has a STANDARD_JSON parameter, if set to False, generate_json_result will not add the elements to the json

											
										
										
											5 years ago
+								[91m
-												Merge branch 'dev' into dev-fix-c3-linearalization

 Conflicts:
	slither/core/declarations/structure.py
	slither/core/variables/state_variable.py
	slither/detectors/abstract_detector.py
	slither/detectors/attributes/const_functions.py
	slither/detectors/erc/incorrect_erc20_interface.py
	slither/detectors/erc/unindexed_event_parameters.py
	slither/detectors/naming_convention/naming_convention.py
	slither/detectors/operations/unused_return_values.py
	slither/detectors/statements/calls_in_loop.py
	slither/detectors/statements/incorrect_strict_equality.py
	slither/detectors/statements/tx_origin.py
	slither/detectors/variables/possible_const_state_variables.py
	slither/detectors/variables/unused_state_variables.py
	slither/slithir/convert.py

											
										
										
											6 years ago
+								Reentrancy in Reentrancy.withdrawBalance() (tests/reentrancy.sol#14-21):
-												Improve travis tests:
        - export json with indent=2
        - export .txt file with direct slither output content

											
										
										
											6 years ago
+									External calls:
-												Fix incorrect source mapping on if/while/for condition (close #245)

											
										
										
											6 years ago
+									- ! (msg.sender.call.value(userBalance[msg.sender])()) (tests/reentrancy.sol#17)
-												Improve travis tests:
        - export json with indent=2
        - export .txt file with direct slither output content

											
										
										
											6 years ago
+									State variables written after the call(s):
-												Refactor reentrancy to show where are the calls/write to variables in internal calls (fix #412)

											
										
										
											5 years ago
+									- userBalance[msg.sender] = 0 (tests/reentrancy.sol#20)
-												Merge branch 'dev' into dev-fix-c3-linearalization

 Conflicts:
	slither/core/declarations/structure.py
	slither/core/variables/state_variable.py
	slither/detectors/abstract_detector.py
	slither/detectors/attributes/const_functions.py
	slither/detectors/erc/incorrect_erc20_interface.py
	slither/detectors/erc/unindexed_event_parameters.py
	slither/detectors/naming_convention/naming_convention.py
	slither/detectors/operations/unused_return_values.py
	slither/detectors/statements/calls_in_loop.py
	slither/detectors/statements/incorrect_strict_equality.py
	slither/detectors/statements/tx_origin.py
	slither/detectors/variables/possible_const_state_variables.py
	slither/detectors/variables/unused_state_variables.py
	slither/slithir/convert.py

											
										
										
											6 years ago
+								Reentrancy in Reentrancy.withdrawBalance_nested() (tests/reentrancy.sol#64-70):
-												Improve travis tests:
        - export json with indent=2
        - export .txt file with direct slither output content

											
										
										
											6 years ago
+									External calls:
 									- msg.sender.call.value(amount / 2)() (tests/reentrancy.sol#67)
 									State variables written after the call(s):
-												Refactor reentrancy to show where are the calls/write to variables in internal calls (fix #412)

											
										
										
											5 years ago
+									- userBalance[msg.sender] = 0 (tests/reentrancy.sol#68)
-												Improve travis tests:
        - export json with indent=2
        - export .txt file with direct slither output content

											
										
										
											6 years ago
+								Reference: https://github.com/crytic/slither/wiki/Detector-Documentation#reentrancy-vulnerabilities[0m
-												Refactor reentrancy to show where are the calls/write to variables in internal calls (fix #412)

											
										
										
											5 years ago
+								tests/reentrancy.sol analyzed (3 contracts with 1 detectors), 2 result(s) found
 								[94mUse https://crytic.io/ to get access to additional detectors and Github integration[0m