From 1d278f520cd8b5eb8bb07f706e0bdf151e9242e6 Mon Sep 17 00:00:00 2001
From: Josselin <josselin@trailofbits.com>
Date: Mon, 14 Jan 2019 09:03:07 +0100
Subject: [PATCH] Add missing testcase

---
 tests/incorrect_equality.sol | 136 +++++++++++++++++++++++++++++++++++
 1 file changed, 136 insertions(+)
 create mode 100644 tests/incorrect_equality.sol

diff --git a/tests/incorrect_equality.sol b/tests/incorrect_equality.sol
new file mode 100644
index 000000000..d37d0663d
--- /dev/null
+++ b/tests/incorrect_equality.sol
@@ -0,0 +1,136 @@
+contract ERC20Function{
+    function balanceOf(address _owner) external returns(uint);
+}
+
+contract ERC20Variable{
+    mapping(address => uint) public balanceOf;
+}
+
+
+contract ERC20TestBalance{
+
+
+    function good0(ERC20Function erc) external{
+        require(erc.balanceOf(msg.sender) > 0);
+    }
+
+    function good1(ERC20Variable erc) external{
+        require(erc.balanceOf(msg.sender) > 0);
+    }
+
+    function bad0(ERC20Function erc) external{
+        require(erc.balanceOf(address(this)) == 10);
+    }
+
+    function bad1(ERC20Variable erc) external{
+        require(erc.balanceOf(msg.sender) ==10);
+    }
+}
+
+contract TestContractBalance {
+
+    function bad0() external {
+        require(address(address(this)).balance == 10 ether);
+        msg.sender.transfer(0.1 ether);
+    }
+
+    function bad1() external {
+        require(10 ether == address(address(this)).balance);
+        msg.sender.transfer(0.1 ether);
+    }
+
+    function bad2() external {
+        require(address(this).balance == 10 ether);
+        msg.sender.transfer(0.1 ether);
+    }
+
+    function bad3() external {
+        require(10 ether == address(this).balance);
+        msg.sender.transfer(0.1 ether);
+    }
+
+    function bad4() external {
+        uint256 balance = address(this).balance;
+        if (balance == 10 ether) {
+            msg.sender.transfer(0.1 ether);
+        }
+    }
+
+    function bad5() external {
+        uint256 balance = address(this).balance;
+        if (10 ether == balance) {
+            msg.sender.transfer(0.1 ether);
+        }
+    }
+
+    function bad6() external {
+        uint256 balance = address(address(this)).balance;
+        if (balance == 10 ether) {
+            msg.sender.transfer(0.1 ether);
+        }
+    }
+
+    function myfunc(uint256 balance) pure internal returns (uint256) {
+        return balance - balance;
+    }
+
+    function good1() external {
+        require (address(address(this)).balance >= 10 ether);
+        msg.sender.transfer(0.1 ether);
+    }
+
+    function good2() external {
+        require (10 <= address(address(this)).balance);
+        msg.sender.transfer(0.1 ether);
+    }
+
+    function good3() external {
+        require (address(this).balance >= 10 ether);
+        msg.sender.transfer(0.1 ether);
+    }
+
+    function good4() external {
+        require (10 <= address(this).balance);
+        msg.sender.transfer(0.1 ether);
+    }
+
+}
+
+contract TestSolidityKeyword{
+
+    function good0() external{
+        require(now > 0);
+    }
+
+    function good1() external{
+        require(block.number > 0);
+    }
+
+    function good2() external{
+        require(block.timestamp > 0);
+    }
+
+    function good3(uint param) public{
+        // address(this) simulate a particular corner case
+        // where the SSA is better
+        // the naive data dependency without SSA
+        // will consider param and block.number to have a dep
+        if(param == 0){
+            param = block.number;
+        }
+    }
+
+    function bad0() external{
+        require(now ==  0);
+    }
+
+    function bad1() external{
+        require(block.number== 0);
+    }
+
+    function bad2() external{
+        require(block.number == 0);
+    }
+
+}
+