Merge pull request #1387 from crytic/dev-modifier-virtual

Improve support for virtual modifier
2 years ago · 8c01f9597c
parent 6ee3adf0a4 7951ec1c4e
commit 8c01f9597c
225 changed files with 394 additions and 3 deletions
--- a/slither/solc_parsing/declarations/modifier.py
+++ b/slither/solc_parsing/declarations/modifier.py
@ -62,7 +62,7 @@ class ModifierSolc(FunctionSolc):
        self._content_was_analyzed = True

        if self.is_compact_ast:
-            body = self._functionNotParsed["body"]
+            body = self._functionNotParsed.get("body", None)

            if body and body[self.get_key()] == "Block":
                self._function.is_implemented = True
--- a/tests/ast-parsing/compile/modifier-0.7.0.sol-0.7.0-compact.zip
+++ b/tests/ast-parsing/compile/modifier-0.7.0.sol-0.7.0-compact.zip
--- a/tests/ast-parsing/compile/modifier-0.7.0.sol-0.7.0-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-0.7.0.sol-0.7.0-legacy.zip
--- a/tests/ast-parsing/compile/modifier-0.7.0.sol-0.7.1-compact.zip
+++ b/tests/ast-parsing/compile/modifier-0.7.0.sol-0.7.1-compact.zip
--- a/tests/ast-parsing/compile/modifier-0.7.0.sol-0.7.1-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-0.7.0.sol-0.7.1-legacy.zip
--- a/tests/ast-parsing/compile/modifier-0.7.0.sol-0.7.2-compact.zip
+++ b/tests/ast-parsing/compile/modifier-0.7.0.sol-0.7.2-compact.zip
--- a/tests/ast-parsing/compile/modifier-0.7.0.sol-0.7.2-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-0.7.0.sol-0.7.2-legacy.zip
--- a/tests/ast-parsing/compile/modifier-0.7.0.sol-0.7.3-compact.zip
+++ b/tests/ast-parsing/compile/modifier-0.7.0.sol-0.7.3-compact.zip
--- a/tests/ast-parsing/compile/modifier-0.7.0.sol-0.7.3-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-0.7.0.sol-0.7.3-legacy.zip
--- a/tests/ast-parsing/compile/modifier-0.7.0.sol-0.7.4-compact.zip
+++ b/tests/ast-parsing/compile/modifier-0.7.0.sol-0.7.4-compact.zip
--- a/tests/ast-parsing/compile/modifier-0.7.0.sol-0.7.4-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-0.7.0.sol-0.7.4-legacy.zip
--- a/tests/ast-parsing/compile/modifier-0.7.0.sol-0.7.5-compact.zip
+++ b/tests/ast-parsing/compile/modifier-0.7.0.sol-0.7.5-compact.zip
--- a/tests/ast-parsing/compile/modifier-0.7.0.sol-0.7.5-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-0.7.0.sol-0.7.5-legacy.zip
--- a/tests/ast-parsing/compile/modifier-0.7.0.sol-0.7.6-compact.zip
+++ b/tests/ast-parsing/compile/modifier-0.7.0.sol-0.7.6-compact.zip
--- a/tests/ast-parsing/compile/modifier-0.7.0.sol-0.7.6-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-0.7.0.sol-0.7.6-legacy.zip
--- a/tests/ast-parsing/compile/modifier-0.7.0.sol-0.8.0-compact.zip
+++ b/tests/ast-parsing/compile/modifier-0.7.0.sol-0.8.0-compact.zip
--- a/tests/ast-parsing/compile/modifier-0.7.0.sol-0.8.1-compact.zip
+++ b/tests/ast-parsing/compile/modifier-0.7.0.sol-0.8.1-compact.zip
--- a/tests/ast-parsing/compile/modifier-0.7.0.sol-0.8.10-compact.zip
+++ b/tests/ast-parsing/compile/modifier-0.7.0.sol-0.8.10-compact.zip
--- a/tests/ast-parsing/compile/modifier-0.7.0.sol-0.8.11-compact.zip
+++ b/tests/ast-parsing/compile/modifier-0.7.0.sol-0.8.11-compact.zip
--- a/tests/ast-parsing/compile/modifier-0.7.0.sol-0.8.12-compact.zip
+++ b/tests/ast-parsing/compile/modifier-0.7.0.sol-0.8.12-compact.zip
--- a/tests/ast-parsing/compile/modifier-0.7.0.sol-0.8.13-compact.zip
+++ b/tests/ast-parsing/compile/modifier-0.7.0.sol-0.8.13-compact.zip
--- a/tests/ast-parsing/compile/modifier-0.7.0.sol-0.8.14-compact.zip
+++ b/tests/ast-parsing/compile/modifier-0.7.0.sol-0.8.14-compact.zip
--- a/tests/ast-parsing/compile/modifier-0.7.0.sol-0.8.15-compact.zip
+++ b/tests/ast-parsing/compile/modifier-0.7.0.sol-0.8.15-compact.zip
--- a/tests/ast-parsing/compile/modifier-0.7.0.sol-0.8.2-compact.zip
+++ b/tests/ast-parsing/compile/modifier-0.7.0.sol-0.8.2-compact.zip
--- a/tests/ast-parsing/compile/modifier-0.7.0.sol-0.8.3-compact.zip
+++ b/tests/ast-parsing/compile/modifier-0.7.0.sol-0.8.3-compact.zip
--- a/tests/ast-parsing/compile/modifier-0.7.0.sol-0.8.4-compact.zip
+++ b/tests/ast-parsing/compile/modifier-0.7.0.sol-0.8.4-compact.zip
--- a/tests/ast-parsing/compile/modifier-0.7.0.sol-0.8.5-compact.zip
+++ b/tests/ast-parsing/compile/modifier-0.7.0.sol-0.8.5-compact.zip
--- a/tests/ast-parsing/compile/modifier-0.7.0.sol-0.8.6-compact.zip
+++ b/tests/ast-parsing/compile/modifier-0.7.0.sol-0.8.6-compact.zip
--- a/tests/ast-parsing/compile/modifier-0.7.0.sol-0.8.7-compact.zip
+++ b/tests/ast-parsing/compile/modifier-0.7.0.sol-0.8.7-compact.zip
--- a/tests/ast-parsing/compile/modifier-0.7.0.sol-0.8.8-compact.zip
+++ b/tests/ast-parsing/compile/modifier-0.7.0.sol-0.8.8-compact.zip
--- a/tests/ast-parsing/compile/modifier-0.7.0.sol-0.8.9-compact.zip
+++ b/tests/ast-parsing/compile/modifier-0.7.0.sol-0.8.9-compact.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.0-compact.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.0-compact.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.0-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.0-legacy.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.1-compact.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.1-compact.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.1-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.1-legacy.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.10-compact.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.10-compact.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.10-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.10-legacy.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.11-compact.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.11-compact.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.11-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.11-legacy.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.12-compact.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.12-compact.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.12-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.12-legacy.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.13-compact.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.13-compact.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.13-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.13-legacy.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.14-compact.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.14-compact.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.14-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.14-legacy.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.15-compact.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.15-compact.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.15-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.15-legacy.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.16-compact.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.16-compact.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.16-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.16-legacy.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.17-compact.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.17-compact.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.17-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.17-legacy.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.18-compact.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.18-compact.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.18-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.18-legacy.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.19-compact.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.19-compact.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.19-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.19-legacy.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.2-compact.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.2-compact.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.2-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.2-legacy.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.20-compact.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.20-compact.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.20-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.20-legacy.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.21-compact.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.21-compact.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.21-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.21-legacy.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.22-compact.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.22-compact.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.22-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.22-legacy.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.23-compact.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.23-compact.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.23-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.23-legacy.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.24-compact.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.24-compact.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.24-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.24-legacy.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.25-compact.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.25-compact.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.25-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.25-legacy.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.26-compact.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.26-compact.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.26-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.26-legacy.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.3-compact.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.3-compact.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.3-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.3-legacy.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.4-compact.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.4-compact.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.4-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.4-legacy.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.5-compact.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.5-compact.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.5-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.5-legacy.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.6-compact.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.6-compact.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.6-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.6-legacy.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.7-compact.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.7-compact.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.7-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.7-legacy.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.8-compact.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.8-compact.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.8-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.8-legacy.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.9-compact.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.9-compact.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.4.9-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.4.9-legacy.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.5.0-compact.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.5.0-compact.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.5.0-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.5.0-legacy.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.5.1-compact.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.5.1-compact.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.5.1-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.5.1-legacy.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.5.10-compact.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.5.10-compact.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.5.10-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.5.10-legacy.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.5.11-compact.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.5.11-compact.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.5.11-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.5.11-legacy.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.5.12-compact.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.5.12-compact.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.5.12-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.5.12-legacy.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.5.13-compact.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.5.13-compact.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.5.13-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.5.13-legacy.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.5.14-compact.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.5.14-compact.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.5.14-legacy.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.5.14-legacy.zip
--- a/tests/ast-parsing/compile/modifier-all.sol-0.5.15-compact.zip
+++ b/tests/ast-parsing/compile/modifier-all.sol-0.5.15-compact.zip
--- a/Show More
+++ b/Show More