From bb057c1435da4d5ad5f065aa87405408f513be3b Mon Sep 17 00:00:00 2001 From: David Pokora Date: Mon, 7 Jan 2019 14:48:14 -0500 Subject: [PATCH] Fixed an issue in external-functions detector that iterated on a contract instead of its function properties. --- slither/detectors/functions/external_function.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/slither/detectors/functions/external_function.py b/slither/detectors/functions/external_function.py index 6b39f6273..20cc95cfa 100644 --- a/slither/detectors/functions/external_function.py +++ b/slither/detectors/functions/external_function.py @@ -143,7 +143,7 @@ class ExternalFunction(AbstractDetector): sources_with_dynamic_calls = set(all_possible_sources) & dynamic_call_contracts if sources_with_dynamic_calls: functions_in_dynamic_call_sources = set([f for dyn_contract in sources_with_dynamic_calls - for f in dyn_contract if not f.is_constructor]) + for f in dyn_contract.functions if not f.is_constructor]) completed_functions = completed_functions.union(functions_in_dynamic_call_sources) continue