From d4adca66dacf1363a32b8da3f10c76f19be70e06 Mon Sep 17 00:00:00 2001 From: Ardis Lu Date: Mon, 14 Nov 2022 22:13:02 -0800 Subject: [PATCH] Remove unnecessary uppercase check --- .../naming_convention/naming_convention.py | 29 +++++++++---------- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/slither/detectors/naming_convention/naming_convention.py b/slither/detectors/naming_convention/naming_convention.py index 706f4ae6c..177eaaf25 100644 --- a/slither/detectors/naming_convention/naming_convention.py +++ b/slither/detectors/naming_convention/naming_convention.py @@ -119,22 +119,21 @@ Solidity defines a [naming convention](https://solidity.readthedocs.io/en/v0.4.2 for var in contract.state_variables_declared: if self.should_avoid_name(var.name): - if not self.is_upper_case_with_underscores(var.name): - info = [ - "Variable ", - var, - " used l, O, I, which should not be used\n", - ] + info = [ + "Variable ", + var, + " used l, O, I, which should not be used\n", + ] - res = self.generate_result(info) - res.add( - var, - { - "target": "variable", - "convention": "l_O_I_should_not_be_used", - }, - ) - results.append(res) + res = self.generate_result(info) + res.add( + var, + { + "target": "variable", + "convention": "l_O_I_should_not_be_used", + }, + ) + results.append(res) if var.is_constant is True: # For ERC20 compatibility