mirror of https://github.com/crytic/slither
Josselin
6 years ago
commit
d962ddeb5b
@ -0,0 +1,7 @@ |
||||
""" |
||||
This module import all slither exceptions |
||||
""" |
||||
from slither.slithir.exceptions import SlithIRError |
||||
from slither.solc_parsing.exceptions import ParsingError, ParsingContractNotFound, ParsingNameReuse |
||||
from slither.core.exceptions import SlitherCoreError |
||||
from slither.exceptions import SlitherException |
||||
@ -0,0 +1,3 @@ |
||||
from slither.exceptions import SlitherException |
||||
|
||||
class SlitherCoreError(SlitherException): pass |
||||
@ -1,8 +1,53 @@ |
||||
from .variable import Variable |
||||
from slither.core.children.child_contract import ChildContract |
||||
from slither.utils.type import export_nested_types_from_variable |
||||
|
||||
class StateVariable(ChildContract, Variable): |
||||
|
||||
################################################################################### |
||||
################################################################################### |
||||
# region Signature |
||||
################################################################################### |
||||
################################################################################### |
||||
|
||||
@property |
||||
def signature(self): |
||||
""" |
||||
Return the signature of the state variable as a function signature |
||||
:return: (str, list(str), list(str)), as (name, list parameters type, list return values type) |
||||
""" |
||||
return self.name, [str(x) for x in export_nested_types_from_variable(self)], self.type |
||||
|
||||
@property |
||||
def signature_str(self): |
||||
""" |
||||
Return the signature of the state variable as a function signature |
||||
:return: str: func_name(type1,type2) returns(type3) |
||||
""" |
||||
name, parameters, returnVars = self.signature |
||||
return name+'('+','.join(parameters)+') returns('+','.join(returnVars)+')' |
||||
|
||||
# endregion |
||||
################################################################################### |
||||
################################################################################### |
||||
# region Name |
||||
################################################################################### |
||||
################################################################################### |
||||
|
||||
@property |
||||
def canonical_name(self): |
||||
return '{}:{}'.format(self.contract.name, self.name) |
||||
|
||||
@property |
||||
def full_name(self): |
||||
""" |
||||
Return the name of the state variable as a function signaure |
||||
str: func_name(type1,type2) |
||||
:return: the function signature without the return values |
||||
""" |
||||
name, parameters, _ = self.signature |
||||
return name+'('+','.join(parameters)+')' |
||||
|
||||
# endregion |
||||
################################################################################### |
||||
################################################################################### |
||||
|
||||
@ -0,0 +1,43 @@ |
||||
""" |
||||
Module detecting unused return values from low level |
||||
""" |
||||
from slither.detectors.abstract_detector import DetectorClassification |
||||
from .unused_return_values import UnusedReturnValues |
||||
from slither.slithir.operations import LowLevelCall |
||||
|
||||
class UncheckedLowLevel(UnusedReturnValues): |
||||
""" |
||||
If the return value of a send is not checked, it might lead to losing ether |
||||
""" |
||||
|
||||
ARGUMENT = 'unchecked-lowlevel' |
||||
HELP = 'Unchecked low-level calls' |
||||
IMPACT = DetectorClassification.MEDIUM |
||||
CONFIDENCE = DetectorClassification.MEDIUM |
||||
|
||||
WIKI = 'https://github.com/crytic/slither/wiki/Detector-Documentation#unchecked-low-level' |
||||
|
||||
WIKI_TITLE = 'Unchecked low-level calls' |
||||
WIKI_DESCRIPTION = 'The return value of a low-level call is not checked.' |
||||
WIKI_EXPLOIT_SCENARIO = ''' |
||||
```solidity |
||||
contract MyConc{ |
||||
function my_func(address payable dst) public payable{ |
||||
dst.call.value(msg.value)(""); |
||||
} |
||||
} |
||||
``` |
||||
The return value of the low-level call is not checked. As a result if the callfailed, the ether will be locked in the contract. |
||||
If the low level is used to prevent blocking operations, consider logging failed calls. |
||||
''' |
||||
|
||||
WIKI_RECOMMENDATION = 'Ensure that the return value of low-level call is checked or logged.' |
||||
|
||||
_txt_description = "low-level calls" |
||||
|
||||
def _is_instance(self, ir): |
||||
return isinstance(ir, LowLevelCall) |
||||
|
||||
|
||||
|
||||
|
||||
@ -0,0 +1,40 @@ |
||||
""" |
||||
Module detecting unused return values from send |
||||
""" |
||||
|
||||
from slither.detectors.abstract_detector import DetectorClassification |
||||
from .unused_return_values import UnusedReturnValues |
||||
from slither.slithir.operations import Send |
||||
|
||||
class UncheckedSend(UnusedReturnValues): |
||||
""" |
||||
If the return value of a send is not checked, it might lead to losing ether |
||||
""" |
||||
|
||||
ARGUMENT = 'unchecked-send' |
||||
HELP = 'Unchecked send' |
||||
IMPACT = DetectorClassification.MEDIUM |
||||
CONFIDENCE = DetectorClassification.MEDIUM |
||||
|
||||
WIKI = 'https://github.com/crytic/slither/wiki/Detector-Documentation#unchecked-send' |
||||
|
||||
WIKI_TITLE = 'Unchecked Send' |
||||
WIKI_DESCRIPTION = 'The return value of a send is not checked.' |
||||
WIKI_EXPLOIT_SCENARIO = ''' |
||||
```solidity |
||||
contract MyConc{ |
||||
function my_func(address payable dst) public payable{ |
||||
dst.send(msg.value); |
||||
} |
||||
} |
||||
``` |
||||
The return value of `send` is not checked. As a result if the send failed, the ether will be locked in the contract. |
||||
If `send` is used to prevent blocking operations, consider logging the failed sent. |
||||
''' |
||||
|
||||
WIKI_RECOMMENDATION = 'Ensure that the return value of send is checked or logged.' |
||||
|
||||
_txt_description = "send calls" |
||||
|
||||
def _is_instance(self, ir): |
||||
return isinstance(ir, Send) |
||||
@ -0,0 +1,3 @@ |
||||
class SlitherException(Exception): pass |
||||
|
||||
class SlitherError(SlitherException): pass |
||||
@ -0,0 +1,3 @@ |
||||
from slither.exceptions import SlitherException |
||||
|
||||
class SlithIRError(SlitherException): pass |
||||
@ -0,0 +1,7 @@ |
||||
from slither.exceptions import SlitherException |
||||
|
||||
class ParsingError(SlitherException): pass |
||||
|
||||
class ParsingNameReuse(SlitherException): pass |
||||
|
||||
class ParsingContractNotFound(SlitherException): pass |
||||
@ -0,0 +1,69 @@ |
||||
|
||||
def erc_to_signatures(erc): |
||||
return [f'{e[0]}({",".join(e[1])})' for e in erc] |
||||
|
||||
|
||||
# Final |
||||
# https://eips.ethereum.org/EIPS/eip-20 |
||||
# name, symbolc, decimals are optionals |
||||
ERC20 = [('totalSupply', [], 'uint256'), |
||||
('balanceOf', ['address'], 'uint256'), |
||||
('transfer', ['address', 'uint256'], 'bool'), |
||||
('transferFrom', ['address', 'address', 'uint256'], 'bool'), |
||||
('approve', ['address', 'uint256'], 'bool'), |
||||
('allowance', ['address', 'address'], 'uint256')] |
||||
ERC20_signatures = erc_to_signatures(ERC20) |
||||
|
||||
# Draft |
||||
# https://github.com/ethereum/eips/issues/223 |
||||
ERC223 = [('name', [], 'string'), |
||||
('symbol', [], 'string'), |
||||
('decimals', [], 'uint8'), |
||||
('totalSupply', [], 'uint256'), |
||||
('balanceOf', ['address'], 'uint256'), |
||||
('transfer', ['address', 'uint256'], 'bool'), |
||||
('transfer', ['address', 'uint256', 'bytes'], 'bool'), |
||||
('transfer', ['address', 'uint256', 'bytes', 'string'], 'bool')] |
||||
ERC223_signatures = erc_to_signatures(ERC223) |
||||
|
||||
# Final |
||||
# https://eips.ethereum.org/EIPS/eip-165 |
||||
ERC165 = [('supportsInterface', ['bytes4'], 'bool')] |
||||
ERC165_signatures = erc_to_signatures(ERC165) |
||||
|
||||
# Final |
||||
# https://eips.ethereum.org/EIPS/eip-721 |
||||
# Must have ERC165 |
||||
# name, symbol, tokenURI are optionals |
||||
ERC721 = [('balanceOf', ['address'], 'uint256'), |
||||
('ownerOf', ['uint256'], 'address'), |
||||
('safeTransferFrom', ['address', 'address', 'uint256', 'bytes'], ''), |
||||
('safeTransferFrom', ['address', 'address', 'uint256'], ''), |
||||
('transferFrom', ['address', 'address', 'uint256'], ''), |
||||
('approve', ['address', 'uint256'], ''), |
||||
('setApprovalForAll', ['address', 'bool'], ''), |
||||
('getApproved', ['uint256'], 'address'), |
||||
('isApprovedForAll', ['address', 'address'], 'bool')] + ERC165 |
||||
ERC721_signatures = erc_to_signatures(ERC721) |
||||
|
||||
# Final |
||||
# https://eips.ethereum.org/EIPS/eip-1820 |
||||
ERC1820 = [('canImplementInterfaceForAddress', ['bytes32', 'address'], 'bytes32')] |
||||
ERC1820_signatures = erc_to_signatures(ERC1820) |
||||
|
||||
# Last Call |
||||
# https://eips.ethereum.org/EIPS/eip-777 |
||||
ERC777 = [('name', [], 'string'), |
||||
('symbol', [], 'string'), |
||||
('totalSupply', [], 'uint256'), |
||||
('balanceOf', ['address'], 'uint256'), |
||||
('granularity', [], 'uint256'), |
||||
('defaultOperators', [], 'address[]'), |
||||
('isOperatorFor', ['address', 'address'], 'bool'), |
||||
('authorizeOperator', ['address'], ''), |
||||
('revokeOperator', ['address'], ''), |
||||
('send', ['address', 'uint256', 'bytes'], ''), |
||||
('operatorSend', ['address', 'address', 'uint256', 'bytes', 'bytes'], ''), |
||||
('burn', ['uint256', 'bytes'] , ''), |
||||
('operatorBurn', ['address', 'uint256', 'bytes', 'bytes'] , '')] |
||||
ERC777_signatures = erc_to_signatures(ERC777) |
||||
@ -0,0 +1,193 @@ |
||||
from pathlib import Path |
||||
|
||||
|
||||
libraries = { |
||||
'Openzeppelin-SafeMath': lambda x: is_openzepellin_safemath(x), |
||||
'Openzeppelin-ECRecovery': lambda x: is_openzepellin_ecrecovery(x), |
||||
'Openzeppelin-Ownable': lambda x: is_openzepellin_ownable(x), |
||||
'Openzeppelin-ERC20': lambda x: is_openzepellin_erc20(x), |
||||
'Openzeppelin-ERC721': lambda x: is_openzepellin_erc721(x), |
||||
'Zos-Upgrade': lambda x: is_zos_initializable(x), |
||||
'Dapphub-DSAuth': lambda x: is_dapphub_ds_auth(x), |
||||
'Dapphub-DSMath': lambda x: is_dapphub_ds_math(x), |
||||
'Dapphub-DSToken': lambda x: is_dapphub_ds_token(x), |
||||
'Dapphub-DSProxy': lambda x: is_dapphub_ds_proxy(x), |
||||
'Dapphub-DSGroup': lambda x: is_dapphub_ds_group(x), |
||||
} |
||||
|
||||
def is_standard_library(contract): |
||||
for name, is_lib in libraries.items(): |
||||
if is_lib(contract): |
||||
return name |
||||
return None |
||||
|
||||
|
||||
################################################################################### |
||||
################################################################################### |
||||
# region General libraries |
||||
################################################################################### |
||||
################################################################################### |
||||
|
||||
|
||||
def is_openzepellin(contract): |
||||
if not contract.is_from_dependency(): |
||||
return False |
||||
return 'openzeppelin-solidity' in Path(contract.source_mapping['filename_absolute']).parts |
||||
|
||||
|
||||
def is_zos(contract): |
||||
if not contract.is_from_dependency(): |
||||
return False |
||||
return 'zos-lib' in Path(contract.source_mapping['filename_absolute']).parts |
||||
|
||||
|
||||
# endregion |
||||
################################################################################### |
||||
################################################################################### |
||||
# region SafeMath |
||||
################################################################################### |
||||
################################################################################### |
||||
|
||||
|
||||
def is_safemath(contract): |
||||
return contract.name == "SafeMath" |
||||
|
||||
|
||||
def is_openzepellin_safemath(contract): |
||||
return is_safemath(contract) and is_openzepellin(contract) |
||||
|
||||
# endregion |
||||
################################################################################### |
||||
################################################################################### |
||||
# region ECRecovery |
||||
################################################################################### |
||||
################################################################################### |
||||
|
||||
|
||||
def is_ecrecovery(contract): |
||||
return contract.name == 'ECRecovery' |
||||
|
||||
|
||||
def is_openzepellin_ecrecovery(contract): |
||||
return is_ecrecovery(contract) and is_openzepellin(contract) |
||||
|
||||
|
||||
# endregion |
||||
################################################################################### |
||||
################################################################################### |
||||
# region Ownable |
||||
################################################################################### |
||||
################################################################################### |
||||
|
||||
|
||||
def is_ownable(contract): |
||||
return contract.name == 'Ownable' |
||||
|
||||
|
||||
def is_openzepellin_ownable(contract): |
||||
return is_ownable(contract) and is_openzepellin(contract) |
||||
|
||||
|
||||
# endregion |
||||
################################################################################### |
||||
################################################################################### |
||||
# region ERC20 |
||||
################################################################################### |
||||
################################################################################### |
||||
|
||||
|
||||
def is_erc20(contract): |
||||
return contract.name == 'ERC20' |
||||
|
||||
|
||||
def is_openzepellin_erc20(contract): |
||||
return is_erc20(contract) and is_openzepellin(contract) |
||||
|
||||
|
||||
# endregion |
||||
################################################################################### |
||||
################################################################################### |
||||
# region ERC721 |
||||
################################################################################### |
||||
################################################################################### |
||||
|
||||
|
||||
def is_erc721(contract): |
||||
return contract.name == 'ERC721' |
||||
|
||||
|
||||
def is_openzepellin_erc721(contract): |
||||
return is_erc721(contract) and is_openzepellin(contract) |
||||
|
||||
|
||||
# endregion |
||||
################################################################################### |
||||
################################################################################### |
||||
# region Zos Initializable |
||||
################################################################################### |
||||
################################################################################### |
||||
|
||||
|
||||
def is_initializable(contract): |
||||
return contract.name == 'Initializable' |
||||
|
||||
|
||||
def is_zos_initializable(contract): |
||||
return is_initializable(contract) and is_zos(contract) |
||||
|
||||
|
||||
# endregion |
||||
################################################################################### |
||||
################################################################################### |
||||
# region DappHub |
||||
################################################################################### |
||||
################################################################################### |
||||
|
||||
dapphubs = { |
||||
'DSAuth': 'ds-auth', |
||||
'DSMath': 'ds-math', |
||||
'DSToken': 'ds-token', |
||||
'DSProxy': 'ds-proxy', |
||||
'DSGroup': 'ds-group', |
||||
} |
||||
|
||||
|
||||
def _is_ds(contract, name): |
||||
return contract.name == name |
||||
|
||||
def _is_dappdhub_ds(contract, name): |
||||
if not contract.is_from_dependency(): |
||||
return False |
||||
if not dapphubs[name] in Path(contract.source_mapping['filename_absolute']).parts: |
||||
return False |
||||
return _is_ds(contract, name) |
||||
|
||||
def is_ds_auth(contract): |
||||
return _is_ds(contract, 'DSAuth') |
||||
|
||||
def is_dapphub_ds_auth(contract): |
||||
return _is_dappdhub_ds(contract, 'DSAuth') |
||||
|
||||
def is_ds_math(contract): |
||||
return _is_ds(contract, 'DSMath') |
||||
|
||||
def is_dapphub_ds_math(contract): |
||||
return _is_dappdhub_ds(contract, 'DSMath') |
||||
|
||||
def is_ds_token(contract): |
||||
return _is_ds(contract, 'DSToken') |
||||
|
||||
def is_dapphub_ds_token(contract): |
||||
return _is_dappdhub_ds(contract, 'DSToken') |
||||
|
||||
def is_ds_proxy(contract): |
||||
return _is_ds(contract, 'DSProxy') |
||||
|
||||
def is_dapphub_ds_proxy(contract): |
||||
return _is_dappdhub_ds(contract, 'DSProxy') |
||||
|
||||
def is_ds_group(contract): |
||||
return _is_ds(contract, 'DSGroup') |
||||
|
||||
def is_dapphub_ds_group(contract): |
||||
return _is_dappdhub_ds(contract, 'DSGroup') |
||||
@ -1,204 +1,208 @@ |
||||
[ |
||||
{ |
||||
"check": "arbitrary-send", |
||||
"impact": "High", |
||||
"confidence": "Medium", |
||||
"description": "Test.direct (tests/arbitrary_send-0.5.1.sol#11-13) sends eth to arbitrary user\n\tDangerous calls:\n\t- msg.sender.send(address(this).balance) (tests/arbitrary_send-0.5.1.sol#12)\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "function", |
||||
"name": "direct", |
||||
"source_mapping": { |
||||
"start": 162, |
||||
"length": 79, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/arbitrary_send-0.5.1.sol", |
||||
"filename_relative": "tests/arbitrary_send-0.5.1.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/arbitrary_send-0.5.1.sol", |
||||
"filename_short": "tests/arbitrary_send-0.5.1.sol", |
||||
"lines": [ |
||||
11, |
||||
12, |
||||
13 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 6 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Test", |
||||
{ |
||||
"success": true, |
||||
"error": null, |
||||
"results": [ |
||||
{ |
||||
"check": "arbitrary-send", |
||||
"impact": "High", |
||||
"confidence": "Medium", |
||||
"description": "Test.direct (tests/arbitrary_send-0.5.1.sol#11-13) sends eth to arbitrary user\n\tDangerous calls:\n\t- msg.sender.send(address(this).balance) (tests/arbitrary_send-0.5.1.sol#12)\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "function", |
||||
"name": "direct", |
||||
"source_mapping": { |
||||
"start": 0, |
||||
"length": 884, |
||||
"start": 162, |
||||
"length": 79, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/arbitrary_send-0.5.1.sol", |
||||
"filename_relative": "tests/arbitrary_send-0.5.1.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/arbitrary_send-0.5.1.sol", |
||||
"filename_short": "tests/arbitrary_send-0.5.1.sol", |
||||
"lines": [ |
||||
1, |
||||
2, |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16, |
||||
17, |
||||
18, |
||||
19, |
||||
20, |
||||
21, |
||||
22, |
||||
23, |
||||
24, |
||||
25, |
||||
26, |
||||
27, |
||||
28, |
||||
29, |
||||
30, |
||||
31, |
||||
32, |
||||
33, |
||||
34, |
||||
35, |
||||
36, |
||||
37, |
||||
38, |
||||
39, |
||||
40, |
||||
41 |
||||
13 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
"starting_column": 5, |
||||
"ending_column": 6 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Test", |
||||
"source_mapping": { |
||||
"start": 0, |
||||
"length": 884, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/arbitrary_send-0.5.1.sol", |
||||
"filename_relative": "tests/arbitrary_send-0.5.1.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/arbitrary_send-0.5.1.sol", |
||||
"filename_short": "tests/arbitrary_send-0.5.1.sol", |
||||
"lines": [ |
||||
1, |
||||
2, |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16, |
||||
17, |
||||
18, |
||||
19, |
||||
20, |
||||
21, |
||||
22, |
||||
23, |
||||
24, |
||||
25, |
||||
26, |
||||
27, |
||||
28, |
||||
29, |
||||
30, |
||||
31, |
||||
32, |
||||
33, |
||||
34, |
||||
35, |
||||
36, |
||||
37, |
||||
38, |
||||
39, |
||||
40, |
||||
41 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
} |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "expression", |
||||
"expression": "msg.sender.send(address(this).balance)", |
||||
"source_mapping": { |
||||
"start": 196, |
||||
"length": 38, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/arbitrary_send-0.5.1.sol", |
||||
"filename_relative": "tests/arbitrary_send-0.5.1.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/arbitrary_send-0.5.1.sol", |
||||
"filename_short": "tests/arbitrary_send-0.5.1.sol", |
||||
"lines": [ |
||||
12 |
||||
], |
||||
"starting_column": 9, |
||||
"ending_column": 47 |
||||
} |
||||
} |
||||
] |
||||
}, |
||||
{ |
||||
"check": "arbitrary-send", |
||||
"impact": "High", |
||||
"confidence": "Medium", |
||||
"description": "Test.indirect (tests/arbitrary_send-0.5.1.sol#19-21) sends eth to arbitrary user\n\tDangerous calls:\n\t- destination.send(address(this).balance) (tests/arbitrary_send-0.5.1.sol#20)\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "function", |
||||
"name": "indirect", |
||||
"source_mapping": { |
||||
"start": 316, |
||||
"length": 82, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/arbitrary_send-0.5.1.sol", |
||||
"filename_relative": "tests/arbitrary_send-0.5.1.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/arbitrary_send-0.5.1.sol", |
||||
"filename_short": "tests/arbitrary_send-0.5.1.sol", |
||||
"lines": [ |
||||
19, |
||||
20, |
||||
21 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 6 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Test", |
||||
{ |
||||
"type": "expression", |
||||
"expression": "msg.sender.send(address(this).balance)", |
||||
"source_mapping": { |
||||
"start": 0, |
||||
"length": 884, |
||||
"start": 196, |
||||
"length": 38, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/arbitrary_send-0.5.1.sol", |
||||
"filename_relative": "tests/arbitrary_send-0.5.1.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/arbitrary_send-0.5.1.sol", |
||||
"filename_short": "tests/arbitrary_send-0.5.1.sol", |
||||
"lines": [ |
||||
12 |
||||
], |
||||
"starting_column": 9, |
||||
"ending_column": 47 |
||||
} |
||||
} |
||||
] |
||||
}, |
||||
{ |
||||
"check": "arbitrary-send", |
||||
"impact": "High", |
||||
"confidence": "Medium", |
||||
"description": "Test.indirect (tests/arbitrary_send-0.5.1.sol#19-21) sends eth to arbitrary user\n\tDangerous calls:\n\t- destination.send(address(this).balance) (tests/arbitrary_send-0.5.1.sol#20)\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "function", |
||||
"name": "indirect", |
||||
"source_mapping": { |
||||
"start": 316, |
||||
"length": 82, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/arbitrary_send-0.5.1.sol", |
||||
"filename_relative": "tests/arbitrary_send-0.5.1.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/arbitrary_send-0.5.1.sol", |
||||
"filename_short": "tests/arbitrary_send-0.5.1.sol", |
||||
"lines": [ |
||||
1, |
||||
2, |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16, |
||||
17, |
||||
18, |
||||
19, |
||||
20, |
||||
21, |
||||
22, |
||||
23, |
||||
24, |
||||
25, |
||||
26, |
||||
27, |
||||
28, |
||||
29, |
||||
30, |
||||
31, |
||||
32, |
||||
33, |
||||
34, |
||||
35, |
||||
36, |
||||
37, |
||||
38, |
||||
39, |
||||
40, |
||||
41 |
||||
21 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
"starting_column": 5, |
||||
"ending_column": 6 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Test", |
||||
"source_mapping": { |
||||
"start": 0, |
||||
"length": 884, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/arbitrary_send-0.5.1.sol", |
||||
"filename_relative": "tests/arbitrary_send-0.5.1.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/arbitrary_send-0.5.1.sol", |
||||
"filename_short": "tests/arbitrary_send-0.5.1.sol", |
||||
"lines": [ |
||||
1, |
||||
2, |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16, |
||||
17, |
||||
18, |
||||
19, |
||||
20, |
||||
21, |
||||
22, |
||||
23, |
||||
24, |
||||
25, |
||||
26, |
||||
27, |
||||
28, |
||||
29, |
||||
30, |
||||
31, |
||||
32, |
||||
33, |
||||
34, |
||||
35, |
||||
36, |
||||
37, |
||||
38, |
||||
39, |
||||
40, |
||||
41 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "expression", |
||||
"expression": "destination.send(address(this).balance)", |
||||
"source_mapping": { |
||||
"start": 352, |
||||
"length": 39, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/arbitrary_send-0.5.1.sol", |
||||
"filename_relative": "tests/arbitrary_send-0.5.1.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/arbitrary_send-0.5.1.sol", |
||||
"filename_short": "tests/arbitrary_send-0.5.1.sol", |
||||
"lines": [ |
||||
20 |
||||
], |
||||
"starting_column": 9, |
||||
"ending_column": 48 |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "expression", |
||||
"expression": "destination.send(address(this).balance)", |
||||
"source_mapping": { |
||||
"start": 352, |
||||
"length": 39, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/arbitrary_send-0.5.1.sol", |
||||
"filename_relative": "tests/arbitrary_send-0.5.1.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/arbitrary_send-0.5.1.sol", |
||||
"filename_short": "tests/arbitrary_send-0.5.1.sol", |
||||
"lines": [ |
||||
20 |
||||
], |
||||
"starting_column": 9, |
||||
"ending_column": 48 |
||||
} |
||||
} |
||||
] |
||||
} |
||||
] |
||||
] |
||||
} |
||||
] |
||||
} |
||||
@ -1,204 +1,208 @@ |
||||
[ |
||||
{ |
||||
"check": "arbitrary-send", |
||||
"impact": "High", |
||||
"confidence": "Medium", |
||||
"description": "Test.direct (tests/arbitrary_send.sol#11-13) sends eth to arbitrary user\n\tDangerous calls:\n\t- msg.sender.send(address(this).balance) (tests/arbitrary_send.sol#12)\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "function", |
||||
"name": "direct", |
||||
"source_mapping": { |
||||
"start": 147, |
||||
"length": 79, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/arbitrary_send.sol", |
||||
"filename_relative": "tests/arbitrary_send.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/arbitrary_send.sol", |
||||
"filename_short": "tests/arbitrary_send.sol", |
||||
"lines": [ |
||||
11, |
||||
12, |
||||
13 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 6 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Test", |
||||
{ |
||||
"success": true, |
||||
"error": null, |
||||
"results": [ |
||||
{ |
||||
"check": "arbitrary-send", |
||||
"impact": "High", |
||||
"confidence": "Medium", |
||||
"description": "Test.direct (tests/arbitrary_send.sol#11-13) sends eth to arbitrary user\n\tDangerous calls:\n\t- msg.sender.send(address(this).balance) (tests/arbitrary_send.sol#12)\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "function", |
||||
"name": "direct", |
||||
"source_mapping": { |
||||
"start": 0, |
||||
"length": 869, |
||||
"start": 147, |
||||
"length": 79, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/arbitrary_send.sol", |
||||
"filename_relative": "tests/arbitrary_send.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/arbitrary_send.sol", |
||||
"filename_short": "tests/arbitrary_send.sol", |
||||
"lines": [ |
||||
1, |
||||
2, |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16, |
||||
17, |
||||
18, |
||||
19, |
||||
20, |
||||
21, |
||||
22, |
||||
23, |
||||
24, |
||||
25, |
||||
26, |
||||
27, |
||||
28, |
||||
29, |
||||
30, |
||||
31, |
||||
32, |
||||
33, |
||||
34, |
||||
35, |
||||
36, |
||||
37, |
||||
38, |
||||
39, |
||||
40, |
||||
41 |
||||
13 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
"starting_column": 5, |
||||
"ending_column": 6 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Test", |
||||
"source_mapping": { |
||||
"start": 0, |
||||
"length": 869, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/arbitrary_send.sol", |
||||
"filename_relative": "tests/arbitrary_send.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/arbitrary_send.sol", |
||||
"filename_short": "tests/arbitrary_send.sol", |
||||
"lines": [ |
||||
1, |
||||
2, |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16, |
||||
17, |
||||
18, |
||||
19, |
||||
20, |
||||
21, |
||||
22, |
||||
23, |
||||
24, |
||||
25, |
||||
26, |
||||
27, |
||||
28, |
||||
29, |
||||
30, |
||||
31, |
||||
32, |
||||
33, |
||||
34, |
||||
35, |
||||
36, |
||||
37, |
||||
38, |
||||
39, |
||||
40, |
||||
41 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
} |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "expression", |
||||
"expression": "msg.sender.send(address(this).balance)", |
||||
"source_mapping": { |
||||
"start": 181, |
||||
"length": 38, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/arbitrary_send.sol", |
||||
"filename_relative": "tests/arbitrary_send.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/arbitrary_send.sol", |
||||
"filename_short": "tests/arbitrary_send.sol", |
||||
"lines": [ |
||||
12 |
||||
], |
||||
"starting_column": 9, |
||||
"ending_column": 47 |
||||
} |
||||
} |
||||
] |
||||
}, |
||||
{ |
||||
"check": "arbitrary-send", |
||||
"impact": "High", |
||||
"confidence": "Medium", |
||||
"description": "Test.indirect (tests/arbitrary_send.sol#19-21) sends eth to arbitrary user\n\tDangerous calls:\n\t- destination.send(address(this).balance) (tests/arbitrary_send.sol#20)\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "function", |
||||
"name": "indirect", |
||||
"source_mapping": { |
||||
"start": 301, |
||||
"length": 82, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/arbitrary_send.sol", |
||||
"filename_relative": "tests/arbitrary_send.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/arbitrary_send.sol", |
||||
"filename_short": "tests/arbitrary_send.sol", |
||||
"lines": [ |
||||
19, |
||||
20, |
||||
21 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 6 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Test", |
||||
{ |
||||
"type": "expression", |
||||
"expression": "msg.sender.send(address(this).balance)", |
||||
"source_mapping": { |
||||
"start": 0, |
||||
"length": 869, |
||||
"start": 181, |
||||
"length": 38, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/arbitrary_send.sol", |
||||
"filename_relative": "tests/arbitrary_send.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/arbitrary_send.sol", |
||||
"filename_short": "tests/arbitrary_send.sol", |
||||
"lines": [ |
||||
12 |
||||
], |
||||
"starting_column": 9, |
||||
"ending_column": 47 |
||||
} |
||||
} |
||||
] |
||||
}, |
||||
{ |
||||
"check": "arbitrary-send", |
||||
"impact": "High", |
||||
"confidence": "Medium", |
||||
"description": "Test.indirect (tests/arbitrary_send.sol#19-21) sends eth to arbitrary user\n\tDangerous calls:\n\t- destination.send(address(this).balance) (tests/arbitrary_send.sol#20)\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "function", |
||||
"name": "indirect", |
||||
"source_mapping": { |
||||
"start": 301, |
||||
"length": 82, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/arbitrary_send.sol", |
||||
"filename_relative": "tests/arbitrary_send.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/arbitrary_send.sol", |
||||
"filename_short": "tests/arbitrary_send.sol", |
||||
"lines": [ |
||||
1, |
||||
2, |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16, |
||||
17, |
||||
18, |
||||
19, |
||||
20, |
||||
21, |
||||
22, |
||||
23, |
||||
24, |
||||
25, |
||||
26, |
||||
27, |
||||
28, |
||||
29, |
||||
30, |
||||
31, |
||||
32, |
||||
33, |
||||
34, |
||||
35, |
||||
36, |
||||
37, |
||||
38, |
||||
39, |
||||
40, |
||||
41 |
||||
21 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
"starting_column": 5, |
||||
"ending_column": 6 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Test", |
||||
"source_mapping": { |
||||
"start": 0, |
||||
"length": 869, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/arbitrary_send.sol", |
||||
"filename_relative": "tests/arbitrary_send.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/arbitrary_send.sol", |
||||
"filename_short": "tests/arbitrary_send.sol", |
||||
"lines": [ |
||||
1, |
||||
2, |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16, |
||||
17, |
||||
18, |
||||
19, |
||||
20, |
||||
21, |
||||
22, |
||||
23, |
||||
24, |
||||
25, |
||||
26, |
||||
27, |
||||
28, |
||||
29, |
||||
30, |
||||
31, |
||||
32, |
||||
33, |
||||
34, |
||||
35, |
||||
36, |
||||
37, |
||||
38, |
||||
39, |
||||
40, |
||||
41 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "expression", |
||||
"expression": "destination.send(address(this).balance)", |
||||
"source_mapping": { |
||||
"start": 337, |
||||
"length": 39, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/arbitrary_send.sol", |
||||
"filename_relative": "tests/arbitrary_send.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/arbitrary_send.sol", |
||||
"filename_short": "tests/arbitrary_send.sol", |
||||
"lines": [ |
||||
20 |
||||
], |
||||
"starting_column": 9, |
||||
"ending_column": 48 |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "expression", |
||||
"expression": "destination.send(address(this).balance)", |
||||
"source_mapping": { |
||||
"start": 337, |
||||
"length": 39, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/arbitrary_send.sol", |
||||
"filename_relative": "tests/arbitrary_send.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/arbitrary_send.sol", |
||||
"filename_short": "tests/arbitrary_send.sol", |
||||
"lines": [ |
||||
20 |
||||
], |
||||
"starting_column": 9, |
||||
"ending_column": 48 |
||||
} |
||||
} |
||||
] |
||||
} |
||||
] |
||||
] |
||||
} |
||||
] |
||||
} |
||||
@ -1,52 +1,56 @@ |
||||
[ |
||||
{ |
||||
"check": "backdoor", |
||||
"impact": "High", |
||||
"confidence": "High", |
||||
"description": "Backdoor function found in C.i_am_a_backdoor (tests/backdoor.sol#4-6)\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "function", |
||||
"name": "i_am_a_backdoor", |
||||
"source_mapping": { |
||||
"start": 18, |
||||
"length": 74, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/backdoor.sol", |
||||
"filename_relative": "tests/backdoor.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/backdoor.sol", |
||||
"filename_short": "tests/backdoor.sol", |
||||
"lines": [ |
||||
4, |
||||
5, |
||||
6 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 6 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "C", |
||||
{ |
||||
"success": true, |
||||
"error": null, |
||||
"results": [ |
||||
{ |
||||
"check": "backdoor", |
||||
"impact": "High", |
||||
"confidence": "High", |
||||
"description": "Backdoor function found in C.i_am_a_backdoor (tests/backdoor.sol#4-6)\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "function", |
||||
"name": "i_am_a_backdoor", |
||||
"source_mapping": { |
||||
"start": 1, |
||||
"length": 94, |
||||
"start": 18, |
||||
"length": 74, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/backdoor.sol", |
||||
"filename_relative": "tests/backdoor.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/backdoor.sol", |
||||
"filename_short": "tests/backdoor.sol", |
||||
"lines": [ |
||||
2, |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8 |
||||
6 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
"starting_column": 5, |
||||
"ending_column": 6 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "C", |
||||
"source_mapping": { |
||||
"start": 1, |
||||
"length": 94, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/backdoor.sol", |
||||
"filename_relative": "tests/backdoor.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/backdoor.sol", |
||||
"filename_short": "tests/backdoor.sol", |
||||
"lines": [ |
||||
2, |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
} |
||||
} |
||||
} |
||||
} |
||||
] |
||||
} |
||||
] |
||||
] |
||||
} |
||||
] |
||||
} |
||||
@ -1,52 +1,56 @@ |
||||
[ |
||||
{ |
||||
"check": "suicidal", |
||||
"impact": "High", |
||||
"confidence": "High", |
||||
"description": "C.i_am_a_backdoor (tests/backdoor.sol#4-6) allows anyone to destruct the contract\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "function", |
||||
"name": "i_am_a_backdoor", |
||||
"source_mapping": { |
||||
"start": 18, |
||||
"length": 74, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/backdoor.sol", |
||||
"filename_relative": "tests/backdoor.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/backdoor.sol", |
||||
"filename_short": "tests/backdoor.sol", |
||||
"lines": [ |
||||
4, |
||||
5, |
||||
6 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 6 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "C", |
||||
{ |
||||
"success": true, |
||||
"error": null, |
||||
"results": [ |
||||
{ |
||||
"check": "suicidal", |
||||
"impact": "High", |
||||
"confidence": "High", |
||||
"description": "C.i_am_a_backdoor (tests/backdoor.sol#4-6) allows anyone to destruct the contract\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "function", |
||||
"name": "i_am_a_backdoor", |
||||
"source_mapping": { |
||||
"start": 1, |
||||
"length": 94, |
||||
"start": 18, |
||||
"length": 74, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/backdoor.sol", |
||||
"filename_relative": "tests/backdoor.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/backdoor.sol", |
||||
"filename_short": "tests/backdoor.sol", |
||||
"lines": [ |
||||
2, |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8 |
||||
6 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
"starting_column": 5, |
||||
"ending_column": 6 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "C", |
||||
"source_mapping": { |
||||
"start": 1, |
||||
"length": 94, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/backdoor.sol", |
||||
"filename_relative": "tests/backdoor.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/backdoor.sol", |
||||
"filename_short": "tests/backdoor.sol", |
||||
"lines": [ |
||||
2, |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
} |
||||
} |
||||
} |
||||
} |
||||
] |
||||
} |
||||
] |
||||
] |
||||
} |
||||
] |
||||
} |
||||
@ -1,112 +1,116 @@ |
||||
[ |
||||
{ |
||||
"check": "constable-states", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "A.myFriendsAddress should be constant (tests/const_state_variables.sol#7)\nA.test should be constant (tests/const_state_variables.sol#10)\nA.text2 should be constant (tests/const_state_variables.sol#14)\nB.mySistersAddress should be constant (tests/const_state_variables.sol#26)\nMyConc.should_be_constant should be constant (tests/const_state_variables.sol#42)\nMyConc.should_be_constant_2 should be constant (tests/const_state_variables.sol#43)\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "variable", |
||||
"name": "myFriendsAddress", |
||||
"source_mapping": { |
||||
"start": 132, |
||||
"length": 76, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/const_state_variables.sol", |
||||
"filename_relative": "tests/const_state_variables.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/const_state_variables.sol", |
||||
"filename_short": "tests/const_state_variables.sol", |
||||
"lines": [ |
||||
7 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 81 |
||||
{ |
||||
"success": true, |
||||
"error": null, |
||||
"results": [ |
||||
{ |
||||
"check": "constable-states", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "A.myFriendsAddress should be constant (tests/const_state_variables.sol#7)\nA.test should be constant (tests/const_state_variables.sol#10)\nA.text2 should be constant (tests/const_state_variables.sol#14)\nB.mySistersAddress should be constant (tests/const_state_variables.sol#26)\nMyConc.should_be_constant should be constant (tests/const_state_variables.sol#42)\nMyConc.should_be_constant_2 should be constant (tests/const_state_variables.sol#43)\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "variable", |
||||
"name": "myFriendsAddress", |
||||
"source_mapping": { |
||||
"start": 132, |
||||
"length": 76, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/const_state_variables.sol", |
||||
"filename_relative": "tests/const_state_variables.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/const_state_variables.sol", |
||||
"filename_short": "tests/const_state_variables.sol", |
||||
"lines": [ |
||||
7 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 81 |
||||
} |
||||
}, |
||||
{ |
||||
"type": "variable", |
||||
"name": "mySistersAddress", |
||||
"source_mapping": { |
||||
"start": 496, |
||||
"length": 76, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/const_state_variables.sol", |
||||
"filename_relative": "tests/const_state_variables.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/const_state_variables.sol", |
||||
"filename_short": "tests/const_state_variables.sol", |
||||
"lines": [ |
||||
26 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 81 |
||||
} |
||||
}, |
||||
{ |
||||
"type": "variable", |
||||
"name": "should_be_constant", |
||||
"source_mapping": { |
||||
"start": 793, |
||||
"length": 42, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/const_state_variables.sol", |
||||
"filename_relative": "tests/const_state_variables.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/const_state_variables.sol", |
||||
"filename_short": "tests/const_state_variables.sol", |
||||
"lines": [ |
||||
42 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 47 |
||||
} |
||||
}, |
||||
{ |
||||
"type": "variable", |
||||
"name": "should_be_constant_2", |
||||
"source_mapping": { |
||||
"start": 841, |
||||
"length": 33, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/const_state_variables.sol", |
||||
"filename_relative": "tests/const_state_variables.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/const_state_variables.sol", |
||||
"filename_short": "tests/const_state_variables.sol", |
||||
"lines": [ |
||||
43 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 38 |
||||
} |
||||
}, |
||||
{ |
||||
"type": "variable", |
||||
"name": "test", |
||||
"source_mapping": { |
||||
"start": 237, |
||||
"length": 20, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/const_state_variables.sol", |
||||
"filename_relative": "tests/const_state_variables.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/const_state_variables.sol", |
||||
"filename_short": "tests/const_state_variables.sol", |
||||
"lines": [ |
||||
10 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 25 |
||||
} |
||||
}, |
||||
{ |
||||
"type": "variable", |
||||
"name": "text2", |
||||
"source_mapping": { |
||||
"start": 333, |
||||
"length": 20, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/const_state_variables.sol", |
||||
"filename_relative": "tests/const_state_variables.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/const_state_variables.sol", |
||||
"filename_short": "tests/const_state_variables.sol", |
||||
"lines": [ |
||||
14 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 25 |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "variable", |
||||
"name": "mySistersAddress", |
||||
"source_mapping": { |
||||
"start": 496, |
||||
"length": 76, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/const_state_variables.sol", |
||||
"filename_relative": "tests/const_state_variables.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/const_state_variables.sol", |
||||
"filename_short": "tests/const_state_variables.sol", |
||||
"lines": [ |
||||
26 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 81 |
||||
} |
||||
}, |
||||
{ |
||||
"type": "variable", |
||||
"name": "should_be_constant", |
||||
"source_mapping": { |
||||
"start": 793, |
||||
"length": 42, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/const_state_variables.sol", |
||||
"filename_relative": "tests/const_state_variables.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/const_state_variables.sol", |
||||
"filename_short": "tests/const_state_variables.sol", |
||||
"lines": [ |
||||
42 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 47 |
||||
} |
||||
}, |
||||
{ |
||||
"type": "variable", |
||||
"name": "should_be_constant_2", |
||||
"source_mapping": { |
||||
"start": 841, |
||||
"length": 33, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/const_state_variables.sol", |
||||
"filename_relative": "tests/const_state_variables.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/const_state_variables.sol", |
||||
"filename_short": "tests/const_state_variables.sol", |
||||
"lines": [ |
||||
43 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 38 |
||||
} |
||||
}, |
||||
{ |
||||
"type": "variable", |
||||
"name": "test", |
||||
"source_mapping": { |
||||
"start": 237, |
||||
"length": 20, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/const_state_variables.sol", |
||||
"filename_relative": "tests/const_state_variables.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/const_state_variables.sol", |
||||
"filename_short": "tests/const_state_variables.sol", |
||||
"lines": [ |
||||
10 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 25 |
||||
} |
||||
}, |
||||
{ |
||||
"type": "variable", |
||||
"name": "text2", |
||||
"source_mapping": { |
||||
"start": 333, |
||||
"length": 20, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/const_state_variables.sol", |
||||
"filename_relative": "tests/const_state_variables.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/const_state_variables.sol", |
||||
"filename_short": "tests/const_state_variables.sol", |
||||
"lines": [ |
||||
14 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 25 |
||||
} |
||||
} |
||||
] |
||||
} |
||||
] |
||||
] |
||||
} |
||||
] |
||||
} |
||||
@ -1,67 +1,71 @@ |
||||
[ |
||||
{ |
||||
"check": "constant-function", |
||||
"impact": "Medium", |
||||
"confidence": "Medium", |
||||
"description": "Constant.test_assembly_bug (tests/constant-0.5.1.sol#15-17) is declared view but contains assembly code\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "function", |
||||
"name": "test_assembly_bug", |
||||
"source_mapping": { |
||||
"start": 185, |
||||
"length": 66, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/constant-0.5.1.sol", |
||||
"filename_relative": "tests/constant-0.5.1.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/constant-0.5.1.sol", |
||||
"filename_short": "tests/constant-0.5.1.sol", |
||||
"lines": [ |
||||
15, |
||||
16, |
||||
17 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 6 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Constant", |
||||
{ |
||||
"success": true, |
||||
"error": null, |
||||
"results": [ |
||||
{ |
||||
"check": "constant-function", |
||||
"impact": "Medium", |
||||
"confidence": "Medium", |
||||
"description": "Constant.test_assembly_bug (tests/constant-0.5.1.sol#15-17) is declared view but contains assembly code\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "function", |
||||
"name": "test_assembly_bug", |
||||
"source_mapping": { |
||||
"start": 0, |
||||
"length": 253, |
||||
"start": 185, |
||||
"length": 66, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/constant-0.5.1.sol", |
||||
"filename_relative": "tests/constant-0.5.1.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/constant-0.5.1.sol", |
||||
"filename_short": "tests/constant-0.5.1.sol", |
||||
"lines": [ |
||||
1, |
||||
2, |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16, |
||||
17, |
||||
18 |
||||
17 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
"starting_column": 5, |
||||
"ending_column": 6 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Constant", |
||||
"source_mapping": { |
||||
"start": 0, |
||||
"length": 253, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/constant-0.5.1.sol", |
||||
"filename_relative": "tests/constant-0.5.1.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/constant-0.5.1.sol", |
||||
"filename_short": "tests/constant-0.5.1.sol", |
||||
"lines": [ |
||||
1, |
||||
2, |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16, |
||||
17, |
||||
18 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "info", |
||||
"contains_assembly": true |
||||
} |
||||
}, |
||||
{ |
||||
"type": "info", |
||||
"contains_assembly": true |
||||
} |
||||
] |
||||
} |
||||
] |
||||
] |
||||
} |
||||
] |
||||
} |
||||
@ -1,252 +1,256 @@ |
||||
[ |
||||
{ |
||||
"check": "constant-function", |
||||
"impact": "Medium", |
||||
"confidence": "Medium", |
||||
"description": "Constant.test_view_bug (tests/constant.sol#5-7) is declared view but changes state variables:\n\t- Constant.a\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "function", |
||||
"name": "test_view_bug", |
||||
"source_mapping": { |
||||
"start": 45, |
||||
"length": 58, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/constant.sol", |
||||
"filename_relative": "tests/constant.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/constant.sol", |
||||
"filename_short": "tests/constant.sol", |
||||
"lines": [ |
||||
5, |
||||
6, |
||||
7 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 6 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Constant", |
||||
{ |
||||
"success": true, |
||||
"error": null, |
||||
"results": [ |
||||
{ |
||||
"check": "constant-function", |
||||
"impact": "Medium", |
||||
"confidence": "Medium", |
||||
"description": "Constant.test_view_bug (tests/constant.sol#5-7) is declared view but changes state variables:\n\t- Constant.a\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "function", |
||||
"name": "test_view_bug", |
||||
"source_mapping": { |
||||
"start": 0, |
||||
"length": 392, |
||||
"start": 45, |
||||
"length": 58, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/constant.sol", |
||||
"filename_relative": "tests/constant.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/constant.sol", |
||||
"filename_short": "tests/constant.sol", |
||||
"lines": [ |
||||
1, |
||||
2, |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16, |
||||
17, |
||||
18, |
||||
19, |
||||
20, |
||||
21, |
||||
22, |
||||
23, |
||||
24, |
||||
25 |
||||
7 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
"starting_column": 5, |
||||
"ending_column": 6 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Constant", |
||||
"source_mapping": { |
||||
"start": 0, |
||||
"length": 392, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/constant.sol", |
||||
"filename_relative": "tests/constant.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/constant.sol", |
||||
"filename_short": "tests/constant.sol", |
||||
"lines": [ |
||||
1, |
||||
2, |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16, |
||||
17, |
||||
18, |
||||
19, |
||||
20, |
||||
21, |
||||
22, |
||||
23, |
||||
24, |
||||
25 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
} |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "variable", |
||||
"name": "a", |
||||
"source_mapping": { |
||||
"start": 28, |
||||
"length": 6, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/constant.sol", |
||||
"filename_relative": "tests/constant.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/constant.sol", |
||||
"filename_short": "tests/constant.sol", |
||||
"lines": [ |
||||
3 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 11 |
||||
} |
||||
}, |
||||
{ |
||||
"type": "info", |
||||
"contains_assembly": false |
||||
} |
||||
] |
||||
}, |
||||
{ |
||||
"check": "constant-function", |
||||
"impact": "Medium", |
||||
"confidence": "Medium", |
||||
"description": "Constant.test_constant_bug (tests/constant.sol#9-11) is declared view but changes state variables:\n\t- Constant.a\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "function", |
||||
"name": "test_constant_bug", |
||||
"source_mapping": { |
||||
"start": 113, |
||||
"length": 66, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/constant.sol", |
||||
"filename_relative": "tests/constant.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/constant.sol", |
||||
"filename_short": "tests/constant.sol", |
||||
"lines": [ |
||||
9, |
||||
10, |
||||
11 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 6 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Constant", |
||||
{ |
||||
"type": "variable", |
||||
"name": "a", |
||||
"source_mapping": { |
||||
"start": 0, |
||||
"length": 392, |
||||
"start": 28, |
||||
"length": 6, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/constant.sol", |
||||
"filename_relative": "tests/constant.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/constant.sol", |
||||
"filename_short": "tests/constant.sol", |
||||
"lines": [ |
||||
1, |
||||
2, |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16, |
||||
17, |
||||
18, |
||||
19, |
||||
20, |
||||
21, |
||||
22, |
||||
23, |
||||
24, |
||||
25 |
||||
3 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
"starting_column": 5, |
||||
"ending_column": 11 |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "variable", |
||||
"name": "a", |
||||
"source_mapping": { |
||||
"start": 28, |
||||
"length": 6, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/constant.sol", |
||||
"filename_relative": "tests/constant.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/constant.sol", |
||||
"filename_short": "tests/constant.sol", |
||||
"lines": [ |
||||
3 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 11 |
||||
} |
||||
}, |
||||
{ |
||||
"type": "info", |
||||
"contains_assembly": false |
||||
} |
||||
] |
||||
}, |
||||
{ |
||||
"check": "constant-function", |
||||
"impact": "Medium", |
||||
"confidence": "Medium", |
||||
"description": "Constant.test_assembly_bug (tests/constant.sol#22-24) is declared view but contains assembly code\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "function", |
||||
"name": "test_assembly_bug", |
||||
"source_mapping": { |
||||
"start": 324, |
||||
"length": 66, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/constant.sol", |
||||
"filename_relative": "tests/constant.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/constant.sol", |
||||
"filename_short": "tests/constant.sol", |
||||
"lines": [ |
||||
22, |
||||
23, |
||||
24 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 6 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Constant", |
||||
{ |
||||
"type": "info", |
||||
"contains_assembly": false |
||||
} |
||||
] |
||||
}, |
||||
{ |
||||
"check": "constant-function", |
||||
"impact": "Medium", |
||||
"confidence": "Medium", |
||||
"description": "Constant.test_constant_bug (tests/constant.sol#9-11) is declared view but changes state variables:\n\t- Constant.a\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "function", |
||||
"name": "test_constant_bug", |
||||
"source_mapping": { |
||||
"start": 0, |
||||
"length": 392, |
||||
"start": 113, |
||||
"length": 66, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/constant.sol", |
||||
"filename_relative": "tests/constant.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/constant.sol", |
||||
"filename_short": "tests/constant.sol", |
||||
"lines": [ |
||||
1, |
||||
2, |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16, |
||||
17, |
||||
18, |
||||
19, |
||||
20, |
||||
21, |
||||
11 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 6 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Constant", |
||||
"source_mapping": { |
||||
"start": 0, |
||||
"length": 392, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/constant.sol", |
||||
"filename_relative": "tests/constant.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/constant.sol", |
||||
"filename_short": "tests/constant.sol", |
||||
"lines": [ |
||||
1, |
||||
2, |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16, |
||||
17, |
||||
18, |
||||
19, |
||||
20, |
||||
21, |
||||
22, |
||||
23, |
||||
24, |
||||
25 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "variable", |
||||
"name": "a", |
||||
"source_mapping": { |
||||
"start": 28, |
||||
"length": 6, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/constant.sol", |
||||
"filename_relative": "tests/constant.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/constant.sol", |
||||
"filename_short": "tests/constant.sol", |
||||
"lines": [ |
||||
3 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 11 |
||||
} |
||||
}, |
||||
{ |
||||
"type": "info", |
||||
"contains_assembly": false |
||||
} |
||||
] |
||||
}, |
||||
{ |
||||
"check": "constant-function", |
||||
"impact": "Medium", |
||||
"confidence": "Medium", |
||||
"description": "Constant.test_assembly_bug (tests/constant.sol#22-24) is declared view but contains assembly code\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "function", |
||||
"name": "test_assembly_bug", |
||||
"source_mapping": { |
||||
"start": 324, |
||||
"length": 66, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/constant.sol", |
||||
"filename_relative": "tests/constant.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/constant.sol", |
||||
"filename_short": "tests/constant.sol", |
||||
"lines": [ |
||||
22, |
||||
23, |
||||
24, |
||||
25 |
||||
24 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
"starting_column": 5, |
||||
"ending_column": 6 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Constant", |
||||
"source_mapping": { |
||||
"start": 0, |
||||
"length": 392, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/constant.sol", |
||||
"filename_relative": "tests/constant.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/constant.sol", |
||||
"filename_short": "tests/constant.sol", |
||||
"lines": [ |
||||
1, |
||||
2, |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16, |
||||
17, |
||||
18, |
||||
19, |
||||
20, |
||||
21, |
||||
22, |
||||
23, |
||||
24, |
||||
25 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "info", |
||||
"contains_assembly": true |
||||
} |
||||
}, |
||||
{ |
||||
"type": "info", |
||||
"contains_assembly": true |
||||
} |
||||
] |
||||
} |
||||
] |
||||
] |
||||
} |
||||
] |
||||
} |
||||
@ -1,173 +1,177 @@ |
||||
[ |
||||
{ |
||||
"check": "controlled-delegatecall", |
||||
"impact": "High", |
||||
"confidence": "Medium", |
||||
"description": "C.bad_delegate_call (tests/controlled_delegatecall.sol#8-11) uses delegatecall to a input-controlled function id\n\taddr_bad.delegatecall(data) (tests/controlled_delegatecall.sol#10)\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "function", |
||||
"name": "bad_delegate_call", |
||||
"source_mapping": { |
||||
"start": 101, |
||||
"length": 134, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/controlled_delegatecall.sol", |
||||
"filename_relative": "tests/controlled_delegatecall.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/controlled_delegatecall.sol", |
||||
"filename_short": "tests/controlled_delegatecall.sol", |
||||
"lines": [ |
||||
8, |
||||
9, |
||||
10, |
||||
11 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 6 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "C", |
||||
{ |
||||
"success": true, |
||||
"error": null, |
||||
"results": [ |
||||
{ |
||||
"check": "controlled-delegatecall", |
||||
"impact": "High", |
||||
"confidence": "Medium", |
||||
"description": "C.bad_delegate_call (tests/controlled_delegatecall.sol#8-11) uses delegatecall to a input-controlled function id\n\taddr_bad.delegatecall(data) (tests/controlled_delegatecall.sol#10)\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "function", |
||||
"name": "bad_delegate_call", |
||||
"source_mapping": { |
||||
"start": 0, |
||||
"length": 585, |
||||
"start": 101, |
||||
"length": 134, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/controlled_delegatecall.sol", |
||||
"filename_relative": "tests/controlled_delegatecall.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/controlled_delegatecall.sol", |
||||
"filename_short": "tests/controlled_delegatecall.sol", |
||||
"lines": [ |
||||
1, |
||||
2, |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16, |
||||
17, |
||||
18, |
||||
19, |
||||
20, |
||||
21, |
||||
22, |
||||
23, |
||||
24, |
||||
25 |
||||
11 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
"starting_column": 5, |
||||
"ending_column": 6 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "C", |
||||
"source_mapping": { |
||||
"start": 0, |
||||
"length": 585, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/controlled_delegatecall.sol", |
||||
"filename_relative": "tests/controlled_delegatecall.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/controlled_delegatecall.sol", |
||||
"filename_short": "tests/controlled_delegatecall.sol", |
||||
"lines": [ |
||||
1, |
||||
2, |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16, |
||||
17, |
||||
18, |
||||
19, |
||||
20, |
||||
21, |
||||
22, |
||||
23, |
||||
24, |
||||
25 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
} |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "expression", |
||||
"expression": "addr_bad.delegatecall(data)", |
||||
"source_mapping": { |
||||
"start": 201, |
||||
"length": 27, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/controlled_delegatecall.sol", |
||||
"filename_relative": "tests/controlled_delegatecall.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/controlled_delegatecall.sol", |
||||
"filename_short": "tests/controlled_delegatecall.sol", |
||||
"lines": [ |
||||
10 |
||||
], |
||||
"starting_column": 9, |
||||
"ending_column": 36 |
||||
} |
||||
} |
||||
] |
||||
}, |
||||
{ |
||||
"check": "controlled-delegatecall", |
||||
"impact": "High", |
||||
"confidence": "Medium", |
||||
"description": "C.bad_delegate_call2 (tests/controlled_delegatecall.sol#18-20) uses delegatecall to a input-controlled function id\n\taddr_bad.delegatecall(abi.encode(func_id,data)) (tests/controlled_delegatecall.sol#19)\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "function", |
||||
"name": "bad_delegate_call2", |
||||
"source_mapping": { |
||||
"start": 337, |
||||
"length": 118, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/controlled_delegatecall.sol", |
||||
"filename_relative": "tests/controlled_delegatecall.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/controlled_delegatecall.sol", |
||||
"filename_short": "tests/controlled_delegatecall.sol", |
||||
"lines": [ |
||||
18, |
||||
19, |
||||
20 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 6 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "C", |
||||
{ |
||||
"type": "expression", |
||||
"expression": "addr_bad.delegatecall(data)", |
||||
"source_mapping": { |
||||
"start": 0, |
||||
"length": 585, |
||||
"start": 201, |
||||
"length": 27, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/controlled_delegatecall.sol", |
||||
"filename_relative": "tests/controlled_delegatecall.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/controlled_delegatecall.sol", |
||||
"filename_short": "tests/controlled_delegatecall.sol", |
||||
"lines": [ |
||||
10 |
||||
], |
||||
"starting_column": 9, |
||||
"ending_column": 36 |
||||
} |
||||
} |
||||
] |
||||
}, |
||||
{ |
||||
"check": "controlled-delegatecall", |
||||
"impact": "High", |
||||
"confidence": "Medium", |
||||
"description": "C.bad_delegate_call2 (tests/controlled_delegatecall.sol#18-20) uses delegatecall to a input-controlled function id\n\taddr_bad.delegatecall(abi.encode(func_id,data)) (tests/controlled_delegatecall.sol#19)\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "function", |
||||
"name": "bad_delegate_call2", |
||||
"source_mapping": { |
||||
"start": 337, |
||||
"length": 118, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/controlled_delegatecall.sol", |
||||
"filename_relative": "tests/controlled_delegatecall.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/controlled_delegatecall.sol", |
||||
"filename_short": "tests/controlled_delegatecall.sol", |
||||
"lines": [ |
||||
1, |
||||
2, |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16, |
||||
17, |
||||
18, |
||||
19, |
||||
20, |
||||
21, |
||||
22, |
||||
23, |
||||
24, |
||||
25 |
||||
20 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
"starting_column": 5, |
||||
"ending_column": 6 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "C", |
||||
"source_mapping": { |
||||
"start": 0, |
||||
"length": 585, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/controlled_delegatecall.sol", |
||||
"filename_relative": "tests/controlled_delegatecall.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/controlled_delegatecall.sol", |
||||
"filename_short": "tests/controlled_delegatecall.sol", |
||||
"lines": [ |
||||
1, |
||||
2, |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16, |
||||
17, |
||||
18, |
||||
19, |
||||
20, |
||||
21, |
||||
22, |
||||
23, |
||||
24, |
||||
25 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "expression", |
||||
"expression": "addr_bad.delegatecall(abi.encode(func_id,data))", |
||||
"source_mapping": { |
||||
"start": 400, |
||||
"length": 48, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/controlled_delegatecall.sol", |
||||
"filename_relative": "tests/controlled_delegatecall.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/controlled_delegatecall.sol", |
||||
"filename_short": "tests/controlled_delegatecall.sol", |
||||
"lines": [ |
||||
19 |
||||
], |
||||
"starting_column": 9, |
||||
"ending_column": 57 |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "expression", |
||||
"expression": "addr_bad.delegatecall(abi.encode(func_id,data))", |
||||
"source_mapping": { |
||||
"start": 400, |
||||
"length": 48, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/controlled_delegatecall.sol", |
||||
"filename_relative": "tests/controlled_delegatecall.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/controlled_delegatecall.sol", |
||||
"filename_short": "tests/controlled_delegatecall.sol", |
||||
"lines": [ |
||||
19 |
||||
], |
||||
"starting_column": 9, |
||||
"ending_column": 57 |
||||
} |
||||
} |
||||
] |
||||
} |
||||
] |
||||
] |
||||
} |
||||
] |
||||
} |
||||
@ -1,180 +1,184 @@ |
||||
[ |
||||
{ |
||||
"check": "deprecated-standards", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Deprecated standard detected @ tests/deprecated_calls.sol#2:\n\t- Usage of \"block.blockhash()\" should be replaced with \"blockhash()\"\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "variable", |
||||
"name": "globalBlockHash", |
||||
"source_mapping": { |
||||
"start": 48, |
||||
"length": 44, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/deprecated_calls.sol", |
||||
"filename_relative": "tests/deprecated_calls.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/deprecated_calls.sol", |
||||
"filename_short": "tests/deprecated_calls.sol", |
||||
"lines": [ |
||||
2 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 49 |
||||
{ |
||||
"success": true, |
||||
"error": null, |
||||
"results": [ |
||||
{ |
||||
"check": "deprecated-standards", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Deprecated standard detected @ tests/deprecated_calls.sol#2:\n\t- Usage of \"block.blockhash()\" should be replaced with \"blockhash()\"\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "variable", |
||||
"name": "globalBlockHash", |
||||
"source_mapping": { |
||||
"start": 48, |
||||
"length": 44, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/deprecated_calls.sol", |
||||
"filename_relative": "tests/deprecated_calls.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/deprecated_calls.sol", |
||||
"filename_short": "tests/deprecated_calls.sol", |
||||
"lines": [ |
||||
2 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 49 |
||||
} |
||||
} |
||||
} |
||||
] |
||||
}, |
||||
{ |
||||
"check": "deprecated-standards", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Deprecated standard detected @ tests/deprecated_calls.sol#7-10:\n\t- Usage of \"msg.gas\" should be replaced with \"gasleft()\"\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "expression", |
||||
"expression": "msg.gas == msg.value", |
||||
"source_mapping": { |
||||
"start": 258, |
||||
"length": 107, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/deprecated_calls.sol", |
||||
"filename_relative": "tests/deprecated_calls.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/deprecated_calls.sol", |
||||
"filename_short": "tests/deprecated_calls.sol", |
||||
"lines": [ |
||||
7, |
||||
8, |
||||
9, |
||||
10 |
||||
], |
||||
"starting_column": 9, |
||||
"ending_column": 10 |
||||
] |
||||
}, |
||||
{ |
||||
"check": "deprecated-standards", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Deprecated standard detected @ tests/deprecated_calls.sol#7-10:\n\t- Usage of \"msg.gas\" should be replaced with \"gasleft()\"\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "expression", |
||||
"expression": "msg.gas == msg.value", |
||||
"source_mapping": { |
||||
"start": 258, |
||||
"length": 107, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/deprecated_calls.sol", |
||||
"filename_relative": "tests/deprecated_calls.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/deprecated_calls.sol", |
||||
"filename_short": "tests/deprecated_calls.sol", |
||||
"lines": [ |
||||
7, |
||||
8, |
||||
9, |
||||
10 |
||||
], |
||||
"starting_column": 9, |
||||
"ending_column": 10 |
||||
} |
||||
} |
||||
} |
||||
] |
||||
}, |
||||
{ |
||||
"check": "deprecated-standards", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Deprecated standard detected @ tests/deprecated_calls.sol#9:\n\t- Usage of \"throw\" should be replaced with \"revert()\"\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "expression", |
||||
"expression": "None", |
||||
"source_mapping": { |
||||
"start": 349, |
||||
"length": 5, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/deprecated_calls.sol", |
||||
"filename_relative": "tests/deprecated_calls.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/deprecated_calls.sol", |
||||
"filename_short": "tests/deprecated_calls.sol", |
||||
"lines": [ |
||||
9 |
||||
], |
||||
"starting_column": 13, |
||||
"ending_column": 18 |
||||
] |
||||
}, |
||||
{ |
||||
"check": "deprecated-standards", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Deprecated standard detected @ tests/deprecated_calls.sol#9:\n\t- Usage of \"throw\" should be replaced with \"revert()\"\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "expression", |
||||
"expression": "None", |
||||
"source_mapping": { |
||||
"start": 349, |
||||
"length": 5, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/deprecated_calls.sol", |
||||
"filename_relative": "tests/deprecated_calls.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/deprecated_calls.sol", |
||||
"filename_short": "tests/deprecated_calls.sol", |
||||
"lines": [ |
||||
9 |
||||
], |
||||
"starting_column": 13, |
||||
"ending_column": 18 |
||||
} |
||||
} |
||||
} |
||||
] |
||||
}, |
||||
{ |
||||
"check": "deprecated-standards", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Deprecated standard detected @ tests/deprecated_calls.sol#16:\n\t- Usage of \"sha3()\" should be replaced with \"keccak256()\"\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "expression", |
||||
"expression": "sha3Result = sha3()(test deprecated sha3 usage)", |
||||
"source_mapping": { |
||||
"start": 542, |
||||
"length": 55, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/deprecated_calls.sol", |
||||
"filename_relative": "tests/deprecated_calls.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/deprecated_calls.sol", |
||||
"filename_short": "tests/deprecated_calls.sol", |
||||
"lines": [ |
||||
16 |
||||
], |
||||
"starting_column": 9, |
||||
"ending_column": 64 |
||||
] |
||||
}, |
||||
{ |
||||
"check": "deprecated-standards", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Deprecated standard detected @ tests/deprecated_calls.sol#16:\n\t- Usage of \"sha3()\" should be replaced with \"keccak256()\"\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "expression", |
||||
"expression": "sha3Result = sha3()(test deprecated sha3 usage)", |
||||
"source_mapping": { |
||||
"start": 542, |
||||
"length": 55, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/deprecated_calls.sol", |
||||
"filename_relative": "tests/deprecated_calls.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/deprecated_calls.sol", |
||||
"filename_short": "tests/deprecated_calls.sol", |
||||
"lines": [ |
||||
16 |
||||
], |
||||
"starting_column": 9, |
||||
"ending_column": 64 |
||||
} |
||||
} |
||||
} |
||||
] |
||||
}, |
||||
{ |
||||
"check": "deprecated-standards", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Deprecated standard detected @ tests/deprecated_calls.sol#19:\n\t- Usage of \"block.blockhash()\" should be replaced with \"blockhash()\"\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "expression", |
||||
"expression": "blockHashResult = block.blockhash(0)", |
||||
"source_mapping": { |
||||
"start": 671, |
||||
"length": 44, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/deprecated_calls.sol", |
||||
"filename_relative": "tests/deprecated_calls.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/deprecated_calls.sol", |
||||
"filename_short": "tests/deprecated_calls.sol", |
||||
"lines": [ |
||||
19 |
||||
], |
||||
"starting_column": 9, |
||||
"ending_column": 53 |
||||
] |
||||
}, |
||||
{ |
||||
"check": "deprecated-standards", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Deprecated standard detected @ tests/deprecated_calls.sol#19:\n\t- Usage of \"block.blockhash()\" should be replaced with \"blockhash()\"\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "expression", |
||||
"expression": "blockHashResult = block.blockhash(0)", |
||||
"source_mapping": { |
||||
"start": 671, |
||||
"length": 44, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/deprecated_calls.sol", |
||||
"filename_relative": "tests/deprecated_calls.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/deprecated_calls.sol", |
||||
"filename_short": "tests/deprecated_calls.sol", |
||||
"lines": [ |
||||
19 |
||||
], |
||||
"starting_column": 9, |
||||
"ending_column": 53 |
||||
} |
||||
} |
||||
} |
||||
] |
||||
}, |
||||
{ |
||||
"check": "deprecated-standards", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Deprecated standard detected @ tests/deprecated_calls.sol#22:\n\t- Usage of \"callcode\" should be replaced with \"delegatecall\"\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "expression", |
||||
"expression": "address(this).callcode()", |
||||
"source_mapping": { |
||||
"start": 785, |
||||
"length": 24, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/deprecated_calls.sol", |
||||
"filename_relative": "tests/deprecated_calls.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/deprecated_calls.sol", |
||||
"filename_short": "tests/deprecated_calls.sol", |
||||
"lines": [ |
||||
22 |
||||
], |
||||
"starting_column": 9, |
||||
"ending_column": 33 |
||||
] |
||||
}, |
||||
{ |
||||
"check": "deprecated-standards", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Deprecated standard detected @ tests/deprecated_calls.sol#22:\n\t- Usage of \"callcode\" should be replaced with \"delegatecall\"\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "expression", |
||||
"expression": "address(this).callcode()", |
||||
"source_mapping": { |
||||
"start": 785, |
||||
"length": 24, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/deprecated_calls.sol", |
||||
"filename_relative": "tests/deprecated_calls.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/deprecated_calls.sol", |
||||
"filename_short": "tests/deprecated_calls.sol", |
||||
"lines": [ |
||||
22 |
||||
], |
||||
"starting_column": 9, |
||||
"ending_column": 33 |
||||
} |
||||
} |
||||
} |
||||
] |
||||
}, |
||||
{ |
||||
"check": "deprecated-standards", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Deprecated standard detected @ tests/deprecated_calls.sol#25:\n\t- Usage of \"suicide()\" should be replaced with \"selfdestruct()\"\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "expression", |
||||
"expression": "suicide(address)(address(0))", |
||||
"source_mapping": { |
||||
"start": 878, |
||||
"length": 19, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/deprecated_calls.sol", |
||||
"filename_relative": "tests/deprecated_calls.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/deprecated_calls.sol", |
||||
"filename_short": "tests/deprecated_calls.sol", |
||||
"lines": [ |
||||
25 |
||||
], |
||||
"starting_column": 9, |
||||
"ending_column": 28 |
||||
] |
||||
}, |
||||
{ |
||||
"check": "deprecated-standards", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Deprecated standard detected @ tests/deprecated_calls.sol#25:\n\t- Usage of \"suicide()\" should be replaced with \"selfdestruct()\"\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "expression", |
||||
"expression": "suicide(address)(address(0))", |
||||
"source_mapping": { |
||||
"start": 878, |
||||
"length": 19, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/deprecated_calls.sol", |
||||
"filename_relative": "tests/deprecated_calls.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/deprecated_calls.sol", |
||||
"filename_short": "tests/deprecated_calls.sol", |
||||
"lines": [ |
||||
25 |
||||
], |
||||
"starting_column": 9, |
||||
"ending_column": 28 |
||||
} |
||||
} |
||||
} |
||||
] |
||||
} |
||||
] |
||||
] |
||||
} |
||||
] |
||||
} |
||||
@ -1,182 +1,186 @@ |
||||
[ |
||||
{ |
||||
"check": "erc20-indexed", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "IERC20Bad (tests/erc20_indexed.sol#12-21) does not mark important ERC20 parameters as 'indexed':\n\t-Transfer (tests/erc20_indexed.sol#19) does not index parameter 'from'\n\t-Transfer (tests/erc20_indexed.sol#19) does not index parameter 'to'\n\t-Approval (tests/erc20_indexed.sol#20) does not index parameter 'owner'\n\t-Approval (tests/erc20_indexed.sol#20) does not index parameter 'spender'\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "function", |
||||
"name": "Approval", |
||||
"source_mapping": { |
||||
"start": 1148, |
||||
"length": 59, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/erc20_indexed.sol", |
||||
"filename_relative": "tests/erc20_indexed.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/erc20_indexed.sol", |
||||
"filename_short": "tests/erc20_indexed.sol", |
||||
"lines": [ |
||||
20 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 64 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "IERC20Bad", |
||||
{ |
||||
"success": true, |
||||
"error": null, |
||||
"results": [ |
||||
{ |
||||
"check": "erc20-indexed", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "IERC20Bad (tests/erc20_indexed.sol#12-21) does not mark important ERC20 parameters as 'indexed':\n\t-Transfer (tests/erc20_indexed.sol#19) does not index parameter 'from'\n\t-Transfer (tests/erc20_indexed.sol#19) does not index parameter 'to'\n\t-Approval (tests/erc20_indexed.sol#20) does not index parameter 'owner'\n\t-Approval (tests/erc20_indexed.sol#20) does not index parameter 'spender'\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "function", |
||||
"name": "Approval", |
||||
"source_mapping": { |
||||
"start": 622, |
||||
"length": 587, |
||||
"start": 1148, |
||||
"length": 59, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/erc20_indexed.sol", |
||||
"filename_relative": "tests/erc20_indexed.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/erc20_indexed.sol", |
||||
"filename_short": "tests/erc20_indexed.sol", |
||||
"lines": [ |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16, |
||||
17, |
||||
18, |
||||
19, |
||||
20, |
||||
21 |
||||
20 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
"starting_column": 5, |
||||
"ending_column": 64 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "IERC20Bad", |
||||
"source_mapping": { |
||||
"start": 622, |
||||
"length": 587, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/erc20_indexed.sol", |
||||
"filename_relative": "tests/erc20_indexed.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/erc20_indexed.sol", |
||||
"filename_short": "tests/erc20_indexed.sol", |
||||
"lines": [ |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16, |
||||
17, |
||||
18, |
||||
19, |
||||
20, |
||||
21 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
} |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "function", |
||||
"name": "Approval", |
||||
"source_mapping": { |
||||
"start": 1148, |
||||
"length": 59, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/erc20_indexed.sol", |
||||
"filename_relative": "tests/erc20_indexed.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/erc20_indexed.sol", |
||||
"filename_short": "tests/erc20_indexed.sol", |
||||
"lines": [ |
||||
20 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 64 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "IERC20Bad", |
||||
{ |
||||
"type": "function", |
||||
"name": "Approval", |
||||
"source_mapping": { |
||||
"start": 622, |
||||
"length": 587, |
||||
"start": 1148, |
||||
"length": 59, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/erc20_indexed.sol", |
||||
"filename_relative": "tests/erc20_indexed.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/erc20_indexed.sol", |
||||
"filename_short": "tests/erc20_indexed.sol", |
||||
"lines": [ |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16, |
||||
17, |
||||
18, |
||||
19, |
||||
20, |
||||
21 |
||||
20 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
"starting_column": 5, |
||||
"ending_column": 64 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "IERC20Bad", |
||||
"source_mapping": { |
||||
"start": 622, |
||||
"length": 587, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/erc20_indexed.sol", |
||||
"filename_relative": "tests/erc20_indexed.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/erc20_indexed.sol", |
||||
"filename_short": "tests/erc20_indexed.sol", |
||||
"lines": [ |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16, |
||||
17, |
||||
18, |
||||
19, |
||||
20, |
||||
21 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
} |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "function", |
||||
"name": "Transfer", |
||||
"source_mapping": { |
||||
"start": 1090, |
||||
"length": 53, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/erc20_indexed.sol", |
||||
"filename_relative": "tests/erc20_indexed.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/erc20_indexed.sol", |
||||
"filename_short": "tests/erc20_indexed.sol", |
||||
"lines": [ |
||||
19 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 58 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "IERC20Bad", |
||||
{ |
||||
"type": "function", |
||||
"name": "Transfer", |
||||
"source_mapping": { |
||||
"start": 622, |
||||
"length": 587, |
||||
"start": 1090, |
||||
"length": 53, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/erc20_indexed.sol", |
||||
"filename_relative": "tests/erc20_indexed.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/erc20_indexed.sol", |
||||
"filename_short": "tests/erc20_indexed.sol", |
||||
"lines": [ |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16, |
||||
17, |
||||
18, |
||||
19, |
||||
20, |
||||
21 |
||||
19 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
"starting_column": 5, |
||||
"ending_column": 58 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "IERC20Bad", |
||||
"source_mapping": { |
||||
"start": 622, |
||||
"length": 587, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/erc20_indexed.sol", |
||||
"filename_relative": "tests/erc20_indexed.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/erc20_indexed.sol", |
||||
"filename_short": "tests/erc20_indexed.sol", |
||||
"lines": [ |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16, |
||||
17, |
||||
18, |
||||
19, |
||||
20, |
||||
21 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
} |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "function", |
||||
"name": "Transfer", |
||||
"source_mapping": { |
||||
"start": 1090, |
||||
"length": 53, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/erc20_indexed.sol", |
||||
"filename_relative": "tests/erc20_indexed.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/erc20_indexed.sol", |
||||
"filename_short": "tests/erc20_indexed.sol", |
||||
"lines": [ |
||||
19 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 58 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "IERC20Bad", |
||||
{ |
||||
"type": "function", |
||||
"name": "Transfer", |
||||
"source_mapping": { |
||||
"start": 622, |
||||
"length": 587, |
||||
"start": 1090, |
||||
"length": 53, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/erc20_indexed.sol", |
||||
"filename_relative": "tests/erc20_indexed.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/erc20_indexed.sol", |
||||
"filename_short": "tests/erc20_indexed.sol", |
||||
"lines": [ |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16, |
||||
17, |
||||
18, |
||||
19, |
||||
20, |
||||
21 |
||||
19 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
"starting_column": 5, |
||||
"ending_column": 58 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "IERC20Bad", |
||||
"source_mapping": { |
||||
"start": 622, |
||||
"length": 587, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/erc20_indexed.sol", |
||||
"filename_relative": "tests/erc20_indexed.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/erc20_indexed.sol", |
||||
"filename_short": "tests/erc20_indexed.sol", |
||||
"lines": [ |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16, |
||||
17, |
||||
18, |
||||
19, |
||||
20, |
||||
21 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
} |
||||
} |
||||
} |
||||
} |
||||
] |
||||
} |
||||
] |
||||
] |
||||
} |
||||
] |
||||
} |
||||
@ -1 +1,5 @@ |
||||
[] |
||||
{ |
||||
"success": true, |
||||
"error": null, |
||||
"results": [] |
||||
} |
||||
File diff suppressed because it is too large
Load Diff
@ -1,256 +1,260 @@ |
||||
[ |
||||
{ |
||||
"check": "erc20-interface", |
||||
"impact": "Medium", |
||||
"confidence": "High", |
||||
"description": "Token (tests/incorrect_erc20_interface.sol#3-10) has incorrect ERC20 function interface(s):\n\t-transfer (tests/incorrect_erc20_interface.sol#4)\n\t-approve (tests/incorrect_erc20_interface.sol#5)\n\t-transferFrom (tests/incorrect_erc20_interface.sol#6)\n\t-totalSupply (tests/incorrect_erc20_interface.sol#7)\n\t-balanceOf (tests/incorrect_erc20_interface.sol#8)\n\t-allowance (tests/incorrect_erc20_interface.sol#9)\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "function", |
||||
"name": "allowance", |
||||
"source_mapping": { |
||||
"start": 319, |
||||
"length": 60, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc20_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc20_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc20_interface.sol", |
||||
"filename_short": "tests/incorrect_erc20_interface.sol", |
||||
"lines": [ |
||||
9 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 65 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Token", |
||||
{ |
||||
"success": true, |
||||
"error": null, |
||||
"results": [ |
||||
{ |
||||
"check": "erc20-interface", |
||||
"impact": "Medium", |
||||
"confidence": "High", |
||||
"description": "Token (tests/incorrect_erc20_interface.sol#3-10) has incorrect ERC20 function interface(s):\n\t-transfer (tests/incorrect_erc20_interface.sol#4)\n\t-approve (tests/incorrect_erc20_interface.sol#5)\n\t-transferFrom (tests/incorrect_erc20_interface.sol#6)\n\t-totalSupply (tests/incorrect_erc20_interface.sol#7)\n\t-balanceOf (tests/incorrect_erc20_interface.sol#8)\n\t-allowance (tests/incorrect_erc20_interface.sol#9)\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "function", |
||||
"name": "allowance", |
||||
"source_mapping": { |
||||
"start": 26, |
||||
"length": 355, |
||||
"start": 319, |
||||
"length": 60, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc20_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc20_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc20_interface.sol", |
||||
"filename_short": "tests/incorrect_erc20_interface.sol", |
||||
"lines": [ |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10 |
||||
9 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
"starting_column": 5, |
||||
"ending_column": 65 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Token", |
||||
"source_mapping": { |
||||
"start": 26, |
||||
"length": 355, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc20_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc20_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc20_interface.sol", |
||||
"filename_short": "tests/incorrect_erc20_interface.sol", |
||||
"lines": [ |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
} |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "function", |
||||
"name": "approve", |
||||
"source_mapping": { |
||||
"start": 102, |
||||
"length": 55, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc20_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc20_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc20_interface.sol", |
||||
"filename_short": "tests/incorrect_erc20_interface.sol", |
||||
"lines": [ |
||||
5 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 60 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Token", |
||||
{ |
||||
"type": "function", |
||||
"name": "approve", |
||||
"source_mapping": { |
||||
"start": 26, |
||||
"length": 355, |
||||
"start": 102, |
||||
"length": 55, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc20_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc20_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc20_interface.sol", |
||||
"filename_short": "tests/incorrect_erc20_interface.sol", |
||||
"lines": [ |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10 |
||||
5 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
"starting_column": 5, |
||||
"ending_column": 60 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Token", |
||||
"source_mapping": { |
||||
"start": 26, |
||||
"length": 355, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc20_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc20_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc20_interface.sol", |
||||
"filename_short": "tests/incorrect_erc20_interface.sol", |
||||
"lines": [ |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
} |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "function", |
||||
"name": "balanceOf", |
||||
"source_mapping": { |
||||
"start": 273, |
||||
"length": 41, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc20_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc20_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc20_interface.sol", |
||||
"filename_short": "tests/incorrect_erc20_interface.sol", |
||||
"lines": [ |
||||
8 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 46 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Token", |
||||
{ |
||||
"type": "function", |
||||
"name": "balanceOf", |
||||
"source_mapping": { |
||||
"start": 26, |
||||
"length": 355, |
||||
"start": 273, |
||||
"length": 41, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc20_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc20_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc20_interface.sol", |
||||
"filename_short": "tests/incorrect_erc20_interface.sol", |
||||
"lines": [ |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10 |
||||
8 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
"starting_column": 5, |
||||
"ending_column": 46 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Token", |
||||
"source_mapping": { |
||||
"start": 26, |
||||
"length": 355, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc20_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc20_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc20_interface.sol", |
||||
"filename_short": "tests/incorrect_erc20_interface.sol", |
||||
"lines": [ |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
} |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "function", |
||||
"name": "totalSupply", |
||||
"source_mapping": { |
||||
"start": 236, |
||||
"length": 32, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc20_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc20_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc20_interface.sol", |
||||
"filename_short": "tests/incorrect_erc20_interface.sol", |
||||
"lines": [ |
||||
7 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 37 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Token", |
||||
{ |
||||
"type": "function", |
||||
"name": "totalSupply", |
||||
"source_mapping": { |
||||
"start": 26, |
||||
"length": 355, |
||||
"start": 236, |
||||
"length": 32, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc20_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc20_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc20_interface.sol", |
||||
"filename_short": "tests/incorrect_erc20_interface.sol", |
||||
"lines": [ |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10 |
||||
7 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
"starting_column": 5, |
||||
"ending_column": 37 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Token", |
||||
"source_mapping": { |
||||
"start": 26, |
||||
"length": 355, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc20_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc20_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc20_interface.sol", |
||||
"filename_short": "tests/incorrect_erc20_interface.sol", |
||||
"lines": [ |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
} |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "function", |
||||
"name": "transfer", |
||||
"source_mapping": { |
||||
"start": 46, |
||||
"length": 51, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc20_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc20_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc20_interface.sol", |
||||
"filename_short": "tests/incorrect_erc20_interface.sol", |
||||
"lines": [ |
||||
4 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 56 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Token", |
||||
{ |
||||
"type": "function", |
||||
"name": "transfer", |
||||
"source_mapping": { |
||||
"start": 26, |
||||
"length": 355, |
||||
"start": 46, |
||||
"length": 51, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc20_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc20_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc20_interface.sol", |
||||
"filename_short": "tests/incorrect_erc20_interface.sol", |
||||
"lines": [ |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10 |
||||
4 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
"starting_column": 5, |
||||
"ending_column": 56 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Token", |
||||
"source_mapping": { |
||||
"start": 26, |
||||
"length": 355, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc20_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc20_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc20_interface.sol", |
||||
"filename_short": "tests/incorrect_erc20_interface.sol", |
||||
"lines": [ |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
} |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "function", |
||||
"name": "transferFrom", |
||||
"source_mapping": { |
||||
"start": 162, |
||||
"length": 69, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc20_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc20_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc20_interface.sol", |
||||
"filename_short": "tests/incorrect_erc20_interface.sol", |
||||
"lines": [ |
||||
6 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 74 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Token", |
||||
{ |
||||
"type": "function", |
||||
"name": "transferFrom", |
||||
"source_mapping": { |
||||
"start": 26, |
||||
"length": 355, |
||||
"start": 162, |
||||
"length": 69, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc20_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc20_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc20_interface.sol", |
||||
"filename_short": "tests/incorrect_erc20_interface.sol", |
||||
"lines": [ |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10 |
||||
6 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
"starting_column": 5, |
||||
"ending_column": 74 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Token", |
||||
"source_mapping": { |
||||
"start": 26, |
||||
"length": 355, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc20_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc20_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc20_interface.sol", |
||||
"filename_short": "tests/incorrect_erc20_interface.sol", |
||||
"lines": [ |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
} |
||||
} |
||||
} |
||||
} |
||||
] |
||||
} |
||||
] |
||||
] |
||||
} |
||||
] |
||||
} |
||||
@ -1,442 +1,446 @@ |
||||
[ |
||||
{ |
||||
"check": "erc721-interface", |
||||
"impact": "Medium", |
||||
"confidence": "High", |
||||
"description": "Token (tests/incorrect_erc721_interface.sol#6-16) has incorrect ERC721 function interface(s):\n\t-supportsInterface (tests/incorrect_erc721_interface.sol#4)\n\t-balanceOf (tests/incorrect_erc721_interface.sol#7)\n\t-ownerOf (tests/incorrect_erc721_interface.sol#8)\n\t-safeTransferFrom (tests/incorrect_erc721_interface.sol#9)\n\t-safeTransferFrom (tests/incorrect_erc721_interface.sol#10)\n\t-transferFrom (tests/incorrect_erc721_interface.sol#11)\n\t-approve (tests/incorrect_erc721_interface.sol#12)\n\t-setApprovalForAll (tests/incorrect_erc721_interface.sol#13)\n\t-getApproved (tests/incorrect_erc721_interface.sol#14)\n\t-isApprovedForAll (tests/incorrect_erc721_interface.sol#15)\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "function", |
||||
"name": "approve", |
||||
"source_mapping": { |
||||
"start": 549, |
||||
"length": 78, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc721_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_short": "tests/incorrect_erc721_interface.sol", |
||||
"lines": [ |
||||
12 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 83 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Token", |
||||
{ |
||||
"success": true, |
||||
"error": null, |
||||
"results": [ |
||||
{ |
||||
"check": "erc721-interface", |
||||
"impact": "Medium", |
||||
"confidence": "High", |
||||
"description": "Token (tests/incorrect_erc721_interface.sol#6-16) has incorrect ERC721 function interface(s):\n\t-supportsInterface (tests/incorrect_erc721_interface.sol#4)\n\t-balanceOf (tests/incorrect_erc721_interface.sol#7)\n\t-ownerOf (tests/incorrect_erc721_interface.sol#8)\n\t-safeTransferFrom (tests/incorrect_erc721_interface.sol#9)\n\t-safeTransferFrom (tests/incorrect_erc721_interface.sol#10)\n\t-transferFrom (tests/incorrect_erc721_interface.sol#11)\n\t-approve (tests/incorrect_erc721_interface.sol#12)\n\t-setApprovalForAll (tests/incorrect_erc721_interface.sol#13)\n\t-getApproved (tests/incorrect_erc721_interface.sol#14)\n\t-isApprovedForAll (tests/incorrect_erc721_interface.sol#15)\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "function", |
||||
"name": "approve", |
||||
"source_mapping": { |
||||
"start": 109, |
||||
"length": 739, |
||||
"start": 549, |
||||
"length": 78, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc721_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_short": "tests/incorrect_erc721_interface.sol", |
||||
"lines": [ |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16 |
||||
12 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
"starting_column": 5, |
||||
"ending_column": 83 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Token", |
||||
"source_mapping": { |
||||
"start": 109, |
||||
"length": 739, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc721_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_short": "tests/incorrect_erc721_interface.sol", |
||||
"lines": [ |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
} |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "function", |
||||
"name": "balanceOf", |
||||
"source_mapping": { |
||||
"start": 140, |
||||
"length": 44, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc721_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_short": "tests/incorrect_erc721_interface.sol", |
||||
"lines": [ |
||||
7 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 49 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Token", |
||||
{ |
||||
"type": "function", |
||||
"name": "balanceOf", |
||||
"source_mapping": { |
||||
"start": 109, |
||||
"length": 739, |
||||
"start": 140, |
||||
"length": 44, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc721_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_short": "tests/incorrect_erc721_interface.sol", |
||||
"lines": [ |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16 |
||||
7 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
"starting_column": 5, |
||||
"ending_column": 49 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Token", |
||||
"source_mapping": { |
||||
"start": 109, |
||||
"length": 739, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc721_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_short": "tests/incorrect_erc721_interface.sol", |
||||
"lines": [ |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
} |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "function", |
||||
"name": "getApproved", |
||||
"source_mapping": { |
||||
"start": 723, |
||||
"length": 48, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc721_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_short": "tests/incorrect_erc721_interface.sol", |
||||
"lines": [ |
||||
14 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 53 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Token", |
||||
{ |
||||
"type": "function", |
||||
"name": "getApproved", |
||||
"source_mapping": { |
||||
"start": 109, |
||||
"length": 739, |
||||
"start": 723, |
||||
"length": 48, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc721_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_short": "tests/incorrect_erc721_interface.sol", |
||||
"lines": [ |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16 |
||||
14 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
"starting_column": 5, |
||||
"ending_column": 53 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Token", |
||||
"source_mapping": { |
||||
"start": 109, |
||||
"length": 739, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc721_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_short": "tests/incorrect_erc721_interface.sol", |
||||
"lines": [ |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
} |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "function", |
||||
"name": "isApprovedForAll", |
||||
"source_mapping": { |
||||
"start": 776, |
||||
"length": 70, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc721_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_short": "tests/incorrect_erc721_interface.sol", |
||||
"lines": [ |
||||
15 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 75 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Token", |
||||
{ |
||||
"type": "function", |
||||
"name": "isApprovedForAll", |
||||
"source_mapping": { |
||||
"start": 109, |
||||
"length": 739, |
||||
"start": 776, |
||||
"length": 70, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc721_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_short": "tests/incorrect_erc721_interface.sol", |
||||
"lines": [ |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16 |
||||
15 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
"starting_column": 5, |
||||
"ending_column": 75 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Token", |
||||
"source_mapping": { |
||||
"start": 109, |
||||
"length": 739, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc721_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_short": "tests/incorrect_erc721_interface.sol", |
||||
"lines": [ |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
} |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "function", |
||||
"name": "ownerOf", |
||||
"source_mapping": { |
||||
"start": 189, |
||||
"length": 44, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc721_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_short": "tests/incorrect_erc721_interface.sol", |
||||
"lines": [ |
||||
8 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 49 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Token", |
||||
{ |
||||
"type": "function", |
||||
"name": "ownerOf", |
||||
"source_mapping": { |
||||
"start": 109, |
||||
"length": 739, |
||||
"start": 189, |
||||
"length": 44, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc721_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_short": "tests/incorrect_erc721_interface.sol", |
||||
"lines": [ |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16 |
||||
8 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
"starting_column": 5, |
||||
"ending_column": 49 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Token", |
||||
"source_mapping": { |
||||
"start": 109, |
||||
"length": 739, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc721_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_short": "tests/incorrect_erc721_interface.sol", |
||||
"lines": [ |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
} |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "function", |
||||
"name": "safeTransferFrom", |
||||
"source_mapping": { |
||||
"start": 238, |
||||
"length": 108, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc721_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_short": "tests/incorrect_erc721_interface.sol", |
||||
"lines": [ |
||||
9 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 113 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Token", |
||||
{ |
||||
"type": "function", |
||||
"name": "safeTransferFrom", |
||||
"source_mapping": { |
||||
"start": 109, |
||||
"length": 739, |
||||
"start": 238, |
||||
"length": 108, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc721_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_short": "tests/incorrect_erc721_interface.sol", |
||||
"lines": [ |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16 |
||||
9 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
"starting_column": 5, |
||||
"ending_column": 113 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Token", |
||||
"source_mapping": { |
||||
"start": 109, |
||||
"length": 739, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc721_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_short": "tests/incorrect_erc721_interface.sol", |
||||
"lines": [ |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
} |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "function", |
||||
"name": "safeTransferFrom", |
||||
"source_mapping": { |
||||
"start": 351, |
||||
"length": 96, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc721_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_short": "tests/incorrect_erc721_interface.sol", |
||||
"lines": [ |
||||
10 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 101 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Token", |
||||
{ |
||||
"type": "function", |
||||
"name": "safeTransferFrom", |
||||
"source_mapping": { |
||||
"start": 109, |
||||
"length": 739, |
||||
"start": 351, |
||||
"length": 96, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc721_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_short": "tests/incorrect_erc721_interface.sol", |
||||
"lines": [ |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16 |
||||
10 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
"starting_column": 5, |
||||
"ending_column": 101 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Token", |
||||
"source_mapping": { |
||||
"start": 109, |
||||
"length": 739, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc721_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_short": "tests/incorrect_erc721_interface.sol", |
||||
"lines": [ |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
} |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "function", |
||||
"name": "setApprovalForAll", |
||||
"source_mapping": { |
||||
"start": 632, |
||||
"length": 86, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc721_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_short": "tests/incorrect_erc721_interface.sol", |
||||
"lines": [ |
||||
13 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 91 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Token", |
||||
{ |
||||
"type": "function", |
||||
"name": "setApprovalForAll", |
||||
"source_mapping": { |
||||
"start": 109, |
||||
"length": 739, |
||||
"start": 632, |
||||
"length": 86, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc721_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_short": "tests/incorrect_erc721_interface.sol", |
||||
"lines": [ |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16 |
||||
13 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
"starting_column": 5, |
||||
"ending_column": 91 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Token", |
||||
"source_mapping": { |
||||
"start": 109, |
||||
"length": 739, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc721_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_short": "tests/incorrect_erc721_interface.sol", |
||||
"lines": [ |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
} |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "function", |
||||
"name": "supportsInterface", |
||||
"source_mapping": { |
||||
"start": 50, |
||||
"length": 56, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc721_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_short": "tests/incorrect_erc721_interface.sol", |
||||
"lines": [ |
||||
4 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 61 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "IERC165", |
||||
{ |
||||
"type": "function", |
||||
"name": "supportsInterface", |
||||
"source_mapping": { |
||||
"start": 26, |
||||
"length": 82, |
||||
"start": 50, |
||||
"length": 56, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc721_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_short": "tests/incorrect_erc721_interface.sol", |
||||
"lines": [ |
||||
3, |
||||
4, |
||||
5 |
||||
4 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
"starting_column": 5, |
||||
"ending_column": 61 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "IERC165", |
||||
"source_mapping": { |
||||
"start": 26, |
||||
"length": 82, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc721_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_short": "tests/incorrect_erc721_interface.sol", |
||||
"lines": [ |
||||
3, |
||||
4, |
||||
5 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
} |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "function", |
||||
"name": "transferFrom", |
||||
"source_mapping": { |
||||
"start": 452, |
||||
"length": 92, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc721_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_short": "tests/incorrect_erc721_interface.sol", |
||||
"lines": [ |
||||
11 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 97 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Token", |
||||
{ |
||||
"type": "function", |
||||
"name": "transferFrom", |
||||
"source_mapping": { |
||||
"start": 109, |
||||
"length": 739, |
||||
"start": 452, |
||||
"length": 92, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc721_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_short": "tests/incorrect_erc721_interface.sol", |
||||
"lines": [ |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16 |
||||
11 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
"starting_column": 5, |
||||
"ending_column": 97 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Token", |
||||
"source_mapping": { |
||||
"start": 109, |
||||
"length": 739, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_relative": "tests/incorrect_erc721_interface.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/incorrect_erc721_interface.sol", |
||||
"filename_short": "tests/incorrect_erc721_interface.sol", |
||||
"lines": [ |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
} |
||||
} |
||||
} |
||||
} |
||||
] |
||||
} |
||||
] |
||||
] |
||||
} |
||||
] |
||||
} |
||||
@ -1,69 +1,73 @@ |
||||
[ |
||||
{ |
||||
"check": "locked-ether", |
||||
"impact": "Medium", |
||||
"confidence": "High", |
||||
"description": "Contract locking ether found in :\n\tContract OnlyLocked has payable functions:\n\t - receive (tests/locked_ether-0.5.1.sol#4-6)\n\tBut does not have a function to withdraw the ether\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "function", |
||||
"name": "receive", |
||||
"source_mapping": { |
||||
"start": 46, |
||||
"length": 72, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/locked_ether-0.5.1.sol", |
||||
"filename_relative": "tests/locked_ether-0.5.1.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/locked_ether-0.5.1.sol", |
||||
"filename_short": "tests/locked_ether-0.5.1.sol", |
||||
"lines": [ |
||||
4, |
||||
5, |
||||
6 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 6 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Locked", |
||||
{ |
||||
"success": true, |
||||
"error": null, |
||||
"results": [ |
||||
{ |
||||
"check": "locked-ether", |
||||
"impact": "Medium", |
||||
"confidence": "High", |
||||
"description": "Contract locking ether found in :\n\tContract OnlyLocked has payable functions:\n\t - receive (tests/locked_ether-0.5.1.sol#4-6)\n\tBut does not have a function to withdraw the ether\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "function", |
||||
"name": "receive", |
||||
"source_mapping": { |
||||
"start": 24, |
||||
"length": 97, |
||||
"start": 46, |
||||
"length": 72, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/locked_ether-0.5.1.sol", |
||||
"filename_relative": "tests/locked_ether-0.5.1.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/locked_ether-0.5.1.sol", |
||||
"filename_short": "tests/locked_ether-0.5.1.sol", |
||||
"lines": [ |
||||
2, |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8 |
||||
6 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 6 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Locked", |
||||
"source_mapping": { |
||||
"start": 24, |
||||
"length": 97, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/locked_ether-0.5.1.sol", |
||||
"filename_relative": "tests/locked_ether-0.5.1.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/locked_ether-0.5.1.sol", |
||||
"filename_short": "tests/locked_ether-0.5.1.sol", |
||||
"lines": [ |
||||
2, |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "contract", |
||||
"name": "OnlyLocked", |
||||
"source_mapping": { |
||||
"start": 375, |
||||
"length": 32, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/locked_ether-0.5.1.sol", |
||||
"filename_relative": "tests/locked_ether-0.5.1.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/locked_ether-0.5.1.sol", |
||||
"filename_short": "tests/locked_ether-0.5.1.sol", |
||||
"lines": [ |
||||
26 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
"ending_column": 33 |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "contract", |
||||
"name": "OnlyLocked", |
||||
"source_mapping": { |
||||
"start": 375, |
||||
"length": 32, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/locked_ether-0.5.1.sol", |
||||
"filename_relative": "tests/locked_ether-0.5.1.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/locked_ether-0.5.1.sol", |
||||
"filename_short": "tests/locked_ether-0.5.1.sol", |
||||
"lines": [ |
||||
26 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 33 |
||||
} |
||||
} |
||||
] |
||||
} |
||||
] |
||||
] |
||||
} |
||||
] |
||||
} |
||||
@ -1,69 +1,73 @@ |
||||
[ |
||||
{ |
||||
"check": "locked-ether", |
||||
"impact": "Medium", |
||||
"confidence": "High", |
||||
"description": "Contract locking ether found in :\n\tContract OnlyLocked has payable functions:\n\t - receive (tests/locked_ether.sol#4-6)\n\tBut does not have a function to withdraw the ether\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "function", |
||||
"name": "receive", |
||||
"source_mapping": { |
||||
"start": 47, |
||||
"length": 72, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/locked_ether.sol", |
||||
"filename_relative": "tests/locked_ether.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/locked_ether.sol", |
||||
"filename_short": "tests/locked_ether.sol", |
||||
"lines": [ |
||||
4, |
||||
5, |
||||
6 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 6 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Locked", |
||||
{ |
||||
"success": true, |
||||
"error": null, |
||||
"results": [ |
||||
{ |
||||
"check": "locked-ether", |
||||
"impact": "Medium", |
||||
"confidence": "High", |
||||
"description": "Contract locking ether found in :\n\tContract OnlyLocked has payable functions:\n\t - receive (tests/locked_ether.sol#4-6)\n\tBut does not have a function to withdraw the ether\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "function", |
||||
"name": "receive", |
||||
"source_mapping": { |
||||
"start": 25, |
||||
"length": 97, |
||||
"start": 47, |
||||
"length": 72, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/locked_ether.sol", |
||||
"filename_relative": "tests/locked_ether.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/locked_ether.sol", |
||||
"filename_short": "tests/locked_ether.sol", |
||||
"lines": [ |
||||
2, |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8 |
||||
6 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 6 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Locked", |
||||
"source_mapping": { |
||||
"start": 25, |
||||
"length": 97, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/locked_ether.sol", |
||||
"filename_relative": "tests/locked_ether.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/locked_ether.sol", |
||||
"filename_short": "tests/locked_ether.sol", |
||||
"lines": [ |
||||
2, |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "contract", |
||||
"name": "OnlyLocked", |
||||
"source_mapping": { |
||||
"start": 368, |
||||
"length": 32, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/locked_ether.sol", |
||||
"filename_relative": "tests/locked_ether.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/locked_ether.sol", |
||||
"filename_short": "tests/locked_ether.sol", |
||||
"lines": [ |
||||
26 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
"ending_column": 33 |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "contract", |
||||
"name": "OnlyLocked", |
||||
"source_mapping": { |
||||
"start": 368, |
||||
"length": 32, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/locked_ether.sol", |
||||
"filename_relative": "tests/locked_ether.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/locked_ether.sol", |
||||
"filename_short": "tests/locked_ether.sol", |
||||
"lines": [ |
||||
26 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 33 |
||||
} |
||||
} |
||||
] |
||||
} |
||||
] |
||||
] |
||||
} |
||||
] |
||||
} |
||||
@ -1,67 +1,71 @@ |
||||
[ |
||||
{ |
||||
"check": "low-level-calls", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Low level call in Sender.send (tests/low_level_calls.sol#5-7):\n\t-_receiver.call.value(msg.value).gas(7777)() tests/low_level_calls.sol#6\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "function", |
||||
"name": "send", |
||||
"source_mapping": { |
||||
"start": 51, |
||||
"length": 112, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/low_level_calls.sol", |
||||
"filename_relative": "tests/low_level_calls.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/low_level_calls.sol", |
||||
"filename_short": "tests/low_level_calls.sol", |
||||
"lines": [ |
||||
5, |
||||
6, |
||||
7 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 6 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Sender", |
||||
{ |
||||
"success": true, |
||||
"error": null, |
||||
"results": [ |
||||
{ |
||||
"check": "low-level-calls", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Low level call in Sender.send (tests/low_level_calls.sol#5-7):\n\t-_receiver.call.value(msg.value).gas(7777)() tests/low_level_calls.sol#6\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "function", |
||||
"name": "send", |
||||
"source_mapping": { |
||||
"start": 29, |
||||
"length": 136, |
||||
"start": 51, |
||||
"length": 112, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/low_level_calls.sol", |
||||
"filename_relative": "tests/low_level_calls.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/low_level_calls.sol", |
||||
"filename_short": "tests/low_level_calls.sol", |
||||
"lines": [ |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8 |
||||
7 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
"starting_column": 5, |
||||
"ending_column": 6 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "Sender", |
||||
"source_mapping": { |
||||
"start": 29, |
||||
"length": 136, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/low_level_calls.sol", |
||||
"filename_relative": "tests/low_level_calls.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/low_level_calls.sol", |
||||
"filename_short": "tests/low_level_calls.sol", |
||||
"lines": [ |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "expression", |
||||
"expression": "_receiver.call.value(msg.value).gas(7777)()", |
||||
"source_mapping": { |
||||
"start": 111, |
||||
"length": 45, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/low_level_calls.sol", |
||||
"filename_relative": "tests/low_level_calls.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/low_level_calls.sol", |
||||
"filename_short": "tests/low_level_calls.sol", |
||||
"lines": [ |
||||
6 |
||||
], |
||||
"starting_column": 9, |
||||
"ending_column": 54 |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "expression", |
||||
"expression": "_receiver.call.value(msg.value).gas(7777)()", |
||||
"source_mapping": { |
||||
"start": 111, |
||||
"length": 45, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/low_level_calls.sol", |
||||
"filename_relative": "tests/low_level_calls.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/low_level_calls.sol", |
||||
"filename_short": "tests/low_level_calls.sol", |
||||
"lines": [ |
||||
6 |
||||
], |
||||
"starting_column": 9, |
||||
"ending_column": 54 |
||||
} |
||||
} |
||||
] |
||||
} |
||||
] |
||||
] |
||||
} |
||||
] |
||||
} |
||||
@ -1,79 +1,83 @@ |
||||
[ |
||||
{ |
||||
"check": "calls-loop", |
||||
"impact": "Low", |
||||
"confidence": "Medium", |
||||
"description": "CallInLoop.bad has external calls inside a loop:\n\t- destinations[i].transfer(i) (tests/multiple_calls_in_loop.sol#11)\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "function", |
||||
"name": "bad", |
||||
"source_mapping": { |
||||
"start": 153, |
||||
"length": 135, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/multiple_calls_in_loop.sol", |
||||
"filename_relative": "tests/multiple_calls_in_loop.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/multiple_calls_in_loop.sol", |
||||
"filename_short": "tests/multiple_calls_in_loop.sol", |
||||
"lines": [ |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 6 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "CallInLoop", |
||||
{ |
||||
"success": true, |
||||
"error": null, |
||||
"results": [ |
||||
{ |
||||
"check": "calls-loop", |
||||
"impact": "Low", |
||||
"confidence": "Medium", |
||||
"description": "CallInLoop.bad has external calls inside a loop:\n\t- destinations[i].transfer(i) (tests/multiple_calls_in_loop.sol#11)\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "function", |
||||
"name": "bad", |
||||
"source_mapping": { |
||||
"start": 0, |
||||
"length": 291, |
||||
"start": 153, |
||||
"length": 135, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/multiple_calls_in_loop.sol", |
||||
"filename_relative": "tests/multiple_calls_in_loop.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/multiple_calls_in_loop.sol", |
||||
"filename_short": "tests/multiple_calls_in_loop.sol", |
||||
"lines": [ |
||||
1, |
||||
2, |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15 |
||||
13 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
"starting_column": 5, |
||||
"ending_column": 6 |
||||
}, |
||||
"contract": { |
||||
"type": "contract", |
||||
"name": "CallInLoop", |
||||
"source_mapping": { |
||||
"start": 0, |
||||
"length": 291, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/multiple_calls_in_loop.sol", |
||||
"filename_relative": "tests/multiple_calls_in_loop.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/multiple_calls_in_loop.sol", |
||||
"filename_short": "tests/multiple_calls_in_loop.sol", |
||||
"lines": [ |
||||
1, |
||||
2, |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "expression", |
||||
"expression": "destinations[i].transfer(i)", |
||||
"source_mapping": { |
||||
"start": 244, |
||||
"length": 27, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/multiple_calls_in_loop.sol", |
||||
"filename_relative": "tests/multiple_calls_in_loop.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/multiple_calls_in_loop.sol", |
||||
"filename_short": "tests/multiple_calls_in_loop.sol", |
||||
"lines": [ |
||||
11 |
||||
], |
||||
"starting_column": 13, |
||||
"ending_column": 40 |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "expression", |
||||
"expression": "destinations[i].transfer(i)", |
||||
"source_mapping": { |
||||
"start": 244, |
||||
"length": 27, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/multiple_calls_in_loop.sol", |
||||
"filename_relative": "tests/multiple_calls_in_loop.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/multiple_calls_in_loop.sol", |
||||
"filename_short": "tests/multiple_calls_in_loop.sol", |
||||
"lines": [ |
||||
11 |
||||
], |
||||
"starting_column": 13, |
||||
"ending_column": 40 |
||||
} |
||||
} |
||||
] |
||||
} |
||||
] |
||||
] |
||||
} |
||||
] |
||||
} |
||||
@ -1,366 +1,370 @@ |
||||
[ |
||||
{ |
||||
"check": "naming-convention", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Contract 'naming' (tests/naming_convention.sol#3-48) is not in CapWords\n", |
||||
"elements": [ |
||||
{ |
||||
"target": "contract", |
||||
"convention": "CapWords", |
||||
"name": "naming", |
||||
"source_mapping": { |
||||
"start": 28, |
||||
"length": 642, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_relative": "tests/naming_convention.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_short": "tests/naming_convention.sol", |
||||
"lines": [ |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16, |
||||
17, |
||||
18, |
||||
19, |
||||
20, |
||||
21, |
||||
22, |
||||
23, |
||||
24, |
||||
25, |
||||
26, |
||||
27, |
||||
28, |
||||
29, |
||||
30, |
||||
31, |
||||
32, |
||||
33, |
||||
34, |
||||
35, |
||||
36, |
||||
37, |
||||
38, |
||||
39, |
||||
40, |
||||
41, |
||||
42, |
||||
43, |
||||
44, |
||||
45, |
||||
46, |
||||
47, |
||||
48 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
{ |
||||
"success": true, |
||||
"error": null, |
||||
"results": [ |
||||
{ |
||||
"check": "naming-convention", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Contract 'naming' (tests/naming_convention.sol#3-48) is not in CapWords\n", |
||||
"elements": [ |
||||
{ |
||||
"target": "contract", |
||||
"convention": "CapWords", |
||||
"name": "naming", |
||||
"source_mapping": { |
||||
"start": 28, |
||||
"length": 642, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_relative": "tests/naming_convention.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_short": "tests/naming_convention.sol", |
||||
"lines": [ |
||||
3, |
||||
4, |
||||
5, |
||||
6, |
||||
7, |
||||
8, |
||||
9, |
||||
10, |
||||
11, |
||||
12, |
||||
13, |
||||
14, |
||||
15, |
||||
16, |
||||
17, |
||||
18, |
||||
19, |
||||
20, |
||||
21, |
||||
22, |
||||
23, |
||||
24, |
||||
25, |
||||
26, |
||||
27, |
||||
28, |
||||
29, |
||||
30, |
||||
31, |
||||
32, |
||||
33, |
||||
34, |
||||
35, |
||||
36, |
||||
37, |
||||
38, |
||||
39, |
||||
40, |
||||
41, |
||||
42, |
||||
43, |
||||
44, |
||||
45, |
||||
46, |
||||
47, |
||||
48 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 2 |
||||
} |
||||
} |
||||
} |
||||
] |
||||
}, |
||||
{ |
||||
"check": "naming-convention", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Struct 'naming.test' (tests/naming_convention.sol#14-16) is not in CapWords\n", |
||||
"elements": [ |
||||
{ |
||||
"target": "structure", |
||||
"convention": "CapWords", |
||||
"name": "test", |
||||
"source_mapping": { |
||||
"start": 229, |
||||
"length": 35, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_relative": "tests/naming_convention.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_short": "tests/naming_convention.sol", |
||||
"lines": [ |
||||
14, |
||||
15, |
||||
16 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 6 |
||||
] |
||||
}, |
||||
{ |
||||
"check": "naming-convention", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Struct 'naming.test' (tests/naming_convention.sol#14-16) is not in CapWords\n", |
||||
"elements": [ |
||||
{ |
||||
"target": "structure", |
||||
"convention": "CapWords", |
||||
"name": "test", |
||||
"source_mapping": { |
||||
"start": 229, |
||||
"length": 35, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_relative": "tests/naming_convention.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_short": "tests/naming_convention.sol", |
||||
"lines": [ |
||||
14, |
||||
15, |
||||
16 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 6 |
||||
} |
||||
} |
||||
} |
||||
] |
||||
}, |
||||
{ |
||||
"check": "naming-convention", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Event 'naming.event_' (tests/naming_convention.sol#23) is not in CapWords\n", |
||||
"elements": [ |
||||
{ |
||||
"target": "event", |
||||
"convention": "CapWords", |
||||
"name": "event_", |
||||
"source_mapping": { |
||||
"start": 335, |
||||
"length": 19, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_relative": "tests/naming_convention.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_short": "tests/naming_convention.sol", |
||||
"lines": [ |
||||
23 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 24 |
||||
] |
||||
}, |
||||
{ |
||||
"check": "naming-convention", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Event 'naming.event_' (tests/naming_convention.sol#23) is not in CapWords\n", |
||||
"elements": [ |
||||
{ |
||||
"target": "event", |
||||
"convention": "CapWords", |
||||
"name": "event_", |
||||
"source_mapping": { |
||||
"start": 335, |
||||
"length": 19, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_relative": "tests/naming_convention.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_short": "tests/naming_convention.sol", |
||||
"lines": [ |
||||
23 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 24 |
||||
} |
||||
} |
||||
} |
||||
] |
||||
}, |
||||
{ |
||||
"check": "naming-convention", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Function 'naming.GetOne' (tests/naming_convention.sol#30-33) is not in mixedCase\n", |
||||
"elements": [ |
||||
{ |
||||
"target": "function", |
||||
"convention": "mixedCase", |
||||
"name": "GetOne", |
||||
"source_mapping": { |
||||
"start": 440, |
||||
"length": 75, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_relative": "tests/naming_convention.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_short": "tests/naming_convention.sol", |
||||
"lines": [ |
||||
30, |
||||
31, |
||||
32, |
||||
33 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 6 |
||||
] |
||||
}, |
||||
{ |
||||
"check": "naming-convention", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Function 'naming.GetOne' (tests/naming_convention.sol#30-33) is not in mixedCase\n", |
||||
"elements": [ |
||||
{ |
||||
"target": "function", |
||||
"convention": "mixedCase", |
||||
"name": "GetOne", |
||||
"source_mapping": { |
||||
"start": 440, |
||||
"length": 75, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_relative": "tests/naming_convention.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_short": "tests/naming_convention.sol", |
||||
"lines": [ |
||||
30, |
||||
31, |
||||
32, |
||||
33 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 6 |
||||
} |
||||
} |
||||
} |
||||
] |
||||
}, |
||||
{ |
||||
"check": "naming-convention", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Parameter 'Number2' of naming.setInt (tests/naming_convention.sol#35) is not in mixedCase\n", |
||||
"elements": [ |
||||
{ |
||||
"target": "parameter", |
||||
"convention": "mixedCase", |
||||
"name": "Number2", |
||||
"source_mapping": { |
||||
"start": 551, |
||||
"length": 12, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_relative": "tests/naming_convention.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_short": "tests/naming_convention.sol", |
||||
"lines": [ |
||||
35 |
||||
], |
||||
"starting_column": 35, |
||||
"ending_column": 47 |
||||
] |
||||
}, |
||||
{ |
||||
"check": "naming-convention", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Parameter 'Number2' of naming.setInt (tests/naming_convention.sol#35) is not in mixedCase\n", |
||||
"elements": [ |
||||
{ |
||||
"target": "parameter", |
||||
"convention": "mixedCase", |
||||
"name": "Number2", |
||||
"source_mapping": { |
||||
"start": 551, |
||||
"length": 12, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_relative": "tests/naming_convention.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_short": "tests/naming_convention.sol", |
||||
"lines": [ |
||||
35 |
||||
], |
||||
"starting_column": 35, |
||||
"ending_column": 47 |
||||
} |
||||
} |
||||
} |
||||
] |
||||
}, |
||||
{ |
||||
"check": "naming-convention", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Constant 'naming.MY_other_CONSTANT' (tests/naming_convention.sol#9) is not in UPPER_CASE_WITH_UNDERSCORES\n", |
||||
"elements": [ |
||||
{ |
||||
"target": "variable_constant", |
||||
"convention": "UPPER_CASE_WITH_UNDERSCORES", |
||||
"name": "MY_other_CONSTANT", |
||||
"source_mapping": { |
||||
"start": 143, |
||||
"length": 35, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_relative": "tests/naming_convention.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_short": "tests/naming_convention.sol", |
||||
"lines": [ |
||||
9 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 40 |
||||
] |
||||
}, |
||||
{ |
||||
"check": "naming-convention", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Constant 'naming.MY_other_CONSTANT' (tests/naming_convention.sol#9) is not in UPPER_CASE_WITH_UNDERSCORES\n", |
||||
"elements": [ |
||||
{ |
||||
"target": "variable_constant", |
||||
"convention": "UPPER_CASE_WITH_UNDERSCORES", |
||||
"name": "MY_other_CONSTANT", |
||||
"source_mapping": { |
||||
"start": 143, |
||||
"length": 35, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_relative": "tests/naming_convention.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_short": "tests/naming_convention.sol", |
||||
"lines": [ |
||||
9 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 40 |
||||
} |
||||
} |
||||
} |
||||
] |
||||
}, |
||||
{ |
||||
"check": "naming-convention", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Variable 'naming.Var_One' (tests/naming_convention.sol#11) is not in mixedCase\n", |
||||
"elements": [ |
||||
{ |
||||
"target": "variable", |
||||
"convention": "mixedCase", |
||||
"name": "Var_One", |
||||
"source_mapping": { |
||||
"start": 185, |
||||
"length": 16, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_relative": "tests/naming_convention.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_short": "tests/naming_convention.sol", |
||||
"lines": [ |
||||
11 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 21 |
||||
] |
||||
}, |
||||
{ |
||||
"check": "naming-convention", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Variable 'naming.Var_One' (tests/naming_convention.sol#11) is not in mixedCase\n", |
||||
"elements": [ |
||||
{ |
||||
"target": "variable", |
||||
"convention": "mixedCase", |
||||
"name": "Var_One", |
||||
"source_mapping": { |
||||
"start": 185, |
||||
"length": 16, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_relative": "tests/naming_convention.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_short": "tests/naming_convention.sol", |
||||
"lines": [ |
||||
11 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 21 |
||||
} |
||||
} |
||||
} |
||||
] |
||||
}, |
||||
{ |
||||
"check": "naming-convention", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Enum 'naming.numbers' (tests/naming_convention.sol#6) is not in CapWords\n", |
||||
"elements": [ |
||||
{ |
||||
"target": "enum", |
||||
"convention": "CapWords", |
||||
"name": "numbers", |
||||
"source_mapping": { |
||||
"start": 79, |
||||
"length": 23, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_relative": "tests/naming_convention.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_short": "tests/naming_convention.sol", |
||||
"lines": [ |
||||
6 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 28 |
||||
] |
||||
}, |
||||
{ |
||||
"check": "naming-convention", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Enum 'naming.numbers' (tests/naming_convention.sol#6) is not in CapWords\n", |
||||
"elements": [ |
||||
{ |
||||
"target": "enum", |
||||
"convention": "CapWords", |
||||
"name": "numbers", |
||||
"source_mapping": { |
||||
"start": 79, |
||||
"length": 23, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_relative": "tests/naming_convention.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_short": "tests/naming_convention.sol", |
||||
"lines": [ |
||||
6 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 28 |
||||
} |
||||
} |
||||
} |
||||
] |
||||
}, |
||||
{ |
||||
"check": "naming-convention", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Modifier 'naming.CantDo' (tests/naming_convention.sol#41-43) is not in mixedCase\n", |
||||
"elements": [ |
||||
{ |
||||
"target": "modifier", |
||||
"convention": "mixedCase", |
||||
"name": "CantDo", |
||||
"source_mapping": { |
||||
"start": 591, |
||||
"length": 36, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_relative": "tests/naming_convention.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_short": "tests/naming_convention.sol", |
||||
"lines": [ |
||||
41, |
||||
42, |
||||
43 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 6 |
||||
] |
||||
}, |
||||
{ |
||||
"check": "naming-convention", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Modifier 'naming.CantDo' (tests/naming_convention.sol#41-43) is not in mixedCase\n", |
||||
"elements": [ |
||||
{ |
||||
"target": "modifier", |
||||
"convention": "mixedCase", |
||||
"name": "CantDo", |
||||
"source_mapping": { |
||||
"start": 591, |
||||
"length": 36, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_relative": "tests/naming_convention.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_short": "tests/naming_convention.sol", |
||||
"lines": [ |
||||
41, |
||||
42, |
||||
43 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 6 |
||||
} |
||||
} |
||||
} |
||||
] |
||||
}, |
||||
{ |
||||
"check": "naming-convention", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Parameter '_used' of T.test (tests/naming_convention.sol#59) is not in mixedCase\n", |
||||
"elements": [ |
||||
{ |
||||
"target": "parameter", |
||||
"convention": "mixedCase", |
||||
"name": "_used", |
||||
"source_mapping": { |
||||
"start": 794, |
||||
"length": 10, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_relative": "tests/naming_convention.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_short": "tests/naming_convention.sol", |
||||
"lines": [ |
||||
59 |
||||
], |
||||
"starting_column": 33, |
||||
"ending_column": 43 |
||||
] |
||||
}, |
||||
{ |
||||
"check": "naming-convention", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Parameter '_used' of T.test (tests/naming_convention.sol#59) is not in mixedCase\n", |
||||
"elements": [ |
||||
{ |
||||
"target": "parameter", |
||||
"convention": "mixedCase", |
||||
"name": "_used", |
||||
"source_mapping": { |
||||
"start": 794, |
||||
"length": 10, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_relative": "tests/naming_convention.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_short": "tests/naming_convention.sol", |
||||
"lines": [ |
||||
59 |
||||
], |
||||
"starting_column": 33, |
||||
"ending_column": 43 |
||||
} |
||||
} |
||||
} |
||||
] |
||||
}, |
||||
{ |
||||
"check": "naming-convention", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Variable 'T._myPublicVar' (tests/naming_convention.sol#56) is not in mixedCase\n", |
||||
"elements": [ |
||||
{ |
||||
"target": "variable", |
||||
"convention": "mixedCase", |
||||
"name": "_myPublicVar", |
||||
"source_mapping": { |
||||
"start": 741, |
||||
"length": 17, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_relative": "tests/naming_convention.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_short": "tests/naming_convention.sol", |
||||
"lines": [ |
||||
56 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 22 |
||||
] |
||||
}, |
||||
{ |
||||
"check": "naming-convention", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Variable 'T._myPublicVar' (tests/naming_convention.sol#56) is not in mixedCase\n", |
||||
"elements": [ |
||||
{ |
||||
"target": "variable", |
||||
"convention": "mixedCase", |
||||
"name": "_myPublicVar", |
||||
"source_mapping": { |
||||
"start": 741, |
||||
"length": 17, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_relative": "tests/naming_convention.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_short": "tests/naming_convention.sol", |
||||
"lines": [ |
||||
56 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 22 |
||||
} |
||||
} |
||||
} |
||||
] |
||||
}, |
||||
{ |
||||
"check": "naming-convention", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Variable 'T.l' (tests/naming_convention.sol#67) used l, O, I, which should not be used\n", |
||||
"elements": [ |
||||
{ |
||||
"target": "variable", |
||||
"convention": "l_O_I_should_not_be_used", |
||||
"name": "l", |
||||
"source_mapping": { |
||||
"start": 900, |
||||
"length": 10, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_relative": "tests/naming_convention.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_short": "tests/naming_convention.sol", |
||||
"lines": [ |
||||
67 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 15 |
||||
] |
||||
}, |
||||
{ |
||||
"check": "naming-convention", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Variable 'T.l' (tests/naming_convention.sol#67) used l, O, I, which should not be used\n", |
||||
"elements": [ |
||||
{ |
||||
"target": "variable", |
||||
"convention": "l_O_I_should_not_be_used", |
||||
"name": "l", |
||||
"source_mapping": { |
||||
"start": 900, |
||||
"length": 10, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_relative": "tests/naming_convention.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/naming_convention.sol", |
||||
"filename_short": "tests/naming_convention.sol", |
||||
"lines": [ |
||||
67 |
||||
], |
||||
"starting_column": 5, |
||||
"ending_column": 15 |
||||
} |
||||
} |
||||
} |
||||
] |
||||
} |
||||
] |
||||
] |
||||
} |
||||
] |
||||
} |
||||
@ -1,25 +1,29 @@ |
||||
[ |
||||
{ |
||||
"check": "solc-version", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Detected issues with version pragma in tests/old_solc.sol.json:\n\t- pragma solidity0.4.21 (None): it allows old versions\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "expression", |
||||
"expression": "0.4.21", |
||||
"source_mapping": { |
||||
"start": 0, |
||||
"length": 23, |
||||
"filename_used": "old_solc.sol", |
||||
"filename_relative": null, |
||||
"filename_absolute": null, |
||||
"filename_short": null, |
||||
"lines": [], |
||||
"starting_column": null, |
||||
"ending_column": null |
||||
{ |
||||
"success": true, |
||||
"error": null, |
||||
"results": [ |
||||
{ |
||||
"check": "solc-version", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Detected issues with version pragma in tests/old_solc.sol.json:\n\t- pragma solidity0.4.21 (None): it allows old versions\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "expression", |
||||
"expression": "0.4.21", |
||||
"source_mapping": { |
||||
"start": 0, |
||||
"length": 23, |
||||
"filename_used": "old_solc.sol", |
||||
"filename_relative": null, |
||||
"filename_absolute": null, |
||||
"filename_short": null, |
||||
"lines": [], |
||||
"starting_column": null, |
||||
"ending_column": null |
||||
} |
||||
} |
||||
} |
||||
] |
||||
} |
||||
] |
||||
] |
||||
} |
||||
] |
||||
} |
||||
@ -1,44 +1,48 @@ |
||||
[ |
||||
{ |
||||
"check": "pragma", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Different versions of Solidity is used in :\n\t- Version used: ['^0.4.23', '^0.4.24']\n\t- tests/pragma.0.4.23.sol#1 declares pragma solidity^0.4.23\n\t- tests/pragma.0.4.24.sol#1 declares pragma solidity^0.4.24\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "expression", |
||||
"expression": "^0.4.23", |
||||
"source_mapping": { |
||||
"start": 0, |
||||
"length": 24, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/pragma.0.4.23.sol", |
||||
"filename_relative": "tests/pragma.0.4.23.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/pragma.0.4.23.sol", |
||||
"filename_short": "tests/pragma.0.4.23.sol", |
||||
"lines": [ |
||||
1 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 25 |
||||
{ |
||||
"success": true, |
||||
"error": null, |
||||
"results": [ |
||||
{ |
||||
"check": "pragma", |
||||
"impact": "Informational", |
||||
"confidence": "High", |
||||
"description": "Different versions of Solidity is used in :\n\t- Version used: ['^0.4.23', '^0.4.24']\n\t- tests/pragma.0.4.23.sol#1 declares pragma solidity^0.4.23\n\t- tests/pragma.0.4.24.sol#1 declares pragma solidity^0.4.24\n", |
||||
"elements": [ |
||||
{ |
||||
"type": "expression", |
||||
"expression": "^0.4.23", |
||||
"source_mapping": { |
||||
"start": 0, |
||||
"length": 24, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/pragma.0.4.23.sol", |
||||
"filename_relative": "tests/pragma.0.4.23.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/pragma.0.4.23.sol", |
||||
"filename_short": "tests/pragma.0.4.23.sol", |
||||
"lines": [ |
||||
1 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 25 |
||||
} |
||||
}, |
||||
{ |
||||
"type": "expression", |
||||
"expression": "^0.4.24", |
||||
"source_mapping": { |
||||
"start": 0, |
||||
"length": 24, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/pragma.0.4.24.sol", |
||||
"filename_relative": "tests/pragma.0.4.24.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/pragma.0.4.24.sol", |
||||
"filename_short": "tests/pragma.0.4.24.sol", |
||||
"lines": [ |
||||
1 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 25 |
||||
} |
||||
} |
||||
}, |
||||
{ |
||||
"type": "expression", |
||||
"expression": "^0.4.24", |
||||
"source_mapping": { |
||||
"start": 0, |
||||
"length": 24, |
||||
"filename_used": "/home/travis/build/crytic/slither/tests/pragma.0.4.24.sol", |
||||
"filename_relative": "tests/pragma.0.4.24.sol", |
||||
"filename_absolute": "/home/travis/build/crytic/slither/tests/pragma.0.4.24.sol", |
||||
"filename_short": "tests/pragma.0.4.24.sol", |
||||
"lines": [ |
||||
1 |
||||
], |
||||
"starting_column": 1, |
||||
"ending_column": 25 |
||||
} |
||||
} |
||||
] |
||||
} |
||||
] |
||||
] |
||||
} |
||||
] |
||||
} |
||||
@ -1,10 +0,0 @@ |
||||
Traceback (most recent call last): |
||||
File "/home/monty/Envs/slither/bin/slither", line 11, in <module> |
||||
load_entry_point('slither-analyzer', 'console_scripts', 'slither')() |
||||
File "/home/monty/Private/tob/tools/slither-public/slither/__main__.py", line 469, in main |
||||
main_impl(all_detector_classes=detectors, all_printer_classes=printers) |
||||
File "/home/monty/Private/tob/tools/slither-public/slither/__main__.py", line 483, in main_impl |
||||
detector_classes = choose_detectors(args, all_detector_classes) |
||||
File "/home/monty/Private/tob/tools/slither-public/slither/__main__.py", line 176, in choose_detectors |
||||
raise Exception('Error: {} is not a detector'.format(d)) |
||||
Exception: Error: reentrancy is not a detector |
||||
Some files were not shown because too many files have changed in this diff Show More
Loading…
Reference in new issue