815 Commits (26cfe008d2ad89306d9f75a259e74652ccc51a8b)

Author	SHA1	Message	Date
Feist Josselin	538539ba9e	Add return-bomb detector	1 year ago
Feist Josselin	4d1d32b63f	Add tautological-compare	1 year ago
Feist Josselin	f7ab4a734f	Add incorrect-exp detector	1 year ago
Feist Josselin	700794971b	Release 2 new detectors	1 year ago
Kevin Clancy	cc9e65fe13	fix: reorder named arguments to match declaration order (#1949) ... Store names list in call operations and expressions. Reorder named arguments to match declaration order. A function call with explicitly named parameters, of the form f({argName1: arg1, ...}), may list the parameters in an order different from that of the function's declaration. In this case, the IR should reorder the arguments to match the function declaration order before generating IR. This PR implements named argument reordering for the following forms of function calls: - struct constructors (most important) - static internal calls For the following forms of function calls, the order of the declaration arguments is not directly available during IR generation, so the PR did not implement reordering for them: - external calls (HighLevelCall) - library calls - event calls The get_declared_param_names function returns None for these unimplemented call forms.	1 year ago
Simone	f50a126f2c	Improve custom error parsing with constants (#2115) ... * Improve custom error parsing with constants	1 year ago
alpharush	3147396cbf	fix(convert): do not convert array type to elementary for `InitArray` (#2018) ... fix(convert): do not convert array type to elementary for `InitArray`	1 year ago
Simone	8d5c033fbe	Improve mapping-deletion detector for nested mappings (#2084) ... * Fix for nested mappings * Add test	1 year ago
Simone	ddd9d6561f	Add IR test	1 year ago
Simone	8b07fe59d5	improve name resolution of type aliases (#2061) ... * BREAKING CHANGE: Renamed user_defined_types to type_aliases so it's less confusing with what we call UserDefinedType. * Added type aliased at the Contract level so now at the file scope there are only top level aliasing and fully qualified contract aliasing like C.myAlias. * Fix #1809	1 year ago
alpharush	53c97f9f48	fix: preserve None tuple components in the left and right liftings of ternary expressions (#2120) ... * preserve None tuple components in the left and right liftings of ternary expressions * added a test for ternary lifting over tuples --------- Co-authored-by: Kevin Clancy <kevin.clancy@certik.com>	1 year ago
Emilio López	9da51fff3b	detectors: cache_array_length: include source mapping in finding (#2076) ... * detectors: cache_array_length: include source mapping in finding The detector was manually string-interpolating the code and line information, which left the finding without source mapping metadata and broke filtering. Include the node directly on the finding info so that the metadata is preserved. --------- Co-authored-by: alpharush <0xalpharush@protonmail.com>	1 year ago
joodiewoodo	ff52901e6d	Allow underscore in variable naming convention for internal state variables (#2110) ... * fix: allow underscore in variable naming convention for internal state variables and update test_detector tests snapshot * change set visibility of _myPublic to public, update test snapshots	1 year ago
alpharush	404914cdfa	link issues for TODO comments, lint	1 year ago
alpharush	e8fa8b85fa	more cleanup	1 year ago
alpharush	239369c853	propagate return type on call to state variable with interface type	1 year ago
alpharush	e80238d8e9	add struct defs to file scope	1 year ago
alpharush	c21798021c	fix some lint warnings	1 year ago
alpharush	9df54e9c3a	update tests	1 year ago
alpharush	9c4bc505d3	handle break/continue	1 year ago
alpharush	16140f29c8	cleanup and formatting	1 year ago
alpharush	4845a3bd26	fix and refactor comparison operator, add support for raise	1 year ago
alpharush	81cb124e2d	support default args in calls	1 year ago
alpharush	e287b2f905	fix phi placement by calling SlitherCompilationUnit.add_function	1 year ago
alpharush	47e274c907	consider function unimplemented if body is only pass	1 year ago
alpharush	e561d33eb1	try removing trailing comment	1 year ago
alpharush	f7ef48401e	very simplistic support for reentrancy lock	1 year ago
alpharush	f9633ca67a	fix name resolution for shadowed state variable	1 year ago
alpharush	0efef8babf	add test for parsing and cfgir	1 year ago
alpharush	36c60a93b0	add failing phi test	1 year ago
alpharush	ae45f461e3	initial tests	1 year ago
alpharush	85e63c6ba5	rename fixture	1 year ago
alpharush	d90505826f	fix ternary rewrite test and make assertion more strict (#2067)	1 year ago
Simone	b4add6eb05	Fix enum.max/min when enum in other contract	1 year ago
alpharush	9ecc66ddf8	fix regression that caused retdata to be flagged	1 year ago
alpharush	5c40c52ba1	fix(cache-array-length): handle when `HighLevelCall` is a `StateVariable`	1 year ago
Simone	ace672e27d	Rename tests to run to ALL_TESTS	1 year ago
Simone	f2accfd77d	Add test	1 year ago
bossjoker1	e1febdd74e	Check the respective parameter's storage location for each argument	1 year ago
alpharush	1b5e2e9327	update detector tests to reflect event fmt	1 year ago
alpharush	96b103225f	fix merge/fmt	1 year ago
alpharush	068eee8341	add test	1 year ago
alpharush	cec07db510	feat: add `--unstructured` to slither-read-storage; retrieve custom storage layouts (#1963) ... Retrieve storage values of constant arguments passed to SLOAD. If a call to keccack is made, the expression is evaluated and treated as a constant. --------- Co-authored-by: webthethird <ratzbodell@gmail.com>	1 year ago
alpharush	8a5aab62c9	reduce false positives on modifying storage array by value detector (#1962) ... Check the respective parameter's storage location for each argument --------- Co-authored-by: bossjoker1 <1397157763@qq.com>	1 year ago
alpharush	7cb7cb94ad	inform user if inheritance cannot be resolved (#1956) ... * inform user if inheritance cannot be resolved * lint * update explanation	1 year ago
alpharush	fc9377d28c	fail if artifact does not existing (#1947)	1 year ago
Simone	adabce6180	Detect when ether is sent in Yul (#1909) ... * Detect when ether is sent in Yul * address pylint warning instead of supressing * fix guard clause * remove branch to appease pylint * check that call can send eth prior to reading args --------- Co-authored-by: alpharush <0xalpharush@protonmail.com>	2 years ago
alpharush	0c27b000aa	add support for prevrando (solc 0.8.18)	2 years ago
William E Bodell III	00461aad9a	slither-read-storage native POA support (#1843) ... * Native support for POA networks in read_storage * Set `srs.rpc` before `srs.block` * Type hint * New RpcInfo class w/ RpcInfo.web3 and RpcInfo.block In SlitherReadStorage, self.rpc_info: Optional[RpcInfo] replaces self.rpc, self._block, self._web3 * Black * Update test_read_storage.py * Add import in __init__.py * Avoid instantiating SRS twice * Add comment about `get_block` for POA networks * Pylint * Black * Allow other valid block string arguments ["latest", "earliest", "pending", "safe", "finalized"] * `args.block` can be in ["latest", "earliest", "pending", "safe", "finalized"] * Use BlockTag enum class for valid `str` arguments * Tweak `RpcInfo.__init__()` signature * get rid of `or "latest"` * Import BlockTag * Use `web3.types.BlockIdentifier` * Revert BlockTag enum * Pylint and black * Replace missing newline * Update slither/tools/read_storage/__main__.py Better, cleaner python Co-authored-by: alpharush <0xalpharush@protonmail.com> * Drop try/except around args.block parsing allow ValueError if user provides invalid block arg * Remove unused import --------- Co-authored-by: alpharush <0xalpharush@protonmail.com>	2 years ago
Feist Josselin	649e8d5e94	Minor python improvements	2 years ago