mirror of https://github.com/crytic/slither
You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
4627 lines
228 KiB
4627 lines
228 KiB
[
|
|
[
|
|
{
|
|
"elements": [
|
|
{
|
|
"type": "function",
|
|
"name": "bad0",
|
|
"source_mapping": {
|
|
"start": 119,
|
|
"length": 155,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ReentrancyBenign",
|
|
"source_mapping": {
|
|
"start": 28,
|
|
"length": 1353,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54,
|
|
55,
|
|
56,
|
|
57,
|
|
58,
|
|
59,
|
|
60,
|
|
61,
|
|
62,
|
|
63
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 0
|
|
}
|
|
},
|
|
"signature": "bad0()"
|
|
}
|
|
},
|
|
{
|
|
"type": "node",
|
|
"name": "(success) = msg.sender.call()",
|
|
"source_mapping": {
|
|
"start": 152,
|
|
"length": 37,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
8
|
|
],
|
|
"starting_column": 9,
|
|
"ending_column": 46
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "function",
|
|
"name": "bad0",
|
|
"source_mapping": {
|
|
"start": 119,
|
|
"length": 155,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ReentrancyBenign",
|
|
"source_mapping": {
|
|
"start": 28,
|
|
"length": 1353,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54,
|
|
55,
|
|
56,
|
|
57,
|
|
58,
|
|
59,
|
|
60,
|
|
61,
|
|
62,
|
|
63
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 0
|
|
}
|
|
},
|
|
"signature": "bad0()"
|
|
}
|
|
}
|
|
},
|
|
"additional_fields": {
|
|
"underlying_type": "external_calls"
|
|
}
|
|
},
|
|
{
|
|
"type": "node",
|
|
"name": "(success) = msg.sender.call()",
|
|
"source_mapping": {
|
|
"start": 152,
|
|
"length": 37,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
8
|
|
],
|
|
"starting_column": 9,
|
|
"ending_column": 46
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "function",
|
|
"name": "bad0",
|
|
"source_mapping": {
|
|
"start": 119,
|
|
"length": 155,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ReentrancyBenign",
|
|
"source_mapping": {
|
|
"start": 28,
|
|
"length": 1353,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54,
|
|
55,
|
|
56,
|
|
57,
|
|
58,
|
|
59,
|
|
60,
|
|
61,
|
|
62,
|
|
63
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 0
|
|
}
|
|
},
|
|
"signature": "bad0()"
|
|
}
|
|
}
|
|
},
|
|
"additional_fields": {
|
|
"underlying_type": "external_calls_sending_eth"
|
|
}
|
|
},
|
|
{
|
|
"type": "node",
|
|
"name": "counter += 1",
|
|
"source_mapping": {
|
|
"start": 255,
|
|
"length": 12,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
12
|
|
],
|
|
"starting_column": 9,
|
|
"ending_column": 21
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "function",
|
|
"name": "bad0",
|
|
"source_mapping": {
|
|
"start": 119,
|
|
"length": 155,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ReentrancyBenign",
|
|
"source_mapping": {
|
|
"start": 28,
|
|
"length": 1353,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54,
|
|
55,
|
|
56,
|
|
57,
|
|
58,
|
|
59,
|
|
60,
|
|
61,
|
|
62,
|
|
63
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 0
|
|
}
|
|
},
|
|
"signature": "bad0()"
|
|
}
|
|
}
|
|
},
|
|
"additional_fields": {
|
|
"underlying_type": "variables_written",
|
|
"variable_name": "counter"
|
|
}
|
|
}
|
|
],
|
|
"description": "Reentrancy in ReentrancyBenign.bad0() (tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#7-13):\n\tExternal calls:\n\t- (success) = msg.sender.call() (tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#8)\n\tState variables written after the call(s):\n\t- counter += 1 (tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#12)\n",
|
|
"markdown": "Reentrancy in [ReentrancyBenign.bad0()](tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#L7-L13):\n\tExternal calls:\n\t- [(success) = msg.sender.call()](tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#L8)\n\tState variables written after the call(s):\n\t- [counter += 1](tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#L12)\n",
|
|
"first_markdown_element": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#L7-L13",
|
|
"id": "b162165ec474792dc887b42c40e2d6ba28de0bde22bebdc2b5f63381bde85086",
|
|
"check": "reentrancy-benign",
|
|
"impact": "Low",
|
|
"confidence": "Medium"
|
|
},
|
|
{
|
|
"elements": [
|
|
{
|
|
"type": "function",
|
|
"name": "bad1",
|
|
"source_mapping": {
|
|
"start": 280,
|
|
"length": 135,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ReentrancyBenign",
|
|
"source_mapping": {
|
|
"start": 28,
|
|
"length": 1353,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54,
|
|
55,
|
|
56,
|
|
57,
|
|
58,
|
|
59,
|
|
60,
|
|
61,
|
|
62,
|
|
63
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 0
|
|
}
|
|
},
|
|
"signature": "bad1(address)"
|
|
}
|
|
},
|
|
{
|
|
"type": "node",
|
|
"name": "(success) = target.call()",
|
|
"source_mapping": {
|
|
"start": 327,
|
|
"length": 33,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
16
|
|
],
|
|
"starting_column": 9,
|
|
"ending_column": 42
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "function",
|
|
"name": "bad1",
|
|
"source_mapping": {
|
|
"start": 280,
|
|
"length": 135,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ReentrancyBenign",
|
|
"source_mapping": {
|
|
"start": 28,
|
|
"length": 1353,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54,
|
|
55,
|
|
56,
|
|
57,
|
|
58,
|
|
59,
|
|
60,
|
|
61,
|
|
62,
|
|
63
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 0
|
|
}
|
|
},
|
|
"signature": "bad1(address)"
|
|
}
|
|
}
|
|
},
|
|
"additional_fields": {
|
|
"underlying_type": "external_calls"
|
|
}
|
|
},
|
|
{
|
|
"type": "node",
|
|
"name": "(success) = target.call()",
|
|
"source_mapping": {
|
|
"start": 327,
|
|
"length": 33,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
16
|
|
],
|
|
"starting_column": 9,
|
|
"ending_column": 42
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "function",
|
|
"name": "bad1",
|
|
"source_mapping": {
|
|
"start": 280,
|
|
"length": 135,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ReentrancyBenign",
|
|
"source_mapping": {
|
|
"start": 28,
|
|
"length": 1353,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54,
|
|
55,
|
|
56,
|
|
57,
|
|
58,
|
|
59,
|
|
60,
|
|
61,
|
|
62,
|
|
63
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 0
|
|
}
|
|
},
|
|
"signature": "bad1(address)"
|
|
}
|
|
}
|
|
},
|
|
"additional_fields": {
|
|
"underlying_type": "external_calls_sending_eth"
|
|
}
|
|
},
|
|
{
|
|
"type": "node",
|
|
"name": "counter += 1",
|
|
"source_mapping": {
|
|
"start": 396,
|
|
"length": 12,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
18
|
|
],
|
|
"starting_column": 9,
|
|
"ending_column": 21
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "function",
|
|
"name": "bad1",
|
|
"source_mapping": {
|
|
"start": 280,
|
|
"length": 135,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ReentrancyBenign",
|
|
"source_mapping": {
|
|
"start": 28,
|
|
"length": 1353,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54,
|
|
55,
|
|
56,
|
|
57,
|
|
58,
|
|
59,
|
|
60,
|
|
61,
|
|
62,
|
|
63
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 0
|
|
}
|
|
},
|
|
"signature": "bad1(address)"
|
|
}
|
|
}
|
|
},
|
|
"additional_fields": {
|
|
"underlying_type": "variables_written",
|
|
"variable_name": "counter"
|
|
}
|
|
}
|
|
],
|
|
"description": "Reentrancy in ReentrancyBenign.bad1(address) (tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#15-19):\n\tExternal calls:\n\t- (success) = target.call() (tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#16)\n\tState variables written after the call(s):\n\t- counter += 1 (tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#18)\n",
|
|
"markdown": "Reentrancy in [ReentrancyBenign.bad1(address)](tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#L15-L19):\n\tExternal calls:\n\t- [(success) = target.call()](tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#L16)\n\tState variables written after the call(s):\n\t- [counter += 1](tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#L18)\n",
|
|
"first_markdown_element": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#L15-L19",
|
|
"id": "bc777bbc032af8fcb23146285a47012df0d4a7825596c3fc57a27e8758500dd2",
|
|
"check": "reentrancy-benign",
|
|
"impact": "Low",
|
|
"confidence": "Medium"
|
|
},
|
|
{
|
|
"elements": [
|
|
{
|
|
"type": "function",
|
|
"name": "bad2",
|
|
"source_mapping": {
|
|
"start": 421,
|
|
"length": 243,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ReentrancyBenign",
|
|
"source_mapping": {
|
|
"start": 28,
|
|
"length": 1353,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54,
|
|
55,
|
|
56,
|
|
57,
|
|
58,
|
|
59,
|
|
60,
|
|
61,
|
|
62,
|
|
63
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 0
|
|
}
|
|
},
|
|
"signature": "bad2(address)"
|
|
}
|
|
},
|
|
{
|
|
"type": "node",
|
|
"name": "(success) = target.call()",
|
|
"source_mapping": {
|
|
"start": 468,
|
|
"length": 33,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
22
|
|
],
|
|
"starting_column": 9,
|
|
"ending_column": 42
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "function",
|
|
"name": "bad2",
|
|
"source_mapping": {
|
|
"start": 421,
|
|
"length": 243,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ReentrancyBenign",
|
|
"source_mapping": {
|
|
"start": 28,
|
|
"length": 1353,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54,
|
|
55,
|
|
56,
|
|
57,
|
|
58,
|
|
59,
|
|
60,
|
|
61,
|
|
62,
|
|
63
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 0
|
|
}
|
|
},
|
|
"signature": "bad2(address)"
|
|
}
|
|
}
|
|
},
|
|
"additional_fields": {
|
|
"underlying_type": "external_calls"
|
|
}
|
|
},
|
|
{
|
|
"type": "node",
|
|
"name": "address(target).call{value: 1000}()",
|
|
"source_mapping": {
|
|
"start": 538,
|
|
"length": 36,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
24
|
|
],
|
|
"starting_column": 13,
|
|
"ending_column": 49
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "function",
|
|
"name": "bad2",
|
|
"source_mapping": {
|
|
"start": 421,
|
|
"length": 243,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ReentrancyBenign",
|
|
"source_mapping": {
|
|
"start": 28,
|
|
"length": 1353,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54,
|
|
55,
|
|
56,
|
|
57,
|
|
58,
|
|
59,
|
|
60,
|
|
61,
|
|
62,
|
|
63
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 0
|
|
}
|
|
},
|
|
"signature": "bad2(address)"
|
|
}
|
|
}
|
|
},
|
|
"additional_fields": {
|
|
"underlying_type": "external_calls"
|
|
}
|
|
},
|
|
{
|
|
"type": "node",
|
|
"name": "(success) = target.call()",
|
|
"source_mapping": {
|
|
"start": 468,
|
|
"length": 33,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
22
|
|
],
|
|
"starting_column": 9,
|
|
"ending_column": 42
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "function",
|
|
"name": "bad2",
|
|
"source_mapping": {
|
|
"start": 421,
|
|
"length": 243,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ReentrancyBenign",
|
|
"source_mapping": {
|
|
"start": 28,
|
|
"length": 1353,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54,
|
|
55,
|
|
56,
|
|
57,
|
|
58,
|
|
59,
|
|
60,
|
|
61,
|
|
62,
|
|
63
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 0
|
|
}
|
|
},
|
|
"signature": "bad2(address)"
|
|
}
|
|
}
|
|
},
|
|
"additional_fields": {
|
|
"underlying_type": "external_calls_sending_eth"
|
|
}
|
|
},
|
|
{
|
|
"type": "node",
|
|
"name": "address(target).call{value: 1000}()",
|
|
"source_mapping": {
|
|
"start": 538,
|
|
"length": 36,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
24
|
|
],
|
|
"starting_column": 13,
|
|
"ending_column": 49
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "function",
|
|
"name": "bad2",
|
|
"source_mapping": {
|
|
"start": 421,
|
|
"length": 243,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ReentrancyBenign",
|
|
"source_mapping": {
|
|
"start": 28,
|
|
"length": 1353,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54,
|
|
55,
|
|
56,
|
|
57,
|
|
58,
|
|
59,
|
|
60,
|
|
61,
|
|
62,
|
|
63
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 0
|
|
}
|
|
},
|
|
"signature": "bad2(address)"
|
|
}
|
|
}
|
|
},
|
|
"additional_fields": {
|
|
"underlying_type": "external_calls_sending_eth"
|
|
}
|
|
},
|
|
{
|
|
"type": "node",
|
|
"name": "counter += 1",
|
|
"source_mapping": {
|
|
"start": 588,
|
|
"length": 12,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
25
|
|
],
|
|
"starting_column": 13,
|
|
"ending_column": 25
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "function",
|
|
"name": "bad2",
|
|
"source_mapping": {
|
|
"start": 421,
|
|
"length": 243,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ReentrancyBenign",
|
|
"source_mapping": {
|
|
"start": 28,
|
|
"length": 1353,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54,
|
|
55,
|
|
56,
|
|
57,
|
|
58,
|
|
59,
|
|
60,
|
|
61,
|
|
62,
|
|
63
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 0
|
|
}
|
|
},
|
|
"signature": "bad2(address)"
|
|
}
|
|
}
|
|
},
|
|
"additional_fields": {
|
|
"underlying_type": "variables_written",
|
|
"variable_name": "counter"
|
|
}
|
|
}
|
|
],
|
|
"description": "Reentrancy in ReentrancyBenign.bad2(address) (tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#21-30):\n\tExternal calls:\n\t- (success) = target.call() (tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#22)\n\t- address(target).call{value: 1000}() (tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#24)\n\tExternal calls sending eth:\n\t- address(target).call{value: 1000}() (tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#24)\n\tState variables written after the call(s):\n\t- counter += 1 (tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#25)\n",
|
|
"markdown": "Reentrancy in [ReentrancyBenign.bad2(address)](tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#L21-L30):\n\tExternal calls:\n\t- [(success) = target.call()](tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#L22)\n\t- [address(target).call{value: 1000}()](tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#L24)\n\tExternal calls sending eth:\n\t- [address(target).call{value: 1000}()](tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#L24)\n\tState variables written after the call(s):\n\t- [counter += 1](tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#L25)\n",
|
|
"first_markdown_element": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#L21-L30",
|
|
"id": "79c88ecb3f548fa798f9c5cbb0e3658e78510fbd1cbae4455df47ba39a6fa505",
|
|
"check": "reentrancy-benign",
|
|
"impact": "Low",
|
|
"confidence": "Medium"
|
|
},
|
|
{
|
|
"elements": [
|
|
{
|
|
"type": "function",
|
|
"name": "bad3",
|
|
"source_mapping": {
|
|
"start": 670,
|
|
"length": 125,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ReentrancyBenign",
|
|
"source_mapping": {
|
|
"start": 28,
|
|
"length": 1353,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54,
|
|
55,
|
|
56,
|
|
57,
|
|
58,
|
|
59,
|
|
60,
|
|
61,
|
|
62,
|
|
63
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 0
|
|
}
|
|
},
|
|
"signature": "bad3(address)"
|
|
}
|
|
},
|
|
{
|
|
"type": "node",
|
|
"name": "externalCaller(target)",
|
|
"source_mapping": {
|
|
"start": 717,
|
|
"length": 22,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
33
|
|
],
|
|
"starting_column": 9,
|
|
"ending_column": 31
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "function",
|
|
"name": "bad3",
|
|
"source_mapping": {
|
|
"start": 670,
|
|
"length": 125,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ReentrancyBenign",
|
|
"source_mapping": {
|
|
"start": 28,
|
|
"length": 1353,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54,
|
|
55,
|
|
56,
|
|
57,
|
|
58,
|
|
59,
|
|
60,
|
|
61,
|
|
62,
|
|
63
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 0
|
|
}
|
|
},
|
|
"signature": "bad3(address)"
|
|
}
|
|
}
|
|
},
|
|
"additional_fields": {
|
|
"underlying_type": "external_calls"
|
|
}
|
|
},
|
|
{
|
|
"type": "node",
|
|
"name": "address(target).call()",
|
|
"source_mapping": {
|
|
"start": 1171,
|
|
"length": 24,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
52
|
|
],
|
|
"starting_column": 9,
|
|
"ending_column": 33
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "function",
|
|
"name": "externalCaller",
|
|
"source_mapping": {
|
|
"start": 1113,
|
|
"length": 89,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
51,
|
|
52,
|
|
53
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ReentrancyBenign",
|
|
"source_mapping": {
|
|
"start": 28,
|
|
"length": 1353,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54,
|
|
55,
|
|
56,
|
|
57,
|
|
58,
|
|
59,
|
|
60,
|
|
61,
|
|
62,
|
|
63
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 0
|
|
}
|
|
},
|
|
"signature": "externalCaller(address)"
|
|
}
|
|
}
|
|
},
|
|
"additional_fields": {
|
|
"underlying_type": "external_calls_sending_eth"
|
|
}
|
|
},
|
|
{
|
|
"type": "node",
|
|
"name": "externalCaller(target)",
|
|
"source_mapping": {
|
|
"start": 717,
|
|
"length": 22,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
33
|
|
],
|
|
"starting_column": 9,
|
|
"ending_column": 31
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "function",
|
|
"name": "bad3",
|
|
"source_mapping": {
|
|
"start": 670,
|
|
"length": 125,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ReentrancyBenign",
|
|
"source_mapping": {
|
|
"start": 28,
|
|
"length": 1353,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54,
|
|
55,
|
|
56,
|
|
57,
|
|
58,
|
|
59,
|
|
60,
|
|
61,
|
|
62,
|
|
63
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 0
|
|
}
|
|
},
|
|
"signature": "bad3(address)"
|
|
}
|
|
}
|
|
},
|
|
"additional_fields": {
|
|
"underlying_type": "external_calls_sending_eth"
|
|
}
|
|
},
|
|
{
|
|
"type": "node",
|
|
"name": "address(target).call()",
|
|
"source_mapping": {
|
|
"start": 1171,
|
|
"length": 24,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
52
|
|
],
|
|
"starting_column": 9,
|
|
"ending_column": 33
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "function",
|
|
"name": "externalCaller",
|
|
"source_mapping": {
|
|
"start": 1113,
|
|
"length": 89,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
51,
|
|
52,
|
|
53
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ReentrancyBenign",
|
|
"source_mapping": {
|
|
"start": 28,
|
|
"length": 1353,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54,
|
|
55,
|
|
56,
|
|
57,
|
|
58,
|
|
59,
|
|
60,
|
|
61,
|
|
62,
|
|
63
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 0
|
|
}
|
|
},
|
|
"signature": "externalCaller(address)"
|
|
}
|
|
}
|
|
},
|
|
"additional_fields": {
|
|
"underlying_type": "external_calls_sending_eth"
|
|
}
|
|
},
|
|
{
|
|
"type": "node",
|
|
"name": "varChanger()",
|
|
"source_mapping": {
|
|
"start": 749,
|
|
"length": 12,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
34
|
|
],
|
|
"starting_column": 9,
|
|
"ending_column": 21
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "function",
|
|
"name": "bad3",
|
|
"source_mapping": {
|
|
"start": 670,
|
|
"length": 125,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ReentrancyBenign",
|
|
"source_mapping": {
|
|
"start": 28,
|
|
"length": 1353,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54,
|
|
55,
|
|
56,
|
|
57,
|
|
58,
|
|
59,
|
|
60,
|
|
61,
|
|
62,
|
|
63
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 0
|
|
}
|
|
},
|
|
"signature": "bad3(address)"
|
|
}
|
|
}
|
|
},
|
|
"additional_fields": {
|
|
"underlying_type": "variables_written",
|
|
"variable_name": "anotherVariableToChange"
|
|
}
|
|
},
|
|
{
|
|
"type": "node",
|
|
"name": "anotherVariableToChange ++",
|
|
"source_mapping": {
|
|
"start": 1347,
|
|
"length": 25,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
60
|
|
],
|
|
"starting_column": 9,
|
|
"ending_column": 34
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "function",
|
|
"name": "varChanger",
|
|
"source_mapping": {
|
|
"start": 1307,
|
|
"length": 72,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
59,
|
|
60,
|
|
61
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ReentrancyBenign",
|
|
"source_mapping": {
|
|
"start": 28,
|
|
"length": 1353,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54,
|
|
55,
|
|
56,
|
|
57,
|
|
58,
|
|
59,
|
|
60,
|
|
61,
|
|
62,
|
|
63
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 0
|
|
}
|
|
},
|
|
"signature": "varChanger()"
|
|
}
|
|
}
|
|
},
|
|
"additional_fields": {
|
|
"underlying_type": "variables_written",
|
|
"variable_name": "anotherVariableToChange"
|
|
}
|
|
}
|
|
],
|
|
"description": "Reentrancy in ReentrancyBenign.bad3(address) (tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#32-36):\n\tExternal calls:\n\t- externalCaller(target) (tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#33)\n\t\t- address(target).call() (tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#52)\n\tState variables written after the call(s):\n\t- varChanger() (tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#34)\n\t\t- anotherVariableToChange ++ (tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#60)\n",
|
|
"markdown": "Reentrancy in [ReentrancyBenign.bad3(address)](tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#L32-L36):\n\tExternal calls:\n\t- [externalCaller(target)](tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#L33)\n\t\t- [address(target).call()](tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#L52)\n\tState variables written after the call(s):\n\t- [varChanger()](tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#L34)\n\t\t- [anotherVariableToChange ++](tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#L60)\n",
|
|
"first_markdown_element": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#L32-L36",
|
|
"id": "d8315c27e619d086ab8ec4206250374daad8449de43d0eb685dc2cb38376e6e3",
|
|
"check": "reentrancy-benign",
|
|
"impact": "Low",
|
|
"confidence": "Medium"
|
|
},
|
|
{
|
|
"elements": [
|
|
{
|
|
"type": "function",
|
|
"name": "bad4",
|
|
"source_mapping": {
|
|
"start": 801,
|
|
"length": 172,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ReentrancyBenign",
|
|
"source_mapping": {
|
|
"start": 28,
|
|
"length": 1353,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54,
|
|
55,
|
|
56,
|
|
57,
|
|
58,
|
|
59,
|
|
60,
|
|
61,
|
|
62,
|
|
63
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 0
|
|
}
|
|
},
|
|
"signature": "bad4(address)"
|
|
}
|
|
},
|
|
{
|
|
"type": "node",
|
|
"name": "externalCaller(target)",
|
|
"source_mapping": {
|
|
"start": 848,
|
|
"length": 22,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
39
|
|
],
|
|
"starting_column": 9,
|
|
"ending_column": 31
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "function",
|
|
"name": "bad4",
|
|
"source_mapping": {
|
|
"start": 801,
|
|
"length": 172,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ReentrancyBenign",
|
|
"source_mapping": {
|
|
"start": 28,
|
|
"length": 1353,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54,
|
|
55,
|
|
56,
|
|
57,
|
|
58,
|
|
59,
|
|
60,
|
|
61,
|
|
62,
|
|
63
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 0
|
|
}
|
|
},
|
|
"signature": "bad4(address)"
|
|
}
|
|
}
|
|
},
|
|
"additional_fields": {
|
|
"underlying_type": "external_calls"
|
|
}
|
|
},
|
|
{
|
|
"type": "node",
|
|
"name": "address(target).call()",
|
|
"source_mapping": {
|
|
"start": 1171,
|
|
"length": 24,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
52
|
|
],
|
|
"starting_column": 9,
|
|
"ending_column": 33
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "function",
|
|
"name": "externalCaller",
|
|
"source_mapping": {
|
|
"start": 1113,
|
|
"length": 89,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
51,
|
|
52,
|
|
53
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ReentrancyBenign",
|
|
"source_mapping": {
|
|
"start": 28,
|
|
"length": 1353,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54,
|
|
55,
|
|
56,
|
|
57,
|
|
58,
|
|
59,
|
|
60,
|
|
61,
|
|
62,
|
|
63
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 0
|
|
}
|
|
},
|
|
"signature": "externalCaller(address)"
|
|
}
|
|
}
|
|
},
|
|
"additional_fields": {
|
|
"underlying_type": "external_calls_sending_eth"
|
|
}
|
|
},
|
|
{
|
|
"type": "node",
|
|
"name": "ethSender(address(0))",
|
|
"source_mapping": {
|
|
"start": 880,
|
|
"length": 21,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
40
|
|
],
|
|
"starting_column": 9,
|
|
"ending_column": 30
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "function",
|
|
"name": "bad4",
|
|
"source_mapping": {
|
|
"start": 801,
|
|
"length": 172,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ReentrancyBenign",
|
|
"source_mapping": {
|
|
"start": 28,
|
|
"length": 1353,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54,
|
|
55,
|
|
56,
|
|
57,
|
|
58,
|
|
59,
|
|
60,
|
|
61,
|
|
62,
|
|
63
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 0
|
|
}
|
|
},
|
|
"signature": "bad4(address)"
|
|
}
|
|
}
|
|
},
|
|
"additional_fields": {
|
|
"underlying_type": "external_calls"
|
|
}
|
|
},
|
|
{
|
|
"type": "node",
|
|
"name": "address(target).call{value: 1}()",
|
|
"source_mapping": {
|
|
"start": 1261,
|
|
"length": 33,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
56
|
|
],
|
|
"starting_column": 9,
|
|
"ending_column": 42
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "function",
|
|
"name": "ethSender",
|
|
"source_mapping": {
|
|
"start": 1208,
|
|
"length": 93,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
55,
|
|
56,
|
|
57
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ReentrancyBenign",
|
|
"source_mapping": {
|
|
"start": 28,
|
|
"length": 1353,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54,
|
|
55,
|
|
56,
|
|
57,
|
|
58,
|
|
59,
|
|
60,
|
|
61,
|
|
62,
|
|
63
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 0
|
|
}
|
|
},
|
|
"signature": "ethSender(address)"
|
|
}
|
|
}
|
|
},
|
|
"additional_fields": {
|
|
"underlying_type": "external_calls_sending_eth"
|
|
}
|
|
},
|
|
{
|
|
"type": "node",
|
|
"name": "externalCaller(target)",
|
|
"source_mapping": {
|
|
"start": 848,
|
|
"length": 22,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
39
|
|
],
|
|
"starting_column": 9,
|
|
"ending_column": 31
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "function",
|
|
"name": "bad4",
|
|
"source_mapping": {
|
|
"start": 801,
|
|
"length": 172,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ReentrancyBenign",
|
|
"source_mapping": {
|
|
"start": 28,
|
|
"length": 1353,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54,
|
|
55,
|
|
56,
|
|
57,
|
|
58,
|
|
59,
|
|
60,
|
|
61,
|
|
62,
|
|
63
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 0
|
|
}
|
|
},
|
|
"signature": "bad4(address)"
|
|
}
|
|
}
|
|
},
|
|
"additional_fields": {
|
|
"underlying_type": "external_calls_sending_eth"
|
|
}
|
|
},
|
|
{
|
|
"type": "node",
|
|
"name": "address(target).call()",
|
|
"source_mapping": {
|
|
"start": 1171,
|
|
"length": 24,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
52
|
|
],
|
|
"starting_column": 9,
|
|
"ending_column": 33
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "function",
|
|
"name": "externalCaller",
|
|
"source_mapping": {
|
|
"start": 1113,
|
|
"length": 89,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
51,
|
|
52,
|
|
53
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ReentrancyBenign",
|
|
"source_mapping": {
|
|
"start": 28,
|
|
"length": 1353,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54,
|
|
55,
|
|
56,
|
|
57,
|
|
58,
|
|
59,
|
|
60,
|
|
61,
|
|
62,
|
|
63
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 0
|
|
}
|
|
},
|
|
"signature": "externalCaller(address)"
|
|
}
|
|
}
|
|
},
|
|
"additional_fields": {
|
|
"underlying_type": "external_calls_sending_eth"
|
|
}
|
|
},
|
|
{
|
|
"type": "node",
|
|
"name": "ethSender(address(0))",
|
|
"source_mapping": {
|
|
"start": 880,
|
|
"length": 21,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
40
|
|
],
|
|
"starting_column": 9,
|
|
"ending_column": 30
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "function",
|
|
"name": "bad4",
|
|
"source_mapping": {
|
|
"start": 801,
|
|
"length": 172,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ReentrancyBenign",
|
|
"source_mapping": {
|
|
"start": 28,
|
|
"length": 1353,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54,
|
|
55,
|
|
56,
|
|
57,
|
|
58,
|
|
59,
|
|
60,
|
|
61,
|
|
62,
|
|
63
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 0
|
|
}
|
|
},
|
|
"signature": "bad4(address)"
|
|
}
|
|
}
|
|
},
|
|
"additional_fields": {
|
|
"underlying_type": "external_calls_sending_eth"
|
|
}
|
|
},
|
|
{
|
|
"type": "node",
|
|
"name": "address(target).call{value: 1}()",
|
|
"source_mapping": {
|
|
"start": 1261,
|
|
"length": 33,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
56
|
|
],
|
|
"starting_column": 9,
|
|
"ending_column": 42
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "function",
|
|
"name": "ethSender",
|
|
"source_mapping": {
|
|
"start": 1208,
|
|
"length": 93,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
55,
|
|
56,
|
|
57
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ReentrancyBenign",
|
|
"source_mapping": {
|
|
"start": 28,
|
|
"length": 1353,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54,
|
|
55,
|
|
56,
|
|
57,
|
|
58,
|
|
59,
|
|
60,
|
|
61,
|
|
62,
|
|
63
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 0
|
|
}
|
|
},
|
|
"signature": "ethSender(address)"
|
|
}
|
|
}
|
|
},
|
|
"additional_fields": {
|
|
"underlying_type": "external_calls_sending_eth"
|
|
}
|
|
},
|
|
{
|
|
"type": "node",
|
|
"name": "varChanger()",
|
|
"source_mapping": {
|
|
"start": 911,
|
|
"length": 12,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
41
|
|
],
|
|
"starting_column": 9,
|
|
"ending_column": 21
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "function",
|
|
"name": "bad4",
|
|
"source_mapping": {
|
|
"start": 801,
|
|
"length": 172,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ReentrancyBenign",
|
|
"source_mapping": {
|
|
"start": 28,
|
|
"length": 1353,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54,
|
|
55,
|
|
56,
|
|
57,
|
|
58,
|
|
59,
|
|
60,
|
|
61,
|
|
62,
|
|
63
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 0
|
|
}
|
|
},
|
|
"signature": "bad4(address)"
|
|
}
|
|
}
|
|
},
|
|
"additional_fields": {
|
|
"underlying_type": "variables_written",
|
|
"variable_name": "anotherVariableToChange"
|
|
}
|
|
},
|
|
{
|
|
"type": "node",
|
|
"name": "anotherVariableToChange ++",
|
|
"source_mapping": {
|
|
"start": 1347,
|
|
"length": 25,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
60
|
|
],
|
|
"starting_column": 9,
|
|
"ending_column": 34
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "function",
|
|
"name": "varChanger",
|
|
"source_mapping": {
|
|
"start": 1307,
|
|
"length": 72,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
59,
|
|
60,
|
|
61
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ReentrancyBenign",
|
|
"source_mapping": {
|
|
"start": 28,
|
|
"length": 1353,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54,
|
|
55,
|
|
56,
|
|
57,
|
|
58,
|
|
59,
|
|
60,
|
|
61,
|
|
62,
|
|
63
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 0
|
|
}
|
|
},
|
|
"signature": "varChanger()"
|
|
}
|
|
}
|
|
},
|
|
"additional_fields": {
|
|
"underlying_type": "variables_written",
|
|
"variable_name": "anotherVariableToChange"
|
|
}
|
|
}
|
|
],
|
|
"description": "Reentrancy in ReentrancyBenign.bad4(address) (tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#38-43):\n\tExternal calls:\n\t- externalCaller(target) (tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#39)\n\t\t- address(target).call() (tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#52)\n\t- ethSender(address(0)) (tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#40)\n\t\t- address(target).call{value: 1}() (tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#56)\n\tExternal calls sending eth:\n\t- ethSender(address(0)) (tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#40)\n\t\t- address(target).call{value: 1}() (tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#56)\n\tState variables written after the call(s):\n\t- varChanger() (tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#41)\n\t\t- anotherVariableToChange ++ (tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#60)\n",
|
|
"markdown": "Reentrancy in [ReentrancyBenign.bad4(address)](tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#L38-L43):\n\tExternal calls:\n\t- [externalCaller(target)](tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#L39)\n\t\t- [address(target).call()](tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#L52)\n\t- [ethSender(address(0))](tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#L40)\n\t\t- [address(target).call{value: 1}()](tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#L56)\n\tExternal calls sending eth:\n\t- [ethSender(address(0))](tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#L40)\n\t\t- [address(target).call{value: 1}()](tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#L56)\n\tState variables written after the call(s):\n\t- [varChanger()](tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#L41)\n\t\t- [anotherVariableToChange ++](tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#L60)\n",
|
|
"first_markdown_element": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#L38-L43",
|
|
"id": "693e60a81db5856504cce9c31c639630515a7bf4431ba129d2f1dfbef4caa0e6",
|
|
"check": "reentrancy-benign",
|
|
"impact": "Low",
|
|
"confidence": "Medium"
|
|
},
|
|
{
|
|
"elements": [
|
|
{
|
|
"type": "function",
|
|
"name": "bad5",
|
|
"source_mapping": {
|
|
"start": 979,
|
|
"length": 128,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ReentrancyBenign",
|
|
"source_mapping": {
|
|
"start": 28,
|
|
"length": 1353,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54,
|
|
55,
|
|
56,
|
|
57,
|
|
58,
|
|
59,
|
|
60,
|
|
61,
|
|
62,
|
|
63
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 0
|
|
}
|
|
},
|
|
"signature": "bad5(address)"
|
|
}
|
|
},
|
|
{
|
|
"type": "node",
|
|
"name": "ethSender(address(0))",
|
|
"source_mapping": {
|
|
"start": 1026,
|
|
"length": 21,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
46
|
|
],
|
|
"starting_column": 9,
|
|
"ending_column": 30
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "function",
|
|
"name": "bad5",
|
|
"source_mapping": {
|
|
"start": 979,
|
|
"length": 128,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ReentrancyBenign",
|
|
"source_mapping": {
|
|
"start": 28,
|
|
"length": 1353,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54,
|
|
55,
|
|
56,
|
|
57,
|
|
58,
|
|
59,
|
|
60,
|
|
61,
|
|
62,
|
|
63
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 0
|
|
}
|
|
},
|
|
"signature": "bad5(address)"
|
|
}
|
|
}
|
|
},
|
|
"additional_fields": {
|
|
"underlying_type": "external_calls"
|
|
}
|
|
},
|
|
{
|
|
"type": "node",
|
|
"name": "address(target).call{value: 1}()",
|
|
"source_mapping": {
|
|
"start": 1261,
|
|
"length": 33,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
56
|
|
],
|
|
"starting_column": 9,
|
|
"ending_column": 42
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "function",
|
|
"name": "ethSender",
|
|
"source_mapping": {
|
|
"start": 1208,
|
|
"length": 93,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
55,
|
|
56,
|
|
57
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ReentrancyBenign",
|
|
"source_mapping": {
|
|
"start": 28,
|
|
"length": 1353,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54,
|
|
55,
|
|
56,
|
|
57,
|
|
58,
|
|
59,
|
|
60,
|
|
61,
|
|
62,
|
|
63
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 0
|
|
}
|
|
},
|
|
"signature": "ethSender(address)"
|
|
}
|
|
}
|
|
},
|
|
"additional_fields": {
|
|
"underlying_type": "external_calls_sending_eth"
|
|
}
|
|
},
|
|
{
|
|
"type": "node",
|
|
"name": "varChanger()",
|
|
"source_mapping": {
|
|
"start": 1057,
|
|
"length": 12,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
47
|
|
],
|
|
"starting_column": 9,
|
|
"ending_column": 21
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "function",
|
|
"name": "bad5",
|
|
"source_mapping": {
|
|
"start": 979,
|
|
"length": 128,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ReentrancyBenign",
|
|
"source_mapping": {
|
|
"start": 28,
|
|
"length": 1353,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54,
|
|
55,
|
|
56,
|
|
57,
|
|
58,
|
|
59,
|
|
60,
|
|
61,
|
|
62,
|
|
63
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 0
|
|
}
|
|
},
|
|
"signature": "bad5(address)"
|
|
}
|
|
}
|
|
},
|
|
"additional_fields": {
|
|
"underlying_type": "variables_written",
|
|
"variable_name": "anotherVariableToChange"
|
|
}
|
|
},
|
|
{
|
|
"type": "node",
|
|
"name": "anotherVariableToChange ++",
|
|
"source_mapping": {
|
|
"start": 1347,
|
|
"length": 25,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
60
|
|
],
|
|
"starting_column": 9,
|
|
"ending_column": 34
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "function",
|
|
"name": "varChanger",
|
|
"source_mapping": {
|
|
"start": 1307,
|
|
"length": 72,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
59,
|
|
60,
|
|
61
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ReentrancyBenign",
|
|
"source_mapping": {
|
|
"start": 28,
|
|
"length": 1353,
|
|
"filename_used": "/GENERIC_PATH",
|
|
"filename_relative": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"filename_absolute": "/GENERIC_PATH",
|
|
"filename_short": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54,
|
|
55,
|
|
56,
|
|
57,
|
|
58,
|
|
59,
|
|
60,
|
|
61,
|
|
62,
|
|
63
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 0
|
|
}
|
|
},
|
|
"signature": "varChanger()"
|
|
}
|
|
}
|
|
},
|
|
"additional_fields": {
|
|
"underlying_type": "variables_written",
|
|
"variable_name": "anotherVariableToChange"
|
|
}
|
|
}
|
|
],
|
|
"description": "Reentrancy in ReentrancyBenign.bad5(address) (tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#45-49):\n\tExternal calls:\n\t- ethSender(address(0)) (tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#46)\n\t\t- address(target).call{value: 1}() (tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#56)\n\tState variables written after the call(s):\n\t- varChanger() (tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#47)\n\t\t- anotherVariableToChange ++ (tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#60)\n",
|
|
"markdown": "Reentrancy in [ReentrancyBenign.bad5(address)](tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#L45-L49):\n\tExternal calls:\n\t- [ethSender(address(0))](tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#L46)\n\t\t- [address(target).call{value: 1}()](tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#L56)\n\tState variables written after the call(s):\n\t- [varChanger()](tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#L47)\n\t\t- [anotherVariableToChange ++](tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#L60)\n",
|
|
"first_markdown_element": "tests/detectors/reentrancy-benign/0.7.6/reentrancy-benign.sol#L45-L49",
|
|
"id": "068323f92a1eaa2d419e19d35185150639a2b3f992b9b382972f13d546cd414d",
|
|
"check": "reentrancy-benign",
|
|
"impact": "Low",
|
|
"confidence": "Medium"
|
|
}
|
|
]
|
|
] |