mirror of https://github.com/crytic/slither
You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
665 lines
19 KiB
665 lines
19 KiB
{
|
|
"success": true,
|
|
"error": null,
|
|
"results": [
|
|
{
|
|
"check": "reentrancy-eth",
|
|
"impact": "High",
|
|
"confidence": "Medium",
|
|
"description": "Reentrancy in Reentrancy.withdrawBalance (tests/reentrancy-0.5.1.sol#14-22):\n\tExternal calls:\n\t- (ret,mem) = msg.sender.call.value(userBalance[msg.sender])() (tests/reentrancy-0.5.1.sol#17)\n\tState variables written after the call(s):\n\t- userBalance (tests/reentrancy-0.5.1.sol#21)\n",
|
|
"elements": [
|
|
{
|
|
"type": "function",
|
|
"name": "withdrawBalance",
|
|
"source_mapping": {
|
|
"start": 298,
|
|
"length": 357,
|
|
"filename_used": "/home/travis/build/crytic/slither/tests/reentrancy-0.5.1.sol",
|
|
"filename_relative": "tests/reentrancy-0.5.1.sol",
|
|
"filename_absolute": "/home/travis/build/crytic/slither/tests/reentrancy-0.5.1.sol",
|
|
"filename_short": "tests/reentrancy-0.5.1.sol",
|
|
"lines": [
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"contract": {
|
|
"type": "contract",
|
|
"name": "Reentrancy",
|
|
"source_mapping": {
|
|
"start": 25,
|
|
"length": 1807,
|
|
"filename_used": "/home/travis/build/crytic/slither/tests/reentrancy-0.5.1.sol",
|
|
"filename_relative": "tests/reentrancy-0.5.1.sol",
|
|
"filename_absolute": "/home/travis/build/crytic/slither/tests/reentrancy-0.5.1.sol",
|
|
"filename_short": "tests/reentrancy-0.5.1.sol",
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 2
|
|
}
|
|
}
|
|
},
|
|
{
|
|
"type": "node",
|
|
"name": "(ret,mem) = msg.sender.call.value(userBalance[msg.sender])()",
|
|
"source_mapping": {
|
|
"start": 477,
|
|
"length": 81,
|
|
"filename_used": "/home/travis/build/crytic/slither/tests/reentrancy-0.5.1.sol",
|
|
"filename_relative": "tests/reentrancy-0.5.1.sol",
|
|
"filename_absolute": "/home/travis/build/crytic/slither/tests/reentrancy-0.5.1.sol",
|
|
"filename_short": "tests/reentrancy-0.5.1.sol",
|
|
"lines": [
|
|
17
|
|
],
|
|
"starting_column": 9,
|
|
"ending_column": 90
|
|
},
|
|
"additional_fields": {
|
|
"underlying_type": "external_calls"
|
|
},
|
|
"function": {
|
|
"type": "function",
|
|
"name": "withdrawBalance",
|
|
"source_mapping": {
|
|
"start": 298,
|
|
"length": 357,
|
|
"filename_used": "/home/travis/build/crytic/slither/tests/reentrancy-0.5.1.sol",
|
|
"filename_relative": "tests/reentrancy-0.5.1.sol",
|
|
"filename_absolute": "/home/travis/build/crytic/slither/tests/reentrancy-0.5.1.sol",
|
|
"filename_short": "tests/reentrancy-0.5.1.sol",
|
|
"lines": [
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"contract": {
|
|
"type": "contract",
|
|
"name": "Reentrancy",
|
|
"source_mapping": {
|
|
"start": 25,
|
|
"length": 1807,
|
|
"filename_used": "/home/travis/build/crytic/slither/tests/reentrancy-0.5.1.sol",
|
|
"filename_relative": "tests/reentrancy-0.5.1.sol",
|
|
"filename_absolute": "/home/travis/build/crytic/slither/tests/reentrancy-0.5.1.sol",
|
|
"filename_short": "tests/reentrancy-0.5.1.sol",
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 2
|
|
}
|
|
}
|
|
}
|
|
},
|
|
{
|
|
"type": "node",
|
|
"name": "userBalance[msg.sender] = 0",
|
|
"source_mapping": {
|
|
"start": 621,
|
|
"length": 27,
|
|
"filename_used": "/home/travis/build/crytic/slither/tests/reentrancy-0.5.1.sol",
|
|
"filename_relative": "tests/reentrancy-0.5.1.sol",
|
|
"filename_absolute": "/home/travis/build/crytic/slither/tests/reentrancy-0.5.1.sol",
|
|
"filename_short": "tests/reentrancy-0.5.1.sol",
|
|
"lines": [
|
|
21
|
|
],
|
|
"starting_column": 9,
|
|
"ending_column": 36
|
|
},
|
|
"additional_fields": {
|
|
"underlying_type": "variables_written",
|
|
"variable_name": "userBalance"
|
|
},
|
|
"function": {
|
|
"type": "function",
|
|
"name": "withdrawBalance",
|
|
"source_mapping": {
|
|
"start": 298,
|
|
"length": 357,
|
|
"filename_used": "/home/travis/build/crytic/slither/tests/reentrancy-0.5.1.sol",
|
|
"filename_relative": "tests/reentrancy-0.5.1.sol",
|
|
"filename_absolute": "/home/travis/build/crytic/slither/tests/reentrancy-0.5.1.sol",
|
|
"filename_short": "tests/reentrancy-0.5.1.sol",
|
|
"lines": [
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"contract": {
|
|
"type": "contract",
|
|
"name": "Reentrancy",
|
|
"source_mapping": {
|
|
"start": 25,
|
|
"length": 1807,
|
|
"filename_used": "/home/travis/build/crytic/slither/tests/reentrancy-0.5.1.sol",
|
|
"filename_relative": "tests/reentrancy-0.5.1.sol",
|
|
"filename_absolute": "/home/travis/build/crytic/slither/tests/reentrancy-0.5.1.sol",
|
|
"filename_short": "tests/reentrancy-0.5.1.sol",
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 2
|
|
}
|
|
}
|
|
}
|
|
}
|
|
]
|
|
},
|
|
{
|
|
"check": "reentrancy-eth",
|
|
"impact": "High",
|
|
"confidence": "Medium",
|
|
"description": "Reentrancy in Reentrancy.withdrawBalance_fixed_3 (tests/reentrancy-0.5.1.sol#44-53):\n\tExternal calls:\n\t- (ret,mem) = msg.sender.call.value(amount)() (tests/reentrancy-0.5.1.sol#49)\n\tState variables written after the call(s):\n\t- userBalance (tests/reentrancy-0.5.1.sol#51)\n",
|
|
"elements": [
|
|
{
|
|
"type": "function",
|
|
"name": "withdrawBalance_fixed_3",
|
|
"source_mapping": {
|
|
"start": 1434,
|
|
"length": 393,
|
|
"filename_used": "/home/travis/build/crytic/slither/tests/reentrancy-0.5.1.sol",
|
|
"filename_relative": "tests/reentrancy-0.5.1.sol",
|
|
"filename_absolute": "/home/travis/build/crytic/slither/tests/reentrancy-0.5.1.sol",
|
|
"filename_short": "tests/reentrancy-0.5.1.sol",
|
|
"lines": [
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"contract": {
|
|
"type": "contract",
|
|
"name": "Reentrancy",
|
|
"source_mapping": {
|
|
"start": 25,
|
|
"length": 1807,
|
|
"filename_used": "/home/travis/build/crytic/slither/tests/reentrancy-0.5.1.sol",
|
|
"filename_relative": "tests/reentrancy-0.5.1.sol",
|
|
"filename_absolute": "/home/travis/build/crytic/slither/tests/reentrancy-0.5.1.sol",
|
|
"filename_short": "tests/reentrancy-0.5.1.sol",
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 2
|
|
}
|
|
}
|
|
},
|
|
{
|
|
"type": "node",
|
|
"name": "(ret,mem) = msg.sender.call.value(amount)()",
|
|
"source_mapping": {
|
|
"start": 1679,
|
|
"length": 64,
|
|
"filename_used": "/home/travis/build/crytic/slither/tests/reentrancy-0.5.1.sol",
|
|
"filename_relative": "tests/reentrancy-0.5.1.sol",
|
|
"filename_absolute": "/home/travis/build/crytic/slither/tests/reentrancy-0.5.1.sol",
|
|
"filename_short": "tests/reentrancy-0.5.1.sol",
|
|
"lines": [
|
|
49
|
|
],
|
|
"starting_column": 9,
|
|
"ending_column": 73
|
|
},
|
|
"additional_fields": {
|
|
"underlying_type": "external_calls"
|
|
},
|
|
"function": {
|
|
"type": "function",
|
|
"name": "withdrawBalance_fixed_3",
|
|
"source_mapping": {
|
|
"start": 1434,
|
|
"length": 393,
|
|
"filename_used": "/home/travis/build/crytic/slither/tests/reentrancy-0.5.1.sol",
|
|
"filename_relative": "tests/reentrancy-0.5.1.sol",
|
|
"filename_absolute": "/home/travis/build/crytic/slither/tests/reentrancy-0.5.1.sol",
|
|
"filename_short": "tests/reentrancy-0.5.1.sol",
|
|
"lines": [
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"contract": {
|
|
"type": "contract",
|
|
"name": "Reentrancy",
|
|
"source_mapping": {
|
|
"start": 25,
|
|
"length": 1807,
|
|
"filename_used": "/home/travis/build/crytic/slither/tests/reentrancy-0.5.1.sol",
|
|
"filename_relative": "tests/reentrancy-0.5.1.sol",
|
|
"filename_absolute": "/home/travis/build/crytic/slither/tests/reentrancy-0.5.1.sol",
|
|
"filename_short": "tests/reentrancy-0.5.1.sol",
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 2
|
|
}
|
|
}
|
|
}
|
|
},
|
|
{
|
|
"type": "node",
|
|
"name": "userBalance[msg.sender] = amount",
|
|
"source_mapping": {
|
|
"start": 1778,
|
|
"length": 32,
|
|
"filename_used": "/home/travis/build/crytic/slither/tests/reentrancy-0.5.1.sol",
|
|
"filename_relative": "tests/reentrancy-0.5.1.sol",
|
|
"filename_absolute": "/home/travis/build/crytic/slither/tests/reentrancy-0.5.1.sol",
|
|
"filename_short": "tests/reentrancy-0.5.1.sol",
|
|
"lines": [
|
|
51
|
|
],
|
|
"starting_column": 13,
|
|
"ending_column": 45
|
|
},
|
|
"additional_fields": {
|
|
"underlying_type": "variables_written",
|
|
"variable_name": "userBalance"
|
|
},
|
|
"function": {
|
|
"type": "function",
|
|
"name": "withdrawBalance_fixed_3",
|
|
"source_mapping": {
|
|
"start": 1434,
|
|
"length": 393,
|
|
"filename_used": "/home/travis/build/crytic/slither/tests/reentrancy-0.5.1.sol",
|
|
"filename_relative": "tests/reentrancy-0.5.1.sol",
|
|
"filename_absolute": "/home/travis/build/crytic/slither/tests/reentrancy-0.5.1.sol",
|
|
"filename_short": "tests/reentrancy-0.5.1.sol",
|
|
"lines": [
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"contract": {
|
|
"type": "contract",
|
|
"name": "Reentrancy",
|
|
"source_mapping": {
|
|
"start": 25,
|
|
"length": 1807,
|
|
"filename_used": "/home/travis/build/crytic/slither/tests/reentrancy-0.5.1.sol",
|
|
"filename_relative": "tests/reentrancy-0.5.1.sol",
|
|
"filename_absolute": "/home/travis/build/crytic/slither/tests/reentrancy-0.5.1.sol",
|
|
"filename_short": "tests/reentrancy-0.5.1.sol",
|
|
"lines": [
|
|
3,
|
|
4,
|
|
5,
|
|
6,
|
|
7,
|
|
8,
|
|
9,
|
|
10,
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29,
|
|
30,
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40,
|
|
41,
|
|
42,
|
|
43,
|
|
44,
|
|
45,
|
|
46,
|
|
47,
|
|
48,
|
|
49,
|
|
50,
|
|
51,
|
|
52,
|
|
53,
|
|
54
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 2
|
|
}
|
|
}
|
|
}
|
|
}
|
|
]
|
|
}
|
|
]
|
|
} |