mirror of https://github.com/crytic/slither
You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
331 lines
11 KiB
331 lines
11 KiB
{
|
|
"success": true,
|
|
"error": null,
|
|
"results": {
|
|
"detectors": [
|
|
{
|
|
"check": "external-function",
|
|
"impact": "Optimization",
|
|
"confidence": "High",
|
|
"description": "funcNotCalled3() should be declared external:\n\t- ContractWithFunctionNotCalled.funcNotCalled3() (tests/external_function.sol#13-15)\n",
|
|
"elements": [
|
|
{
|
|
"type": "function",
|
|
"name": "funcNotCalled3",
|
|
"source_mapping": {
|
|
"start": 259,
|
|
"length": 41,
|
|
"filename_used": "/home/travis/build/crytic/slither/tests/external_function.sol",
|
|
"filename_relative": "tests/external_function.sol",
|
|
"filename_absolute": "/home/travis/build/crytic/slither/tests/external_function.sol",
|
|
"filename_short": "tests/external_function.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
13,
|
|
14,
|
|
15
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ContractWithFunctionNotCalled",
|
|
"source_mapping": {
|
|
"start": 213,
|
|
"length": 258,
|
|
"filename_used": "/home/travis/build/crytic/slither/tests/external_function.sol",
|
|
"filename_relative": "tests/external_function.sol",
|
|
"filename_absolute": "/home/travis/build/crytic/slither/tests/external_function.sol",
|
|
"filename_short": "tests/external_function.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 2
|
|
}
|
|
},
|
|
"signature": "funcNotCalled3()"
|
|
}
|
|
}
|
|
]
|
|
},
|
|
{
|
|
"check": "external-function",
|
|
"impact": "Optimization",
|
|
"confidence": "High",
|
|
"description": "funcNotCalled2() should be declared external:\n\t- ContractWithFunctionNotCalled.funcNotCalled2() (tests/external_function.sol#17-19)\n",
|
|
"elements": [
|
|
{
|
|
"type": "function",
|
|
"name": "funcNotCalled2",
|
|
"source_mapping": {
|
|
"start": 306,
|
|
"length": 41,
|
|
"filename_used": "/home/travis/build/crytic/slither/tests/external_function.sol",
|
|
"filename_relative": "tests/external_function.sol",
|
|
"filename_absolute": "/home/travis/build/crytic/slither/tests/external_function.sol",
|
|
"filename_short": "tests/external_function.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
17,
|
|
18,
|
|
19
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ContractWithFunctionNotCalled",
|
|
"source_mapping": {
|
|
"start": 213,
|
|
"length": 258,
|
|
"filename_used": "/home/travis/build/crytic/slither/tests/external_function.sol",
|
|
"filename_relative": "tests/external_function.sol",
|
|
"filename_absolute": "/home/travis/build/crytic/slither/tests/external_function.sol",
|
|
"filename_short": "tests/external_function.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 2
|
|
}
|
|
},
|
|
"signature": "funcNotCalled2()"
|
|
}
|
|
}
|
|
]
|
|
},
|
|
{
|
|
"check": "external-function",
|
|
"impact": "Optimization",
|
|
"confidence": "High",
|
|
"description": "funcNotCalled() should be declared external:\n\t- ContractWithFunctionNotCalled.funcNotCalled() (tests/external_function.sol#21-23)\n",
|
|
"elements": [
|
|
{
|
|
"type": "function",
|
|
"name": "funcNotCalled",
|
|
"source_mapping": {
|
|
"start": 353,
|
|
"length": 40,
|
|
"filename_used": "/home/travis/build/crytic/slither/tests/external_function.sol",
|
|
"filename_relative": "tests/external_function.sol",
|
|
"filename_absolute": "/home/travis/build/crytic/slither/tests/external_function.sol",
|
|
"filename_short": "tests/external_function.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
21,
|
|
22,
|
|
23
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ContractWithFunctionNotCalled",
|
|
"source_mapping": {
|
|
"start": 213,
|
|
"length": 258,
|
|
"filename_used": "/home/travis/build/crytic/slither/tests/external_function.sol",
|
|
"filename_relative": "tests/external_function.sol",
|
|
"filename_absolute": "/home/travis/build/crytic/slither/tests/external_function.sol",
|
|
"filename_short": "tests/external_function.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
11,
|
|
12,
|
|
13,
|
|
14,
|
|
15,
|
|
16,
|
|
17,
|
|
18,
|
|
19,
|
|
20,
|
|
21,
|
|
22,
|
|
23,
|
|
24,
|
|
25,
|
|
26,
|
|
27,
|
|
28,
|
|
29
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 2
|
|
}
|
|
},
|
|
"signature": "funcNotCalled()"
|
|
}
|
|
}
|
|
]
|
|
},
|
|
{
|
|
"check": "external-function",
|
|
"impact": "Optimization",
|
|
"confidence": "High",
|
|
"description": "funcNotCalled() should be declared external:\n\t- ContractWithFunctionNotCalled2.funcNotCalled() (tests/external_function.sol#32-39)\n",
|
|
"elements": [
|
|
{
|
|
"type": "function",
|
|
"name": "funcNotCalled",
|
|
"source_mapping": {
|
|
"start": 554,
|
|
"length": 325,
|
|
"filename_used": "/home/travis/build/crytic/slither/tests/external_function.sol",
|
|
"filename_relative": "tests/external_function.sol",
|
|
"filename_absolute": "/home/travis/build/crytic/slither/tests/external_function.sol",
|
|
"filename_short": "tests/external_function.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39
|
|
],
|
|
"starting_column": 5,
|
|
"ending_column": 6
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "ContractWithFunctionNotCalled2",
|
|
"source_mapping": {
|
|
"start": 473,
|
|
"length": 408,
|
|
"filename_used": "/home/travis/build/crytic/slither/tests/external_function.sol",
|
|
"filename_relative": "tests/external_function.sol",
|
|
"filename_absolute": "/home/travis/build/crytic/slither/tests/external_function.sol",
|
|
"filename_short": "tests/external_function.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
31,
|
|
32,
|
|
33,
|
|
34,
|
|
35,
|
|
36,
|
|
37,
|
|
38,
|
|
39,
|
|
40
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 2
|
|
}
|
|
},
|
|
"signature": "funcNotCalled()"
|
|
}
|
|
}
|
|
]
|
|
},
|
|
{
|
|
"check": "external-function",
|
|
"impact": "Optimization",
|
|
"confidence": "High",
|
|
"description": "parameter_read_ok_for_external(uint256) should be declared external:\n\t- FunctionParameterWrite.parameter_read_ok_for_external(uint256) (tests/external_function.sol#74-76)\n",
|
|
"elements": [
|
|
{
|
|
"type": "function",
|
|
"name": "parameter_read_ok_for_external",
|
|
"source_mapping": {
|
|
"start": 1420,
|
|
"length": 81,
|
|
"filename_used": "/home/travis/build/crytic/slither/tests/external_function.sol",
|
|
"filename_relative": "tests/external_function.sol",
|
|
"filename_absolute": "/home/travis/build/crytic/slither/tests/external_function.sol",
|
|
"filename_short": "tests/external_function.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
74,
|
|
75,
|
|
76
|
|
],
|
|
"starting_column": 3,
|
|
"ending_column": 4
|
|
},
|
|
"type_specific_fields": {
|
|
"parent": {
|
|
"type": "contract",
|
|
"name": "FunctionParameterWrite",
|
|
"source_mapping": {
|
|
"start": 1381,
|
|
"length": 234,
|
|
"filename_used": "/home/travis/build/crytic/slither/tests/external_function.sol",
|
|
"filename_relative": "tests/external_function.sol",
|
|
"filename_absolute": "/home/travis/build/crytic/slither/tests/external_function.sol",
|
|
"filename_short": "tests/external_function.sol",
|
|
"is_dependency": false,
|
|
"lines": [
|
|
72,
|
|
73,
|
|
74,
|
|
75,
|
|
76,
|
|
77,
|
|
78,
|
|
79,
|
|
80,
|
|
81,
|
|
82
|
|
],
|
|
"starting_column": 1,
|
|
"ending_column": 2
|
|
}
|
|
},
|
|
"signature": "parameter_read_ok_for_external(uint256)"
|
|
}
|
|
}
|
|
]
|
|
}
|
|
]
|
|
}
|
|
} |