Block on skipped matrix (#6818)

* also fail on cancelled and skipped
* DCO correction

---------

Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Stefan Pingel <16143240+pinges@users.noreply.github.com>
Co-authored-by: Simon Dudley <simon.dudley@consensys.net>
Co-authored-by: Usman Saleem <usman@usmans.info>
Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Lucas Saldanha <lucas.saldanha@consensys.net>
Co-authored-by: Jason Frame <jason.frame@consensys.net>
Co-authored-by: Karim TAAM <karim.t2am@gmail.com>

.github/workflows/acceptance-tests.yml

@@ -77,6 +77,15 @@ jobs:
     permissions:
       checks: write
       statuses: write
+    if: always()
     steps:
-      - name: consolidation
+      # Fail if any `needs` job was not a success.
-        run: echo "consolidating statuses"
+      # Along with `if: always()`, this allows this job to act as a single required status check for the entire workflow.
+      - name: Fail on workflow error
+        run: exit 1
+        if: >-
+          ${{
+            contains(needs.*.result, 'failure')
+            || contains(needs.*.result, 'cancelled')
+            || contains(needs.*.result, 'skipped')
+          }}

.github/workflows/pre-review.yml

@@ -135,6 +135,15 @@ jobs:
     permissions:
       checks: write
       statuses: write
+    if: always()
     steps:
-      - name: consolidation
+      # Fail if any `needs` job was not a success.
-        run: echo "consolidating statuses"
+      # Along with `if: always()`, this allows this job to act as a single required status check for the entire workflow.
+      - name: Fail on workflow error
+        run: exit 1
+        if: >-
+          ${{
+            contains(needs.*.result, 'failure')
+            || contains(needs.*.result, 'cancelled')
+            || contains(needs.*.result, 'skipped')
+          }}

.github/workflows/reference-tests.yml

@@ -69,7 +69,15 @@ jobs:
     permissions:
       checks: write
       statuses: write
+    if: always()
     steps:
-      - name: consolidation
+      # Fail if any `needs` job was not a success.
-        run: echo "consolidating statuses"
+      # Along with `if: always()`, this allows this job to act as a single required status check for the entire workflow.
-
+      - name: Fail on workflow error
+        run: exit 1
+        if: >-
+          ${{
+            contains(needs.*.result, 'failure')
+            || contains(needs.*.result, 'cancelled')
+            || contains(needs.*.result, 'skipped')
+          }}