NC-1675 Ensure that default logging is appropriate (#113)

More logging demotions.
Danno Ferrin 6 years ago committed by GitHub
parent e0a160e070
commit 9fe2cdfdf0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      consensus/clique/src/main/java/tech/pegasys/pantheon/consensus/clique/CliqueVoteTallyUpdater.java
  2. 8
      ethereum/eth/src/main/java/tech/pegasys/pantheon/ethereum/eth/manager/EthServer.java
  3. 2
      ethereum/eth/src/main/java/tech/pegasys/pantheon/ethereum/eth/sync/TrailingPeerLimiter.java
  4. 2
      ethereum/eth/src/main/java/tech/pegasys/pantheon/ethereum/eth/sync/tasks/DownloadHeaderSequenceTask.java
  5. 2
      ethereum/jsonrpc/src/main/java/tech/pegasys/pantheon/ethereum/jsonrpc/JsonRpcHttpService.java
  6. 2
      ethereum/jsonrpc/src/main/java/tech/pegasys/pantheon/ethereum/jsonrpc/websocket/WebSocketRequestHandler.java
  7. 2
      ethereum/jsonrpc/src/main/java/tech/pegasys/pantheon/ethereum/jsonrpc/websocket/subscription/SubscriptionManager.java
  8. 2
      ethereum/p2p/src/main/java/tech/pegasys/pantheon/ethereum/p2p/NetworkRunner.java
  9. 2
      ethereum/p2p/src/main/java/tech/pegasys/pantheon/ethereum/p2p/netty/AbstractHandshakeHandler.java
  10. 2
      ethereum/p2p/src/main/java/tech/pegasys/pantheon/ethereum/p2p/netty/WireKeepAlive.java

@ -40,7 +40,7 @@ public class CliqueVoteTallyUpdater {
public VoteTally buildVoteTallyFromBlockchain(final Blockchain blockchain) { public VoteTally buildVoteTallyFromBlockchain(final Blockchain blockchain) {
final long chainHeadBlockNumber = blockchain.getChainHeadBlockNumber(); final long chainHeadBlockNumber = blockchain.getChainHeadBlockNumber();
final long epochBlockNumber = epochManager.getLastEpochBlock(chainHeadBlockNumber); final long epochBlockNumber = epochManager.getLastEpochBlock(chainHeadBlockNumber);
LOG.info("Loading validator voting state starting from block {}", epochBlockNumber); LOG.debug("Loading validator voting state starting from block {}", epochBlockNumber);
final BlockHeader epochBlock = blockchain.getBlockHeader(epochBlockNumber).get(); final BlockHeader epochBlock = blockchain.getBlockHeader(epochBlockNumber).get();
final List<Address> initialValidators = final List<Address> initialValidators =
CliqueExtraData.decode(epochBlock.getExtraData()).getValidators(); CliqueExtraData.decode(epochBlock.getExtraData()).getValidators();

@ -65,7 +65,7 @@ class EthServer {
} }
private void handleGetBlockHeaders(final EthMessage message) { private void handleGetBlockHeaders(final EthMessage message) {
LOG.info("Responding to GET_BLOCK_HEADERS request"); LOG.trace("Responding to GET_BLOCK_HEADERS request");
try { try {
final MessageData response = final MessageData response =
constructGetHeadersResponse(blockchain, message.getData(), requestLimit); constructGetHeadersResponse(blockchain, message.getData(), requestLimit);
@ -78,7 +78,7 @@ class EthServer {
} }
private void handleGetBlockBodies(final EthMessage message) { private void handleGetBlockBodies(final EthMessage message) {
LOG.info("Responding to GET_BLOCK_BODIES request"); LOG.trace("Responding to GET_BLOCK_BODIES request");
try { try {
final MessageData response = final MessageData response =
constructGetBodiesResponse(blockchain, message.getData(), requestLimit); constructGetBodiesResponse(blockchain, message.getData(), requestLimit);
@ -91,7 +91,7 @@ class EthServer {
} }
private void handleGetReceipts(final EthMessage message) { private void handleGetReceipts(final EthMessage message) {
LOG.info("Responding to GET_RECEIPTS request"); LOG.trace("Responding to GET_RECEIPTS request");
try { try {
final MessageData response = final MessageData response =
constructGetReceiptsResponse(blockchain, message.getData(), requestLimit); constructGetReceiptsResponse(blockchain, message.getData(), requestLimit);
@ -104,7 +104,7 @@ class EthServer {
} }
private void handleGetNodeData(final EthMessage message) { private void handleGetNodeData(final EthMessage message) {
LOG.info("Responding to GET_NODE_DATA request"); LOG.trace("Responding to GET_NODE_DATA request");
try { try {
final MessageData response = constructGetNodeDataResponse(message.getData(), requestLimit); final MessageData response = constructGetNodeDataResponse(message.getData(), requestLimit);
message.getPeer().send(response); message.getPeer().send(response);

@ -67,7 +67,7 @@ public class TrailingPeerLimiter implements BlockAddedObserver {
while (!trailingPeers.isEmpty() && trailingPeers.size() > maxTrailingPeers) { while (!trailingPeers.isEmpty() && trailingPeers.size() > maxTrailingPeers) {
final EthPeer peerToDisconnect = trailingPeers.remove(0); final EthPeer peerToDisconnect = trailingPeers.remove(0);
LOG.info("Enforcing trailing peers limit by disconnecting {}", peerToDisconnect); LOG.debug("Enforcing trailing peers limit by disconnecting {}", peerToDisconnect);
peerToDisconnect.disconnect(DisconnectReason.TOO_MANY_PEERS); peerToDisconnect.disconnect(DisconnectReason.TOO_MANY_PEERS);
} }
} }

@ -178,7 +178,7 @@ public class DownloadHeaderSequenceTask<C> extends AbstractRetryingPeerTask<List
if (!validateHeader(child, header)) { if (!validateHeader(child, header)) {
// Invalid headers - disconnect from peer // Invalid headers - disconnect from peer
LOG.info( LOG.debug(
"Received invalid headers from peer, disconnecting from: {}", "Received invalid headers from peer, disconnecting from: {}",
headersResult.getPeer()); headersResult.getPeer());
headersResult.getPeer().disconnect(DisconnectReason.BREACH_OF_PROTOCOL); headersResult.getPeer().disconnect(DisconnectReason.BREACH_OF_PROTOCOL);

@ -310,7 +310,7 @@ public class JsonRpcHttpService {
return NO_RESPONSE; return NO_RESPONSE;
} }
LOG.info("JSON-RPC request -> {}", request.getMethod()); LOG.debug("JSON-RPC request -> {}", request.getMethod());
// Find method handler // Find method handler
final JsonRpcMethod method = jsonRpcMethods.get(request.getMethod()); final JsonRpcMethod method = jsonRpcMethods.get(request.getMethod());
if (method == null) { if (method == null) {

@ -56,7 +56,7 @@ public class WebSocketRequestHandler {
} }
final JsonRpcMethod method = methods.get(request.getMethod()); final JsonRpcMethod method = methods.get(request.getMethod());
try { try {
LOG.info("WS-RPC request -> {}", request.getMethod()); LOG.debug("WS-RPC request -> {}", request.getMethod());
request.setConnectionId(id); request.setConnectionId(id);
future.complete(method.response(request)); future.complete(method.response(request));
} catch (final Exception e) { } catch (final Exception e) {

@ -56,7 +56,7 @@ public class SubscriptionManager extends AbstractVerticle {
} }
public Long subscribe(final SubscribeRequest request) { public Long subscribe(final SubscribeRequest request) {
LOG.info("Subscribe request {}", request); LOG.debug("Subscribe request {}", request);
final long subscriptionId = subscriptionCounter.incrementAndGet(); final long subscriptionId = subscriptionCounter.incrementAndGet();
final Subscription subscription = subscriptionBuilder.build(subscriptionId, request); final Subscription subscription = subscriptionBuilder.build(subscriptionId, request);

@ -120,7 +120,7 @@ public class NetworkRunner implements AutoCloseable {
final int code = message.getData().getCode(); final int code = message.getData().getCode();
if (!protocol.isValidMessageCode(cap.getVersion(), code)) { if (!protocol.isValidMessageCode(cap.getVersion(), code)) {
// Handle invalid messsages by disconnecting // Handle invalid messsages by disconnecting
LOG.info( LOG.debug(
"Invalid message code ({}-{}, {}) received from peer, disconnecting from:", "Invalid message code ({}-{}, {}) received from peer, disconnecting from:",
cap.getName(), cap.getName(),
cap.getVersion(), cap.getVersion(),

@ -82,7 +82,7 @@ abstract class AbstractHandshakeHandler extends SimpleChannelInboundHandler<Byte
final BytesValue nodeId = handshaker.partyPubKey().getEncodedBytes(); final BytesValue nodeId = handshaker.partyPubKey().getEncodedBytes();
if (peerConnectionRegistry.isAlreadyConnected(nodeId)) { if (peerConnectionRegistry.isAlreadyConnected(nodeId)) {
LOG.info("Rejecting connection from already connected client {}", nodeId); LOG.debug("Rejecting connection from already connected client {}", nodeId);
ctx.writeAndFlush( ctx.writeAndFlush(
new OutboundMessage( new OutboundMessage(
null, DisconnectMessage.create(DisconnectReason.ALREADY_CONNECTED))) null, DisconnectMessage.create(DisconnectReason.ALREADY_CONNECTED)))

@ -49,7 +49,7 @@ final class WireKeepAlive extends ChannelDuplexHandler {
if (waitingForPong.get()) { if (waitingForPong.get()) {
// We are still waiting for a response from our last pong, disconnect with timeout error // We are still waiting for a response from our last pong, disconnect with timeout error
LOG.info("Wire PONG never received, disconnecting from peer."); LOG.debug("Wire PONG never received, disconnecting from peer.");
connection.disconnect(DisconnectReason.TIMEOUT); connection.disconnect(DisconnectReason.TIMEOUT);
return; return;
} }

Loading…
Cancel
Save