Fix flaky OpenTelemetry acceptance test (#2375)

Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
pull/2379/head
Antoine Toulme 4 years ago committed by GitHub
parent e90cef0f6d
commit b9aaa15d59
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 11
      acceptance-tests/tests/src/test/java/org/hyperledger/besu/tests/acceptance/OpenTelemetryAcceptanceTest.java

@ -24,6 +24,7 @@ import org.hyperledger.besu.tests.acceptance.dsl.WaitUtils;
import org.hyperledger.besu.tests.acceptance.dsl.node.BesuNode; import org.hyperledger.besu.tests.acceptance.dsl.node.BesuNode;
import org.hyperledger.besu.tests.acceptance.dsl.node.configuration.BesuNodeConfigurationBuilder; import org.hyperledger.besu.tests.acceptance.dsl.node.configuration.BesuNodeConfigurationBuilder;
import java.time.Duration;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.List; import java.util.List;
@ -190,8 +191,13 @@ public class OpenTelemetryAcceptanceTest extends AcceptanceTestBase {
@Test @Test
public void traceReportingWithTraceId() { public void traceReportingWithTraceId() {
Duration timeout = Duration.ofSeconds(1);
OkHttpClient okClient = new OkHttpClient(); OkHttpClient okClient =
new OkHttpClient.Builder()
.connectTimeout(timeout)
.readTimeout(timeout)
.writeTimeout(timeout)
.build();
WaitUtils.waitFor( WaitUtils.waitFor(
30, 30,
() -> { () -> {
@ -213,6 +219,7 @@ public class OpenTelemetryAcceptanceTest extends AcceptanceTestBase {
.build(); .build();
Response response = client.newCall(request).execute(); Response response = client.newCall(request).execute();
assertThat(response.code()).isEqualTo(200); assertThat(response.code()).isEqualTo(200);
response.close();
List<ResourceSpans> spans = new ArrayList<>(fakeTracesCollector.getReceivedSpans()); List<ResourceSpans> spans = new ArrayList<>(fakeTracesCollector.getReceivedSpans());
fakeTracesCollector.getReceivedSpans().clear(); fakeTracesCollector.getReceivedSpans().clear();
assertThat(spans.isEmpty()).isFalse(); assertThat(spans.isEmpty()).isFalse();

Loading…
Cancel
Save