Set the notifications webhook by URL to prevent false alerts (#952)

In the event that someone who has forked this repository sets up CircleCI integrations for it, we would like that builds on their master branch would not be able to send alerts to the Hyperledger Rocket Chat #besu-contributors channel. Here we move to having the notification web-hook be sent to an address set by the HUBOT_URL variable instead. This environment variable is set in the CircleCI web-app in the same place we set the variables for our secrets for other 3rd party app access.

It has been tested that an environment without the variable being set would cause no issues for the CircleCI build system either for other forked projects.

Signed-off-by: Edward Evans <edward.joshua.evans@gmail.com>

pull/962/head

Edward 5 years ago committed by

GitHub

parent 93996e349e

commit f5bb050ae2

No known key found for this signature in database

GPG Key ID: 4AEE18F83AFDEB23

1 changed files with 1 additions and 1 deletions

								
									2

.circleci/config.yml

								Unescape
								Escape
							
									View File
								
					@ -27,7 +27,7 @@ executors:
				
					notify:
				
					  webhooks:
				
					    - url: https://hyperledger-rocket-chat-hubot.herokuapp.com/hubot/circleci
				
					    - url: $HUBOT_URL
				
					commands:
				
					  prepare:

Set the notifications webhook by URL to prevent false alerts (#952)

2 .circleci/config.yml Unescape Escape View File

2

.circleci/config.yml

Unescape Escape View File