allow domain names with dashes in ethstats (#1379)

The NETSTATS_URL_REGEX allows domain names but only allows dots, letters and numbers.
Modified the NETSTATS_URL_REGEX to allow dashes

Signed-off-by: Roderik van der Veer <roderik@settlemint.com>

Co-authored-by: matkt <karim.t2am@gmail.com>

ethereum/ethstats/src/main/java/org/hyperledger/besu/ethstats/util/NetstatsUrl.java

@@ -26,7 +26,7 @@ import org.immutables.value.Value;
 @Value.Immutable
 public interface NetstatsUrl {
 
-  Pattern NETSTATS_URL_REGEX = Pattern.compile("([-\\w]+):([\\w]+)?@([.\\w]+):([\\d]+)");
+  Pattern NETSTATS_URL_REGEX = Pattern.compile("([-\\w]+):([\\w]+)?@([-.\\w]+):([\\d]+)");
 
   String getNodeName();
 

ethereum/ethstats/src/test/java/org/hyperledger/besu/ethstats/util/NetstatsUrlTest.java

@@ -38,6 +38,17 @@ public class NetstatsUrlTest {
     assertThat(netstatsUrl.getContact()).isEqualTo(CONTACT);
   }
 
+  @Test
+  public void buildWithValidHost() {
+    final String[] validHosts =
+        new String[] {"url-test.test.com", "url.test.com", "test.com", "10.10.10.15"};
+    for (String host : validHosts) {
+      final NetstatsUrl netstatsUrl =
+          NetstatsUrl.fromParams("Dev-Node-1:secret@" + host + ":3001", CONTACT);
+      assertThat(netstatsUrl.getHost()).isEqualTo(host);
+    }
+  }
+
   @Test
   public void shouldDetectEmptyParams() {
     assertThatThrownBy(() -> NetstatsUrl.fromParams("", CONTACT))