Usman Saleem
e954537fcc
build - Refactor Besu custom error prone dependency ( #6692 )
...
Move Besu custom error-prone checks into its own repository and use it as an external dependency. This allows to move to a newer version of Google errorprone checks as well while cleaning up build.gradle file.
Key changes resulted due to this change:
* String toLowerCase and toUpperCase to use Locale.ROOT as argument
* Use interface such as List,Map or NavigatableMap instead of concrete class where appropriate.
* Simplify StringBuilder to plain String
* Suppress warnings where appropriate.
-----
Signed-off-by: Usman Saleem <usman@usmans.info>
8 months ago
Justin Florentine
56e1844415
Block on skipped matrix ( #6818 )
...
* also fail on cancelled and skipped
* DCO correction
---------
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
Signed-off-by: Jason Frame <jason.frame@consensys.net>
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Stefan Pingel <16143240+pinges@users.noreply.github.com>
Co-authored-by: Simon Dudley <simon.dudley@consensys.net>
Co-authored-by: Usman Saleem <usman@usmans.info>
Co-authored-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Co-authored-by: Lucas Saldanha <lucas.saldanha@consensys.net>
Co-authored-by: Jason Frame <jason.frame@consensys.net>
Co-authored-by: Karim TAAM <karim.t2am@gmail.com>
8 months ago
ahamlat
bb647d1443
Modify the message when the selection of transactions is interrupted because it reached the maximum configured duration ( #6814 )
...
Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
8 months ago
Karim TAAM
15cbd8423b
Fix issues during snap sync ( #6802 )
...
The purpose of this commit is to fix some bugs detected in the snap sync. This should allow for greater stability with the snap sync and the healing of the flat DB.
---------
Signed-off-by: Karim Taam <karim.t2am@gmail.com>
8 months ago
Fabio Di Fabio
02dd244233
Support running executable Gradle tasks on Windows with WSL ( #6803 )
...
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
8 months ago
Simon Dudley
2222bb197b
Set noisy TransactionLogBloomCacher debug log to trace ( #6808 )
...
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
8 months ago
Simon Dudley
6fe547a3be
Remove draft config from develop release action ( #6807 )
...
Trying to get develop tag to be a pre-release
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
8 months ago
Jason Frame
15d54afdf9
Reduce receipt size ( #6602 )
...
Signed-off-by: Jason Frame <jason.frame@consensys.net>
8 months ago
Simon Dudley
bb9ba13cf8
Refactor BackwardsSyncAlgorithm.pickNextStep for readability ( #6775 )
...
* Refactor BackwardsSyncAlgorithm.pickNextStep for readability
...mostly extracting methods
- Result null check
- Remove redundant BannedMethod suppressions
- Add sonar config back in that was removed by mistake
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
8 months ago
Lucas Saldanha
2eca4d5a4e
Adding engine_getPayloadV4 and engine_newPayloadV4 ( #6783 )
...
Moved engine_newPayload6110 and engine_getPayload6110 to V4
Signed-off-by: Lucas Saldanha <lucascrsaldanha@gmail.com>
8 months ago
Fabio Di Fabio
7abb29cdc8
Improve PluginRpcEndpointException log ( #6789 )
...
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
8 months ago
Usman Saleem
c9c237e57d
ci: Fix Publish GH workflow Artifactory secrets ( #6788 )
...
Signed-off-by: Usman Saleem <usman@usmans.info>
Co-authored-by: Justin Florentine <justin+github@florentine.us>
8 months ago
Stefan Pingel
42f4748ab9
Fix "Backward sync stuck in a loop" #6749 ( #6756 )
...
* minimal change to fix BWS
Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Co-authored-by: Simon Dudley <simon.dudley@consensys.net>
8 months ago
Sally MacFarlane
3455ddf3fb
updated PR template ( #6773 )
...
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
8 months ago
Sally MacFarlane
6fcac7bd45
extra check for syncing ( #6771 )
...
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
8 months ago
Justin Florentine
bee0e5e807
Cleanup dev releases ( #6782 )
...
* delete develop release before creating new one
---------
Signed-off-by: Justin Florentine <justin+github@florentine.us>
8 months ago
Sally MacFarlane
380c0c93f7
for fcu v2 use correct invalid params error code ( #6766 )
...
* fcu v2 use invalid params error code per spec
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
---------
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
8 months ago
Justin Florentine
6337689e09
typo in env var ( #6780 )
...
* get value for sonar options from vars
---------
Signed-off-by: Justin Florentine <justin+github@florentine.us>
8 months ago
Justin Florentine
97d88d1365
Artifactory publish ( #6781 )
...
* correcting env vars
* removes conditionals which result in skipped tasks being considered success
* spotless fix
---------
Signed-off-by: Justin Florentine <justin+github@florentine.us>
8 months ago
Danno Ferrin
da4be733e3
GraphQL serializes BlobVersionedHashes ( #6769 )
...
Fix error where GraphQL fails to serialize the versioned hash of a
blob transaction.
Signed-off-by: Danno Ferrin (shemnon) <danno.ferrin@shemnon.com>
8 months ago
Fabio Di Fabio
010f947836
Fix for `Method input parameters must be final` compilation error ( #6778 )
...
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
8 months ago
Justin Florentine
c564fcd919
get value for sonar options from vars ( #6767 )
...
Signed-off-by: Justin Florentine <justin+github@florentine.us>
8 months ago
Fabio Di Fabio
86cc6cb19e
Extend error handling of plugin RPC methods ( #6759 )
...
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
8 months ago
Danno Ferrin
2bfd510785
Log blob count ( #6761 )
...
Current blog logging shows blob transaction count. The blob count is
more relevant and reflects the label better.
Signed-off-by: Danno Ferrin (shemnon) <danno.ferrin@shemnon.com>
8 months ago
Matt Whitehead
42b32d2531
Log an info message on startup to indicate if IPv6 peer connectivity is possible ( #6750 )
...
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
8 months ago
Sally MacFarlane
cc201691f9
allow empty maxFeePerBlobGas for eth_call ( #6731 )
...
* allow empty blob gas for eth_call
* handle empty maxFeePerBlobGas by setting to blobBaseFee if empty
* set allowExceedingBalance if blobGas not specified
* added a test case for strict with zero blob gas
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
---------
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Justin Florentine <justin+github@florentine.us>
8 months ago
Justin Florentine
578d14ec26
uprevved kzg library dependency, aligns version num with upstream ( #6745 )
...
Signed-off-by: Justin Florentine <justin+github@florentine.us>
8 months ago
Sally MacFarlane
391d670026
disable not ignore ( #6754 )
...
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
8 months ago
Usman Saleem
5c1e1e1879
Suppress ComparisonOutOfRange error-prone warning in AbstractGasLimitSpecification ( #6727 )
...
* Add suppression for ComparisonOutOfRange
* test: Add unit test to cover max gas limit
---------
Signed-off-by: Usman Saleem <usman@usmans.info>
8 months ago
Andrew Davis
4bd8733367
fix(build): docker git ref ( #6744 )
...
Signed-off-by: Andrew Davis <1709934+Savid@users.noreply.github.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
8 months ago
standstaff
9439a1cb60
chore: fix some typos ( #6741 )
...
Signed-off-by: standstaff <zhengxingru@yeah.net>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
8 months ago
Sally MacFarlane
34bd2032a0
ignore flaky test ( #6748 )
...
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
8 months ago
Justin Florentine
8c41e7c44d
Artifactory publish ( #6746 )
...
* resumes publishing jars, but not distros to artifactory
* checkMavenCoordinateCollisions needs a publication with an explicitly set version, does not inherit project.version
---------
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Co-authored-by: garyschulte <garyschulte@gmail.com>
8 months ago
Suraneti
feb1764199
feat: add fixed basefee options ( #6562 )
...
* feat: add fixed basefee options
Signed-off-by: Suraneti Rodsuwan <suraneti.rod@gmail.com>
* Refactor zero base fee to be extension of fixed base fee
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
* feat: use MiningParameters to fixed base fee
Signed-off-by: Suraneti Rodsuwan <suraneti.rod@gmail.com>
* feat: add mining parameters arg on protocol schedule builder
* feat: add miningParameters on gray glacier and prague
Signed-off-by: Suraneti Rodsuwan <suraneti.rod@gmail.com>
* feat: add miningParameters on gray glacier and prague
Signed-off-by: Suraneti Rodsuwan <suraneti.rod@gmail.com>
* feat: add miningParameters on paris,shanghai,future,experimental
Signed-off-by: Suraneti Rodsuwan <suraneti.rod@gmail.com>
---------
Signed-off-by: Suraneti Rodsuwan <suraneti.rod@gmail.com>
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
Signed-off-by: Suraneti <suraneti.rod@gmail.com>
Co-authored-by: Matthew Whitehead <matthew1001@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
8 months ago
Justin Florentine
de0704afbf
PR Annotations removed ( #6735 )
...
* pull_req instead of target
* updates template to put description first
* compensate for changes to versioning on interim builds
---------
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
8 months ago
Gabriel-Trintinalia
9881e201df
Fix permissioning plugin test ( #6737 )
...
Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
8 months ago
Usman Saleem
22daf346ee
Refactor StorageRangeDataRequest to fix nodes saved variable ( #6726 )
...
* Refactor StorageRangeDataRequest
-- Remove ununsed nbNodesSaved
Signed-off-by: Usman Saleem <usman@usmans.info>
* Fix import
Signed-off-by: Usman Saleem <usman@usmans.info>
* fix: Increment nodes saved variable
Signed-off-by: Usman Saleem <usman@usmans.info>
---------
Signed-off-by: Usman Saleem <usman@usmans.info>
8 months ago
Matt Whitehead
b239fb6099
Add comments to a couple of the the EthPeer methods to clarify their behaviour ( #6733 )
...
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
8 months ago
wellweek
2ce2a5546e
chore: remove repetitive words ( #6730 )
...
Signed-off-by: wellweek <xiezitai@outlook.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
9 months ago
MASDXI
9bf542732b
Change`txpool_beusPendingTransactions`:`numResults` from a required parameter to an optional parameter ( #6708 )
...
Signed-off-by: MASDXI <sirawitt42@gmail.com>
9 months ago
Simon Dudley
6dd3c84052
Move potentially spammy peer discovery warn log to debug ( #6728 )
...
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
9 months ago
Usman Saleem
3db07568ae
Refactor PluginPrivacyController ( #6725 )
...
fix parameter name to match overridden method
Signed-off-by: Usman Saleem <usman@usmans.info>
9 months ago
garyschulte
39a356f824
proposed "develop" build versions ( #6699 )
...
* proposed "develop" build versions
Signed-off-by: garyschulte <garyschulte@gmail.com>
9 months ago
Fabio Di Fabio
4cc6b744cf
Transaction simulation service ( #6686 )
...
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
9 months ago
Fabio Di Fabio
efd1bc7070
Fix txpool dump/restore race condition ( #6665 )
...
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
9 months ago
Sally MacFarlane
e56a37da11
verify syncing false ( #6720 )
...
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
9 months ago
Usman Saleem
602999f4cf
Refactor BadBlockReason enum out of BadBlockCause ( #6716 )
...
* Refactor BadBlockReason enum out of BadBlockCause
Signed-off-by: Usman Saleem <usman@usmans.info>
* Deleting ununsed enum value
Signed-off-by: Usman Saleem <usman@usmans.info>
---------
Signed-off-by: Usman Saleem <usman@usmans.info>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
9 months ago
Sally MacFarlane
501d169db5
edits to changelog for 24.3.0 ( #6712 )
...
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
9 months ago
garyschulte
c39ca6d44f
Support pruned chain history in peer validators ( #6698 )
...
* dao fork block presence is optional in peer validator to support peers with pruned chain history
Signed-off-by: garyschulte <garyschulte@gmail.com>
* Update ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/peervalidation/AbstractPeerBlockValidator.java
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
---------
Signed-off-by: garyschulte <garyschulte@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
9 months ago
Justin Florentine
934e43558b
Gha updates ( #6705 )
...
* make artifacts more snapshot friendly
* break out new workflows for snapshots, and a develop releease
* removes checking for approval, runs on pr update
* adds concurrency so updated refs cancel prior runs if still running
* explicitly disable caching on gradle setup tasks
---------
Signed-off-by: Justin Florentine <justin+github@florentine.us>
9 months ago