Merge pull request #2270 from poanetwork/pp-dedup-params-in-token_balance-fetcher

Remove duplicate params in `Indexer.Fetcher.TokenBalance`

CHANGELOG.md

@@ -58,6 +58,7 @@
 - [#2204](https://github.com/poanetwork/blockscout/pull/2204) - fix large contract verification
 - [#2247](https://github.com/poanetwork/blockscout/pull/2247) - hide logs search if there are no logs
 - [#2248](https://github.com/poanetwork/blockscout/pull/2248) - sort block after query execution for average block time
+- [#2270](https://github.com/poanetwork/blockscout/pull/2270) - Remove duplicate params in `Indexer.Fetcher.TokenBalance`
 - [#2268](https://github.com/poanetwork/blockscout/pull/2268) - remove not existing assigns in html code
 
 ### Chore

apps/indexer/lib/indexer/fetcher/token_balance.ex

@@ -93,7 +93,10 @@ defmodule Indexer.Fetcher.TokenBalance do
   end
 
   def fetch_from_blockchain(params_list) do
-    retryable_params_list = Enum.filter(params_list, &(&1.retries_count <= @max_retries))
+    retryable_params_list =
+      params_list
+      |> Enum.filter(&(&1.retries_count <= @max_retries))
+      |> Enum.uniq_by(&Map.take(&1, [:token_contract_address_hash, :address_hash, :block_number]))
 
     Logger.metadata(count: Enum.count(retryable_params_list))
 

apps/indexer/test/indexer/fetcher/token_balance_test.exs

@@ -111,6 +111,41 @@ defmodule Indexer.Fetcher.TokenBalanceTest do
 
       assert TokenBalance.run(token_balances, nil) == :ok
     end
+
+    test "fetches duplicate params only once" do
+      %Address.TokenBalance{
+        address_hash: %Hash{bytes: address_hash_bytes} = address_hash,
+        token_contract_address_hash: %Hash{bytes: token_contract_address_hash_bytes},
+        block_number: block_number
+      } = insert(:token_balance, value_fetched_at: nil, value: nil)
+
+      expect(
+        EthereumJSONRPC.Mox,
+        :json_rpc,
+        fn [%{id: id, method: "eth_call", params: [%{data: _, to: _}, _]}], _options ->
+          {:ok,
+           [
+             %{
+               id: id,
+               jsonrpc: "2.0",
+               result: "0x00000000000000000000000000000000000000000000d3c21bcecceda1000000"
+             }
+           ]}
+        end
+      )
+
+      assert TokenBalance.run(
+               [
+                 {address_hash_bytes, token_contract_address_hash_bytes, block_number, 0},
+                 {address_hash_bytes, token_contract_address_hash_bytes, block_number, 0}
+               ],
+               nil
+             ) == :ok
+
+      assert 1 =
+               from(tb in Address.TokenBalance, where: tb.address_hash == ^address_hash)
+               |> Explorer.Repo.aggregate(:count, :id)
+    end
   end
 
   describe "import_token_balances/1" do