Adds error example values to API docs page

Why:

* For users to be able to see an example of what errors might look like
when perusing the API's docs pages.
* Issue link: related to
https://github.com/poanetwork/poa-explorer/issues/138

This change addresses the need by:

* Editing `ExplorerWeb.Etherscan` to include "error" example values for
`account#balance`, `account#balancemulti`, and `account#txlist` calls.
Also, adding "description" field for responses.
* Editing `templates/api_docs/_action_tile.html.eex` to only render
model information for the first response in the responses table. Also,
rendering description field from the documentation data passed to the
template (from `ExplorerWeb.Etherscan`).
pull/512/head
Sebastian Abondano 6 years ago
parent d0c1e70f13
commit af24e24d98
  1. 30
      apps/explorer_web/lib/explorer_web/etherscan.ex
  2. 11
      apps/explorer_web/lib/explorer_web/templates/api_docs/_action_tile.html.eex

@ -9,6 +9,12 @@ defmodule ExplorerWeb.Etherscan do
"result" => "663046792267785498951364" "result" => "663046792267785498951364"
} }
@account_balance_example_value_error %{
"status" => "0",
"message" => "Invalid address hash",
"result" => nil
}
@account_balancemulti_example_value %{ @account_balancemulti_example_value %{
"status" => "1", "status" => "1",
"message" => "OK", "message" => "OK",
@ -56,6 +62,12 @@ defmodule ExplorerWeb.Etherscan do
] ]
} }
@account_txlist_example_value_error %{
"status" => "0",
"message" => "No transactions found",
"result" => []
}
@status_type %{ @status_type %{
type: "status", type: "status",
enum: ~s(["0", "1"]), enum: ~s(["0", "1"]),
@ -173,6 +185,7 @@ defmodule ExplorerWeb.Etherscan do
responses: [ responses: [
%{ %{
code: "200", code: "200",
description: "successful operation",
example_value: Jason.encode!(@account_balance_example_value), example_value: Jason.encode!(@account_balance_example_value),
model: %{ model: %{
name: "Result", name: "Result",
@ -182,6 +195,11 @@ defmodule ExplorerWeb.Etherscan do
result: @wei_type result: @wei_type
} }
} }
},
%{
code: "200",
description: "error",
example_value: Jason.encode!(@account_balance_example_value_error)
} }
] ]
} }
@ -202,6 +220,7 @@ defmodule ExplorerWeb.Etherscan do
responses: [ responses: [
%{ %{
code: "200", code: "200",
description: "successful operation",
example_value: Jason.encode!(@account_balancemulti_example_value), example_value: Jason.encode!(@account_balancemulti_example_value),
model: %{ model: %{
name: "Result", name: "Result",
@ -214,6 +233,11 @@ defmodule ExplorerWeb.Etherscan do
} }
} }
} }
},
%{
code: "200",
description: "error",
example_value: Jason.encode!(@account_balance_example_value_error)
} }
] ]
} }
@ -262,6 +286,7 @@ defmodule ExplorerWeb.Etherscan do
responses: [ responses: [
%{ %{
code: "200", code: "200",
description: "successful operation",
example_value: Jason.encode!(@account_txlist_example_value), example_value: Jason.encode!(@account_txlist_example_value),
model: %{ model: %{
name: "Result", name: "Result",
@ -274,6 +299,11 @@ defmodule ExplorerWeb.Etherscan do
} }
} }
} }
},
%{
code: "200",
description: "error",
example_value: Jason.encode!(@account_txlist_example_value_error)
} }
] ]
} }

@ -148,14 +148,14 @@
</tr> </tr>
</thead> </thead>
<tbody> <tbody>
<%= for response <- @action.responses do %> <%= for {response, index} <- Enum.with_index(@action.responses) do %>
<tr> <tr>
<td> <td>
<%= response.code %> <%= response.code %>
</td> </td>
<td> <td>
<div class="card card-body bg-dark rounded p-0"> <div class="card card-body bg-dark rounded p-0">
<pre class="text-white m-2"><em>successful operation</em></pre> <pre class="text-white m-2"><em><%= response.description %></em></pre>
</div> </div>
<ul class="nav nav-pills mb-3" role="tablist"> <ul class="nav nav-pills mb-3" role="tablist">
@ -170,6 +170,8 @@
Example Value Example Value
</a> </a>
</li> </li>
<%= if index == 0 do %>
<li class="nav-item"> <li class="nav-item">
<a class="nav-link" <a class="nav-link"
id="<%= "#{@module_name}-#{@action.name}-model-tab" %>" id="<%= "#{@module_name}-#{@action.name}-model-tab" %>"
@ -181,6 +183,7 @@
Model Model
</a> </a>
</li> </li>
<% end %>
</ul> </ul>
<div class="tab-content"> <div class="tab-content">
<div class="tab-pane fade show active" <div class="tab-pane fade show active"
@ -191,12 +194,16 @@
<pre class="text-white m-2" data-json='<%= response.example_value %>'></pre> <pre class="text-white m-2" data-json='<%= response.example_value %>'></pre>
</div> </div>
</div> <!-- /tab-pane --> </div> <!-- /tab-pane -->
<%= if index == 0 do %>
<div class="tab-pane fade" <div class="tab-pane fade"
id="<%= "#{@module_name}-#{@action.name}-model" %>" id="<%= "#{@module_name}-#{@action.name}-model" %>"
role="tabpanel" role="tabpanel"
aria-labelledby="<%= "#{@module_name}-#{@action.name}-model-tab" %>"> aria-labelledby="<%= "#{@module_name}-#{@action.name}-model-tab" %>">
<%= render "_model_table.html", model: response.model %> <%= render "_model_table.html", model: response.model %>
</div> <!-- /tab-pane --> </div> <!-- /tab-pane -->
<% end %>
</div> <!-- /tab-content --> </div> <!-- /tab-content -->
</td> </td>

Loading…
Cancel
Save