14ef0b7652
Checking PC validity performance improvement ( #89 )
...
* Checking PC validity performance improvement
1 year ago
628065cf23
[EVM-736]: Quorum calculation discrepancy between SC and Edge ( #86 )
...
Fix calculateQuorum
1 year ago
12f2a17e73
Introduce metrics to go-ibft ( #85 )
...
metrics added
1 year ago
fa4235351c
HasPrepareQuorum - log missing proposal only in prepare state ( #81 )
1 year ago
081b97a063
Fix minor audit issues ( #63 )
...
* Pick correct round from prepared certificate on building block
* Fix checking proposal for non-zero round
* Revert validating RoundChange messages in proposal
* Add unit tests for ValidateProposal
* Correct test name
* Remove duplicated test
Fix lint error
2 years ago
337b82c3c3
SignalEvent on subscription panic ( #73 )
2 years ago
875a237fb0
Evm-566: Move quorum function to go ibft ( #72 )
...
HasQuorum has been moved from backend to consensus
Co-authored-by: stana-ethernal <stana.miric@ethernal.tech>
Co-authored-by: Igor Crevar <crewce@gmail.com>
2 years ago
72a09919e6
Go-ibft ignores some future messages ( #67 )
...
* Go-ibft ignores some future messages
* Additional test case (same height, lower message round)
* Test for greater height and lower round added
---------
Co-authored-by: Stefan Negovanović <stefan@ethernal.tech>
2 years ago
ec72c80bc6
Revert "Run messaging handlings in parallel" ( #66 )
...
* Revert "Run messaging handlings in parallel (#57 )"
This reverts commit b1a0900563
2 years ago
b1a0900563
Run messaging handlings in parallel ( #57 )
...
* Run messaging handlings in parallel
* Fix comments
* Fix stuck issue due to missing reset of commitSent
* Fix lint error
* Correct comments
* Add deep copy for value in state which is reference type value
* Fix lint error
* Move logging to proper position
2 years ago
9a2958bc32
Provide `View` instance to `BuildProposal` ( #62 )
...
Provide view to BuildProposal
2 years ago
d3776f4434
Improve Code Comments ( #54 )
...
* Add supplement of comments for backend
* Rename IsValidSender to IsValidValidator
* Fix lint error
* Fix comment
2 years ago
a6e7eea07f
[PoC] Fix hash calculation for proposal ( #55 )
...
* Introduced the ProposedBlock (EB,r) struct.
* Fixed the InsertBlock signature.
* Added getEthereumBlockFromProposal state fn
* Fixed all method signatures that expect a proposal.
* Tests refactored and failing.
* Removed unused pb type
* Add round validation in reception of Proposal
* Fix failing tests
* Fix lint error
* Rename EthereumBlock to RawProposal
* Rename BuildEthereumBlock to BuildBlock
* Rename getEthereumBlockFromProposal to getRawDataFromProposal
* Fix function comment
* Fix interface of InsertBlock
* Remove ExtractEthereumBlock
* Fix failed test
* Reorder checks in validateProposalCommon
* Rename ProposedBlock to Proposal
* Fix lint error
* Rename Block to Proposal
* Fix comment
* Rename IsValidBlock to IsValidProposal
* Fix lint error
* Fix lint error
* Add comment in messages.proto
* Fix failed tests
* revert proposalMatches
* Revert "revert proposalMatches"
This reverts commit 57ea12f00f368025c938
2 years ago
c5dbcd0d15
Remove redundant code and Add Safe check in bulding committed seals ( #53 )
...
* Remove redundant local variables in validateProposal
* Add safe check in ExtractCommittedSeals
* Fix lint error
2 years ago
d055e2b151
Fix wrong selection of proposed block from previous round in non-zero… ( #52 )
...
* Fix wrong selection of proposed block from previous round in non-zero round
* Fix lint error
* Fix lint error
* Fix fetching of extendedRCC
* Fix lint error
* Update maxRound in buildProposal for round > 0
* Add early continue to skip useless message validity check in GetExtendedRCC
2 years ago
503b703b40
Suggestion 4: Add Fault Tests ( #58 )
...
* Drop tests
2 years ago
d6431af3ac
Byzantine tests ( #56 )
...
* Byzantine tests
2 years ago
730c09c2a8
Audit improvements ( #50 )
...
* Audit improvements
2 years ago
eea78df818
Fix Wrong Round Value in Validation of roundsAndPreparedBlockHashes ( #51 )
...
Fix round in roundsAndP reparedBlockHashes
2 years ago
e2b5fd3bd5
Remove redundant changeState ( #49 )
2 years ago
50da8f5c4e
Added per round event-based setup in rapid tests ( #47 )
2 years ago
8b1e3f20c4
EVM-220 TestClusterBlockSync/BLS fails in voting power branch ( #48 )
2 years ago
2ac556e04f
Implement event generator for rapid testing ( #46 )
2 years ago
70fa07d86c
Add rapid test with bad proposal coming from byzantine node ( #44 )
2 years ago
21b620873b
Minor fixes in ibft and tests ( #45 )
2 years ago
12435ef98c
update linters ( #40 )
...
* updated
* run all
* Update .github/workflows/lint.yml
Co-authored-by: Victor Castell <victor@victorcastell.com>
* count parallel code
* cr
* linters
* linters
* linters
* linters
* linters
* linters
* linters
* use io.copy
* linters
* linters
* linters
Co-authored-by: Victor Castell <victor@victorcastell.com>
2 years ago
ee4d8a0bb2
Move logic for quorum check to the backend ( #39 )
...
* Move logic for quorum check to the backend
* Checking quorum with abstracted HasQuorum
* Refactor MaxFaultyNodes func
* Remove MinNumMessages usage
* Remove backend Quorum and move test to use HasQuorumFn
* Remove MaxFaulty, is not being used at all
2 years ago
49b0ca1c3b
Expand `BuildProposal` with current round information ( #43 )
...
Expand BuildProposal with current round information
2 years ago
0acf0db7c9
reproducible builds ( #42 )
...
* initial
* fix
* fix
* fix
* fix
* fix
2 years ago
805919c413
Use shuffle in all go test ( #37 )
...
use shuffle in all go test
2 years ago
d9166abecd
bump golang to 1.19 ( #41 )
...
initial
2 years ago
856fb298ad
Github Actions Workflow Refactor ( #33 )
...
* initial workflow rework
* adding appropriate branches
* refactoring to fit go-ibft
* name update
* removing unneeded braces. creating diff
* offloading Main workflow Snyk scans to Github integration.
* adding missing golangci configuration
* fixed branch
* adding needed codecov CI
2 years ago
602237fdeb
Bump github.com/stretchr/testify from 1.8.0 to 1.8.1 ( #34 )
...
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify ) from 1.8.0 to 1.8.1.
- [Release notes](https://github.com/stretchr/testify/releases )
- [Commits](https://github.com/stretchr/testify/compare/v1.8.0...v1.8.1 )
---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2 years ago
130e9cb55b
Introduce drop property tests ( #31 )
...
* introduce drop property tests
2 years ago
3e9fecd21d
Integrate goleak to tests ( #32 )
...
* Integrated goleak
* Added goleak.IgnoreCurrent() in order to ignore existing goroutines
* Implementation
2 years ago
faaae0a8ff
Add golang vulnerabilities checker ( #30 )
2 years ago
20516d0371
Resolve data races in tests utilizing go routines ( #29 )
...
* Remove parallel execution for rapid tests
* Resolve data races in tests
* Add race test to workflow
* Resolve faulty path in test dir
* Remove double context cancels
* Add newline to the workflow file
2 years ago
d583c51e66
Introduce property based tests with Rapid + bump go version ( #27 )
...
* Introduce the Rapid framework, add base rapid cluster test
* Bump the go version in the workflow files
* Add TestProperty_MajorityHonestNodes
* Resolve linting errors
* Minor cleanup
* Simplify the quorum method
* Remove pointer manipulation for mockNodeContext
2 years ago
e43142f8d2
Fix type of CommittedSeal in IsValidCommittedSeal and InsertBlock ( #24 )
...
* Change type of CommittedSeal
* Downgrade golangci in actions
* Fix version format of golangcli in actions
2 years ago
09f8c3c345
Bump google.golang.org/protobuf from 1.28.0 to 1.28.1 ( #22 )
...
Bumps [google.golang.org/protobuf](https://github.com/protocolbuffers/protobuf-go ) from 1.28.0 to 1.28.1.
- [Release notes](https://github.com/protocolbuffers/protobuf-go/releases )
- [Changelog](https://github.com/protocolbuffers/protobuf-go/blob/master/release.bash )
- [Commits](https://github.com/protocolbuffers/protobuf-go/compare/v1.28.0...v1.28.1 )
---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2 years ago
0f95a9c3a0
Final Feedback ( #21 )
...
* Empty branch
* Simplify loop conditional
* Add quorum optimal helper to test
* Remove newlines
* Expand abbreviation:
* Change SubscriptionDetails field
* add common proposal validation method
* Change variable name in log
* Change variable name in log
* Add syntax sugar for transport multicasts
* Add simple start method for state
* Add log for invalid proposal
* Change naming of routine method
* Simplify block preprepare acceptance
* Add explainer for loop iteration
* Add to barrier before starting the routine
* Have the barrier increase right before the go routines
* Make the conditional for subscription pushes more clear
* Fix conditional for higher rounds
2 years ago
f0abb68d33
Increase coverage of base IBFT tests
2 years ago
16fac25c96
Add coverage for message helpers
2 years ago
2b86d60ff7
Cleanup the subscription interface
2 years ago
1cdc547b2a
Resolve linting error
2 years ago
afbc7335b3
Add support for future RCC tests
2 years ago
863e0c0340
added codecov badge
2 years ago
f728986655
added codecov
2 years ago
3548770705
Update the go.mod
2 years ago
6333668242
fix log
2 years ago
Stana Miric
Goran Rojovic
Nemanja Nedic
kourin
Igor Crevar
Victor Castell
Stefan Negovanović
Vuk Gavrilovic
Roman Behma
Evgeny Danilenko
Epikichi
dependabot[bot]
Dusan Brajovic
Miloš Živković
kourin
ZeljkoBenovic