each region only deploys max 500 at once. fixed

aws-experiment-launch/deploy.py

@@ -36,28 +36,13 @@ CURRENT_SESSION = datetime.datetime.fromtimestamp(
 PLACEMENT_GROUP = "PLACEMENT-" + CURRENT_SESSION
 NODE_NAME_SUFFIX = "NODE-" + CURRENT_SESSION
 
-def run_one_region_codedeploy(region_number, region_config, node_name_tag, commit_id):
+
+def run_one_region_codedeploy(region_number, region_config, node_name_tag_list, commit_id):
     ec2_client, session = utils.create_ec2_client(region_number, region_config)
+    for node_name_tag in node_name_tag_list:
         filters = [{'Name': 'tag:Name','Values': [node_name_tag]}]
         instance_ids = utils.get_instance_ids(ec2_client.describe_instances(Filters=filters))
 
-    total_instances = len(instance_ids)
-    thread_pool = []
-    i = 0
-    while i < total_instances:
-        j = min(total_instances, i + utils.MAX_INSTANCES_FOR_DEPLOYMENT)
-        t = threading.Thread(target=run_one_region_codedeploy_with_max_500_instances, args=(
-                            ec2_client, session, region_number, instance_ids[i:j],
-                            node_name_tag, commit_id, i))
-        t.start()
-        thread_pool.append(t)
-        i = i + utils.MAX_INSTANCES_FOR_DEPLOYMENT
-    for t in thread_pool:
-        t.join()
-
-
-def run_one_region_codedeploy_with_max_500_instances(ec2_client, session, region_number,
-        instance_ids, node_name_tag, commit_id, tag_id):
         LOGGER.info("Number of instances: %d" % len(instance_ids))
 
         LOGGER.info("Waiting for %d instances in region %s to be in RUNNING" % (len(instance_ids), region_number))
@@ -77,7 +62,7 @@ def run_one_region_codedeploy_with_max_500_instances(ec2_client, session, region
 
         codedeploy = session.client('codedeploy')
         application_name = APPLICATION_NAME
-    deployment_group_name = APPLICATION_NAME + "-" + commit_id[:6] + "-" + str(tag_id) + "-" + CURRENT_SESSION
+        deployment_group_name = APPLICATION_NAME + "-" + commit_id[:6] + "-" + node_name_tag + "-" + CURRENT_SESSION
         repo = REPO
 
         LOGGER.info("Setting up to deploy commit_id %s on region %s" % (commit_id, region_number))
@@ -89,7 +74,7 @@ def run_one_region_codedeploy_with_max_500_instances(ec2_client, session, region
         else:
             LOGGER.info("Created deployment group with name %s was created" % deployment_group_name)
         deployment_id, status = deploy(codedeploy, application_name, deployment_group_name, repo, commit_id)
-    return region_number, deployment_id, status
+        LOGGER.info("Done with deployment with id: %s and status: %s" % (deployment_id, status))
 
 
 def deploy(codedeploy, application_name, deployment_group, repo, commit_id):
@@ -137,12 +122,17 @@ def deploy(codedeploy, application_name, deployment_group, repo, commit_id):
     return deployment_id, status
 
 def launch_code_deploy(region_list, region_config, commit_id):
-    thread_pool = []
+    region_collection = {}
     for region_tuppple in region_list:
         # node_name_tag comes first.
         node_name_tag, region_number = region_tuppple
+        if not region_collection.get(region_number):
+            region_collection[region_number] = []
+        region_collection[region_number].append(node_name_tag)
+    thread_pool = []
+    for region_number in region_collection.iterkeys():
         t = threading.Thread(target=run_one_region_codedeploy, args=(
-            region_number, region_config, node_name_tag, commit_id))
+            region_number, region_config, region_collection[region_number], commit_id))
         t.start()
         thread_pool.append(t)
     for t in thread_pool: