[viewchange] filter out viewchange message in p2p validation

filter out viewchange/newview message when the validator is not in viewchanging mode.

Signed-off-by: Leo Chen <leo@harmony.one>

consensus/consensus_v2.go

@@ -43,13 +43,6 @@ func (consensus *Consensus) HandleMessageUpdate(ctx context.Context, msg *msg_pb
 		return nil
 	}
 
-	// when node is not in ViewChanging mode, ignore viewchange / newview messages
-	if !consensus.IsViewChangingMode() &&
-		(msg.Type == msg_pb.MessageType_VIEWCHANGE ||
-			msg.Type == msg_pb.MessageType_NEWVIEW) {
-		return nil
-	}
-
 	intendedForValidator, intendedForLeader :=
 		!consensus.IsLeader(),
 		consensus.IsLeader()

node/node.go

@@ -461,9 +461,9 @@ func (node *Node) validateShardBoundMessage(
 			return nil, nil, true, nil
 		}
 	} else {
-		// ignore newview message if the node is not in viewchanging mode
+		// ignore viewchange/newview message if the node is not in viewchanging mode
 		switch m.Type {
-		case msg_pb.MessageType_NEWVIEW:
+		case msg_pb.MessageType_NEWVIEW, msg_pb.MessageType_VIEWCHANGE:
 			return nil, nil, true, nil
 		}
 	}