set SnapshotLimit to zero by default for all networks

cmd/harmony/config.go

@@ -161,9 +161,15 @@ func getDefaultCacheConfig(nt nodeconfig.NetworkType) harmonyconfig.CacheConfig
 	case nodeconfig.Mainnet:
 		cacheConfig.Disabled = true
 		cacheConfig.Preimages = true
+		cacheConfig.SnapshotLimit = 0
 	case nodeconfig.Testnet:
-		cacheConfig.Disabled = false
+		cacheConfig.Disabled = true
+		cacheConfig.Preimages = true
+		cacheConfig.SnapshotLimit = 0
+	case nodeconfig.Partner:
+		cacheConfig.Disabled = true
 		cacheConfig.Preimages = true
+		cacheConfig.SnapshotLimit = 0
 	case nodeconfig.Localnet:
 		cacheConfig.Disabled = false
 		cacheConfig.Preimages = false

cmd/harmony/flags_test.go

@@ -1440,7 +1440,7 @@ func TestCacheFlags(t *testing.T) {
 				TrieNodeLimit:   defaultCacheConfig.TrieNodeLimit,
 				TriesInMemory:   defaultCacheConfig.TriesInMemory,
 				TrieTimeLimit:   defaultCacheConfig.TrieTimeLimit,
-				SnapshotLimit:   defaultCacheConfig.SnapshotLimit,
+				SnapshotLimit:   0, // based on network type,
 				SnapshotWait:    defaultCacheConfig.SnapshotWait,
 				Preimages:       defaultCacheConfig.Preimages, // based on network type
 				SnapshotNoBuild: defaultCacheConfig.SnapshotNoBuild,