|
|
|
/**
|
|
|
|
* @file The entry point for the web extension singleton process.
|
|
|
|
*/
|
|
|
|
|
|
|
|
import endOfStream from 'end-of-stream';
|
|
|
|
import pump from 'pump';
|
|
|
|
import debounce from 'debounce-stream';
|
|
|
|
import log from 'loglevel';
|
|
|
|
import browser from 'webextension-polyfill';
|
|
|
|
import { storeAsStream, storeTransformStream } from '@metamask/obs-store';
|
|
|
|
import PortStream from 'extension-port-stream';
|
|
|
|
import { captureException } from '@sentry/browser';
|
|
|
|
|
|
|
|
import { ethErrors } from 'eth-rpc-errors';
|
|
|
|
import {
|
|
|
|
ENVIRONMENT_TYPE_POPUP,
|
|
|
|
ENVIRONMENT_TYPE_NOTIFICATION,
|
|
|
|
ENVIRONMENT_TYPE_FULLSCREEN,
|
|
|
|
PLATFORM_FIREFOX,
|
|
|
|
} from '../../shared/constants/app';
|
|
|
|
import { SECOND } from '../../shared/constants/time';
|
|
|
|
import {
|
|
|
|
REJECT_NOTFICIATION_CLOSE,
|
|
|
|
REJECT_NOTFICIATION_CLOSE_SIG,
|
|
|
|
} from '../../shared/constants/metametrics';
|
|
|
|
import { isManifestV3 } from '../../shared/modules/mv3.utils';
|
|
|
|
import { maskObject } from '../../shared/modules/object.utils';
|
|
|
|
import migrations from './migrations';
|
|
|
|
import Migrator from './lib/migrator';
|
|
|
|
import ExtensionPlatform from './platforms/extension';
|
|
|
|
import LocalStore from './lib/local-store';
|
|
|
|
import ReadOnlyNetworkStore from './lib/network-store';
|
|
|
|
import { SENTRY_STATE } from './lib/setupSentry';
|
|
|
|
|
|
|
|
import createStreamSink from './lib/createStreamSink';
|
|
|
|
import NotificationManager, {
|
|
|
|
NOTIFICATION_MANAGER_EVENTS,
|
|
|
|
} from './lib/notification-manager';
|
|
|
|
import MetamaskController, {
|
|
|
|
METAMASK_CONTROLLER_EVENTS,
|
|
|
|
} from './metamask-controller';
|
|
|
|
import rawFirstTimeState from './first-time-state';
|
|
|
|
import getFirstPreferredLangCode from './lib/get-first-preferred-lang-code';
|
|
|
|
import getObjStructure from './lib/getObjStructure';
|
|
|
|
import setupEnsIpfsResolver from './lib/ens-ipfs/setup';
|
|
|
|
import { getPlatform } from './lib/util';
|
|
|
|
/* eslint-enable import/first */
|
|
|
|
|
|
|
|
const { sentry } = global;
|
|
|
|
const firstTimeState = { ...rawFirstTimeState };
|
|
|
|
|
|
|
|
const metamaskInternalProcessHash = {
|
|
|
|
[ENVIRONMENT_TYPE_POPUP]: true,
|
|
|
|
[ENVIRONMENT_TYPE_NOTIFICATION]: true,
|
|
|
|
[ENVIRONMENT_TYPE_FULLSCREEN]: true,
|
|
|
|
};
|
|
|
|
|
|
|
|
const metamaskBlockedPorts = ['trezor-connect'];
|
|
|
|
|
|
|
|
log.setDefaultLevel(process.env.METAMASK_DEBUG ? 'debug' : 'info');
|
|
|
|
|
|
|
|
const platform = new ExtensionPlatform();
|
|
|
|
|
|
|
|
const notificationManager = new NotificationManager();
|
|
|
|
global.METAMASK_NOTIFIER = notificationManager;
|
|
|
|
|
|
|
|
let popupIsOpen = false;
|
|
|
|
let notificationIsOpen = false;
|
|
|
|
let uiIsTriggering = false;
|
|
|
|
const openMetamaskTabsIDs = {};
|
|
|
|
const requestAccountTabIds = {};
|
|
|
|
|
|
|
|
// state persistence
|
|
|
|
const inTest = process.env.IN_TEST;
|
|
|
|
const localStore = inTest ? new ReadOnlyNetworkStore() : new LocalStore();
|
|
|
|
let versionedData;
|
|
|
|
|
|
|
|
if (inTest || process.env.METAMASK_DEBUG) {
|
|
|
|
global.metamaskGetState = localStore.get.bind(localStore);
|
|
|
|
}
|
|
|
|
|
|
|
|
const phishingPageUrl = new URL(process.env.PHISHING_WARNING_PAGE_URL);
|
|
|
|
|
|
|
|
const ONE_SECOND_IN_MILLISECONDS = 1_000;
|
|
|
|
// Timeout for initializing phishing warning page.
|
|
|
|
const PHISHING_WARNING_PAGE_TIMEOUT = ONE_SECOND_IN_MILLISECONDS;
|
|
|
|
|
|
|
|
/**
|
|
|
|
* In case of MV3 we attach a "onConnect" event listener as soon as the application is initialised.
|
|
|
|
* Reason is that in case of MV3 a delay in doing this was resulting in missing first connect event after service worker is re-activated.
|
|
|
|
*/
|
|
|
|
|
|
|
|
const initApp = async (remotePort) => {
|
|
|
|
browser.runtime.onConnect.removeListener(initApp);
|
|
|
|
await initialize(remotePort);
|
|
|
|
log.info('MetaMask initialization complete.');
|
|
|
|
};
|
|
|
|
|
|
|
|
if (isManifestV3()) {
|
|
|
|
browser.runtime.onConnect.addListener(initApp);
|
|
|
|
} else {
|
|
|
|
// initialization flow
|
|
|
|
initialize().catch(log.error);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @typedef {import('../../shared/constants/transaction').TransactionMeta} TransactionMeta
|
|
|
|
*/
|
|
|
|
|
|
|
|
/**
|
|
|
|
* The data emitted from the MetaMaskController.store EventEmitter, also used to initialize the MetaMaskController. Available in UI on React state as state.metamask.
|
|
|
|
*
|
|
|
|
* @typedef MetaMaskState
|
|
|
|
* @property {boolean} isInitialized - Whether the first vault has been created.
|
|
|
|
* @property {boolean} isUnlocked - Whether the vault is currently decrypted and accounts are available for selection.
|
|
|
|
* @property {boolean} isAccountMenuOpen - Represents whether the main account selection UI is currently displayed.
|
|
|
|
* @property {Object} identities - An object matching lower-case hex addresses to Identity objects with "address" and "name" (nickname) keys.
|
|
|
|
* @property {Object} unapprovedTxs - An object mapping transaction hashes to unapproved transactions.
|
|
|
|
* @property {Array} frequentRpcList - A list of frequently used RPCs, including custom user-provided ones.
|
|
|
|
* @property {Array} addressBook - A list of previously sent to addresses.
|
|
|
|
* @property {Object} contractExchangeRates - Info about current token prices.
|
|
|
|
* @property {Array} tokens - Tokens held by the current user, including their balances.
|
|
|
|
* @property {Object} send - TODO: Document
|
|
|
|
* @property {boolean} useBlockie - Indicates preferred user identicon format. True for blockie, false for Jazzicon.
|
|
|
|
* @property {Object} featureFlags - An object for optional feature flags.
|
|
|
|
* @property {boolean} welcomeScreen - True if welcome screen should be shown.
|
|
|
|
* @property {string} currentLocale - A locale string matching the user's preferred display language.
|
|
|
|
* @property {Object} provider - The current selected network provider.
|
|
|
|
* @property {string} provider.rpcUrl - The address for the RPC API, if using an RPC API.
|
|
|
|
* @property {string} provider.type - An identifier for the type of network selected, allows MetaMask to use custom provider strategies for known networks.
|
|
|
|
* @property {string} network - A stringified number of the current network ID.
|
|
|
|
* @property {Object} accounts - An object mapping lower-case hex addresses to objects with "balance" and "address" keys, both storing hex string values.
|
|
|
|
* @property {hex} currentBlockGasLimit - The most recently seen block gas limit, in a lower case hex prefixed string.
|
|
|
|
* @property {TransactionMeta[]} currentNetworkTxList - An array of transactions associated with the currently selected network.
|
|
|
|
* @property {Object} unapprovedMsgs - An object of messages pending approval, mapping a unique ID to the options.
|
|
|
|
* @property {number} unapprovedMsgCount - The number of messages in unapprovedMsgs.
|
|
|
|
* @property {Object} unapprovedPersonalMsgs - An object of messages pending approval, mapping a unique ID to the options.
|
|
|
|
* @property {number} unapprovedPersonalMsgCount - The number of messages in unapprovedPersonalMsgs.
|
|
|
|
* @property {Object} unapprovedEncryptionPublicKeyMsgs - An object of messages pending approval, mapping a unique ID to the options.
|
|
|
|
* @property {number} unapprovedEncryptionPublicKeyMsgCount - The number of messages in EncryptionPublicKeyMsgs.
|
|
|
|
* @property {Object} unapprovedDecryptMsgs - An object of messages pending approval, mapping a unique ID to the options.
|
|
|
|
* @property {number} unapprovedDecryptMsgCount - The number of messages in unapprovedDecryptMsgs.
|
|
|
|
* @property {Object} unapprovedTypedMsgs - An object of messages pending approval, mapping a unique ID to the options.
|
|
|
|
* @property {number} unapprovedTypedMsgCount - The number of messages in unapprovedTypedMsgs.
|
|
|
|
* @property {number} pendingApprovalCount - The number of pending request in the approval controller.
|
|
|
|
* @property {string[]} keyringTypes - An array of unique keyring identifying strings, representing available strategies for creating accounts.
|
|
|
|
* @property {Keyring[]} keyrings - An array of keyring descriptions, summarizing the accounts that are available for use, and what keyrings they belong to.
|
|
|
|
* @property {string} selectedAddress - A lower case hex string of the currently selected address.
|
|
|
|
* @property {string} currentCurrency - A string identifying the user's preferred display currency, for use in showing conversion rates.
|
|
|
|
* @property {number} conversionRate - A number representing the current exchange rate from the user's preferred currency to Ether.
|
|
|
|
* @property {number} conversionDate - A unix epoch date (ms) for the time the current conversion rate was last retrieved.
|
|
|
|
* @property {boolean} forgottenPassword - Returns true if the user has initiated the password recovery screen, is recovering from seed phrase.
|
|
|
|
*/
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @typedef VersionedData
|
|
|
|
* @property {MetaMaskState} data - The data emitted from MetaMask controller, or used to initialize it.
|
|
|
|
* @property {number} version - The latest migration version that has been run.
|
|
|
|
*/
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Initializes the MetaMask controller, and sets up all platform configuration.
|
|
|
|
*
|
|
|
|
* @param {string} remotePort - remote application port connecting to extension.
|
|
|
|
* @returns {Promise} Setup complete.
|
|
|
|
*/
|
|
|
|
async function initialize(remotePort) {
|
|
|
|
const initState = await loadStateFromPersistence();
|
|
|
|
const initLangCode = await getFirstPreferredLangCode();
|
|
|
|
await setupController(initState, initLangCode, remotePort);
|
|
|
|
await loadPhishingWarningPage();
|
|
|
|
log.info('MetaMask initialization complete.');
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* An error thrown if the phishing warning page takes too long to load.
|
|
|
|
*/
|
|
|
|
class PhishingWarningPageTimeoutError extends Error {
|
|
|
|
constructor() {
|
|
|
|
super('Timeout failed');
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Load the phishing warning page temporarily to ensure the service
|
|
|
|
* worker has been registered, so that the warning page works offline.
|
|
|
|
*/
|
|
|
|
async function loadPhishingWarningPage() {
|
|
|
|
let iframe;
|
|
|
|
try {
|
|
|
|
const extensionStartupPhishingPageUrl = new URL(
|
|
|
|
process.env.PHISHING_WARNING_PAGE_URL,
|
|
|
|
);
|
|
|
|
// The `extensionStartup` hash signals to the phishing warning page that it should not bother
|
|
|
|
// setting up streams for user interaction. Otherwise this page load would cause a console
|
|
|
|
// error.
|
|
|
|
extensionStartupPhishingPageUrl.hash = '#extensionStartup';
|
|
|
|
|
|
|
|
iframe = window.document.createElement('iframe');
|
|
|
|
iframe.setAttribute('src', extensionStartupPhishingPageUrl.href);
|
|
|
|
iframe.setAttribute('sandbox', 'allow-scripts allow-same-origin');
|
|
|
|
|
|
|
|
// Create "deferred Promise" to allow passing resolve/reject to event handlers
|
|
|
|
let deferredResolve;
|
|
|
|
let deferredReject;
|
|
|
|
const loadComplete = new Promise((resolve, reject) => {
|
|
|
|
deferredResolve = resolve;
|
|
|
|
deferredReject = reject;
|
|
|
|
});
|
|
|
|
|
|
|
|
// The load event is emitted once loading has completed, even if the loading failed.
|
|
|
|
// If loading failed we can't do anything about it, so we don't need to check.
|
|
|
|
iframe.addEventListener('load', deferredResolve);
|
|
|
|
|
|
|
|
// This step initiates the page loading.
|
|
|
|
window.document.body.appendChild(iframe);
|
|
|
|
|
|
|
|
// This timeout ensures that this iframe gets cleaned up in a reasonable
|
|
|
|
// timeframe, and ensures that the "initialization complete" message
|
|
|
|
// doesn't get delayed too long.
|
|
|
|
setTimeout(
|
|
|
|
() => deferredReject(new PhishingWarningPageTimeoutError()),
|
|
|
|
PHISHING_WARNING_PAGE_TIMEOUT,
|
|
|
|
);
|
|
|
|
await loadComplete;
|
|
|
|
} catch (error) {
|
|
|
|
if (error instanceof PhishingWarningPageTimeoutError) {
|
|
|
|
console.warn(
|
|
|
|
'Phishing warning page timeout; page not guaraneteed to work offline.',
|
|
|
|
);
|
|
|
|
} else {
|
|
|
|
console.error('Failed to initialize phishing warning page', error);
|
|
|
|
}
|
|
|
|
} finally {
|
|
|
|
if (iframe) {
|
|
|
|
iframe.remove();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
//
|
|
|
|
// State and Persistence
|
|
|
|
//
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Loads any stored data, prioritizing the latest storage strategy.
|
|
|
|
* Migrates that data schema in case it was last loaded on an older version.
|
|
|
|
*
|
|
|
|
* @returns {Promise<MetaMaskState>} Last data emitted from previous instance of MetaMask.
|
|
|
|
*/
|
|
|
|
async function loadStateFromPersistence() {
|
|
|
|
// migrations
|
|
|
|
const migrator = new Migrator({ migrations });
|
|
|
|
migrator.on('error', console.warn);
|
|
|
|
|
|
|
|
// read from disk
|
|
|
|
// first from preferred, async API:
|
|
|
|
versionedData =
|
|
|
|
(await localStore.get()) || migrator.generateInitialState(firstTimeState);
|
|
|
|
|
|
|
|
// check if somehow state is empty
|
|
|
|
// this should never happen but new error reporting suggests that it has
|
|
|
|
// for a small number of users
|
|
|
|
// https://github.com/metamask/metamask-extension/issues/3919
|
|
|
|
if (versionedData && !versionedData.data) {
|
|
|
|
// unable to recover, clear state
|
|
|
|
versionedData = migrator.generateInitialState(firstTimeState);
|
|
|
|
sentry.captureMessage('MetaMask - Empty vault found - unable to recover');
|
|
|
|
}
|
|
|
|
|
|
|
|
// report migration errors to sentry
|
|
|
|
migrator.on('error', (err) => {
|
|
|
|
// get vault structure without secrets
|
|
|
|
const vaultStructure = getObjStructure(versionedData);
|
|
|
|
sentry.captureException(err, {
|
|
|
|
// "extra" key is required by Sentry
|
|
|
|
extra: { vaultStructure },
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
// migrate data
|
|
|
|
versionedData = await migrator.migrateData(versionedData);
|
|
|
|
if (!versionedData) {
|
|
|
|
throw new Error('MetaMask - migrator returned undefined');
|
|
|
|
}
|
|
|
|
|
|
|
|
// write to disk
|
|
|
|
if (localStore.isSupported) {
|
|
|
|
localStore.set(versionedData);
|
|
|
|
} else {
|
|
|
|
// throw in setTimeout so as to not block boot
|
|
|
|
setTimeout(() => {
|
|
|
|
throw new Error('MetaMask - Localstore not supported');
|
|
|
|
});
|
|
|
|
}
|
|
|
|
|
|
|
|
// return just the data
|
|
|
|
return versionedData.data;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Initializes the MetaMask Controller with any initial state and default language.
|
|
|
|
* Configures platform-specific error reporting strategy.
|
|
|
|
* Streams emitted state updates to platform-specific storage strategy.
|
|
|
|
* Creates platform listeners for new Dapps/Contexts, and sets up their data connections to the controller.
|
|
|
|
*
|
|
|
|
* @param {Object} initState - The initial state to start the controller with, matches the state that is emitted from the controller.
|
|
|
|
* @param {string} initLangCode - The region code for the language preferred by the current user.
|
|
|
|
* @param {string} remoteSourcePort - remote application port connecting to extension.
|
|
|
|
* @returns {Promise} After setup is complete.
|
|
|
|
*/
|
|
|
|
function setupController(initState, initLangCode, remoteSourcePort) {
|
|
|
|
//
|
|
|
|
// MetaMask Controller
|
|
|
|
//
|
|
|
|
|
|
|
|
const controller = new MetamaskController({
|
|
|
|
infuraProjectId: process.env.INFURA_PROJECT_ID,
|
|
|
|
// User confirmation callbacks:
|
|
|
|
showUserConfirmation: triggerUi,
|
|
|
|
openPopup,
|
|
|
|
// initial state
|
|
|
|
initState,
|
|
|
|
// initial locale code
|
|
|
|
initLangCode,
|
|
|
|
// platform specific api
|
|
|
|
platform,
|
|
|
|
notificationManager,
|
|
|
|
browser,
|
Connect distinct accounts per site (#7004)
* add PermissionsController
remove provider approval controller
integrate rpc-cap
create PermissionsController
move provider approval functionality to permissions controller
add permissions approval ui, settings page
add permissions activity and history
move some functionality to metamask-inpage-provider
rename siteMetadata -> domainMetadata
add accountsChange notification to inpage provider
move functionality to inpage provider
update inpage provider
Remove 'Connections' settings page (#7369)
add hooks for exposing accounts in settings
rename unused messages in non-English locales
Add external extension id to metadata (#7396)
update inpage provider, rpc-cap
add eth_requestAccounts handling to background
prevent notifying connections if extension is locked
update inpage provider
Fix lint errors
add migration
review fixes
transaction controller review updates
removed unused messages
* Login Per Site UI (#7368)
* LoginPerSite original UI changes to keep
* First commit
* Get necessary connected tab info for redirect and icon display for permissioned sites
* Fix up designs and add missing features
* Some lint fixes
* More lint fixes
* Ensures the tx controller + tx-state-manager orders transactions in the order they are received
* Code cleanup for LoginPerSite-ui
* Update e2e tests to use new connection flow
* Fix display of connect screen and app header after login when connect request present
* Update metamask-responsive-ui.spec for new item in accounts dropdown
* Fix approve container by replacing approvedOrigins with domainMetaData
* Adds test/e2e/permissions.spec.js
* Correctly handle cancellation of a permissions request
* Redirect to home after disconnecting all sites / cancelling all permissions
* Fix display of site icons in menu
* Fix height of permissions page container
* Remove unused locale messages
* Set default values for openExternalTabs and tabIdOrigins in account-menu.container
* More code cleanup for LoginPerSite-ui
* Use extensions api to close tab in permissions-connect
* Remove unnecessary change in domIsReady() in contentscript
* Remove unnecessary private function markers and class methods (for background tab info) in metamask-controller.
* Adds getOriginOfCurrentTab selector
* Adds IconWithFallback component and substitutes for appropriate cases
* Add and utilize font mixins
* Remove unused method in disconnect-all.container.js
* Simplify buttonSizeLarge code in page-container-footer.component.js
* Add and utilize getAccountsWithLabels selector
* Remove console.log in ui/app/store/actions.js
* Change last connected time format to yyyy-M-d
* Fix css associated with IconWithFallback change
* Ensure tracked openNonMetamaskTabsIDs are correctly set to inactive on tab changes
* Code cleanup for LoginPerSite-ui
* Use reusable function for modifying openNonMetamaskTabsIDs in background.js
* Enables automatic switching to connected account when connected domain is open
* Prevent exploit of tabIdOriginMap in background.js
* Remove unneeded code from contentscript.js
* Simplify current tab origin and window opener logic using remotePort listener tabs.queryTabs
* Design and styling fixes for LoginPerSite-ui
* Fix permissionHistory and permission logging for eth_requestAccounts and eth_accounts
* Front end changes to support display of lastConnected time in connected and permissions screens
* Fix lint errors
* Refactor structure of permissionsHistory
* Fix default values and object modifications for domain and permissionsHistory related data
* Fix connecting to new accounts from modal
* Replace retweet.svg with connect-white.svg
* Fix signature-request.spec
* Update metamask-inpage-provider version
* Fix permissions e2e tests
* Remove unneeded delay from test/e2e/signature-request.spec.js
* Add delay before attempting to retrieve network id in dapp in ethereum-on=.spec
* Use requestAccountTabIds strategy for determining tab id that opened a given window
* Improve default values for permissions requests
* Add some message descriptions to app/_locales/en/messages.json
* Code clean up in permission controller
* Stopped deep cloning object in mapObjectValues
* Bump metamask-inpage-provider version
* Add missing description in app/_locales/en/messages.json
* Return promises from queryTabs and switchToTab of extension.js
* Remove unused getAllPermissions function
* Use default props in icon-with-fallback.component.js
* Stop passing to permissions controller
* Delete no longer used clear-approved-origins modal code
* Remove duplicate imports in ui/app/components/app/index.scss
* Use URL instead of regex in getOriginFromUrl()
* Add runtime error checking to platform, promise based extension.tab methods
* Support permission requests from external extensions
* Improve font size and colour of the domain origin on the permission confirmation screen
* Add support for toggling permissions
* Ensure getRenderablePermissionsDomains only returns domains with exposedAccount caveat permissions
* Remove unused code from LoginPerSite-ui branch
* Ensure modal closes on Enter press for new-account-modal.component.js
* Lint fix
* fixup! Login Per Site UI (#7368)
* Some code cleanup for LoginPerSite
* Adds UX for connecting to dapps via the connected sites screen (#7593)
* Adds UX for connecting to dapps via the connected sites screen
* Use openMetaMaskTabIds from background.js to determine if current active tab is MetaMask
* Delete unused permissions controller methods
* Fixes two small bugs in the LoginPerSite ui (#7595)
* Restore `providerRequest` message translations (#7600)
This message was removed, but it was replaced with a very similar
message called `likeToConnect`. The only difference is that the new
message has "MetaMask" in it. Preserving these messages without
"MetaMask" is probably better than deleting them, so these messages
have all been restored and renamed to `likeToConnect`.
* Login per site no sitemetadata fix (#7610)
* Support connected sites for which we have no site metadata.
* Change property containing subtitle info often populated by origin to a more accurate of purpose name
* Lint fix
* Improve disconnection modal messages (#7612)
* Improve disconnectAccountModalDescription and disconnectAllModalDescription messages
* Update disconnectAccountModalDescription app/_locales/en/messages.json
Co-Authored-By: Mark Stacey <markjstacey@gmail.com>
* Improve disconnectAccount modal message clarity
* Adds cancel button to the account selection screen of the permissions request flow (#7613)
* Fix eth_accounts permission language & selectability (#7614)
* fix eth_accounts language & selectability
* fix MetaMask capitalization in all messages
* Close sidebar when opening connected sites (#7611)
The 'Connected Sites' button in the accounts details now closes the
sidebar, if it is open. This was accomplished by pulling the click
handler for that button up to the wallet view component, where another
button already followed a similar pattern of closing the sidebar.
It seemed confusing to me that one handler was in the `AccountsDetails`
container component, and one was handed down from above, so I added
PropTypes to the container component.
I'm not sure that the WalletView component is the best place for this
logic, but I've put it there for now to be consistent with the add
token button.
* Reject permissions request upon tab close (#7618)
Permissions requests are now rejected when the page is closed. This
only applies to the full-screen view, as that is the view permission
requests should be handled in. The case where the user deals with the
request through a different view is handled in #7617
* Handle tab update failure (#7619)
`extension.tabs.update` can sometimes fail if the user interacts with
the tabs directly around the same time. The redirect flow has been
updated to ensure that the permissions tab is still closed in that
case. The user is on their own to find the dapp tab again in that case.
* Login per site tab popup fixes (#7617)
* Handle redirect in response to state update in permissions-connect
* Ensure origin is available to permissions-connect subcomponents during redirect
* Hide app bar whenever on redirect route
* Improvements to handling of redirects in permissions-connect
* Ensure permission request id change handling only happens when page is not null
* Lint fix
* Decouple confirm transaction screen from the selected address (#7622)
* Avoid race condtion that could prevent contextual account switching (#7623)
There was a race condition in the logic responsible for switching the
selected account based upon the active tab. It was asynchronously
querying the active tab, then assuming it had been retrieved later.
The active tab info itself was already in the redux store in another
spot, one that is guaranteed to be set before the UI renders. The
race condition was avoided by deleting the duplicate state, and using
the other active tab state.
* Only redirect back to dapp if current tab is active (#7621)
The "redirect back to dapp" behaviour can be disruptive when the
permissions connect tab is not active. The purpose of the redirect was
to maintain context between the dapp and the permissions request, but
if the user has already moved to another tab, that no longer applies.
* Fix JSX style lint errors
* Remove unused state
5 years ago
|
|
|
getRequestAccountTabIds: () => {
|
|
|
|
return requestAccountTabIds;
|
Connect distinct accounts per site (#7004)
* add PermissionsController
remove provider approval controller
integrate rpc-cap
create PermissionsController
move provider approval functionality to permissions controller
add permissions approval ui, settings page
add permissions activity and history
move some functionality to metamask-inpage-provider
rename siteMetadata -> domainMetadata
add accountsChange notification to inpage provider
move functionality to inpage provider
update inpage provider
Remove 'Connections' settings page (#7369)
add hooks for exposing accounts in settings
rename unused messages in non-English locales
Add external extension id to metadata (#7396)
update inpage provider, rpc-cap
add eth_requestAccounts handling to background
prevent notifying connections if extension is locked
update inpage provider
Fix lint errors
add migration
review fixes
transaction controller review updates
removed unused messages
* Login Per Site UI (#7368)
* LoginPerSite original UI changes to keep
* First commit
* Get necessary connected tab info for redirect and icon display for permissioned sites
* Fix up designs and add missing features
* Some lint fixes
* More lint fixes
* Ensures the tx controller + tx-state-manager orders transactions in the order they are received
* Code cleanup for LoginPerSite-ui
* Update e2e tests to use new connection flow
* Fix display of connect screen and app header after login when connect request present
* Update metamask-responsive-ui.spec for new item in accounts dropdown
* Fix approve container by replacing approvedOrigins with domainMetaData
* Adds test/e2e/permissions.spec.js
* Correctly handle cancellation of a permissions request
* Redirect to home after disconnecting all sites / cancelling all permissions
* Fix display of site icons in menu
* Fix height of permissions page container
* Remove unused locale messages
* Set default values for openExternalTabs and tabIdOrigins in account-menu.container
* More code cleanup for LoginPerSite-ui
* Use extensions api to close tab in permissions-connect
* Remove unnecessary change in domIsReady() in contentscript
* Remove unnecessary private function markers and class methods (for background tab info) in metamask-controller.
* Adds getOriginOfCurrentTab selector
* Adds IconWithFallback component and substitutes for appropriate cases
* Add and utilize font mixins
* Remove unused method in disconnect-all.container.js
* Simplify buttonSizeLarge code in page-container-footer.component.js
* Add and utilize getAccountsWithLabels selector
* Remove console.log in ui/app/store/actions.js
* Change last connected time format to yyyy-M-d
* Fix css associated with IconWithFallback change
* Ensure tracked openNonMetamaskTabsIDs are correctly set to inactive on tab changes
* Code cleanup for LoginPerSite-ui
* Use reusable function for modifying openNonMetamaskTabsIDs in background.js
* Enables automatic switching to connected account when connected domain is open
* Prevent exploit of tabIdOriginMap in background.js
* Remove unneeded code from contentscript.js
* Simplify current tab origin and window opener logic using remotePort listener tabs.queryTabs
* Design and styling fixes for LoginPerSite-ui
* Fix permissionHistory and permission logging for eth_requestAccounts and eth_accounts
* Front end changes to support display of lastConnected time in connected and permissions screens
* Fix lint errors
* Refactor structure of permissionsHistory
* Fix default values and object modifications for domain and permissionsHistory related data
* Fix connecting to new accounts from modal
* Replace retweet.svg with connect-white.svg
* Fix signature-request.spec
* Update metamask-inpage-provider version
* Fix permissions e2e tests
* Remove unneeded delay from test/e2e/signature-request.spec.js
* Add delay before attempting to retrieve network id in dapp in ethereum-on=.spec
* Use requestAccountTabIds strategy for determining tab id that opened a given window
* Improve default values for permissions requests
* Add some message descriptions to app/_locales/en/messages.json
* Code clean up in permission controller
* Stopped deep cloning object in mapObjectValues
* Bump metamask-inpage-provider version
* Add missing description in app/_locales/en/messages.json
* Return promises from queryTabs and switchToTab of extension.js
* Remove unused getAllPermissions function
* Use default props in icon-with-fallback.component.js
* Stop passing to permissions controller
* Delete no longer used clear-approved-origins modal code
* Remove duplicate imports in ui/app/components/app/index.scss
* Use URL instead of regex in getOriginFromUrl()
* Add runtime error checking to platform, promise based extension.tab methods
* Support permission requests from external extensions
* Improve font size and colour of the domain origin on the permission confirmation screen
* Add support for toggling permissions
* Ensure getRenderablePermissionsDomains only returns domains with exposedAccount caveat permissions
* Remove unused code from LoginPerSite-ui branch
* Ensure modal closes on Enter press for new-account-modal.component.js
* Lint fix
* fixup! Login Per Site UI (#7368)
* Some code cleanup for LoginPerSite
* Adds UX for connecting to dapps via the connected sites screen (#7593)
* Adds UX for connecting to dapps via the connected sites screen
* Use openMetaMaskTabIds from background.js to determine if current active tab is MetaMask
* Delete unused permissions controller methods
* Fixes two small bugs in the LoginPerSite ui (#7595)
* Restore `providerRequest` message translations (#7600)
This message was removed, but it was replaced with a very similar
message called `likeToConnect`. The only difference is that the new
message has "MetaMask" in it. Preserving these messages without
"MetaMask" is probably better than deleting them, so these messages
have all been restored and renamed to `likeToConnect`.
* Login per site no sitemetadata fix (#7610)
* Support connected sites for which we have no site metadata.
* Change property containing subtitle info often populated by origin to a more accurate of purpose name
* Lint fix
* Improve disconnection modal messages (#7612)
* Improve disconnectAccountModalDescription and disconnectAllModalDescription messages
* Update disconnectAccountModalDescription app/_locales/en/messages.json
Co-Authored-By: Mark Stacey <markjstacey@gmail.com>
* Improve disconnectAccount modal message clarity
* Adds cancel button to the account selection screen of the permissions request flow (#7613)
* Fix eth_accounts permission language & selectability (#7614)
* fix eth_accounts language & selectability
* fix MetaMask capitalization in all messages
* Close sidebar when opening connected sites (#7611)
The 'Connected Sites' button in the accounts details now closes the
sidebar, if it is open. This was accomplished by pulling the click
handler for that button up to the wallet view component, where another
button already followed a similar pattern of closing the sidebar.
It seemed confusing to me that one handler was in the `AccountsDetails`
container component, and one was handed down from above, so I added
PropTypes to the container component.
I'm not sure that the WalletView component is the best place for this
logic, but I've put it there for now to be consistent with the add
token button.
* Reject permissions request upon tab close (#7618)
Permissions requests are now rejected when the page is closed. This
only applies to the full-screen view, as that is the view permission
requests should be handled in. The case where the user deals with the
request through a different view is handled in #7617
* Handle tab update failure (#7619)
`extension.tabs.update` can sometimes fail if the user interacts with
the tabs directly around the same time. The redirect flow has been
updated to ensure that the permissions tab is still closed in that
case. The user is on their own to find the dapp tab again in that case.
* Login per site tab popup fixes (#7617)
* Handle redirect in response to state update in permissions-connect
* Ensure origin is available to permissions-connect subcomponents during redirect
* Hide app bar whenever on redirect route
* Improvements to handling of redirects in permissions-connect
* Ensure permission request id change handling only happens when page is not null
* Lint fix
* Decouple confirm transaction screen from the selected address (#7622)
* Avoid race condtion that could prevent contextual account switching (#7623)
There was a race condition in the logic responsible for switching the
selected account based upon the active tab. It was asynchronously
querying the active tab, then assuming it had been retrieved later.
The active tab info itself was already in the redux store in another
spot, one that is guaranteed to be set before the UI renders. The
race condition was avoided by deleting the duplicate state, and using
the other active tab state.
* Only redirect back to dapp if current tab is active (#7621)
The "redirect back to dapp" behaviour can be disruptive when the
permissions connect tab is not active. The purpose of the redirect was
to maintain context between the dapp and the permissions request, but
if the user has already moved to another tab, that no longer applies.
* Fix JSX style lint errors
* Remove unused state
5 years ago
|
|
|
},
|
|
|
|
getOpenMetamaskTabsIds: () => {
|
|
|
|
return openMetamaskTabsIDs;
|
Connect distinct accounts per site (#7004)
* add PermissionsController
remove provider approval controller
integrate rpc-cap
create PermissionsController
move provider approval functionality to permissions controller
add permissions approval ui, settings page
add permissions activity and history
move some functionality to metamask-inpage-provider
rename siteMetadata -> domainMetadata
add accountsChange notification to inpage provider
move functionality to inpage provider
update inpage provider
Remove 'Connections' settings page (#7369)
add hooks for exposing accounts in settings
rename unused messages in non-English locales
Add external extension id to metadata (#7396)
update inpage provider, rpc-cap
add eth_requestAccounts handling to background
prevent notifying connections if extension is locked
update inpage provider
Fix lint errors
add migration
review fixes
transaction controller review updates
removed unused messages
* Login Per Site UI (#7368)
* LoginPerSite original UI changes to keep
* First commit
* Get necessary connected tab info for redirect and icon display for permissioned sites
* Fix up designs and add missing features
* Some lint fixes
* More lint fixes
* Ensures the tx controller + tx-state-manager orders transactions in the order they are received
* Code cleanup for LoginPerSite-ui
* Update e2e tests to use new connection flow
* Fix display of connect screen and app header after login when connect request present
* Update metamask-responsive-ui.spec for new item in accounts dropdown
* Fix approve container by replacing approvedOrigins with domainMetaData
* Adds test/e2e/permissions.spec.js
* Correctly handle cancellation of a permissions request
* Redirect to home after disconnecting all sites / cancelling all permissions
* Fix display of site icons in menu
* Fix height of permissions page container
* Remove unused locale messages
* Set default values for openExternalTabs and tabIdOrigins in account-menu.container
* More code cleanup for LoginPerSite-ui
* Use extensions api to close tab in permissions-connect
* Remove unnecessary change in domIsReady() in contentscript
* Remove unnecessary private function markers and class methods (for background tab info) in metamask-controller.
* Adds getOriginOfCurrentTab selector
* Adds IconWithFallback component and substitutes for appropriate cases
* Add and utilize font mixins
* Remove unused method in disconnect-all.container.js
* Simplify buttonSizeLarge code in page-container-footer.component.js
* Add and utilize getAccountsWithLabels selector
* Remove console.log in ui/app/store/actions.js
* Change last connected time format to yyyy-M-d
* Fix css associated with IconWithFallback change
* Ensure tracked openNonMetamaskTabsIDs are correctly set to inactive on tab changes
* Code cleanup for LoginPerSite-ui
* Use reusable function for modifying openNonMetamaskTabsIDs in background.js
* Enables automatic switching to connected account when connected domain is open
* Prevent exploit of tabIdOriginMap in background.js
* Remove unneeded code from contentscript.js
* Simplify current tab origin and window opener logic using remotePort listener tabs.queryTabs
* Design and styling fixes for LoginPerSite-ui
* Fix permissionHistory and permission logging for eth_requestAccounts and eth_accounts
* Front end changes to support display of lastConnected time in connected and permissions screens
* Fix lint errors
* Refactor structure of permissionsHistory
* Fix default values and object modifications for domain and permissionsHistory related data
* Fix connecting to new accounts from modal
* Replace retweet.svg with connect-white.svg
* Fix signature-request.spec
* Update metamask-inpage-provider version
* Fix permissions e2e tests
* Remove unneeded delay from test/e2e/signature-request.spec.js
* Add delay before attempting to retrieve network id in dapp in ethereum-on=.spec
* Use requestAccountTabIds strategy for determining tab id that opened a given window
* Improve default values for permissions requests
* Add some message descriptions to app/_locales/en/messages.json
* Code clean up in permission controller
* Stopped deep cloning object in mapObjectValues
* Bump metamask-inpage-provider version
* Add missing description in app/_locales/en/messages.json
* Return promises from queryTabs and switchToTab of extension.js
* Remove unused getAllPermissions function
* Use default props in icon-with-fallback.component.js
* Stop passing to permissions controller
* Delete no longer used clear-approved-origins modal code
* Remove duplicate imports in ui/app/components/app/index.scss
* Use URL instead of regex in getOriginFromUrl()
* Add runtime error checking to platform, promise based extension.tab methods
* Support permission requests from external extensions
* Improve font size and colour of the domain origin on the permission confirmation screen
* Add support for toggling permissions
* Ensure getRenderablePermissionsDomains only returns domains with exposedAccount caveat permissions
* Remove unused code from LoginPerSite-ui branch
* Ensure modal closes on Enter press for new-account-modal.component.js
* Lint fix
* fixup! Login Per Site UI (#7368)
* Some code cleanup for LoginPerSite
* Adds UX for connecting to dapps via the connected sites screen (#7593)
* Adds UX for connecting to dapps via the connected sites screen
* Use openMetaMaskTabIds from background.js to determine if current active tab is MetaMask
* Delete unused permissions controller methods
* Fixes two small bugs in the LoginPerSite ui (#7595)
* Restore `providerRequest` message translations (#7600)
This message was removed, but it was replaced with a very similar
message called `likeToConnect`. The only difference is that the new
message has "MetaMask" in it. Preserving these messages without
"MetaMask" is probably better than deleting them, so these messages
have all been restored and renamed to `likeToConnect`.
* Login per site no sitemetadata fix (#7610)
* Support connected sites for which we have no site metadata.
* Change property containing subtitle info often populated by origin to a more accurate of purpose name
* Lint fix
* Improve disconnection modal messages (#7612)
* Improve disconnectAccountModalDescription and disconnectAllModalDescription messages
* Update disconnectAccountModalDescription app/_locales/en/messages.json
Co-Authored-By: Mark Stacey <markjstacey@gmail.com>
* Improve disconnectAccount modal message clarity
* Adds cancel button to the account selection screen of the permissions request flow (#7613)
* Fix eth_accounts permission language & selectability (#7614)
* fix eth_accounts language & selectability
* fix MetaMask capitalization in all messages
* Close sidebar when opening connected sites (#7611)
The 'Connected Sites' button in the accounts details now closes the
sidebar, if it is open. This was accomplished by pulling the click
handler for that button up to the wallet view component, where another
button already followed a similar pattern of closing the sidebar.
It seemed confusing to me that one handler was in the `AccountsDetails`
container component, and one was handed down from above, so I added
PropTypes to the container component.
I'm not sure that the WalletView component is the best place for this
logic, but I've put it there for now to be consistent with the add
token button.
* Reject permissions request upon tab close (#7618)
Permissions requests are now rejected when the page is closed. This
only applies to the full-screen view, as that is the view permission
requests should be handled in. The case where the user deals with the
request through a different view is handled in #7617
* Handle tab update failure (#7619)
`extension.tabs.update` can sometimes fail if the user interacts with
the tabs directly around the same time. The redirect flow has been
updated to ensure that the permissions tab is still closed in that
case. The user is on their own to find the dapp tab again in that case.
* Login per site tab popup fixes (#7617)
* Handle redirect in response to state update in permissions-connect
* Ensure origin is available to permissions-connect subcomponents during redirect
* Hide app bar whenever on redirect route
* Improvements to handling of redirects in permissions-connect
* Ensure permission request id change handling only happens when page is not null
* Lint fix
* Decouple confirm transaction screen from the selected address (#7622)
* Avoid race condtion that could prevent contextual account switching (#7623)
There was a race condition in the logic responsible for switching the
selected account based upon the active tab. It was asynchronously
querying the active tab, then assuming it had been retrieved later.
The active tab info itself was already in the redux store in another
spot, one that is guaranteed to be set before the UI renders. The
race condition was avoided by deleting the duplicate state, and using
the other active tab state.
* Only redirect back to dapp if current tab is active (#7621)
The "redirect back to dapp" behaviour can be disruptive when the
permissions connect tab is not active. The purpose of the redirect was
to maintain context between the dapp and the permissions request, but
if the user has already moved to another tab, that no longer applies.
* Fix JSX style lint errors
* Remove unused state
5 years ago
|
|
|
},
|
|
|
|
});
|
|
|
|
|
|
|
|
setupEnsIpfsResolver({
|
|
|
|
getCurrentChainId: controller.networkController.getCurrentChainId.bind(
|
|
|
|
controller.networkController,
|
|
|
|
),
|
|
|
|
getIpfsGateway: controller.preferencesController.getIpfsGateway.bind(
|
|
|
|
controller.preferencesController,
|
|
|
|
),
|
|
|
|
provider: controller.provider,
|
|
|
|
});
|
|
|
|
|
|
|
|
// setup state persistence
|
|
|
|
pump(
|
|
|
|
storeAsStream(controller.store),
|
|
|
|
debounce(1000),
|
|
|
|
storeTransformStream(versionifyData),
|
|
|
|
createStreamSink(persistData),
|
|
|
|
(error) => {
|
|
|
|
log.error('MetaMask - Persistence pipeline failed', error);
|
|
|
|
},
|
|
|
|
);
|
|
|
|
|
|
|
|
setupSentryGetStateGlobal(controller.store);
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Assigns the given state to the versioned object (with metadata), and returns that.
|
|
|
|
*
|
|
|
|
* @param {Object} state - The state object as emitted by the MetaMaskController.
|
|
|
|
* @returns {VersionedData} The state object wrapped in an object that includes a metadata key.
|
|
|
|
*/
|
|
|
|
function versionifyData(state) {
|
|
|
|
versionedData.data = state;
|
|
|
|
return versionedData;
|
|
|
|
}
|
|
|
|
|
|
|
|
let dataPersistenceFailing = false;
|
|
|
|
|
|
|
|
async function persistData(state) {
|
|
|
|
if (!state) {
|
|
|
|
throw new Error('MetaMask - updated state is missing');
|
|
|
|
}
|
|
|
|
if (!state.data) {
|
|
|
|
throw new Error('MetaMask - updated state does not have data');
|
|
|
|
}
|
|
|
|
if (localStore.isSupported) {
|
|
|
|
try {
|
|
|
|
await localStore.set(state);
|
|
|
|
if (dataPersistenceFailing) {
|
|
|
|
dataPersistenceFailing = false;
|
|
|
|
}
|
|
|
|
} catch (err) {
|
|
|
|
// log error so we dont break the pipeline
|
|
|
|
if (!dataPersistenceFailing) {
|
|
|
|
dataPersistenceFailing = true;
|
|
|
|
captureException(err);
|
|
|
|
}
|
|
|
|
log.error('error setting state in local store:', err);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
//
|
|
|
|
// connect to other contexts
|
|
|
|
//
|
|
|
|
if (isManifestV3() && remoteSourcePort) {
|
|
|
|
connectRemote(remoteSourcePort);
|
|
|
|
}
|
|
|
|
|
|
|
|
browser.runtime.onConnect.addListener(connectRemote);
|
|
|
|
browser.runtime.onConnectExternal.addListener(connectExternal);
|
|
|
|
|
|
|
|
const isClientOpenStatus = () => {
|
|
|
|
return (
|
|
|
|
popupIsOpen ||
|
|
|
|
Boolean(Object.keys(openMetamaskTabsIDs).length) ||
|
|
|
|
notificationIsOpen
|
|
|
|
);
|
|
|
|
};
|
|
|
|
|
|
|
|
const onCloseEnvironmentInstances = (isClientOpen, environmentType) => {
|
|
|
|
// if all instances of metamask are closed we call a method on the controller to stop gasFeeController polling
|
|
|
|
if (isClientOpen === false) {
|
|
|
|
controller.onClientClosed();
|
|
|
|
// otherwise we want to only remove the polling tokens for the environment type that has closed
|
|
|
|
} else {
|
|
|
|
// in the case of fullscreen environment a user might have multiple tabs open so we don't want to disconnect all of
|
|
|
|
// its corresponding polling tokens unless all tabs are closed.
|
|
|
|
if (
|
|
|
|
environmentType === ENVIRONMENT_TYPE_FULLSCREEN &&
|
|
|
|
Boolean(Object.keys(openMetamaskTabsIDs).length)
|
|
|
|
) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
controller.onEnvironmentTypeClosed(environmentType);
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
/**
|
|
|
|
* A runtime.Port object, as provided by the browser:
|
|
|
|
*
|
|
|
|
* @see https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/runtime/Port
|
|
|
|
* @typedef Port
|
|
|
|
* @type Object
|
|
|
|
*/
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Connects a Port to the MetaMask controller via a multiplexed duplex stream.
|
|
|
|
* This method identifies trusted (MetaMask) interfaces, and connects them differently from untrusted (web pages).
|
|
|
|
*
|
|
|
|
* @param {Port} remotePort - The port provided by a new context.
|
|
|
|
*/
|
|
|
|
function connectRemote(remotePort) {
|
|
|
|
const processName = remotePort.name;
|
|
|
|
|
|
|
|
if (metamaskBlockedPorts.includes(remotePort.name)) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
let isMetaMaskInternalProcess = false;
|
|
|
|
const sourcePlatform = getPlatform();
|
|
|
|
|
|
|
|
if (sourcePlatform === PLATFORM_FIREFOX) {
|
|
|
|
isMetaMaskInternalProcess = metamaskInternalProcessHash[processName];
|
|
|
|
} else {
|
|
|
|
isMetaMaskInternalProcess =
|
|
|
|
remotePort.sender.origin === `chrome-extension://${browser.runtime.id}`;
|
|
|
|
}
|
|
|
|
|
|
|
|
const senderUrl = remotePort.sender?.url
|
|
|
|
? new URL(remotePort.sender.url)
|
|
|
|
: null;
|
|
|
|
|
|
|
|
if (isMetaMaskInternalProcess) {
|
|
|
|
const portStream = new PortStream(remotePort);
|
|
|
|
// communication with popup
|
|
|
|
controller.isClientOpen = true;
|
|
|
|
controller.setupTrustedCommunication(portStream, remotePort.sender);
|
|
|
|
|
|
|
|
if (isManifestV3()) {
|
|
|
|
// Message below if captured by UI code in app/scripts/ui.js which will trigger UI initialisation
|
|
|
|
// This ensures that UI is initialised only after background is ready
|
|
|
|
// It fixes the issue of blank screen coming when extension is loaded, the issue is very frequent in MV3
|
|
|
|
remotePort.postMessage({ name: 'CONNECTION_READY' });
|
|
|
|
}
|
|
|
|
|
|
|
|
if (processName === ENVIRONMENT_TYPE_POPUP) {
|
|
|
|
popupIsOpen = true;
|
|
|
|
endOfStream(portStream, () => {
|
|
|
|
popupIsOpen = false;
|
|
|
|
const isClientOpen = isClientOpenStatus();
|
|
|
|
controller.isClientOpen = isClientOpen;
|
|
|
|
onCloseEnvironmentInstances(isClientOpen, ENVIRONMENT_TYPE_POPUP);
|
|
|
|
});
|
|
|
|
}
|
|
|
|
|
|
|
|
if (processName === ENVIRONMENT_TYPE_NOTIFICATION) {
|
|
|
|
notificationIsOpen = true;
|
|
|
|
|
|
|
|
endOfStream(portStream, () => {
|
|
|
|
notificationIsOpen = false;
|
|
|
|
const isClientOpen = isClientOpenStatus();
|
|
|
|
controller.isClientOpen = isClientOpen;
|
|
|
|
onCloseEnvironmentInstances(
|
|
|
|
isClientOpen,
|
|
|
|
ENVIRONMENT_TYPE_NOTIFICATION,
|
|
|
|
);
|
|
|
|
});
|
|
|
|
}
|
|
|
|
|
|
|
|
if (processName === ENVIRONMENT_TYPE_FULLSCREEN) {
|
|
|
|
const tabId = remotePort.sender.tab.id;
|
|
|
|
openMetamaskTabsIDs[tabId] = true;
|
|
|
|
|
|
|
|
endOfStream(portStream, () => {
|
|
|
|
delete openMetamaskTabsIDs[tabId];
|
|
|
|
const isClientOpen = isClientOpenStatus();
|
|
|
|
controller.isClientOpen = isClientOpen;
|
|
|
|
onCloseEnvironmentInstances(
|
|
|
|
isClientOpen,
|
|
|
|
ENVIRONMENT_TYPE_FULLSCREEN,
|
|
|
|
);
|
|
|
|
});
|
|
|
|
}
|
|
|
|
} else if (
|
|
|
|
senderUrl &&
|
|
|
|
senderUrl.origin === phishingPageUrl.origin &&
|
|
|
|
senderUrl.pathname === phishingPageUrl.pathname
|
|
|
|
) {
|
|
|
|
const portStream = new PortStream(remotePort);
|
|
|
|
controller.setupPhishingCommunication({
|
|
|
|
connectionStream: portStream,
|
|
|
|
});
|
|
|
|
} else {
|
Connect distinct accounts per site (#7004)
* add PermissionsController
remove provider approval controller
integrate rpc-cap
create PermissionsController
move provider approval functionality to permissions controller
add permissions approval ui, settings page
add permissions activity and history
move some functionality to metamask-inpage-provider
rename siteMetadata -> domainMetadata
add accountsChange notification to inpage provider
move functionality to inpage provider
update inpage provider
Remove 'Connections' settings page (#7369)
add hooks for exposing accounts in settings
rename unused messages in non-English locales
Add external extension id to metadata (#7396)
update inpage provider, rpc-cap
add eth_requestAccounts handling to background
prevent notifying connections if extension is locked
update inpage provider
Fix lint errors
add migration
review fixes
transaction controller review updates
removed unused messages
* Login Per Site UI (#7368)
* LoginPerSite original UI changes to keep
* First commit
* Get necessary connected tab info for redirect and icon display for permissioned sites
* Fix up designs and add missing features
* Some lint fixes
* More lint fixes
* Ensures the tx controller + tx-state-manager orders transactions in the order they are received
* Code cleanup for LoginPerSite-ui
* Update e2e tests to use new connection flow
* Fix display of connect screen and app header after login when connect request present
* Update metamask-responsive-ui.spec for new item in accounts dropdown
* Fix approve container by replacing approvedOrigins with domainMetaData
* Adds test/e2e/permissions.spec.js
* Correctly handle cancellation of a permissions request
* Redirect to home after disconnecting all sites / cancelling all permissions
* Fix display of site icons in menu
* Fix height of permissions page container
* Remove unused locale messages
* Set default values for openExternalTabs and tabIdOrigins in account-menu.container
* More code cleanup for LoginPerSite-ui
* Use extensions api to close tab in permissions-connect
* Remove unnecessary change in domIsReady() in contentscript
* Remove unnecessary private function markers and class methods (for background tab info) in metamask-controller.
* Adds getOriginOfCurrentTab selector
* Adds IconWithFallback component and substitutes for appropriate cases
* Add and utilize font mixins
* Remove unused method in disconnect-all.container.js
* Simplify buttonSizeLarge code in page-container-footer.component.js
* Add and utilize getAccountsWithLabels selector
* Remove console.log in ui/app/store/actions.js
* Change last connected time format to yyyy-M-d
* Fix css associated with IconWithFallback change
* Ensure tracked openNonMetamaskTabsIDs are correctly set to inactive on tab changes
* Code cleanup for LoginPerSite-ui
* Use reusable function for modifying openNonMetamaskTabsIDs in background.js
* Enables automatic switching to connected account when connected domain is open
* Prevent exploit of tabIdOriginMap in background.js
* Remove unneeded code from contentscript.js
* Simplify current tab origin and window opener logic using remotePort listener tabs.queryTabs
* Design and styling fixes for LoginPerSite-ui
* Fix permissionHistory and permission logging for eth_requestAccounts and eth_accounts
* Front end changes to support display of lastConnected time in connected and permissions screens
* Fix lint errors
* Refactor structure of permissionsHistory
* Fix default values and object modifications for domain and permissionsHistory related data
* Fix connecting to new accounts from modal
* Replace retweet.svg with connect-white.svg
* Fix signature-request.spec
* Update metamask-inpage-provider version
* Fix permissions e2e tests
* Remove unneeded delay from test/e2e/signature-request.spec.js
* Add delay before attempting to retrieve network id in dapp in ethereum-on=.spec
* Use requestAccountTabIds strategy for determining tab id that opened a given window
* Improve default values for permissions requests
* Add some message descriptions to app/_locales/en/messages.json
* Code clean up in permission controller
* Stopped deep cloning object in mapObjectValues
* Bump metamask-inpage-provider version
* Add missing description in app/_locales/en/messages.json
* Return promises from queryTabs and switchToTab of extension.js
* Remove unused getAllPermissions function
* Use default props in icon-with-fallback.component.js
* Stop passing to permissions controller
* Delete no longer used clear-approved-origins modal code
* Remove duplicate imports in ui/app/components/app/index.scss
* Use URL instead of regex in getOriginFromUrl()
* Add runtime error checking to platform, promise based extension.tab methods
* Support permission requests from external extensions
* Improve font size and colour of the domain origin on the permission confirmation screen
* Add support for toggling permissions
* Ensure getRenderablePermissionsDomains only returns domains with exposedAccount caveat permissions
* Remove unused code from LoginPerSite-ui branch
* Ensure modal closes on Enter press for new-account-modal.component.js
* Lint fix
* fixup! Login Per Site UI (#7368)
* Some code cleanup for LoginPerSite
* Adds UX for connecting to dapps via the connected sites screen (#7593)
* Adds UX for connecting to dapps via the connected sites screen
* Use openMetaMaskTabIds from background.js to determine if current active tab is MetaMask
* Delete unused permissions controller methods
* Fixes two small bugs in the LoginPerSite ui (#7595)
* Restore `providerRequest` message translations (#7600)
This message was removed, but it was replaced with a very similar
message called `likeToConnect`. The only difference is that the new
message has "MetaMask" in it. Preserving these messages without
"MetaMask" is probably better than deleting them, so these messages
have all been restored and renamed to `likeToConnect`.
* Login per site no sitemetadata fix (#7610)
* Support connected sites for which we have no site metadata.
* Change property containing subtitle info often populated by origin to a more accurate of purpose name
* Lint fix
* Improve disconnection modal messages (#7612)
* Improve disconnectAccountModalDescription and disconnectAllModalDescription messages
* Update disconnectAccountModalDescription app/_locales/en/messages.json
Co-Authored-By: Mark Stacey <markjstacey@gmail.com>
* Improve disconnectAccount modal message clarity
* Adds cancel button to the account selection screen of the permissions request flow (#7613)
* Fix eth_accounts permission language & selectability (#7614)
* fix eth_accounts language & selectability
* fix MetaMask capitalization in all messages
* Close sidebar when opening connected sites (#7611)
The 'Connected Sites' button in the accounts details now closes the
sidebar, if it is open. This was accomplished by pulling the click
handler for that button up to the wallet view component, where another
button already followed a similar pattern of closing the sidebar.
It seemed confusing to me that one handler was in the `AccountsDetails`
container component, and one was handed down from above, so I added
PropTypes to the container component.
I'm not sure that the WalletView component is the best place for this
logic, but I've put it there for now to be consistent with the add
token button.
* Reject permissions request upon tab close (#7618)
Permissions requests are now rejected when the page is closed. This
only applies to the full-screen view, as that is the view permission
requests should be handled in. The case where the user deals with the
request through a different view is handled in #7617
* Handle tab update failure (#7619)
`extension.tabs.update` can sometimes fail if the user interacts with
the tabs directly around the same time. The redirect flow has been
updated to ensure that the permissions tab is still closed in that
case. The user is on their own to find the dapp tab again in that case.
* Login per site tab popup fixes (#7617)
* Handle redirect in response to state update in permissions-connect
* Ensure origin is available to permissions-connect subcomponents during redirect
* Hide app bar whenever on redirect route
* Improvements to handling of redirects in permissions-connect
* Ensure permission request id change handling only happens when page is not null
* Lint fix
* Decouple confirm transaction screen from the selected address (#7622)
* Avoid race condtion that could prevent contextual account switching (#7623)
There was a race condition in the logic responsible for switching the
selected account based upon the active tab. It was asynchronously
querying the active tab, then assuming it had been retrieved later.
The active tab info itself was already in the redux store in another
spot, one that is guaranteed to be set before the UI renders. The
race condition was avoided by deleting the duplicate state, and using
the other active tab state.
* Only redirect back to dapp if current tab is active (#7621)
The "redirect back to dapp" behaviour can be disruptive when the
permissions connect tab is not active. The purpose of the redirect was
to maintain context between the dapp and the permissions request, but
if the user has already moved to another tab, that no longer applies.
* Fix JSX style lint errors
* Remove unused state
5 years ago
|
|
|
if (remotePort.sender && remotePort.sender.tab && remotePort.sender.url) {
|
|
|
|
const tabId = remotePort.sender.tab.id;
|
|
|
|
const url = new URL(remotePort.sender.url);
|
|
|
|
const { origin } = url;
|
Connect distinct accounts per site (#7004)
* add PermissionsController
remove provider approval controller
integrate rpc-cap
create PermissionsController
move provider approval functionality to permissions controller
add permissions approval ui, settings page
add permissions activity and history
move some functionality to metamask-inpage-provider
rename siteMetadata -> domainMetadata
add accountsChange notification to inpage provider
move functionality to inpage provider
update inpage provider
Remove 'Connections' settings page (#7369)
add hooks for exposing accounts in settings
rename unused messages in non-English locales
Add external extension id to metadata (#7396)
update inpage provider, rpc-cap
add eth_requestAccounts handling to background
prevent notifying connections if extension is locked
update inpage provider
Fix lint errors
add migration
review fixes
transaction controller review updates
removed unused messages
* Login Per Site UI (#7368)
* LoginPerSite original UI changes to keep
* First commit
* Get necessary connected tab info for redirect and icon display for permissioned sites
* Fix up designs and add missing features
* Some lint fixes
* More lint fixes
* Ensures the tx controller + tx-state-manager orders transactions in the order they are received
* Code cleanup for LoginPerSite-ui
* Update e2e tests to use new connection flow
* Fix display of connect screen and app header after login when connect request present
* Update metamask-responsive-ui.spec for new item in accounts dropdown
* Fix approve container by replacing approvedOrigins with domainMetaData
* Adds test/e2e/permissions.spec.js
* Correctly handle cancellation of a permissions request
* Redirect to home after disconnecting all sites / cancelling all permissions
* Fix display of site icons in menu
* Fix height of permissions page container
* Remove unused locale messages
* Set default values for openExternalTabs and tabIdOrigins in account-menu.container
* More code cleanup for LoginPerSite-ui
* Use extensions api to close tab in permissions-connect
* Remove unnecessary change in domIsReady() in contentscript
* Remove unnecessary private function markers and class methods (for background tab info) in metamask-controller.
* Adds getOriginOfCurrentTab selector
* Adds IconWithFallback component and substitutes for appropriate cases
* Add and utilize font mixins
* Remove unused method in disconnect-all.container.js
* Simplify buttonSizeLarge code in page-container-footer.component.js
* Add and utilize getAccountsWithLabels selector
* Remove console.log in ui/app/store/actions.js
* Change last connected time format to yyyy-M-d
* Fix css associated with IconWithFallback change
* Ensure tracked openNonMetamaskTabsIDs are correctly set to inactive on tab changes
* Code cleanup for LoginPerSite-ui
* Use reusable function for modifying openNonMetamaskTabsIDs in background.js
* Enables automatic switching to connected account when connected domain is open
* Prevent exploit of tabIdOriginMap in background.js
* Remove unneeded code from contentscript.js
* Simplify current tab origin and window opener logic using remotePort listener tabs.queryTabs
* Design and styling fixes for LoginPerSite-ui
* Fix permissionHistory and permission logging for eth_requestAccounts and eth_accounts
* Front end changes to support display of lastConnected time in connected and permissions screens
* Fix lint errors
* Refactor structure of permissionsHistory
* Fix default values and object modifications for domain and permissionsHistory related data
* Fix connecting to new accounts from modal
* Replace retweet.svg with connect-white.svg
* Fix signature-request.spec
* Update metamask-inpage-provider version
* Fix permissions e2e tests
* Remove unneeded delay from test/e2e/signature-request.spec.js
* Add delay before attempting to retrieve network id in dapp in ethereum-on=.spec
* Use requestAccountTabIds strategy for determining tab id that opened a given window
* Improve default values for permissions requests
* Add some message descriptions to app/_locales/en/messages.json
* Code clean up in permission controller
* Stopped deep cloning object in mapObjectValues
* Bump metamask-inpage-provider version
* Add missing description in app/_locales/en/messages.json
* Return promises from queryTabs and switchToTab of extension.js
* Remove unused getAllPermissions function
* Use default props in icon-with-fallback.component.js
* Stop passing to permissions controller
* Delete no longer used clear-approved-origins modal code
* Remove duplicate imports in ui/app/components/app/index.scss
* Use URL instead of regex in getOriginFromUrl()
* Add runtime error checking to platform, promise based extension.tab methods
* Support permission requests from external extensions
* Improve font size and colour of the domain origin on the permission confirmation screen
* Add support for toggling permissions
* Ensure getRenderablePermissionsDomains only returns domains with exposedAccount caveat permissions
* Remove unused code from LoginPerSite-ui branch
* Ensure modal closes on Enter press for new-account-modal.component.js
* Lint fix
* fixup! Login Per Site UI (#7368)
* Some code cleanup for LoginPerSite
* Adds UX for connecting to dapps via the connected sites screen (#7593)
* Adds UX for connecting to dapps via the connected sites screen
* Use openMetaMaskTabIds from background.js to determine if current active tab is MetaMask
* Delete unused permissions controller methods
* Fixes two small bugs in the LoginPerSite ui (#7595)
* Restore `providerRequest` message translations (#7600)
This message was removed, but it was replaced with a very similar
message called `likeToConnect`. The only difference is that the new
message has "MetaMask" in it. Preserving these messages without
"MetaMask" is probably better than deleting them, so these messages
have all been restored and renamed to `likeToConnect`.
* Login per site no sitemetadata fix (#7610)
* Support connected sites for which we have no site metadata.
* Change property containing subtitle info often populated by origin to a more accurate of purpose name
* Lint fix
* Improve disconnection modal messages (#7612)
* Improve disconnectAccountModalDescription and disconnectAllModalDescription messages
* Update disconnectAccountModalDescription app/_locales/en/messages.json
Co-Authored-By: Mark Stacey <markjstacey@gmail.com>
* Improve disconnectAccount modal message clarity
* Adds cancel button to the account selection screen of the permissions request flow (#7613)
* Fix eth_accounts permission language & selectability (#7614)
* fix eth_accounts language & selectability
* fix MetaMask capitalization in all messages
* Close sidebar when opening connected sites (#7611)
The 'Connected Sites' button in the accounts details now closes the
sidebar, if it is open. This was accomplished by pulling the click
handler for that button up to the wallet view component, where another
button already followed a similar pattern of closing the sidebar.
It seemed confusing to me that one handler was in the `AccountsDetails`
container component, and one was handed down from above, so I added
PropTypes to the container component.
I'm not sure that the WalletView component is the best place for this
logic, but I've put it there for now to be consistent with the add
token button.
* Reject permissions request upon tab close (#7618)
Permissions requests are now rejected when the page is closed. This
only applies to the full-screen view, as that is the view permission
requests should be handled in. The case where the user deals with the
request through a different view is handled in #7617
* Handle tab update failure (#7619)
`extension.tabs.update` can sometimes fail if the user interacts with
the tabs directly around the same time. The redirect flow has been
updated to ensure that the permissions tab is still closed in that
case. The user is on their own to find the dapp tab again in that case.
* Login per site tab popup fixes (#7617)
* Handle redirect in response to state update in permissions-connect
* Ensure origin is available to permissions-connect subcomponents during redirect
* Hide app bar whenever on redirect route
* Improvements to handling of redirects in permissions-connect
* Ensure permission request id change handling only happens when page is not null
* Lint fix
* Decouple confirm transaction screen from the selected address (#7622)
* Avoid race condtion that could prevent contextual account switching (#7623)
There was a race condition in the logic responsible for switching the
selected account based upon the active tab. It was asynchronously
querying the active tab, then assuming it had been retrieved later.
The active tab info itself was already in the redux store in another
spot, one that is guaranteed to be set before the UI renders. The
race condition was avoided by deleting the duplicate state, and using
the other active tab state.
* Only redirect back to dapp if current tab is active (#7621)
The "redirect back to dapp" behaviour can be disruptive when the
permissions connect tab is not active. The purpose of the redirect was
to maintain context between the dapp and the permissions request, but
if the user has already moved to another tab, that no longer applies.
* Fix JSX style lint errors
* Remove unused state
5 years ago
|
|
|
|
|
|
|
remotePort.onMessage.addListener((msg) => {
|
Connect distinct accounts per site (#7004)
* add PermissionsController
remove provider approval controller
integrate rpc-cap
create PermissionsController
move provider approval functionality to permissions controller
add permissions approval ui, settings page
add permissions activity and history
move some functionality to metamask-inpage-provider
rename siteMetadata -> domainMetadata
add accountsChange notification to inpage provider
move functionality to inpage provider
update inpage provider
Remove 'Connections' settings page (#7369)
add hooks for exposing accounts in settings
rename unused messages in non-English locales
Add external extension id to metadata (#7396)
update inpage provider, rpc-cap
add eth_requestAccounts handling to background
prevent notifying connections if extension is locked
update inpage provider
Fix lint errors
add migration
review fixes
transaction controller review updates
removed unused messages
* Login Per Site UI (#7368)
* LoginPerSite original UI changes to keep
* First commit
* Get necessary connected tab info for redirect and icon display for permissioned sites
* Fix up designs and add missing features
* Some lint fixes
* More lint fixes
* Ensures the tx controller + tx-state-manager orders transactions in the order they are received
* Code cleanup for LoginPerSite-ui
* Update e2e tests to use new connection flow
* Fix display of connect screen and app header after login when connect request present
* Update metamask-responsive-ui.spec for new item in accounts dropdown
* Fix approve container by replacing approvedOrigins with domainMetaData
* Adds test/e2e/permissions.spec.js
* Correctly handle cancellation of a permissions request
* Redirect to home after disconnecting all sites / cancelling all permissions
* Fix display of site icons in menu
* Fix height of permissions page container
* Remove unused locale messages
* Set default values for openExternalTabs and tabIdOrigins in account-menu.container
* More code cleanup for LoginPerSite-ui
* Use extensions api to close tab in permissions-connect
* Remove unnecessary change in domIsReady() in contentscript
* Remove unnecessary private function markers and class methods (for background tab info) in metamask-controller.
* Adds getOriginOfCurrentTab selector
* Adds IconWithFallback component and substitutes for appropriate cases
* Add and utilize font mixins
* Remove unused method in disconnect-all.container.js
* Simplify buttonSizeLarge code in page-container-footer.component.js
* Add and utilize getAccountsWithLabels selector
* Remove console.log in ui/app/store/actions.js
* Change last connected time format to yyyy-M-d
* Fix css associated with IconWithFallback change
* Ensure tracked openNonMetamaskTabsIDs are correctly set to inactive on tab changes
* Code cleanup for LoginPerSite-ui
* Use reusable function for modifying openNonMetamaskTabsIDs in background.js
* Enables automatic switching to connected account when connected domain is open
* Prevent exploit of tabIdOriginMap in background.js
* Remove unneeded code from contentscript.js
* Simplify current tab origin and window opener logic using remotePort listener tabs.queryTabs
* Design and styling fixes for LoginPerSite-ui
* Fix permissionHistory and permission logging for eth_requestAccounts and eth_accounts
* Front end changes to support display of lastConnected time in connected and permissions screens
* Fix lint errors
* Refactor structure of permissionsHistory
* Fix default values and object modifications for domain and permissionsHistory related data
* Fix connecting to new accounts from modal
* Replace retweet.svg with connect-white.svg
* Fix signature-request.spec
* Update metamask-inpage-provider version
* Fix permissions e2e tests
* Remove unneeded delay from test/e2e/signature-request.spec.js
* Add delay before attempting to retrieve network id in dapp in ethereum-on=.spec
* Use requestAccountTabIds strategy for determining tab id that opened a given window
* Improve default values for permissions requests
* Add some message descriptions to app/_locales/en/messages.json
* Code clean up in permission controller
* Stopped deep cloning object in mapObjectValues
* Bump metamask-inpage-provider version
* Add missing description in app/_locales/en/messages.json
* Return promises from queryTabs and switchToTab of extension.js
* Remove unused getAllPermissions function
* Use default props in icon-with-fallback.component.js
* Stop passing to permissions controller
* Delete no longer used clear-approved-origins modal code
* Remove duplicate imports in ui/app/components/app/index.scss
* Use URL instead of regex in getOriginFromUrl()
* Add runtime error checking to platform, promise based extension.tab methods
* Support permission requests from external extensions
* Improve font size and colour of the domain origin on the permission confirmation screen
* Add support for toggling permissions
* Ensure getRenderablePermissionsDomains only returns domains with exposedAccount caveat permissions
* Remove unused code from LoginPerSite-ui branch
* Ensure modal closes on Enter press for new-account-modal.component.js
* Lint fix
* fixup! Login Per Site UI (#7368)
* Some code cleanup for LoginPerSite
* Adds UX for connecting to dapps via the connected sites screen (#7593)
* Adds UX for connecting to dapps via the connected sites screen
* Use openMetaMaskTabIds from background.js to determine if current active tab is MetaMask
* Delete unused permissions controller methods
* Fixes two small bugs in the LoginPerSite ui (#7595)
* Restore `providerRequest` message translations (#7600)
This message was removed, but it was replaced with a very similar
message called `likeToConnect`. The only difference is that the new
message has "MetaMask" in it. Preserving these messages without
"MetaMask" is probably better than deleting them, so these messages
have all been restored and renamed to `likeToConnect`.
* Login per site no sitemetadata fix (#7610)
* Support connected sites for which we have no site metadata.
* Change property containing subtitle info often populated by origin to a more accurate of purpose name
* Lint fix
* Improve disconnection modal messages (#7612)
* Improve disconnectAccountModalDescription and disconnectAllModalDescription messages
* Update disconnectAccountModalDescription app/_locales/en/messages.json
Co-Authored-By: Mark Stacey <markjstacey@gmail.com>
* Improve disconnectAccount modal message clarity
* Adds cancel button to the account selection screen of the permissions request flow (#7613)
* Fix eth_accounts permission language & selectability (#7614)
* fix eth_accounts language & selectability
* fix MetaMask capitalization in all messages
* Close sidebar when opening connected sites (#7611)
The 'Connected Sites' button in the accounts details now closes the
sidebar, if it is open. This was accomplished by pulling the click
handler for that button up to the wallet view component, where another
button already followed a similar pattern of closing the sidebar.
It seemed confusing to me that one handler was in the `AccountsDetails`
container component, and one was handed down from above, so I added
PropTypes to the container component.
I'm not sure that the WalletView component is the best place for this
logic, but I've put it there for now to be consistent with the add
token button.
* Reject permissions request upon tab close (#7618)
Permissions requests are now rejected when the page is closed. This
only applies to the full-screen view, as that is the view permission
requests should be handled in. The case where the user deals with the
request through a different view is handled in #7617
* Handle tab update failure (#7619)
`extension.tabs.update` can sometimes fail if the user interacts with
the tabs directly around the same time. The redirect flow has been
updated to ensure that the permissions tab is still closed in that
case. The user is on their own to find the dapp tab again in that case.
* Login per site tab popup fixes (#7617)
* Handle redirect in response to state update in permissions-connect
* Ensure origin is available to permissions-connect subcomponents during redirect
* Hide app bar whenever on redirect route
* Improvements to handling of redirects in permissions-connect
* Ensure permission request id change handling only happens when page is not null
* Lint fix
* Decouple confirm transaction screen from the selected address (#7622)
* Avoid race condtion that could prevent contextual account switching (#7623)
There was a race condition in the logic responsible for switching the
selected account based upon the active tab. It was asynchronously
querying the active tab, then assuming it had been retrieved later.
The active tab info itself was already in the redux store in another
spot, one that is guaranteed to be set before the UI renders. The
race condition was avoided by deleting the duplicate state, and using
the other active tab state.
* Only redirect back to dapp if current tab is active (#7621)
The "redirect back to dapp" behaviour can be disruptive when the
permissions connect tab is not active. The purpose of the redirect was
to maintain context between the dapp and the permissions request, but
if the user has already moved to another tab, that no longer applies.
* Fix JSX style lint errors
* Remove unused state
5 years ago
|
|
|
if (msg.data && msg.data.method === 'eth_requestAccounts') {
|
|
|
|
requestAccountTabIds[origin] = tabId;
|
Connect distinct accounts per site (#7004)
* add PermissionsController
remove provider approval controller
integrate rpc-cap
create PermissionsController
move provider approval functionality to permissions controller
add permissions approval ui, settings page
add permissions activity and history
move some functionality to metamask-inpage-provider
rename siteMetadata -> domainMetadata
add accountsChange notification to inpage provider
move functionality to inpage provider
update inpage provider
Remove 'Connections' settings page (#7369)
add hooks for exposing accounts in settings
rename unused messages in non-English locales
Add external extension id to metadata (#7396)
update inpage provider, rpc-cap
add eth_requestAccounts handling to background
prevent notifying connections if extension is locked
update inpage provider
Fix lint errors
add migration
review fixes
transaction controller review updates
removed unused messages
* Login Per Site UI (#7368)
* LoginPerSite original UI changes to keep
* First commit
* Get necessary connected tab info for redirect and icon display for permissioned sites
* Fix up designs and add missing features
* Some lint fixes
* More lint fixes
* Ensures the tx controller + tx-state-manager orders transactions in the order they are received
* Code cleanup for LoginPerSite-ui
* Update e2e tests to use new connection flow
* Fix display of connect screen and app header after login when connect request present
* Update metamask-responsive-ui.spec for new item in accounts dropdown
* Fix approve container by replacing approvedOrigins with domainMetaData
* Adds test/e2e/permissions.spec.js
* Correctly handle cancellation of a permissions request
* Redirect to home after disconnecting all sites / cancelling all permissions
* Fix display of site icons in menu
* Fix height of permissions page container
* Remove unused locale messages
* Set default values for openExternalTabs and tabIdOrigins in account-menu.container
* More code cleanup for LoginPerSite-ui
* Use extensions api to close tab in permissions-connect
* Remove unnecessary change in domIsReady() in contentscript
* Remove unnecessary private function markers and class methods (for background tab info) in metamask-controller.
* Adds getOriginOfCurrentTab selector
* Adds IconWithFallback component and substitutes for appropriate cases
* Add and utilize font mixins
* Remove unused method in disconnect-all.container.js
* Simplify buttonSizeLarge code in page-container-footer.component.js
* Add and utilize getAccountsWithLabels selector
* Remove console.log in ui/app/store/actions.js
* Change last connected time format to yyyy-M-d
* Fix css associated with IconWithFallback change
* Ensure tracked openNonMetamaskTabsIDs are correctly set to inactive on tab changes
* Code cleanup for LoginPerSite-ui
* Use reusable function for modifying openNonMetamaskTabsIDs in background.js
* Enables automatic switching to connected account when connected domain is open
* Prevent exploit of tabIdOriginMap in background.js
* Remove unneeded code from contentscript.js
* Simplify current tab origin and window opener logic using remotePort listener tabs.queryTabs
* Design and styling fixes for LoginPerSite-ui
* Fix permissionHistory and permission logging for eth_requestAccounts and eth_accounts
* Front end changes to support display of lastConnected time in connected and permissions screens
* Fix lint errors
* Refactor structure of permissionsHistory
* Fix default values and object modifications for domain and permissionsHistory related data
* Fix connecting to new accounts from modal
* Replace retweet.svg with connect-white.svg
* Fix signature-request.spec
* Update metamask-inpage-provider version
* Fix permissions e2e tests
* Remove unneeded delay from test/e2e/signature-request.spec.js
* Add delay before attempting to retrieve network id in dapp in ethereum-on=.spec
* Use requestAccountTabIds strategy for determining tab id that opened a given window
* Improve default values for permissions requests
* Add some message descriptions to app/_locales/en/messages.json
* Code clean up in permission controller
* Stopped deep cloning object in mapObjectValues
* Bump metamask-inpage-provider version
* Add missing description in app/_locales/en/messages.json
* Return promises from queryTabs and switchToTab of extension.js
* Remove unused getAllPermissions function
* Use default props in icon-with-fallback.component.js
* Stop passing to permissions controller
* Delete no longer used clear-approved-origins modal code
* Remove duplicate imports in ui/app/components/app/index.scss
* Use URL instead of regex in getOriginFromUrl()
* Add runtime error checking to platform, promise based extension.tab methods
* Support permission requests from external extensions
* Improve font size and colour of the domain origin on the permission confirmation screen
* Add support for toggling permissions
* Ensure getRenderablePermissionsDomains only returns domains with exposedAccount caveat permissions
* Remove unused code from LoginPerSite-ui branch
* Ensure modal closes on Enter press for new-account-modal.component.js
* Lint fix
* fixup! Login Per Site UI (#7368)
* Some code cleanup for LoginPerSite
* Adds UX for connecting to dapps via the connected sites screen (#7593)
* Adds UX for connecting to dapps via the connected sites screen
* Use openMetaMaskTabIds from background.js to determine if current active tab is MetaMask
* Delete unused permissions controller methods
* Fixes two small bugs in the LoginPerSite ui (#7595)
* Restore `providerRequest` message translations (#7600)
This message was removed, but it was replaced with a very similar
message called `likeToConnect`. The only difference is that the new
message has "MetaMask" in it. Preserving these messages without
"MetaMask" is probably better than deleting them, so these messages
have all been restored and renamed to `likeToConnect`.
* Login per site no sitemetadata fix (#7610)
* Support connected sites for which we have no site metadata.
* Change property containing subtitle info often populated by origin to a more accurate of purpose name
* Lint fix
* Improve disconnection modal messages (#7612)
* Improve disconnectAccountModalDescription and disconnectAllModalDescription messages
* Update disconnectAccountModalDescription app/_locales/en/messages.json
Co-Authored-By: Mark Stacey <markjstacey@gmail.com>
* Improve disconnectAccount modal message clarity
* Adds cancel button to the account selection screen of the permissions request flow (#7613)
* Fix eth_accounts permission language & selectability (#7614)
* fix eth_accounts language & selectability
* fix MetaMask capitalization in all messages
* Close sidebar when opening connected sites (#7611)
The 'Connected Sites' button in the accounts details now closes the
sidebar, if it is open. This was accomplished by pulling the click
handler for that button up to the wallet view component, where another
button already followed a similar pattern of closing the sidebar.
It seemed confusing to me that one handler was in the `AccountsDetails`
container component, and one was handed down from above, so I added
PropTypes to the container component.
I'm not sure that the WalletView component is the best place for this
logic, but I've put it there for now to be consistent with the add
token button.
* Reject permissions request upon tab close (#7618)
Permissions requests are now rejected when the page is closed. This
only applies to the full-screen view, as that is the view permission
requests should be handled in. The case where the user deals with the
request through a different view is handled in #7617
* Handle tab update failure (#7619)
`extension.tabs.update` can sometimes fail if the user interacts with
the tabs directly around the same time. The redirect flow has been
updated to ensure that the permissions tab is still closed in that
case. The user is on their own to find the dapp tab again in that case.
* Login per site tab popup fixes (#7617)
* Handle redirect in response to state update in permissions-connect
* Ensure origin is available to permissions-connect subcomponents during redirect
* Hide app bar whenever on redirect route
* Improvements to handling of redirects in permissions-connect
* Ensure permission request id change handling only happens when page is not null
* Lint fix
* Decouple confirm transaction screen from the selected address (#7622)
* Avoid race condtion that could prevent contextual account switching (#7623)
There was a race condition in the logic responsible for switching the
selected account based upon the active tab. It was asynchronously
querying the active tab, then assuming it had been retrieved later.
The active tab info itself was already in the redux store in another
spot, one that is guaranteed to be set before the UI renders. The
race condition was avoided by deleting the duplicate state, and using
the other active tab state.
* Only redirect back to dapp if current tab is active (#7621)
The "redirect back to dapp" behaviour can be disruptive when the
permissions connect tab is not active. The purpose of the redirect was
to maintain context between the dapp and the permissions request, but
if the user has already moved to another tab, that no longer applies.
* Fix JSX style lint errors
* Remove unused state
5 years ago
|
|
|
}
|
|
|
|
});
|
Connect distinct accounts per site (#7004)
* add PermissionsController
remove provider approval controller
integrate rpc-cap
create PermissionsController
move provider approval functionality to permissions controller
add permissions approval ui, settings page
add permissions activity and history
move some functionality to metamask-inpage-provider
rename siteMetadata -> domainMetadata
add accountsChange notification to inpage provider
move functionality to inpage provider
update inpage provider
Remove 'Connections' settings page (#7369)
add hooks for exposing accounts in settings
rename unused messages in non-English locales
Add external extension id to metadata (#7396)
update inpage provider, rpc-cap
add eth_requestAccounts handling to background
prevent notifying connections if extension is locked
update inpage provider
Fix lint errors
add migration
review fixes
transaction controller review updates
removed unused messages
* Login Per Site UI (#7368)
* LoginPerSite original UI changes to keep
* First commit
* Get necessary connected tab info for redirect and icon display for permissioned sites
* Fix up designs and add missing features
* Some lint fixes
* More lint fixes
* Ensures the tx controller + tx-state-manager orders transactions in the order they are received
* Code cleanup for LoginPerSite-ui
* Update e2e tests to use new connection flow
* Fix display of connect screen and app header after login when connect request present
* Update metamask-responsive-ui.spec for new item in accounts dropdown
* Fix approve container by replacing approvedOrigins with domainMetaData
* Adds test/e2e/permissions.spec.js
* Correctly handle cancellation of a permissions request
* Redirect to home after disconnecting all sites / cancelling all permissions
* Fix display of site icons in menu
* Fix height of permissions page container
* Remove unused locale messages
* Set default values for openExternalTabs and tabIdOrigins in account-menu.container
* More code cleanup for LoginPerSite-ui
* Use extensions api to close tab in permissions-connect
* Remove unnecessary change in domIsReady() in contentscript
* Remove unnecessary private function markers and class methods (for background tab info) in metamask-controller.
* Adds getOriginOfCurrentTab selector
* Adds IconWithFallback component and substitutes for appropriate cases
* Add and utilize font mixins
* Remove unused method in disconnect-all.container.js
* Simplify buttonSizeLarge code in page-container-footer.component.js
* Add and utilize getAccountsWithLabels selector
* Remove console.log in ui/app/store/actions.js
* Change last connected time format to yyyy-M-d
* Fix css associated with IconWithFallback change
* Ensure tracked openNonMetamaskTabsIDs are correctly set to inactive on tab changes
* Code cleanup for LoginPerSite-ui
* Use reusable function for modifying openNonMetamaskTabsIDs in background.js
* Enables automatic switching to connected account when connected domain is open
* Prevent exploit of tabIdOriginMap in background.js
* Remove unneeded code from contentscript.js
* Simplify current tab origin and window opener logic using remotePort listener tabs.queryTabs
* Design and styling fixes for LoginPerSite-ui
* Fix permissionHistory and permission logging for eth_requestAccounts and eth_accounts
* Front end changes to support display of lastConnected time in connected and permissions screens
* Fix lint errors
* Refactor structure of permissionsHistory
* Fix default values and object modifications for domain and permissionsHistory related data
* Fix connecting to new accounts from modal
* Replace retweet.svg with connect-white.svg
* Fix signature-request.spec
* Update metamask-inpage-provider version
* Fix permissions e2e tests
* Remove unneeded delay from test/e2e/signature-request.spec.js
* Add delay before attempting to retrieve network id in dapp in ethereum-on=.spec
* Use requestAccountTabIds strategy for determining tab id that opened a given window
* Improve default values for permissions requests
* Add some message descriptions to app/_locales/en/messages.json
* Code clean up in permission controller
* Stopped deep cloning object in mapObjectValues
* Bump metamask-inpage-provider version
* Add missing description in app/_locales/en/messages.json
* Return promises from queryTabs and switchToTab of extension.js
* Remove unused getAllPermissions function
* Use default props in icon-with-fallback.component.js
* Stop passing to permissions controller
* Delete no longer used clear-approved-origins modal code
* Remove duplicate imports in ui/app/components/app/index.scss
* Use URL instead of regex in getOriginFromUrl()
* Add runtime error checking to platform, promise based extension.tab methods
* Support permission requests from external extensions
* Improve font size and colour of the domain origin on the permission confirmation screen
* Add support for toggling permissions
* Ensure getRenderablePermissionsDomains only returns domains with exposedAccount caveat permissions
* Remove unused code from LoginPerSite-ui branch
* Ensure modal closes on Enter press for new-account-modal.component.js
* Lint fix
* fixup! Login Per Site UI (#7368)
* Some code cleanup for LoginPerSite
* Adds UX for connecting to dapps via the connected sites screen (#7593)
* Adds UX for connecting to dapps via the connected sites screen
* Use openMetaMaskTabIds from background.js to determine if current active tab is MetaMask
* Delete unused permissions controller methods
* Fixes two small bugs in the LoginPerSite ui (#7595)
* Restore `providerRequest` message translations (#7600)
This message was removed, but it was replaced with a very similar
message called `likeToConnect`. The only difference is that the new
message has "MetaMask" in it. Preserving these messages without
"MetaMask" is probably better than deleting them, so these messages
have all been restored and renamed to `likeToConnect`.
* Login per site no sitemetadata fix (#7610)
* Support connected sites for which we have no site metadata.
* Change property containing subtitle info often populated by origin to a more accurate of purpose name
* Lint fix
* Improve disconnection modal messages (#7612)
* Improve disconnectAccountModalDescription and disconnectAllModalDescription messages
* Update disconnectAccountModalDescription app/_locales/en/messages.json
Co-Authored-By: Mark Stacey <markjstacey@gmail.com>
* Improve disconnectAccount modal message clarity
* Adds cancel button to the account selection screen of the permissions request flow (#7613)
* Fix eth_accounts permission language & selectability (#7614)
* fix eth_accounts language & selectability
* fix MetaMask capitalization in all messages
* Close sidebar when opening connected sites (#7611)
The 'Connected Sites' button in the accounts details now closes the
sidebar, if it is open. This was accomplished by pulling the click
handler for that button up to the wallet view component, where another
button already followed a similar pattern of closing the sidebar.
It seemed confusing to me that one handler was in the `AccountsDetails`
container component, and one was handed down from above, so I added
PropTypes to the container component.
I'm not sure that the WalletView component is the best place for this
logic, but I've put it there for now to be consistent with the add
token button.
* Reject permissions request upon tab close (#7618)
Permissions requests are now rejected when the page is closed. This
only applies to the full-screen view, as that is the view permission
requests should be handled in. The case where the user deals with the
request through a different view is handled in #7617
* Handle tab update failure (#7619)
`extension.tabs.update` can sometimes fail if the user interacts with
the tabs directly around the same time. The redirect flow has been
updated to ensure that the permissions tab is still closed in that
case. The user is on their own to find the dapp tab again in that case.
* Login per site tab popup fixes (#7617)
* Handle redirect in response to state update in permissions-connect
* Ensure origin is available to permissions-connect subcomponents during redirect
* Hide app bar whenever on redirect route
* Improvements to handling of redirects in permissions-connect
* Ensure permission request id change handling only happens when page is not null
* Lint fix
* Decouple confirm transaction screen from the selected address (#7622)
* Avoid race condtion that could prevent contextual account switching (#7623)
There was a race condition in the logic responsible for switching the
selected account based upon the active tab. It was asynchronously
querying the active tab, then assuming it had been retrieved later.
The active tab info itself was already in the redux store in another
spot, one that is guaranteed to be set before the UI renders. The
race condition was avoided by deleting the duplicate state, and using
the other active tab state.
* Only redirect back to dapp if current tab is active (#7621)
The "redirect back to dapp" behaviour can be disruptive when the
permissions connect tab is not active. The purpose of the redirect was
to maintain context between the dapp and the permissions request, but
if the user has already moved to another tab, that no longer applies.
* Fix JSX style lint errors
* Remove unused state
5 years ago
|
|
|
}
|
|
|
|
connectExternal(remotePort);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// communication with page or other extension
|
|
|
|
function connectExternal(remotePort) {
|
|
|
|
const portStream = new PortStream(remotePort);
|
|
|
|
controller.setupUntrustedCommunication({
|
|
|
|
connectionStream: portStream,
|
|
|
|
sender: remotePort.sender,
|
|
|
|
});
|
|
|
|
}
|
|
|
|
|
|
|
|
//
|
|
|
|
// User Interface setup
|
|
|
|
//
|
|
|
|
|
|
|
|
updateBadge();
|
|
|
|
controller.txController.on(
|
|
|
|
METAMASK_CONTROLLER_EVENTS.UPDATE_BADGE,
|
|
|
|
updateBadge,
|
|
|
|
);
|
|
|
|
controller.messageManager.on(
|
|
|
|
METAMASK_CONTROLLER_EVENTS.UPDATE_BADGE,
|
|
|
|
updateBadge,
|
|
|
|
);
|
|
|
|
controller.personalMessageManager.on(
|
|
|
|
METAMASK_CONTROLLER_EVENTS.UPDATE_BADGE,
|
|
|
|
updateBadge,
|
|
|
|
);
|
|
|
|
controller.decryptMessageManager.on(
|
|
|
|
METAMASK_CONTROLLER_EVENTS.UPDATE_BADGE,
|
|
|
|
updateBadge,
|
|
|
|
);
|
|
|
|
controller.encryptionPublicKeyManager.on(
|
|
|
|
METAMASK_CONTROLLER_EVENTS.UPDATE_BADGE,
|
|
|
|
updateBadge,
|
|
|
|
);
|
|
|
|
controller.typedMessageManager.on(
|
|
|
|
METAMASK_CONTROLLER_EVENTS.UPDATE_BADGE,
|
|
|
|
updateBadge,
|
|
|
|
);
|
|
|
|
controller.appStateController.on(
|
|
|
|
METAMASK_CONTROLLER_EVENTS.UPDATE_BADGE,
|
|
|
|
updateBadge,
|
|
|
|
);
|
|
|
|
|
|
|
|
controller.controllerMessenger.subscribe(
|
|
|
|
METAMASK_CONTROLLER_EVENTS.APPROVAL_STATE_CHANGE,
|
|
|
|
updateBadge,
|
|
|
|
);
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Updates the Web Extension's "badge" number, on the little fox in the toolbar.
|
|
|
|
* The number reflects the current number of pending transactions or message signatures needing user approval.
|
|
|
|
*/
|
|
|
|
function updateBadge() {
|
|
|
|
let label = '';
|
|
|
|
const count = getUnapprovedTransactionCount();
|
|
|
|
if (count) {
|
|
|
|
label = String(count);
|
|
|
|
}
|
|
|
|
// browserAction has been replaced by action in MV3
|
|
|
|
if (isManifestV3()) {
|
|
|
|
browser.action.setBadgeText({ text: label });
|
|
|
|
browser.action.setBadgeBackgroundColor({ color: '#037DD6' });
|
|
|
|
} else {
|
|
|
|
browser.browserAction.setBadgeText({ text: label });
|
|
|
|
browser.browserAction.setBadgeBackgroundColor({ color: '#037DD6' });
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
function getUnapprovedTransactionCount() {
|
|
|
|
const unapprovedTxCount = controller.txController.getUnapprovedTxCount();
|
|
|
|
const { unapprovedMsgCount } = controller.messageManager;
|
|
|
|
const { unapprovedPersonalMsgCount } = controller.personalMessageManager;
|
|
|
|
const { unapprovedDecryptMsgCount } = controller.decryptMessageManager;
|
|
|
|
const {
|
|
|
|
unapprovedEncryptionPublicKeyMsgCount,
|
|
|
|
} = controller.encryptionPublicKeyManager;
|
|
|
|
const { unapprovedTypedMessagesCount } = controller.typedMessageManager;
|
|
|
|
const pendingApprovalCount = controller.approvalController.getTotalApprovalCount();
|
|
|
|
const waitingForUnlockCount =
|
|
|
|
controller.appStateController.waitingForUnlock.length;
|
|
|
|
return (
|
|
|
|
unapprovedTxCount +
|
|
|
|
unapprovedMsgCount +
|
|
|
|
unapprovedPersonalMsgCount +
|
|
|
|
unapprovedDecryptMsgCount +
|
|
|
|
unapprovedEncryptionPublicKeyMsgCount +
|
|
|
|
unapprovedTypedMessagesCount +
|
|
|
|
pendingApprovalCount +
|
|
|
|
waitingForUnlockCount
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
notificationManager.on(
|
|
|
|
NOTIFICATION_MANAGER_EVENTS.POPUP_CLOSED,
|
|
|
|
({ automaticallyClosed }) => {
|
|
|
|
if (!automaticallyClosed) {
|
|
|
|
rejectUnapprovedNotifications();
|
|
|
|
} else if (getUnapprovedTransactionCount() > 0) {
|
|
|
|
triggerUi();
|
|
|
|
}
|
|
|
|
},
|
|
|
|
);
|
|
|
|
|
|
|
|
function rejectUnapprovedNotifications() {
|
|
|
|
Object.keys(
|
|
|
|
controller.txController.txStateManager.getUnapprovedTxList(),
|
|
|
|
).forEach((txId) =>
|
|
|
|
controller.txController.txStateManager.setTxStatusRejected(txId),
|
|
|
|
);
|
|
|
|
controller.messageManager.messages
|
|
|
|
.filter((msg) => msg.status === 'unapproved')
|
|
|
|
.forEach((tx) =>
|
|
|
|
controller.messageManager.rejectMsg(
|
|
|
|
tx.id,
|
|
|
|
REJECT_NOTFICIATION_CLOSE_SIG,
|
|
|
|
),
|
|
|
|
);
|
|
|
|
controller.personalMessageManager.messages
|
|
|
|
.filter((msg) => msg.status === 'unapproved')
|
|
|
|
.forEach((tx) =>
|
|
|
|
controller.personalMessageManager.rejectMsg(
|
|
|
|
tx.id,
|
|
|
|
REJECT_NOTFICIATION_CLOSE_SIG,
|
|
|
|
),
|
|
|
|
);
|
|
|
|
controller.typedMessageManager.messages
|
|
|
|
.filter((msg) => msg.status === 'unapproved')
|
|
|
|
.forEach((tx) =>
|
|
|
|
controller.typedMessageManager.rejectMsg(
|
|
|
|
tx.id,
|
|
|
|
REJECT_NOTFICIATION_CLOSE_SIG,
|
|
|
|
),
|
|
|
|
);
|
|
|
|
controller.decryptMessageManager.messages
|
|
|
|
.filter((msg) => msg.status === 'unapproved')
|
|
|
|
.forEach((tx) =>
|
|
|
|
controller.decryptMessageManager.rejectMsg(
|
|
|
|
tx.id,
|
|
|
|
REJECT_NOTFICIATION_CLOSE,
|
|
|
|
),
|
|
|
|
);
|
|
|
|
controller.encryptionPublicKeyManager.messages
|
|
|
|
.filter((msg) => msg.status === 'unapproved')
|
|
|
|
.forEach((tx) =>
|
|
|
|
controller.encryptionPublicKeyManager.rejectMsg(
|
|
|
|
tx.id,
|
|
|
|
REJECT_NOTFICIATION_CLOSE,
|
|
|
|
),
|
|
|
|
);
|
|
|
|
|
Permission System 2.0 (#12243)
# Permission System 2.0
## Background
This PR migrates the extension permission system to [the new `PermissionController`](https://github.com/MetaMask/snaps-skunkworks/tree/main/packages/controllers/src/permissions).
The original permission system, based on [`rpc-cap`](https://github.com/MetaMask/rpc-cap), introduced [`ZCAP-LD`](https://w3c-ccg.github.io/zcap-ld/)-like permissions to our JSON-RPC stack.
We used it to [implement](https://github.com/MetaMask/metamask-extension/pull/7004) what we called "LoginPerSite" in [version 7.7.0](https://github.com/MetaMask/metamask-extension/releases/tag/v7.7.0) of the extension, which enabled the user to choose which accounts, if any, should be exposed to each dapp.
While that was a worthwhile feature in and of itself, we wanted a permission _system_ in order to enable everything we are going to with Snaps.
Unfortunately, the original permission system was difficult to use, and necessitated the creation of the original `PermissionsController` (note the "s"), which was more or less a wrapper for `rpc-cap`.
With this PR, we shake off the yoke of the original permission system, in favor of the modular, self-contained, ergonomic, and more mature permission system 2.0.
Note that [the `PermissionController` readme](https://github.com/MetaMask/snaps-skunkworks/tree/main/packages/controllers/src/permissions/README.md) explains how the new permission system works.
The `PermissionController` and `SubjectMetadataController` are currently shipped via `@metamask/snap-controllers`. This is a temporary state of affairs, and we'll move them to `@metamask/controllers` once they've landed in prod.
## Changes in Detail
First, the changes in this PR are not as big as they seem. Roughly half of the additions in this PR are fixtures in the test for the new migration (number 68), and a significant portion of the remaining ~2500 lines are due to find-and-replace changes in other test fixtures and UI files.
- The extension `PermissionsController` has been deleted, and completely replaced with the new `PermissionController` from [`@metamask/snap-controllers`](https://www.npmjs.com/package/@metamask/snap-controllers).
- The original `PermissionsController` "domain metadata" functionality is now managed by the new `SubjectMetadataController`, also from [`@metamask/snap-controllers`](https://www.npmjs.com/package/@metamask/snap-controllers).
- The permission activity and history log controller has been renamed `PermissionLogController` and has its own top-level state key, but is otherwise functionally equivalent to the existing implementation.
- Migration number 68 has been added to account for the new state changes.
- The tests in `app/scripts/controllers/permissions` have been migrated from `mocha` to `jest`.
Reviewers should focus their attention on the following files:
- `app/scripts/`
- `metamask-controller.js`
- This is where most of the integration work for the new `PermissionController` occurs.
Some functions that were internal to the original controller were moved here.
- `controllers/permissions/`
- `selectors.js`
- These selectors are for `ControllerMessenger` selector subscriptions. The actual subscriptions occur in `metamask-controller.js`. See the `ControllerMessenger` implementation for details.
- `specifications.js`
- The caveat and permission specifications are required by the new `PermissionController`, and are used to specify the `eth_accounts` permission and its JSON-RPC method implementation.
See the `PermissionController` readme for details.
- `migrations/068.js`
- The new state should be cross-referenced with the controllers that manage it.
The accompanying tests should also be thoroughly reviewed.
Some files may appear new but have just moved and/or been renamed:
- `app/scripts/lib/rpc-method-middleware/handlers/request-accounts.js`
- This was previously implemented in `controllers/permissions/permissionsMethodMiddleware.js`.
- `test/mocks/permissions.js`
- A truncated version of `test/mocks/permission-controller.js`.
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
3 years ago
|
|
|
// Finally, reject all approvals managed by the ApprovalController
|
|
|
|
controller.approvalController.clear(
|
|
|
|
ethErrors.provider.userRejectedRequest(),
|
|
|
|
);
|
|
|
|
|
|
|
|
updateBadge();
|
|
|
|
}
|
|
|
|
|
|
|
|
return Promise.resolve();
|
|
|
|
}
|
|
|
|
|
|
|
|
//
|
|
|
|
// Etc...
|
|
|
|
//
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Opens the browser popup for user confirmation
|
|
|
|
*/
|
|
|
|
async function triggerUi() {
|
|
|
|
const tabs = await platform.getActiveTabs();
|
|
|
|
const currentlyActiveMetamaskTab = Boolean(
|
|
|
|
tabs.find((tab) => openMetamaskTabsIDs[tab.id]),
|
|
|
|
);
|
|
|
|
// Vivaldi is not closing port connection on popup close, so popupIsOpen does not work correctly
|
|
|
|
// To be reviewed in the future if this behaviour is fixed - also the way we determine isVivaldi variable might change at some point
|
|
|
|
const isVivaldi =
|
|
|
|
tabs.length > 0 &&
|
|
|
|
tabs[0].extData &&
|
|
|
|
tabs[0].extData.indexOf('vivaldi_tab') > -1;
|
|
|
|
if (
|
|
|
|
!uiIsTriggering &&
|
|
|
|
(isVivaldi || !popupIsOpen) &&
|
|
|
|
!currentlyActiveMetamaskTab
|
|
|
|
) {
|
|
|
|
uiIsTriggering = true;
|
|
|
|
try {
|
|
|
|
await notificationManager.showPopup();
|
|
|
|
} finally {
|
|
|
|
uiIsTriggering = false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Opens the browser popup for user confirmation of watchAsset
|
|
|
|
* then it waits until user interact with the UI
|
|
|
|
*/
|
|
|
|
async function openPopup() {
|
|
|
|
await triggerUi();
|
|
|
|
await new Promise((resolve) => {
|
|
|
|
const interval = setInterval(() => {
|
|
|
|
if (!notificationIsOpen) {
|
|
|
|
clearInterval(interval);
|
|
|
|
resolve();
|
|
|
|
}
|
|
|
|
}, SECOND);
|
|
|
|
});
|
|
|
|
}
|
|
|
|
|
|
|
|
// On first install, open a new tab with MetaMask
|
|
|
|
browser.runtime.onInstalled.addListener(({ reason }) => {
|
|
|
|
if (
|
|
|
|
reason === 'install' &&
|
|
|
|
!(process.env.METAMASK_DEBUG || process.env.IN_TEST)
|
|
|
|
) {
|
|
|
|
platform.openExtensionInBrowser();
|
|
|
|
}
|
|
|
|
});
|
|
|
|
|
|
|
|
function setupSentryGetStateGlobal(store) {
|
|
|
|
global.getSentryState = function () {
|
|
|
|
const fullState = store.getState();
|
|
|
|
const debugState = maskObject(fullState, SENTRY_STATE);
|
|
|
|
return {
|
|
|
|
browser: window.navigator.userAgent,
|
|
|
|
store: debugState,
|
|
|
|
version: global.platform.getVersion(),
|
|
|
|
};
|
|
|
|
};
|
|
|
|
}
|