EIP-1559 - Don't hide advanced form when radio button is chosen (#11643)

ui/components/app/edit-gas-display/edit-gas-display.component.js

@@ -60,8 +60,6 @@ export default function EditGasDisplay({
 }) {
   const t = useContext(I18nContext);
 
-  const alwaysShowForm = !estimateToUse || hasGasErrors || false;
-
   const dappSuggestedAndTxParamGasFeesAreTheSame = areDappSuggestedAndTxParamGasFeesTheSame(
     transaction,
   );
@@ -178,7 +176,7 @@ export default function EditGasDisplay({
               onChange={setEstimateToUse}
             />
           )}
-        {!alwaysShowForm && !requireDappAcknowledgement && (
+        {!requireDappAcknowledgement && (
           <button
             className="edit-gas-display__advanced-button"
             onClick={() => setShowAdvancedForm(!showAdvancedForm)}
@@ -191,27 +189,26 @@ export default function EditGasDisplay({
             )}
           </button>
         )}
-        {!requireDappAcknowledgement &&
+        {!requireDappAcknowledgement && showAdvancedForm && (
-          (alwaysShowForm || showAdvancedForm) && (
+          <AdvancedGasControls
-            <AdvancedGasControls
+            gasFeeEstimates={gasFeeEstimates}
-              gasFeeEstimates={gasFeeEstimates}
+            gasEstimateType={gasEstimateType}
-              gasEstimateType={gasEstimateType}
+            estimateToUse={estimateToUse}
-              estimateToUse={estimateToUse}
+            isGasEstimatesLoading={isGasEstimatesLoading}
-              isGasEstimatesLoading={isGasEstimatesLoading}
+            gasLimit={gasLimit}
-              gasLimit={gasLimit}
+            setGasLimit={setGasLimit}
-              setGasLimit={setGasLimit}
+            maxPriorityFee={maxPriorityFeePerGas}
-              maxPriorityFee={maxPriorityFeePerGas}
+            setMaxPriorityFee={setMaxPriorityFeePerGas}
-              setMaxPriorityFee={setMaxPriorityFeePerGas}
+            maxFee={maxFeePerGas}
-              maxFee={maxFeePerGas}
+            setMaxFee={setMaxFeePerGas}
-              setMaxFee={setMaxFeePerGas}
+            gasPrice={gasPrice}
-              gasPrice={gasPrice}
+            setGasPrice={setGasPrice}
-              setGasPrice={setGasPrice}
+            maxPriorityFeeFiat={maxPriorityFeePerGasFiat}
-              maxPriorityFeeFiat={maxPriorityFeePerGasFiat}
+            maxFeeFiat={maxFeePerGasFiat}
-              maxFeeFiat={maxFeePerGasFiat}
+            gasErrors={gasErrors}
-              gasErrors={gasErrors}
+            onManualChange={onManualChange}
-              onManualChange={onManualChange}
+          />
-            />
+        )}
-          )}
       </div>
       {!requireDappAcknowledgement && showEducationButton && (
         <div className="edit-gas-display__education">

ui/components/app/edit-gas-popover/edit-gas-popover.component.js

@@ -51,7 +51,6 @@ export default function EditGasPopover({
 
   const [warning] = useState(null);
 
-  const [showAdvancedForm, setShowAdvancedForm] = useState(false);
   const [
     dappSuggestedGasFeeAcknowledged,
     setDappSuggestedGasFeeAcknowledged,
@@ -81,6 +80,10 @@ export default function EditGasPopover({
     onManualChange,
   } = useGasFeeInputs(defaultEstimateToUse, transaction);
 
+  const [showAdvancedForm, setShowAdvancedForm] = useState(
+    !estimateToUse || hasGasErrors,
+  );
+
   /**
    * Temporary placeholder, this should be managed by the parent component but
    * we will be extracting this component from the hard to maintain modal/