Add validation for the `fee` property from the `/trades` API response (#10836)

4 years ago · 135f0bb4f0
parent 501829e5ca
commit 135f0bb4f0
3 changed files with 6 additions and 0 deletions
--- a/ui/app/pages/swaps/swaps-util-test-constants.js
+++ b/ui/app/pages/swaps/swaps-util-test-constants.js
@ -101,6 +101,7 @@ export const MOCK_TRADE_RESPONSE_1 = [
    sourceAmount: '10000000000000000',
    destinationAmount: '2248687',
    error: null,
+    fee: 0.875,
    sourceToken: TOKENS[0].address,
    destinationToken: TOKENS[1].address,
    fetchTime: 553,
--- a/ui/app/pages/swaps/swaps.util.js
+++ b/ui/app/pages/swaps/swaps.util.js
@ -131,6 +131,10 @@ const QUOTE_VALIDATORS = [
    type: 'number|undefined',
    validator: (gasEstimate) => gasEstimate === undefined || gasEstimate > 0,
  },
+  {
+    property: 'fee',
+    type: 'number',
+  },
 ];

 const TOKEN_VALIDATORS = [
--- a/ui/app/pages/swaps/swaps.util.test.js
+++ b/ui/app/pages/swaps/swaps.util.test.js
@ -64,6 +64,7 @@ describe('Swaps Util', function () {
        sourceAmount: '10000000000000000',
        destinationAmount: '2248687',
        error: null,
+        fee: 0.875,
        sourceToken: TOKENS[0].address,
        destinationToken: TOKENS[1].address,
        fetchTime: 553,