Merge pull request #1050 from MetaMask/fixConfTxBalanceLogic

Fix conf tx balance logic
feature/default_network_editable
kumavis 8 years ago committed by GitHub
commit 23c2b0b9a5
  1. 1
      CHANGELOG.md
  2. 2
      ui/app/conf-tx.js

@ -2,6 +2,7 @@
## Current Master
- Fix rendering bug where the Confirm transaction view would lets you approve transactions when the account has insufficient balance.
- Add ability to import accounts in JSON file format (used by Mist, Geth, MyEtherWallet, and more!)
## 3.1.1 2017-1-20

@ -134,7 +134,7 @@ ConfirmTxScreen.prototype.checkBalanceAgainstTx = function (txData) {
var address = txData.txParams.from || state.selectedAccount
var account = state.accounts[address]
var balance = account ? account.balance : '0x0'
var maxCost = new BN(txData.maxCost)
var maxCost = new BN(txData.maxCost, 16)
var balanceBn = new BN(ethUtil.stripHexPrefix(balance), 16)
return maxCost.gt(balanceBn)

Loading…
Cancel
Save