Merge pull request #6545 from whymarrh/tOrKey-ConfirmTransactionBase

Use tOrKey for actionKey in ConfirmTransactionBase
feature/default_network_editable
Thomas Huang 6 years ago committed by GitHub
commit 2ff522604b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      ui/app/helpers/higher-order-components/i18n-provider.js
  2. 4
      ui/app/pages/confirm-transaction-base/confirm-transaction-base.component.js

@ -19,7 +19,7 @@ class I18nProvider extends Component {
return t(current, key, ...args) || t(en, key, ...args) || `[${key}]` return t(current, key, ...args) || t(en, key, ...args) || `[${key}]`
}, },
tOrDefault: this.tOrDefault, tOrDefault: this.tOrDefault,
tOrKey (key, ...args) { tOrKey: (key, ...args) => {
return this.tOrDefault(key, key, ...args) return this.tOrDefault(key, key, ...args)
}, },
} }

@ -18,6 +18,7 @@ import AdvancedGasInputs from '../../components/app/gas-customization/advanced-g
export default class ConfirmTransactionBase extends Component { export default class ConfirmTransactionBase extends Component {
static contextTypes = { static contextTypes = {
t: PropTypes.func, t: PropTypes.func,
tOrKey: PropTypes.func.isRequired,
metricsEvent: PropTypes.func, metricsEvent: PropTypes.func,
} }
@ -546,7 +547,8 @@ export default class ConfirmTransactionBase extends Component {
toName={toName} toName={toName}
toAddress={toAddress} toAddress={toAddress}
showEdit={onEdit && !isTxReprice} showEdit={onEdit && !isTxReprice}
action={this.context.t(actionKey) || getMethodName(name) || this.context.t('contractInteraction')} // In the event that the key is falsy (and inherently invalid), use a fallback string
action={this.context.tOrKey(actionKey) || getMethodName(name) || this.context.t('contractInteraction')}
title={title} title={title}
titleComponent={this.renderTitleComponent()} titleComponent={this.renderTitleComponent()}
subtitle={subtitle} subtitle={subtitle}

Loading…
Cancel
Save