Migrate check for GITHUB_TOKEN (#10958)

The check for the GITHUB_TOKEN environment variable was being done in
the wrong release script. It has been migrated to the relevant script.

A second check for the username has also been added, as it is also
required.
feature/default_network_editable
Mark Stacey 4 years ago committed by GitHub
parent bc24d9e696
commit 3d952536d8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 10
      .circleci/scripts/release-commit-version-bump.sh
  2. 6
      .circleci/scripts/release-create-release-pr.sh

@ -16,6 +16,16 @@ then
exit 1 exit 1
fi fi
if [[ -z "${GITHUB_TOKEN:-}" ]]
then
printf '%s\n' 'GITHUB_TOKEN environment variable must be set'
exit 1
elif [[ -z "${GITHUB_TOKEN_USER:-}" ]]
then
printf '%s\n' 'GITHUB_TOKEN_USER environment variable must be set'
exit 1
fi
printf '%s\n' 'Commit the manifest version and changelog if the manifest has changed' printf '%s\n' 'Commit the manifest version and changelog if the manifest has changed'
if git diff --quiet app/manifest/_base.json; if git diff --quiet app/manifest/_base.json;

@ -16,12 +16,6 @@ then
exit 1 exit 1
fi fi
if [[ -z "${GITHUB_TOKEN:-}" ]]
then
printf '%s\n' 'GITHUB_TOKEN environment variable must be set'
exit 1
fi
function install_github_cli () function install_github_cli ()
{ {
printf '%s\n' 'Installing hub CLI' printf '%s\n' 'Installing hub CLI'

Loading…
Cancel
Save