network - improve logging and type conversion

feature/default_network_editable
kumavis 6 years ago committed by GitHub
parent 2f6530a494
commit 61c7bbb1c1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 10
      app/scripts/controllers/network/network.js

@ -86,17 +86,19 @@ module.exports = class NetworkController extends EventEmitter {
return log.warn('NetworkController - lookupNetwork aborted due to missing provider') return log.warn('NetworkController - lookupNetwork aborted due to missing provider')
} }
const ethQuery = new EthQuery(this._provider) const ethQuery = new EthQuery(this._provider)
ethQuery.sendAsync({ method: 'eth_chainId' }, (err, chainId) => { ethQuery.sendAsync({ method: 'eth_chainId' }, (err, chainIdHex) => {
if (err) { if (err) {
// if eth_chainId is not supported, fallback to net_verion
ethQuery.sendAsync({ method: 'net_version' }, (err, network) => { ethQuery.sendAsync({ method: 'net_version' }, (err, network) => {
if (err) return this.setNetworkState('loading') if (err) return this.setNetworkState('loading')
log.info('web3.getNetwork returned net_version = ' + network) log.info(`net_version returned ${network}`)
this.setNetworkState(network) this.setNetworkState(network)
}) })
return return
} }
log.info('web3.getNetwork returned chainId = ' + parseInt(chainId)) const chainId = Number.parseInt(chainIdHex, 16)
this.setNetworkState(parseInt(chainId)) log.info(`net_version returned ${chainId}`)
this.setNetworkState(chainId)
}) })
} }

Loading…
Cancel
Save