fix opensea/autodetect setting dependency relation (#13575)

app/scripts/controllers/preferences.js

@@ -143,13 +143,12 @@ export default class PreferencesController {
   /**
    * Setter for the `openSeaEnabled` property
    *
-   * @param {boolean} val - Whether or not the user prefers to use the OpenSea API for collectibles data.
+   * @param {boolean} openSeaEnabled - Whether or not the user prefers to use the OpenSea API for collectibles data.
    */
-  setOpenSeaEnabled(val) {
+  setOpenSeaEnabled(openSeaEnabled) {
-    this.store.updateState({ openSeaEnabled: val });
+    this.store.updateState({
-    if (!val) {
+      openSeaEnabled,
-      this.store.updateState({ useCollectibleDetection: false });
+    });
-    }
   }
 
   /**

ui/pages/settings/experimental-tab/experimental-tab.component.js

@@ -133,10 +133,11 @@ export default class ExperimentalTab extends PureComponent {
                     name: 'Enabled/Disable OpenSea',
                   },
                 });
-                setOpenSeaEnabled(!value);
+                // value is positive when being toggled off
-                if (value && !useCollectibleDetection) {
+                if (value && useCollectibleDetection) {
-                  setUseCollectibleDetection(true);
+                  setUseCollectibleDetection(false);
                 }
+                setOpenSeaEnabled(!value);
               }}
               offLabel={t('off')}
               onLabel={t('on')}