tests - fix cancle transaction test to better fit new behavior

test/unit/app/controllers/transactions/tx-controller-test.js

@@ -357,9 +357,16 @@ describe('Transaction Controller', function () {
       ])
     })
 
-    it('should set the transaction to rejected from unapproved', async function () {
+    it('should emit a status change to rejected', function (done) {
-      await txController.cancelTransaction(0)
+      txController.once('tx:status-update', (txId, status) => {
-      assert.equal(txController.txStateManager.getTx(0).status, 'rejected')
+        try {
+          assert.equal(status, 'rejected', 'status should e rejected')
+          assert.equal(txId, 0, 'id should e 0')
+          done()
+        } catch (e) { done(e) }
+      })
+
+      txController.cancelTransaction(0)
     })
 
   })

test/unit/app/controllers/transactions/tx-state-manager-test.js

@@ -45,16 +45,6 @@ describe('TransactionStateManager', function () {
   })
 
   describe('#setTxStatusRejected', function () {
-    it('sets the tx status to rejected', function () {
-      let tx = { id: 1, status: 'unapproved', metamaskNetworkId: currentNetworkId, txParams: {} }
-      txStateManager.addTx(tx)
-      txStateManager.setTxStatusRejected(1)
-      let result = txStateManager.getTxList()
-      assert.ok(Array.isArray(result))
-      assert.equal(result.length, 1)
-      assert.equal(result[0].status, 'rejected')
-    })
-
     it('should emit a rejected event to signal the exciton of callback', (done) => {
       let tx = { id: 1, status: 'unapproved', metamaskNetworkId: currentNetworkId, txParams: {} }
       txStateManager.addTx(tx)