Fix no-constant-condition issues (#9210)

See [`no-constant-condition`](https://eslint.org/docs/rules/no-constant-condition) for more information.

This change enables `no-constant-condition` and fixes the issues raised by the rule.

.eslintrc.js

@@ -49,6 +49,7 @@ module.exports = {
     'guard-for-in': 'error',
     'implicit-arrow-linebreak': 'error',
     'no-case-declarations': 'error',
+    'no-constant-condition': 'error',
     'no-dupe-else-if': 'error',
     'no-empty': 'error',
     'no-eq-null': 'error',

test/e2e/benchmark.js

@@ -92,7 +92,7 @@ async function isWritable (directory) {
 }
 
 async function getFirstParentDirectoryThatExists (directory) {
-  while (true) {
+  for (;;) {
     try {
       await fs.access(directory, fsConstants.F_OK)
       return directory