Return keyring metadata on metamask state object

Required making the getState methods for both keyringController and metamaskController async.
They both now return promises, and the main metamask-controller.getState method is now nodeified.

Will allow the UI to render loose keys differently than persisted keys.
feature/default_network_editable
Dan Finlay 8 years ago
parent 2ab34760b0
commit a10fe6b6f4
  1. 27
      app/scripts/keyring-controller.js
  2. 7
      app/scripts/metamask-controller.js

@ -91,12 +91,15 @@ module.exports = class KeyringController extends EventEmitter {
const address = configManager.getSelectedAccount() const address = configManager.getSelectedAccount()
const wallet = configManager.getWallet() // old style vault const wallet = configManager.getWallet() // old style vault
const vault = configManager.getVault() // new style vault const vault = configManager.getVault() // new style vault
const keyrings = this.keyrings
return Promise.all(keyrings.map(this.displayForKeyring))
.then((displayKeyrings) => {
return { return {
seedWords: this.configManager.getSeedWords(), seedWords: this.configManager.getSeedWords(),
isInitialized: (!!wallet || !!vault), isInitialized: (!!wallet || !!vault),
isUnlocked: Boolean(this.password), isUnlocked: Boolean(this.password),
isDisclaimerConfirmed: this.configManager.getConfirmedDisclaimer(), // AUDIT this.configManager.getConfirmedDisclaimer(), isDisclaimerConfirmed: this.configManager.getConfirmedDisclaimer(),
unconfTxs: this.configManager.unconfirmedTxs(), unconfTxs: this.configManager.unconfirmedTxs(),
transactions: this.configManager.getTxList(), transactions: this.configManager.getTxList(),
unconfMsgs: messageManager.unconfirmedMsgs(), unconfMsgs: messageManager.unconfirmedMsgs(),
@ -108,9 +111,12 @@ module.exports = class KeyringController extends EventEmitter {
conversionDate: this.configManager.getConversionDate(), conversionDate: this.configManager.getConversionDate(),
keyringTypes: this.keyringTypes.map(krt => krt.type), keyringTypes: this.keyringTypes.map(krt => krt.type),
identities: this.identities, identities: this.identities,
keyrings: displayKeyrings,
} }
})
} }
// Create New Vault And Keychain // Create New Vault And Keychain
// @string password - The password to encrypt the vault with // @string password - The password to encrypt the vault with
// //
@ -693,7 +699,7 @@ module.exports = class KeyringController extends EventEmitter {
if (typeof password === 'string') { if (typeof password === 'string') {
this.password = password this.password = password
} }
return Promise.all(this.keyrings.map((keyring) => { return Promise.all(this.keyrings.map((keyring, i) => {
return Promise.all([keyring.type, keyring.serialize()]) return Promise.all([keyring.type, keyring.serialize()])
.then((serializedKeyringArray) => { .then((serializedKeyringArray) => {
// Label the output values on each serialized Keyring: // Label the output values on each serialized Keyring:
@ -744,6 +750,7 @@ module.exports = class KeyringController extends EventEmitter {
// On success, returns the resulting @Keyring instance. // On success, returns the resulting @Keyring instance.
restoreKeyring (serialized) { restoreKeyring (serialized) {
const { type, data } = serialized const { type, data } = serialized
const Keyring = this.getKeyringClassForType(type) const Keyring = this.getKeyringClassForType(type)
const keyring = new Keyring() const keyring = new Keyring()
return keyring.deserialize(data) return keyring.deserialize(data)
@ -816,6 +823,22 @@ module.exports = class KeyringController extends EventEmitter {
}) })
} }
// Display For Keyring
// @Keyring keyring
//
// returns Promise( @Object { type:String, accounts:Array } )
//
// Is used for adding the current keyrings to the state object.
displayForKeyring (keyring) {
return keyring.getAccounts()
.then((accounts) => {
return {
type: keyring.type,
accounts: accounts,
}
})
}
// Add Gas Buffer // Add Gas Buffer
// @string gas (as hexadecimal value) // @string gas (as hexadecimal value)
// //

@ -53,15 +53,18 @@ module.exports = class MetamaskController {
} }
getState () { getState () {
return this.keyringController.getState()
.then((keyringControllerState) => {
return extend( return extend(
this.state, this.state,
this.ethStore.getState(), this.ethStore.getState(),
this.configManager.getConfig(), this.configManager.getConfig(),
this.keyringController.getState(), keyringControllerState,
this.noticeController.getState(), { this.noticeController.getState(), {
lostAccounts: this.configManager.getLostAccounts(), lostAccounts: this.configManager.getLostAccounts(),
} }
) )
})
} }
getApi () { getApi () {
@ -69,7 +72,7 @@ module.exports = class MetamaskController {
const noticeController = this.noticeController const noticeController = this.noticeController
return { return {
getState: (cb) => { cb(null, this.getState()) }, getState: nodeify(this.getState.bind(this)),
setRpcTarget: this.setRpcTarget.bind(this), setRpcTarget: this.setRpcTarget.bind(this),
setProviderType: this.setProviderType.bind(this), setProviderType: this.setProviderType.bind(this),
useEtherscanProvider: this.useEtherscanProvider.bind(this), useEtherscanProvider: this.useEtherscanProvider.bind(this),

Loading…
Cancel
Save