Remove unnecessary assertion in e2e metrics test (#9974)

The assertion ensuring that there were at least 3 metrics received
didn't end up being useful. If this assertion fails, it doesn't explain
what segment events _were_ received.

By removing this assertion and letting the later assertions catch this
case, we at least learn which of the three expected events were
present.
feature/default_network_editable
Mark Stacey 4 years ago committed by GitHub
parent 5fb2e544d4
commit ba98edf604
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 4
      test/e2e/metrics.spec.js

@ -35,10 +35,6 @@ describe('Segment metrics', function () {
await driver.findElement(By.css('[data-testid="eth-overview-send"]')) await driver.findElement(By.css('[data-testid="eth-overview-send"]'))
assert.ok(segmentSpy.called, 'Segment should receive metrics') assert.ok(segmentSpy.called, 'Segment should receive metrics')
assert.ok(
segmentSpy.callCount >= 3,
'At least 3 segment events should be sent',
)
const firstSegmentEvent = segmentSpy.getCall(0).args[0] const firstSegmentEvent = segmentSpy.getCall(0).args[0]
assert.equal(firstSegmentEvent.name, 'Home') assert.equal(firstSegmentEvent.name, 'Home')

Loading…
Cancel
Save