Hide token transfers on ETH asset page (#8799)

Token transfers will now be hidden on the ETH asset page. Arguably
token transfers are still relevant to show on the ETH asset page
because the gas for token transfers is paid in ETH, but they weren't
being displayed in a way that highlighted this (only the token amount
was shown inline - not the gas price).

We will likely restore token transfers to the ETH asset page at a later
date, after designs have been updated to highlight their relevance to
this page.

ui/app/components/app/transaction-list/transaction-list.component.js

@@ -12,6 +12,7 @@ import * as actions from '../../../ducks/gas/gas.duck'
 import { useI18nContext } from '../../../hooks/useI18nContext'
 import TransactionListItem from '../transaction-list-item'
 import Button from '../../ui/button'
+import { TOKEN_CATEGORY_HASH } from '../../../helpers/constants/transactions'
 
 const PAGE_INCREMENT = 10
 
@@ -19,7 +20,23 @@ const getTransactionGroupRecipientAddressFilter = (recipientAddress) => {
   return ({ initialTransaction: { txParams } }) => txParams && txParams.to === recipientAddress
 }
 
-export default function TransactionList ({ tokenAddress }) {
+const tokenTransactionFilter = ({
+  initialTransaction: {
+    transactionCategory,
+  },
+}) => !TOKEN_CATEGORY_HASH[transactionCategory]
+
+
+const getFilteredTransactionGroups = (transactionGroups, hideTokenTransactions, tokenAddress) => {
+  if (hideTokenTransactions) {
+    return transactionGroups.filter(tokenTransactionFilter)
+  } else if (tokenAddress) {
+    return transactionGroups.filter(getTransactionGroupRecipientAddressFilter(tokenAddress))
+  }
+  return transactionGroups
+}
+
+export default function TransactionList ({ hideTokenTransactions, tokenAddress }) {
   const [limit, setLimit] = useState(PAGE_INCREMENT)
   const t = useI18nContext()
 
@@ -29,22 +46,12 @@ export default function TransactionList ({ tokenAddress }) {
   const { transactionTime: transactionTimeFeatureActive } = useSelector(getFeatureFlags)
 
   const pendingTransactions = useMemo(
-    () => (
+    () => getFilteredTransactionGroups(unfilteredPendingTransactions, hideTokenTransactions, tokenAddress),
-      tokenAddress && tokenAddress.startsWith('0x')
+    [hideTokenTransactions, tokenAddress, unfilteredPendingTransactions]
-        ? unfilteredPendingTransactions
-          .filter(getTransactionGroupRecipientAddressFilter(tokenAddress))
-        : unfilteredPendingTransactions
-    ),
-    [unfilteredPendingTransactions, tokenAddress]
   )
   const completedTransactions = useMemo(
-    () => (
+    () => getFilteredTransactionGroups(unfilteredCompletedTransactions, hideTokenTransactions, tokenAddress),
-      tokenAddress && tokenAddress.startsWith('0x')
+    [hideTokenTransactions, tokenAddress, unfilteredCompletedTransactions]
-        ? unfilteredCompletedTransactions
-          .filter(getTransactionGroupRecipientAddressFilter(tokenAddress))
-        : unfilteredCompletedTransactions
-    ),
-    [unfilteredCompletedTransactions, tokenAddress]
   )
 
   const { fetchGasEstimates, fetchBasicGasAndTimeEstimates } = useMemo(() => ({
@@ -122,9 +129,11 @@ export default function TransactionList ({ tokenAddress }) {
 }
 
 TransactionList.propTypes = {
+  hideTokenTransactions: PropTypes.bool,
   tokenAddress: PropTypes.string,
 }
 
 TransactionList.defaultProps = {
+  hideTokenTransactions: false,
   tokenAddress: undefined,
 }

ui/app/pages/asset/components/native-asset.js

@@ -22,7 +22,7 @@ export default function NativeAsset ({ nativeCurrency }) {
         onBack={() => history.push(DEFAULT_ROUTE)}
       />
       <EthOverview className="asset__overview" />
-      <TransactionList />
+      <TransactionList hideTokenTransactions />
     </>
   )
 }