Merge pull request #5000 from MetaMask/contract-method-conf-sim-failure

Show error while allowing confirmation of tx where simulation fails
6 years ago · d4af5b7bec
parent 1ae668fa5e 973325a6c4
commit d4af5b7bec
2 changed files with 2 additions and 2 deletions
--- a/ui/app/components/pages/confirm-transaction-base/confirm-transaction-base.component.js
+++ b/ui/app/components/pages/confirm-transaction-base/confirm-transaction-base.component.js
@ -124,7 +124,7 @@ export default class ConfirmTransactionBase extends Component {

    if (simulationFails) {
      return {
-        valid: false,
+        valid: true,
        errorKey: TRANSACTION_ERROR_KEY,
      }
    }
--- a/ui/app/constants/error-keys.js
+++ b/ui/app/constants/error-keys.js
@ -1,3 +1,3 @@
 export const INSUFFICIENT_FUNDS_ERROR_KEY = 'insufficientFunds'
 export const GAS_LIMIT_TOO_LOW_ERROR_KEY = 'gasLimitTooLow'
-export const TRANSACTION_ERROR = 'transactionError'
+export const TRANSACTION_ERROR_KEY = 'transactionError'