Merge pull request #4602 from MetaMask/notice-controller-fix

notice controller - properly show new notices for non-new users

app/scripts/notice-controller.js

@@ -13,12 +13,15 @@ module.exports = class NoticeController extends EventEmitter {
     this.firstVersion = opts.firstVersion
     this.version = opts.version
     const initState = extend({
-      noticesList: this._filterNotices(hardCodedNotices),
+      noticesList: [],
     }, opts.initState)
     this.store = new ObservableStore(initState)
+    // setup memStore
     this.memStore = new ObservableStore({})
     this.store.subscribe(() => this._updateMemstore())
     this._updateMemstore()
+    // pull in latest notices
+    this.updateNoticesList()
   }
 
   getNoticesList () {
@@ -84,8 +87,8 @@ module.exports = class NoticeController extends EventEmitter {
   }
 
   async _retrieveNoticeData () {
-    // Placeholder for the API.
+    // Placeholder for remote notice API.
-    return []
+    return hardCodedNotices
   }
 
   _updateMemstore () {