Use async/await for getRestrictedMethods (#9099)

feature/default_network_editable
Whymarrh Whitby 4 years ago committed by GitHub
parent d990de4a0c
commit e0cc84bbfa
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 48
      app/scripts/controllers/permissions/restrictedMethods.js

@ -1,34 +1,30 @@
export default function getRestrictedMethods ({ getIdentities, getKeyringAccounts }) { export default function getRestrictedMethods ({ getIdentities, getKeyringAccounts }) {
return { return {
'eth_accounts': { 'eth_accounts': {
method: (_, res, __, end) => { method: async (_, res, __, end) => {
getKeyringAccounts() try {
.then((accounts) => { const accounts = await getKeyringAccounts()
const identities = getIdentities() const identities = getIdentities()
res.result = accounts res.result = accounts.sort((firstAddress, secondAddress) => {
.sort((firstAddress, secondAddress) => { if (!identities[firstAddress]) {
if (!identities[firstAddress]) { throw new Error(`Missing identity for address ${firstAddress}`)
throw new Error(`Missing identity for address ${firstAddress}`) } else if (!identities[secondAddress]) {
} else if (!identities[secondAddress]) { throw new Error(`Missing identity for address ${secondAddress}`)
throw new Error(`Missing identity for address ${secondAddress}`) } else if (identities[firstAddress].lastSelected === identities[secondAddress].lastSelected) {
} else if (identities[firstAddress].lastSelected === identities[secondAddress].lastSelected) { return 0
return 0 } else if (identities[firstAddress].lastSelected === undefined) {
} else if (identities[firstAddress].lastSelected === undefined) { return 1
return 1 } else if (identities[secondAddress].lastSelected === undefined) {
} else if (identities[secondAddress].lastSelected === undefined) { return -1
return -1 }
}
return identities[secondAddress].lastSelected - identities[firstAddress].lastSelected return identities[secondAddress].lastSelected - identities[firstAddress].lastSelected
})
end()
}) })
.catch( end()
(err) => { } catch (err) {
res.error = err res.error = err
end(err) end(err)
}, }
)
}, },
}, },
} }

Loading…
Cancel
Save