Improve reliability of beta e2e tests by using webdriver apis to wait for certain dom elements.

feature/default_network_editable
Dan 7 years ago
parent 1d8f257832
commit e293233c5e
  1. 5
      test/e2e/beta/from-import-beta-ui.spec.js
  2. 12
      test/e2e/beta/metamask-beta-ui.spec.js

@ -167,8 +167,7 @@ describe('Using MetaMask with an existing account', function () {
describe('Show account information', () => { describe('Show account information', () => {
it('shows the correct account address', async () => { it('shows the correct account address', async () => {
const detailsButton = await findElement(driver, By.xpath(`//button[contains(text(), 'Details')]`)) await driver.findElement(By.css('.wallet-view__details-button')).click()
detailsButton.click()
await driver.findElement(By.css('.qr-wrapper')).isDisplayed() await driver.findElement(By.css('.qr-wrapper')).isDisplayed()
await delay(regularDelayMs) await delay(regularDelayMs)
@ -264,8 +263,10 @@ describe('Using MetaMask with an existing account', function () {
await configureGas.click() await configureGas.click()
await delay(regularDelayMs) await delay(regularDelayMs)
const gasModal = await driver.findElement(By.css('span .modal'))
const save = await findElement(driver, By.xpath(`//button[contains(text(), 'Save')]`)) const save = await findElement(driver, By.xpath(`//button[contains(text(), 'Save')]`))
await save.click() await save.click()
await driver.wait(until.stalenessOf(gasModal))
await delay(regularDelayMs) await delay(regularDelayMs)
// Continue to next screen // Continue to next screen

@ -136,6 +136,7 @@ describe('MetaMask', function () {
await driver.executeScript('arguments[0].scrollIntoView(true)', bottomOfTos) await driver.executeScript('arguments[0].scrollIntoView(true)', bottomOfTos)
await delay(regularDelayMs) await delay(regularDelayMs)
const acceptTos = await findElement(driver, By.css('.tou button')) const acceptTos = await findElement(driver, By.css('.tou button'))
driver.wait(until.elementIsEnabled(acceptTos))
await acceptTos.click() await acceptTos.click()
await delay(regularDelayMs) await delay(regularDelayMs)
}) })
@ -160,8 +161,9 @@ describe('MetaMask', function () {
let seedPhrase let seedPhrase
it('reveals the seed phrase', async () => { it('reveals the seed phrase', async () => {
await driver.wait(until.elementIsVisible(By.css('.backup-phrase__reveal-button'))) const byRevealButton = By.css('.backup-phrase__secret-blocker .backup-phrase__reveal-button')
const revealSeedPhraseButton = await findElement(driver, By.css('.backup-phrase__reveal-button'), 10000) await driver.wait(until.elementLocated(byRevealButton, 10000))
const revealSeedPhraseButton = await findElement(driver, byRevealButton, 10000)
await revealSeedPhraseButton.click() await revealSeedPhraseButton.click()
await delay(regularDelayMs) await delay(regularDelayMs)
@ -245,8 +247,12 @@ describe('MetaMask', function () {
await driver.findElement(By.css('.qr-wrapper')).isDisplayed() await driver.findElement(By.css('.qr-wrapper')).isDisplayed()
await delay(regularDelayMs) await delay(regularDelayMs)
let accountModal = await driver.findElement(By.css('span .modal'))
await driver.executeScript("document.querySelector('.account-modal-close').click()") await driver.executeScript("document.querySelector('.account-modal-close').click()")
await delay(regularDelayMs * 4)
await driver.wait(until.stalenessOf(accountModal))
await delay(regularDelayMs)
}) })
}) })

Loading…
Cancel
Save