Update build system lockdown parameter (#12556)

* Update build system lockdown parameter

* Add @reduxjs/toolkit patch

* Fix Mozilla lint syntax error

* Standardize a thing

* Remove redundant check for globalThis

app/scripts/lockdown-more.js

@@ -83,7 +83,7 @@ try {
   })();
 } catch (error) {
   console.error('Protecting intrinsics failed:', error);
-  if (globalThis?.sentry.captureException) {
+  if (globalThis.sentry && globalThis.sentry.captureException) {
     globalThis.sentry.captureException(
       new Error(`Protecting intrinsics failed: ${error.message}`),
     );

development/build/README.md

@@ -48,10 +48,10 @@ Options:
                       Defaults to `false` if the entry task is `dev` or
                       `testDev`, and `true` otherwise.
                                                    [boolean] [default: <varies>]
-  --omit-lockdown     Whether to omit SES lockdown files from the extension
+  --lockdown          Whether to include SES lockdown files in the extension
-                      bundle. Useful when linking dependencies that are
+                      bundle. Setting this to `false` is useful e.g. when
-                      incompatible with lockdown.
+                      linking dependencies that are incompatible with lockdown.
-                                                      [boolean] [default: false]
+                                                       [boolean] [default: true]
   --skip-stats        Whether to refrain from logging build progress. Mostly
                       used internally.
                                                       [boolean] [default: false]

development/build/index.js

@@ -137,21 +137,21 @@ function parseArgv() {
   const NamedArgs = {
     BuildType: 'build-type',
     LintFenceFiles: 'lint-fence-files',
-    OmitLockdown: 'omit-lockdown',
+    Lockdown: 'lockdown',
     SkipStats: 'skip-stats',
   };
 
   const argv = minimist(process.argv.slice(2), {
     boolean: [
       NamedArgs.LintFenceFiles,
-      NamedArgs.OmitLockdown,
+      NamedArgs.Lockdown,
       NamedArgs.SkipStats,
     ],
     string: [NamedArgs.BuildType],
     default: {
       [NamedArgs.BuildType]: BuildType.main,
       [NamedArgs.LintFenceFiles]: true,
-      [NamedArgs.OmitLockdown]: false,
+      [NamedArgs.Lockdown]: true,
       [NamedArgs.SkipStats]: false,
     },
   });
@@ -183,7 +183,7 @@ function parseArgv() {
     buildType,
     entryTask,
     isLavaMoat: process.argv[0].includes('lavamoat'),
-    shouldIncludeLockdown: argv[NamedArgs.OmitLockdown],
+    shouldIncludeLockdown: argv[NamedArgs.Lockdown],
     shouldLintFenceFiles,
     skipStats: argv[NamedArgs.SkipStats],
   };