* Ensure the seed phrase reminder is displayed with precedence over the network deprecation message
* Prevent error when attempting to get balance before account info has been fully sete
* Fix implementation of seedphrase-reminder-display-fix
* Prioritize seed phrase reminder notification over portfolio tooltip, and that tooltip over testnet deprecation
* Don't display DetectedTokenSelectionPopover if there are no detected tokens
* adding length greater than 0 check as a 0 is displayed at the end of teh page previously
Co-authored-by: Niranjana Binoy <43930900+NiranjanaBinoy@users.noreply.github.com>
Co-authored-by: ryanml <ryanlanese@gmail.com>
* Ensure New Network Info popup doesn't show when switching to testnets
* Update ui/pages/routes/routes.component.js
Co-authored-by: Alex Donesky <adonesky@gmail.com>
* Fix typo
* Fix isTestNet property name casing
Co-authored-by: Alex Donesky <adonesky@gmail.com>
* 10.19.0 Changelog - first draft
* Remove non-changelog PRs
* Cleanup by removing uncategorized commits that should not go to the Changelog
* Re-write commit descriptions
* Re-phrasing more descriptions
* Add missing spaces and fix URLs for gridplus
* Flask description updated for snap_getBip44Entropy
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
* Flask description updated for snap_getBip32Entropy
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
* Flask description updated for Dapp triggered Snap updates
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
* Flask description updated for fix permissions
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
* Move to the proper categories Flask PRs
* Remove Snap package update as has no user-facing changes
* Fix Changelog
* Add space after Unreleased
* Add Swaps fix for redirect to Activity tab
* Last PR entries added
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
The portfolio URL added in #15407 was meant to be configurable via
environment variable or the `.metamaskrc` file, but that configuration
was broken. Instead the default value was always used.
That configuration has been fixed. The portfolio URL can be set either
by environment variable or configuration file.
Resolve an inconsistency between Chrome and Firefox with how the
contentscript runs in an iframe.
This should have no user-facing impact, it's just meant as a safeguard
in case something unintentionally gets included in the contentscript.
* using the aggregators from tokenList instead of detectedToken to avoid conflicts between static and dynamic list
* removing aggregator from the detectTokens object List
* Show 3box deprecation message in whats new
Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
* Add . after message
Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
* Change deprecation notification message and remove date
Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
* fix issue wherein signing a message sometimes doesn't allow you to scroll all the way to the bottom
done in a way to make it as mergeable as possible
* Fixing length-zero-no-unit lint issue
Co-authored-by: ryanml <ryanlanese@gmail.com>
* warning for deprecated Rinkeby, Ropsten and Kovan test networks
* modified DeprecatedTestNetworks function
* added getCompletedOnboarding
* removed warning message from MetaMask Notification page
* updated deprecatedTestNetworksMsg
* origin/develop: (228 commits)
Update `object.values` patch (#15692)
chore: Adjust trailing whitespace (#15636)
updated casing in import Token for spanish (#15687)
development scripts: add node shebang; mark as executable (#15655)
Created a new contract details modal (#15549)
Token allowance improvements feature flag (#15646)
Updated origin pill component to match the new design (#15603)
Update `depcheck` to latest version (#15690)
Replace `lavamoat-runtime.js` patch (#15682)
upgrade jest (#15642)
Fix Sentry deduplication of events that were never sent (#15677)
Jest configuration fix (#15673)
Header component for transaction confirmation screens (#15614)
New network info popup (#13319)
Consolidating Zendesk URLs in to constants file (#15669)
Created review spending cap component (#15633)
Fix Sentry in LavaMoat contexts (#15672)
Fix LavaMoat policy generation script (#15668)
Using formatIconUrlWithProxy to get the iconUrl proxy of swap token (#15562)
Migrate app constants to typescript (#15611)
...
The package `object.values` was updated in #15293 but we forgot to
update the patch. This was resulting in a warning on the command line
upon each install.
The patch was still applied successfully, so no changes were needed
other than updating the version.
* Version v10.18.4
* Fix default currency symbol for `wallet_addEthereumChain` + improve warnings for data that doesn't match our validation expectations (#15201)
* set more appropriate default for ticker symbol when wallet_addEthereumChain is called
* throw error to dapp when site suggests network with same chainId but different ticker symbol from already added network, instead of showing error and disabled notification to user
* Fix Provider Tracking Metrics (#15082)
* fix filetype audit (#15334)
* Remove decentralized 4byte function signature registry since it contains incorrect signatures and we can't algorithmically check for best option when 4byte.directory is down (#15300)
* remove decentralized 4byte function signature registry since it is griefed and we can't algorithmically check for best option when 4byte is down
* add migration
* remove nock of on chain registry call in getMethodDataAsync test
* remove audit exclusion (#15346)
* Updates `eth-lattice-keyring` to v0.10.0 (#15261)
This is mainly associated with an update in GridPlus SDK and enables
better strategies for fetching calldata decoder data.
`eth-lattice-keyring` changes:
GridPlus/eth-lattice-keyring@v0.7.3...v0.10.0
`gridplus-sdk` changes (which includes a codebase rewrite):
GridPlus/gridplus-sdk@v1.2.3...v2.2.2
* Fix 'block link explorer on custom networks' (#13870)
* Created a logic for the 'Add a block explorer URL'
Removed unused message
Message logic rollback
Modified history push operation
WIP: Pushing before rebasing
Applied requested changes
Removed unintenionally added code
* Lint fix
* Metrics fixed
* Stop injecting provider on docs.google.com (#15459)
* Fix setting of gasPrice when on non-eip 1559 networks (#15628)
* Fix setting of gasPrice when on non-eip 1559 networks
* Fix unit tests
* Fix logic
* Update ui/ducks/send/send.test.js
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
* [GridPlus] Bumps `eth-lattice-keyring` to v0.11.0 (#15490)
* [GridPlus] Bumps `gridplus-sdk` to v2.2.4 (#15561)
* remove exclusions for mismatched object jsdoc type casing (#15351)
* Improve `tokenId` parsing and clean up `useAssetDetails` hook (#15304)
* Fix state creation in setupSentryGetStateGlobal (#15635)
* filter breadcrumbs for improved clarity while debugging sentry errors (#15639)
* Update v10.18.4 changelog (#15645)
* Auto generated changelog
* Update 10.18.4 changelog
* Run lavamoat:auto
* Call metrics event for wallet type selection at the right time (#15591)
* Fix Sentry in LavaMoat contexts (#15672)
Our Sentry setup relies upon application state, but it wasn't able to
access it in LavaMoat builds because it's running in a separate
Compartment.
A patch has been introduced to the LavaMoat runtime to allow the root
Compartment to mutate the `rootGlobals` object, which is accessible
from outside the compartment as well. This lets us expose application
state to our Sentry integration.
* Fix Sentry deduplication of events that were never sent (#15677)
The Sentry `Dedupe` integration has been filtering out our events, even
when they were never sent due to our `beforeSend` handler. It was
wrongly identifying them as duplicates because it has no knowledge of
`beforeSend` or whether they were actually sent or not.
To resolve this, the filtering we were doing in `beforeSend` has been
moved to a Sentry integration. This integration is installed ahead of
the `Dedupe` integration, so `Dedupe` should never find out about any
events that we filter out, and thus will never consider them as sent
when they were not.
* Replace `lavamoat-runtime.js` patch (#15682)
A patch made in #15672 was found to be unnecessary. Instead of setting
a `rootGlobals` object upon construction of the root compartment, we
are now creating a `sentryHooks` object in the initial top-level
compartment. I hadn't realized at the time that the root compartment
would inherit all properties of the initial compartment `globalThis`.
This accomplishes the same goals as #15672 except without needing a
patch.
* Update v10.18.4 changelog
* Fix lint issues
* Update yarn.lock
* Update `depcheck` to latest version (#15690)
`depcheck` has been updated to the latest version. This version pins
`@babel/parser` to v7.16.4 because of unresolved bugs in v7.16.5 that
result in `depcheck` failing to parse TypeScript files correctly.
We had a Yarn resolution in place to ensure `@babel/parser@7.16.4` was
being used already. That resolution is no longer needed so it has been
removed. This should resove the issue the dev team has been seeing
lately where `yarn` and `yarn-deduplicate` disagree about the state the
lockfile should be in.
* Update yarn.lock
* Update LavaMoat policy
* deduplicate
* Update LavaMoat build policy
Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
Co-authored-by: Alex Donesky <adonesky@gmail.com>
Co-authored-by: Brad Decker <bhdecker84@gmail.com>
Co-authored-by: Alex Miller <asmiller1989@gmail.com>
Co-authored-by: Filip Sekulic <filip.sekulic@consensys.net>
Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com>
Co-authored-by: Dan J Miller <danjm.com@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Co-authored-by: seaona <54408225+seaona@users.noreply.github.com>
Co-authored-by: seaona <mariona@gmx.es>
Co-authored-by: PeterYinusa <peter.yinusa@consensys.net>
Dan J Miller
seaona
Mark Stacey
Matthew Epps
PeterYinusa
Niranjana Binoy
Olusegun Akintayo
ryanml
Taylor Monahan
Adnan Sahovic
seaona
VSaric
Jyoti Puri
Lorenz
Thomas Huang
Zbyszek Tenerowicz
Frederik Bolding
Alex Miller
mirjanaKukic
legobeat
MetaMask Bot
Nidhi Kumari