Merge pull request #985 from ConsenSys/maintenance/cleanup_dynamic_load

Remove unnecessary variable from dynamic loading function

mythril/laser/ethereum/call.py

@@ -136,7 +136,7 @@ def get_callee_account(
     log.debug("Attempting to load dependency")
 
     try:
-        code = dynamic_loader.dynld(environment.active_account.address, callee_address)
+        code = dynamic_loader.dynld(callee_address)
     except ValueError as error:
         log.debug("Unable to execute dynamic loader because: {}".format(str(error)))
         raise error

mythril/laser/ethereum/instructions.py

@@ -1097,7 +1097,7 @@ class Instruction:
             return [global_state]
 
         try:
-            code = self.dynamic_loader.dynld(environment.active_account.address, addr)
+            code = self.dynamic_loader.dynld(addr)
         except (ValueError, AttributeError) as e:
             log.debug("error accessing contract storage due to: " + str(e))
             state.stack.append(global_state.new_bitvec("extcodesize_" + str(addr), 256))

mythril/support/loader.py

@@ -58,17 +58,15 @@ class DynLoader:
 
         return data
 
-    def dynld(self, contract_address, dependency_address):
+    def dynld(self, dependency_address):
         """
-
-        :param contract_address:
         :param dependency_address:
         :return:
         """
         if not self.contract_loading:
             raise ValueError("Cannot load contract when contract_loading flag is false")
 
-        log.debug("Dynld at contract " + contract_address + ": " + dependency_address)
+        log.debug("Dynld at contract " + dependency_address)
 
         # Ensure that dependency_address is the correct length, with 0s prepended as needed.
         dependency_address = (