Apply black style formatting

pull/617/head
Dominik Muhs 6 years ago
parent c814c685d9
commit e0cd08a58b
  1. 2
      mythril/__init__.py
  2. 271
      mythril/analysis/callgraph.py
  3. 55
      mythril/analysis/modules/delegatecall.py
  4. 100
      mythril/analysis/modules/dependence_on_predictable_vars.py
  5. 30
      mythril/analysis/modules/deprecated_ops.py
  6. 74
      mythril/analysis/modules/ether_send.py
  7. 47
      mythril/analysis/modules/exceptions.py
  8. 110
      mythril/analysis/modules/external_calls.py
  9. 149
      mythril/analysis/modules/integer.py
  10. 36
      mythril/analysis/modules/multiple_sends.py
  11. 33
      mythril/analysis/modules/suicide.py
  12. 35
      mythril/analysis/modules/transaction_order_dependence.py
  13. 54
      mythril/analysis/modules/unchecked_retval.py
  14. 16
      mythril/analysis/ops.py
  15. 58
      mythril/analysis/report.py
  16. 3
      mythril/analysis/solver.py
  17. 48
      mythril/analysis/swc_data.py
  18. 138
      mythril/analysis/symbolic.py
  19. 143
      mythril/analysis/traceexplore.py
  20. 11
      mythril/disassembler/disassembly.py
  21. 43
      mythril/ether/asm.py
  22. 33
      mythril/ether/ethcontract.py
  23. 25
      mythril/ether/evm.py
  24. 51
      mythril/ether/soliditycontract.py
  25. 15
      mythril/ether/util.py
  26. 39
      mythril/ethereum/interface/leveldb/accountindexing.py
  27. 38
      mythril/ethereum/interface/leveldb/client.py
  28. 50
      mythril/ethereum/interface/leveldb/state.py
  29. 25
      mythril/ethereum/interface/rpc/base_client.py
  30. 34
      mythril/ethereum/interface/rpc/client.py
  31. 12
      mythril/ethereum/interface/rpc/constants.py
  32. 9
      mythril/ethereum/interface/rpc/utils.py
  33. 375
      mythril/interfaces/cli.py
  34. 57
      mythril/laser/ethereum/call.py
  35. 21
      mythril/laser/ethereum/cfg.py
  36. 657
      mythril/laser/ethereum/instructions.py
  37. 1
      mythril/laser/ethereum/keccak.py
  38. 14
      mythril/laser/ethereum/natives.py
  39. 119
      mythril/laser/ethereum/state.py
  40. 2
      mythril/laser/ethereum/strategy/__init__.py
  41. 16
      mythril/laser/ethereum/strategy/basic.py
  42. 172
      mythril/laser/ethereum/svm.py
  43. 135
      mythril/laser/ethereum/taint_analysis.py
  44. 5
      mythril/laser/ethereum/transaction/__init__.py
  45. 38
      mythril/laser/ethereum/transaction/concolic.py
  46. 28
      mythril/laser/ethereum/transaction/symbolic.py
  47. 117
      mythril/laser/ethereum/transaction/transaction_models.py
  48. 15
      mythril/laser/ethereum/util.py
  49. 333
      mythril/mythril.py
  50. 15
      mythril/support/loader.py
  51. 104
      mythril/support/signatures.py
  52. 84
      mythril/support/truffle.py
  53. 2
      mythril/version.py
  54. 137
      setup.py
  55. 16
      tests/__init__.py
  56. 90
      tests/analysis/test_delegatecall.py
  57. 40
      tests/cmd_line_test.py
  58. 5
      tests/disassembler_test.py
  59. 28
      tests/ethcontract_test.py
  60. 20
      tests/graph_test.py
  61. 2
      tests/instructions/codecopy_test.py
  62. 55
      tests/laser/evm_testsuite/evm_test.py
  63. 6
      tests/laser/state/mstack_test.py
  64. 33
      tests/laser/state/mstate_test.py
  65. 6
      tests/laser/state/storage_test.py
  66. 17
      tests/laser/test_transaction.py
  67. 11
      tests/laser/transaction/create_transaction_test.py
  68. 19
      tests/laser/transaction/symbolic_test.py
  69. 64
      tests/native_test.py
  70. 68
      tests/report_test.py
  71. 44
      tests/rpc_test.py
  72. 3
      tests/solidity_contract_test.py
  73. 51
      tests/svm_test.py
  74. 3
      tests/taint_mutate_stack_test.py
  75. 5
      tests/taint_result_test.py
  76. 14
      tests/taint_runner_test.py
  77. 9
      tests/test_cli_opts.py
  78. 6
      tests/testdata/compile.py

@ -1,6 +1,6 @@
# We use RsT document formatting in docstring. For example :param to mark parameters. # We use RsT document formatting in docstring. For example :param to mark parameters.
# See PEP 287 # See PEP 287
__docformat__ = 'restructuredtext' __docformat__ = "restructuredtext"
# Accept mythril.VERSION to get mythril's current version number # Accept mythril.VERSION to get mythril's current version number
from .version import VERSION # NOQA from .version import VERSION # NOQA

@ -5,87 +5,119 @@ from mythril.laser.ethereum.svm import NodeFlags
import z3 import z3
default_opts = { default_opts = {
'autoResize': True, "autoResize": True,
'height': '100%', "height": "100%",
'width': '100%', "width": "100%",
'manipulation': False, "manipulation": False,
'layout': { "layout": {
'improvedLayout': True, "improvedLayout": True,
'hierarchical': { "hierarchical": {
'enabled': True, "enabled": True,
'levelSeparation': 450, "levelSeparation": 450,
'nodeSpacing': 200, "nodeSpacing": 200,
'treeSpacing': 100, "treeSpacing": 100,
'blockShifting': True, "blockShifting": True,
'edgeMinimization': True, "edgeMinimization": True,
'parentCentralization': False, "parentCentralization": False,
'direction': 'LR', "direction": "LR",
'sortMethod': 'directed' "sortMethod": "directed",
} },
}, },
'nodes': { "nodes": {
'color': '#000000', "color": "#000000",
'borderWidth': 1, "borderWidth": 1,
'borderWidthSelected': 2, "borderWidthSelected": 2,
'chosen': True, "chosen": True,
'shape': 'box', "shape": "box",
'font': {'align': 'left', 'color': '#FFFFFF'}, "font": {"align": "left", "color": "#FFFFFF"},
}, },
'edges': { "edges": {
'font': { "font": {
'color': '#FFFFFF', "color": "#FFFFFF",
'face': 'arial', "face": "arial",
'background': 'none', "background": "none",
'strokeWidth': 0, "strokeWidth": 0,
'strokeColor': '#ffffff', "strokeColor": "#ffffff",
'align': 'horizontal', "align": "horizontal",
'multi': False, "multi": False,
'vadjust': 0, "vadjust": 0,
} }
}, },
'physics': {'enabled': False} "physics": {"enabled": False},
} }
phrack_opts = { phrack_opts = {
'nodes': { "nodes": {
'color': '#000000', "color": "#000000",
'borderWidth': 1, "borderWidth": 1,
'borderWidthSelected': 1, "borderWidthSelected": 1,
'shapeProperties': { "shapeProperties": {"borderDashes": False, "borderRadius": 0},
'borderDashes': False, "chosen": True,
'borderRadius': 0, "shape": "box",
}, "font": {"face": "courier new", "align": "left", "color": "#000000"},
'chosen': True,
'shape': 'box',
'font': {'face': 'courier new', 'align': 'left', 'color': '#000000'},
}, },
'edges': { "edges": {
'font': { "font": {
'color': '#000000', "color": "#000000",
'face': 'courier new', "face": "courier new",
'background': 'none', "background": "none",
'strokeWidth': 0, "strokeWidth": 0,
'strokeColor': '#ffffff', "strokeColor": "#ffffff",
'align': 'horizontal', "align": "horizontal",
'multi': False, "multi": False,
'vadjust': 0, "vadjust": 0,
} }
} },
} }
default_colors = [ default_colors = [
{'border': '#26996f', 'background': '#2f7e5b', 'highlight': {'border': '#26996f', 'background': '#28a16f'}}, {
{'border': '#9e42b3', 'background': '#842899', 'highlight': {'border': '#9e42b3', 'background': '#933da6'}}, "border": "#26996f",
{'border': '#b82323', 'background': '#991d1d', 'highlight': {'border': '#b82323', 'background': '#a61f1f'}}, "background": "#2f7e5b",
{'border': '#4753bf', 'background': '#3b46a1', 'highlight': {'border': '#4753bf', 'background': '#424db3'}}, "highlight": {"border": "#26996f", "background": "#28a16f"},
{'border': '#26996f', 'background': '#2f7e5b', 'highlight': {'border': '#26996f', 'background': '#28a16f'}}, },
{'border': '#9e42b3', 'background': '#842899', 'highlight': {'border': '#9e42b3', 'background': '#933da6'}}, {
{'border': '#b82323', 'background': '#991d1d', 'highlight': {'border': '#b82323', 'background': '#a61f1f'}}, "border": "#9e42b3",
{'border': '#4753bf', 'background': '#3b46a1', 'highlight': {'border': '#4753bf', 'background': '#424db3'}}, "background": "#842899",
"highlight": {"border": "#9e42b3", "background": "#933da6"},
},
{
"border": "#b82323",
"background": "#991d1d",
"highlight": {"border": "#b82323", "background": "#a61f1f"},
},
{
"border": "#4753bf",
"background": "#3b46a1",
"highlight": {"border": "#4753bf", "background": "#424db3"},
},
{
"border": "#26996f",
"background": "#2f7e5b",
"highlight": {"border": "#26996f", "background": "#28a16f"},
},
{
"border": "#9e42b3",
"background": "#842899",
"highlight": {"border": "#9e42b3", "background": "#933da6"},
},
{
"border": "#b82323",
"background": "#991d1d",
"highlight": {"border": "#b82323", "background": "#a61f1f"},
},
{
"border": "#4753bf",
"background": "#3b46a1",
"highlight": {"border": "#4753bf", "background": "#424db3"},
},
] ]
phrack_color = {'border': '#000000', 'background': '#ffffff', phrack_color = {
'highlight': {'border': '#000000', 'background': '#ffffff'}} "border": "#000000",
"background": "#ffffff",
"highlight": {"border": "#000000", "background": "#ffffff"},
}
def extract_nodes(statespace, color_map): def extract_nodes(statespace, color_map):
@ -95,28 +127,43 @@ def extract_nodes(statespace, color_map):
instructions = [state.get_current_instruction() for state in node.states] instructions = [state.get_current_instruction() for state in node.states]
code_split = [] code_split = []
for instruction in instructions: for instruction in instructions:
if instruction['opcode'].startswith("PUSH"): if instruction["opcode"].startswith("PUSH"):
code_line = "%d %s %s" % (instruction['address'], instruction['opcode'], instruction['argument']) code_line = "%d %s %s" % (
elif instruction['opcode'].startswith("JUMPDEST") and NodeFlags.FUNC_ENTRY in node.flags and instruction['address'] == node.start_addr: instruction["address"],
instruction["opcode"],
instruction["argument"],
)
elif (
instruction["opcode"].startswith("JUMPDEST")
and NodeFlags.FUNC_ENTRY in node.flags
and instruction["address"] == node.start_addr
):
code_line = node.function_name code_line = node.function_name
else: else:
code_line = "%d %s" % (instruction['address'], instruction['opcode']) code_line = "%d %s" % (instruction["address"], instruction["opcode"])
code_line = re.sub("([0-9a-f]{8})[0-9a-f]+", lambda m: m.group(1) + "(...)", code_line) code_line = re.sub(
"([0-9a-f]{8})[0-9a-f]+", lambda m: m.group(1) + "(...)", code_line
)
code_split.append(code_line) code_split.append(code_line)
truncated_code = '\n'.join(code_split) if (len(code_split) < 7) \ truncated_code = (
else '\n'.join(code_split[:6]) + "\n(click to expand +)" "\n".join(code_split)
if (len(code_split) < 7)
nodes.append({ else "\n".join(code_split[:6]) + "\n(click to expand +)"
'id': str(node_key), )
'color': color_map[node.get_cfg_dict()['contract_name']],
'size': 150, nodes.append(
'fullLabel': '\n'.join(code_split), {
'label': truncated_code, "id": str(node_key),
'truncLabel': truncated_code, "color": color_map[node.get_cfg_dict()["contract_name"]],
'isExpanded': False "size": 150,
}) "fullLabel": "\n".join(code_split),
"label": truncated_code,
"truncLabel": truncated_code,
"isExpanded": False,
}
)
return nodes return nodes
@ -131,21 +178,33 @@ def extract_edges(statespace):
except z3.Z3Exception: except z3.Z3Exception:
label = str(edge.condition).replace("\n", "") label = str(edge.condition).replace("\n", "")
label = re.sub(r'([^_])([\d]{2}\d+)', lambda m: m.group(1) + hex(int(m.group(2))), label) label = re.sub(
r"([^_])([\d]{2}\d+)", lambda m: m.group(1) + hex(int(m.group(2))), label
edges.append({ )
'from': str(edge.as_dict['from']),
'to': str(edge.as_dict['to']), edges.append(
'arrows': 'to', {
'label': label, "from": str(edge.as_dict["from"]),
'smooth': {'type': 'cubicBezier'} "to": str(edge.as_dict["to"]),
}) "arrows": "to",
"label": label,
"smooth": {"type": "cubicBezier"},
}
)
return edges return edges
def generate_graph(statespace, title="Mythril / Ethereum LASER Symbolic VM", physics=False, phrackify=False): def generate_graph(
env = Environment(loader=PackageLoader('mythril.analysis'), autoescape=select_autoescape(['html', 'xml'])) statespace,
template = env.get_template('callgraph.html') title="Mythril / Ethereum LASER Symbolic VM",
physics=False,
phrackify=False,
):
env = Environment(
loader=PackageLoader("mythril.analysis"),
autoescape=select_autoescape(["html", "xml"]),
)
template = env.get_template("callgraph.html")
graph_opts = default_opts graph_opts = default_opts
accounts = statespace.accounts accounts = statespace.accounts
@ -154,13 +213,17 @@ def generate_graph(statespace, title="Mythril / Ethereum LASER Symbolic VM", phy
color_map = {accounts[k].contract_name: phrack_color for k in accounts} color_map = {accounts[k].contract_name: phrack_color for k in accounts}
graph_opts.update(phrack_opts) graph_opts.update(phrack_opts)
else: else:
color_map = {accounts[k].contract_name: default_colors[i % len(default_colors)] for i, k in enumerate(accounts)} color_map = {
accounts[k].contract_name: default_colors[i % len(default_colors)]
for i, k in enumerate(accounts)
}
graph_opts['physics']['enabled'] = physics graph_opts["physics"]["enabled"] = physics
return template.render(title=title, return template.render(
nodes=extract_nodes(statespace, color_map), title=title,
edges=extract_edges(statespace), nodes=extract_nodes(statespace, color_map),
phrackify=phrackify, edges=extract_edges(statespace),
opts=graph_opts phrackify=phrackify,
) opts=graph_opts,
)

@ -5,11 +5,11 @@ from mythril.analysis.report import Issue
import logging import logging
''' """
MODULE DESCRIPTION: MODULE DESCRIPTION:
Check for invocations of delegatecall(msg.data) in the fallback function. Check for invocations of delegatecall(msg.data) in the fallback function.
''' """
def execute(statespace): def execute(statespace):
@ -28,7 +28,7 @@ def execute(statespace):
continue continue
state = call.state state = call.state
address = state.get_current_instruction()['address'] address = state.get_current_instruction()["address"]
meminstart = get_variable(state.mstate.stack[-3]) meminstart = get_variable(state.mstate.stack[-3])
if meminstart.type == VarType.CONCRETE: if meminstart.type == VarType.CONCRETE:
@ -41,17 +41,23 @@ def execute(statespace):
def _concrete_call(call, state, address, meminstart): def _concrete_call(call, state, address, meminstart):
if not re.search(r'calldata.*_0', str(state.mstate.memory[meminstart.val])): if not re.search(r"calldata.*_0", str(state.mstate.memory[meminstart.val])):
return [] return []
issue = Issue(contract=call.node.contract_name, function=call.node.function_name, address=address, issue = Issue(
swc_id=DELEGATECALL_TO_UNTRUSTED_CONTRACT, title="Call data forwarded with delegatecall()", contract=call.node.contract_name,
_type="Informational") function=call.node.function_name,
address=address,
issue.description = \ swc_id=DELEGATECALL_TO_UNTRUSTED_CONTRACT,
"This contract forwards its call data via DELEGATECALL in its fallback function. " \ title="Call data forwarded with delegatecall()",
"This means that any function in the called contract can be executed. Note that the callee contract will have " \ _type="Informational",
)
issue.description = (
"This contract forwards its call data via DELEGATECALL in its fallback function. "
"This means that any function in the called contract can be executed. Note that the callee contract will have "
"access to the storage of the calling contract.\n " "access to the storage of the calling contract.\n "
)
target = hex(call.to.val) if call.to.type == VarType.CONCRETE else str(call.to) target = hex(call.to.val) if call.to.type == VarType.CONCRETE else str(call.to)
issue.description += "DELEGATECALL target: {}".format(target) issue.description += "DELEGATECALL target: {}".format(target)
@ -60,23 +66,34 @@ def _concrete_call(call, state, address, meminstart):
def _symbolic_call(call, state, address, statespace): def _symbolic_call(call, state, address, statespace):
issue = Issue(contract=call.node.contract_name, function=call.node.function_name, address=address, issue = Issue(
swc_id=DELEGATECALL_TO_UNTRUSTED_CONTRACT, title=call.type + " to a user-supplied address") contract=call.node.contract_name,
function=call.node.function_name,
address=address,
swc_id=DELEGATECALL_TO_UNTRUSTED_CONTRACT,
title=call.type + " to a user-supplied address",
)
if "calldata" in str(call.to): if "calldata" in str(call.to):
issue.description = \ issue.description = "This contract delegates execution to a contract address obtained from calldata. "
"This contract delegates execution to a contract address obtained from calldata. "
else: else:
m = re.search(r'storage_([a-z0-9_&^]+)', str(call.to)) m = re.search(r"storage_([a-z0-9_&^]+)", str(call.to))
if m: if m:
idx = m.group(1) idx = m.group(1)
func = statespace.find_storage_write(state.environment.active_account.address, idx) func = statespace.find_storage_write(
state.environment.active_account.address, idx
)
if func: if func:
issue.description = "This contract delegates execution to a contract address in storage slot " + str( issue.description = (
idx) + ". This storage slot can be written to by calling the function `" + func + "`. " "This contract delegates execution to a contract address in storage slot "
+ str(idx)
+ ". This storage slot can be written to by calling the function `"
+ func
+ "`. "
)
else: else:
logging.debug("[DELEGATECALL] No storage writes to index " + str(idx)) logging.debug("[DELEGATECALL] No storage writes to index " + str(idx))

@ -7,7 +7,7 @@ from mythril.analysis.swc_data import TIMESTAMP_DEPENDENCE, PREDICTABLE_VARS_DEP
from mythril.exceptions import UnsatError from mythril.exceptions import UnsatError
import logging import logging
''' """
MODULE DESCRIPTION: MODULE DESCRIPTION:
Check for CALLs that send >0 Ether as a result of computation based on predictable variables such as Check for CALLs that send >0 Ether as a result of computation based on predictable variables such as
@ -17,7 +17,7 @@ TODO:
- block.blockhash(block.number-1) - block.blockhash(block.number-1)
- block.blockhash(some_block_past_256_blocks_from_now)==0 - block.blockhash(some_block_past_256_blocks_from_now)==0
- external source of random numbers (e.g. Oraclize) - external source of random numbers (e.g. Oraclize)
''' """
def execute(statespace): def execute(statespace):
@ -37,7 +37,7 @@ def execute(statespace):
if call.value.type == VarType.CONCRETE and call.value.val == 0: if call.value.type == VarType.CONCRETE and call.value.val == 0:
continue continue
address = call.state.get_current_instruction()['address'] address = call.state.get_current_instruction()["address"]
description = "In the function `" + call.node.function_name + "` " description = "In the function `" + call.node.function_name + "` "
description += "the following predictable state variables are used to determine Ether recipient:\n" description += "the following predictable state variables are used to determine Ether recipient:\n"
@ -56,10 +56,20 @@ def execute(statespace):
for item in found: for item in found:
description += "- block.{}\n".format(item) description += "- block.{}\n".format(item)
if solve(call): if solve(call):
swc_type = TIMESTAMP_DEPENDENCE if item == 'timestamp' else PREDICTABLE_VARS_DEPENDENCE swc_type = (
issue = Issue(contract=call.node.contract_name, function=call.node.function_name, address=address, TIMESTAMP_DEPENDENCE
swc_id=swc_type, title="Dependence on predictable environment variable", if item == "timestamp"
_type="Warning", description=description) else PREDICTABLE_VARS_DEPENDENCE
)
issue = Issue(
contract=call.node.contract_name,
function=call.node.function_name,
address=address,
swc_id=swc_type,
title="Dependence on predictable environment variable",
_type="Warning",
description=description,
)
issues.append(issue) issues.append(issue)
# Second check: blockhash # Second check: blockhash
@ -68,48 +78,75 @@ def execute(statespace):
if "blockhash" in str(constraint): if "blockhash" in str(constraint):
description = "In the function `" + call.node.function_name + "` " description = "In the function `" + call.node.function_name + "` "
if "number" in str(constraint): if "number" in str(constraint):
m = re.search(r'blockhash\w+(\s-\s(\d+))*', str(constraint)) m = re.search(r"blockhash\w+(\s-\s(\d+))*", str(constraint))
if m and solve(call): if m and solve(call):
found = m.group(1) found = m.group(1)
if found: # block.blockhash(block.number - N) if found: # block.blockhash(block.number - N)
description += "predictable expression 'block.blockhash(block.number - " + m.group(2) + \ description += (
")' is used to determine Ether recipient" "predictable expression 'block.blockhash(block.number - "
+ m.group(2)
+ ")' is used to determine Ether recipient"
)
if int(m.group(2)) > 255: if int(m.group(2)) > 255:
description += ", this expression will always be equal to zero." description += (
elif "storage" in str(constraint): # block.blockhash(block.number - storage_0) ", this expression will always be equal to zero."
description += "predictable expression 'block.blockhash(block.number - " + \ )
"some_storage_var)' is used to determine Ether recipient" elif "storage" in str(
constraint
): # block.blockhash(block.number - storage_0)
description += (
"predictable expression 'block.blockhash(block.number - "
+ "some_storage_var)' is used to determine Ether recipient"
)
else: # block.blockhash(block.number) else: # block.blockhash(block.number)
description += "predictable expression 'block.blockhash(block.number)'" + \ description += (
" is used to determine Ether recipient" "predictable expression 'block.blockhash(block.number)'"
description += ", this expression will always be equal to zero." + " is used to determine Ether recipient"
)
issue = Issue(contract=call.node.contract_name, function=call.node.function_name, description += (
address=address, title="Dependence on predictable variable", ", this expression will always be equal to zero."
_type="Warning", description=description, swc_id=PREDICTABLE_VARS_DEPENDENCE) )
issue = Issue(
contract=call.node.contract_name,
function=call.node.function_name,
address=address,
title="Dependence on predictable variable",
_type="Warning",
description=description,
swc_id=PREDICTABLE_VARS_DEPENDENCE,
)
issues.append(issue) issues.append(issue)
break break
else: else:
r = re.search(r'storage_([a-z0-9_&^]+)', str(constraint)) r = re.search(r"storage_([a-z0-9_&^]+)", str(constraint))
if r: # block.blockhash(storage_0) if r: # block.blockhash(storage_0)
''' """
We actually can do better here by adding a constraint blockhash_block_storage_0 == 0 We actually can do better here by adding a constraint blockhash_block_storage_0 == 0
and checking model satisfiability. When this is done, severity can be raised and checking model satisfiability. When this is done, severity can be raised
from 'Informational' to 'Warning'. from 'Informational' to 'Warning'.
Checking that storage at given index can be tainted is not necessary, since it usually contains Checking that storage at given index can be tainted is not necessary, since it usually contains
block.number of the 'commit' transaction in commit-reveal workflow. block.number of the 'commit' transaction in commit-reveal workflow.
''' """
index = r.group(1) index = r.group(1)
if index and solve(call): if index and solve(call):
description += 'block.blockhash() is calculated using a value from storage ' \ description += (
'at index {}'.format(index) "block.blockhash() is calculated using a value from storage "
issue = Issue(contract=call.node.contract_name, function=call.node.function_name, "at index {}".format(index)
address=address, title="Dependence on predictable variable", )
_type="Informational", description=description, swc_id=PREDICTABLE_VARS_DEPENDENCE) issue = Issue(
contract=call.node.contract_name,
function=call.node.function_name,
address=address,
title="Dependence on predictable variable",
_type="Informational",
description=description,
swc_id=PREDICTABLE_VARS_DEPENDENCE,
)
issues.append(issue) issues.append(issue)
break break
return issues return issues
@ -121,7 +158,10 @@ def solve(call):
logging.debug("[DEPENDENCE_ON_PREDICTABLE_VARS] MODEL: " + str(model)) logging.debug("[DEPENDENCE_ON_PREDICTABLE_VARS] MODEL: " + str(model))
for decl in model.decls(): for decl in model.decls():
logging.debug("[DEPENDENCE_ON_PREDICTABLE_VARS] main model: %s = 0x%x" % (decl.name(), model[decl].as_long())) logging.debug(
"[DEPENDENCE_ON_PREDICTABLE_VARS] main model: %s = 0x%x"
% (decl.name(), model[decl].as_long())
)
return True return True
except UnsatError: except UnsatError:

@ -3,11 +3,11 @@ from mythril.analysis.swc_data import TX_ORIGIN_USAGE
import logging import logging
''' """
MODULE DESCRIPTION: MODULE DESCRIPTION:
Check for constraints on tx.origin (i.e., access to some functionality is restricted to a specific origin). Check for constraints on tx.origin (i.e., access to some functionality is restricted to a specific origin).
''' """
def execute(statespace): def execute(statespace):
@ -23,14 +23,24 @@ def execute(statespace):
instruction = state.get_current_instruction() instruction = state.get_current_instruction()
if instruction['opcode'] == "ORIGIN": if instruction["opcode"] == "ORIGIN":
description = "The function `{}` retrieves the transaction origin (tx.origin) using the ORIGIN opcode. " \ description = (
"Use msg.sender instead.\nSee also: " \ "The function `{}` retrieves the transaction origin (tx.origin) using the ORIGIN opcode. "
"https://solidity.readthedocs.io/en/develop/security-considerations.html#tx-origin".format(node.function_name) "Use msg.sender instead.\nSee also: "
"https://solidity.readthedocs.io/en/develop/security-considerations.html#tx-origin".format(
issue = Issue(contract=node.contract_name, function=node.function_name, address=instruction['address'], node.function_name
title="Use of tx.origin", _type="Warning", swc_id=TX_ORIGIN_USAGE, )
description=description) )
issue = Issue(
contract=node.contract_name,
function=node.function_name,
address=instruction["address"],
title="Use of tx.origin",
_type="Warning",
swc_id=TX_ORIGIN_USAGE,
description=description,
)
issues.append(issue) issues.append(issue)
return issues return issues

@ -8,13 +8,13 @@ import re
import logging import logging
''' """
MODULE DESCRIPTION: MODULE DESCRIPTION:
Check for CALLs that send >0 Ether to either the transaction sender, or to an address provided as a function argument. Check for CALLs that send >0 Ether to either the transaction sender, or to an address provided as a function argument.
If msg.sender is checked against a value in storage, check whether that storage index is tainted (i.e. there's an unconstrained write If msg.sender is checked against a value in storage, check whether that storage index is tainted (i.e. there's an unconstrained write
to that index). to that index).
''' """
def execute(statespace): def execute(statespace):
@ -26,7 +26,7 @@ def execute(statespace):
for call in statespace.calls: for call in statespace.calls:
state = call.state state = call.state
address = state.get_current_instruction()['address'] address = state.get_current_instruction()["address"]
if "callvalue" in str(call.value): if "callvalue" in str(call.value):
logging.debug("[ETHER_SEND] Skipping refund function") logging.debug("[ETHER_SEND] Skipping refund function")
@ -41,26 +41,38 @@ def execute(statespace):
description = "In the function `" + call.node.function_name + "` " description = "In the function `" + call.node.function_name + "` "
if re.search(r'caller', str(call.to)): if re.search(r"caller", str(call.to)):
description += "a non-zero amount of Ether is sent to msg.sender.\n" description += "a non-zero amount of Ether is sent to msg.sender.\n"
interesting = True interesting = True
elif re.search(r'calldata', str(call.to)): elif re.search(r"calldata", str(call.to)):
description += "a non-zero amount of Ether is sent to an address taken from function arguments.\n" description += "a non-zero amount of Ether is sent to an address taken from function arguments.\n"
interesting = True interesting = True
else: else:
m = re.search(r'storage_([a-z0-9_&^]+)', str(call.to)) m = re.search(r"storage_([a-z0-9_&^]+)", str(call.to))
if m: if m:
idx = m.group(1) idx = m.group(1)
description += "a non-zero amount of Ether is sent to an address taken from storage slot " + str(idx) + ".\n" description += (
"a non-zero amount of Ether is sent to an address taken from storage slot "
+ str(idx)
+ ".\n"
)
func = statespace.find_storage_write(state.environment.active_account.address, idx) func = statespace.find_storage_write(
state.environment.active_account.address, idx
)
if func: if func:
description += "There is a check on storage index " + str(idx) + ". This storage slot can be written to by calling the function `" + func + "`.\n" description += (
"There is a check on storage index "
+ str(idx)
+ ". This storage slot can be written to by calling the function `"
+ func
+ "`.\n"
)
interesting = True interesting = True
else: else:
logging.debug("[ETHER_SEND] No storage writes to index " + str(idx)) logging.debug("[ETHER_SEND] No storage writes to index " + str(idx))
@ -80,31 +92,45 @@ def execute(statespace):
index += 1 index += 1
logging.debug("[ETHER_SEND] Constraint: " + str(constraint)) logging.debug("[ETHER_SEND] Constraint: " + str(constraint))
m = re.search(r'storage_([a-z0-9_&^]+)', str(constraint)) m = re.search(r"storage_([a-z0-9_&^]+)", str(constraint))
if m: if m:
constrained = True constrained = True
idx = m.group(1) idx = m.group(1)
func = statespace.find_storage_write(state.environment.active_account.address, idx) func = statespace.find_storage_write(
state.environment.active_account.address, idx
)
if func: if func:
description += "\nThere is a check on storage index " + str(idx) + ". This storage slot can be written to by calling the function `" + func + "`." description += (
"\nThere is a check on storage index "
+ str(idx)
+ ". This storage slot can be written to by calling the function `"
+ func
+ "`."
)
else: else:
logging.debug("[ETHER_SEND] No storage writes to index " + str(idx)) logging.debug(
"[ETHER_SEND] No storage writes to index " + str(idx)
)
can_solve = False can_solve = False
break break
# CALLER may also be constrained to hardcoded address. I.e. 'caller' and some integer # CALLER may also be constrained to hardcoded address. I.e. 'caller' and some integer
elif re.search(r"caller", str(constraint)) and re.search(r'[0-9]{20}', str(constraint)): elif re.search(r"caller", str(constraint)) and re.search(
r"[0-9]{20}", str(constraint)
):
constrained = True constrained = True
can_solve = False can_solve = False
break break
if not constrained: if not constrained:
description += "It seems that this function can be called without restrictions." description += (
"It seems that this function can be called without restrictions."
)
if can_solve: if can_solve:
@ -112,13 +138,23 @@ def execute(statespace):
model = solver.get_model(node.constraints) model = solver.get_model(node.constraints)
for decl in model.decls(): for decl in model.decls():
logging.debug("[ETHER_SEND] main model: %s = 0x%x" % (decl.name(), model[decl].as_long())) logging.debug(
"[ETHER_SEND] main model: %s = 0x%x"
% (decl.name(), model[decl].as_long())
)
debug = "SOLVER OUTPUT:\n" + solver.pretty_print_model(model) debug = "SOLVER OUTPUT:\n" + solver.pretty_print_model(model)
issue = Issue(contract=call.node.contract_name, function=call.node.function_name, address=address, issue = Issue(
title="Ether send", _type="Warning", swc_id=UNPROTECTED_ETHER_WITHDRAWAL, contract=call.node.contract_name,
description=description, debug=debug) function=call.node.function_name,
address=address,
title="Ether send",
_type="Warning",
swc_id=UNPROTECTED_ETHER_WITHDRAWAL,
description=description,
debug=debug,
)
issues.append(issue) issues.append(issue)
except UnsatError: except UnsatError:

@ -5,12 +5,12 @@ from mythril.analysis import solver
import logging import logging
''' """
MODULE DESCRIPTION: MODULE DESCRIPTION:
Checks whether any exception states are reachable. Checks whether any exception states are reachable.
''' """
def execute(statespace): def execute(statespace):
@ -25,25 +25,40 @@ def execute(statespace):
for state in node.states: for state in node.states:
instruction = state.get_current_instruction() instruction = state.get_current_instruction()
if instruction['opcode'] == "ASSERT_FAIL": if instruction["opcode"] == "ASSERT_FAIL":
try: try:
model = solver.get_model(node.constraints) model = solver.get_model(node.constraints)
address = state.get_current_instruction()['address'] address = state.get_current_instruction()["address"]
description = "A reachable exception (opcode 0xfe) has been detected. " \ description = (
"This can be caused by type errors, division by zero, " \ "A reachable exception (opcode 0xfe) has been detected. "
"out-of-bounds array access, or assert violations. " "This can be caused by type errors, division by zero, "
description += "This is acceptable in most situations. " \ "out-of-bounds array access, or assert violations. "
"Note however that `assert()` should only be used to check invariants. " \ )
"Use `require()` for regular input checking. " description += (
"This is acceptable in most situations. "
debug = "The exception is triggered under the following conditions:\n\n" "Note however that `assert()` should only be used to check invariants. "
"Use `require()` for regular input checking. "
)
debug = (
"The exception is triggered under the following conditions:\n\n"
)
debug += solver.pretty_print_model(model) debug += solver.pretty_print_model(model)
issues.append(Issue(contract=node.contract_name, function=node.function_name, address=address, issues.append(
swc_id=ASSERT_VIOLATION, title="Exception state", _type="Informational", Issue(
description=description, debug=debug)) contract=node.contract_name,
function=node.function_name,
address=address,
swc_id=ASSERT_VIOLATION,
title="Exception state",
_type="Informational",
description=description,
debug=debug,
)
)
except UnsatError: except UnsatError:
logging.debug("[EXCEPTIONS] no model found") logging.debug("[EXCEPTIONS] no model found")

@ -7,11 +7,11 @@ import re
import logging import logging
''' """
MODULE DESCRIPTION: MODULE DESCRIPTION:
Check for call.value()() to external addresses Check for call.value()() to external addresses
''' """
MAX_SEARCH_DEPTH = 64 MAX_SEARCH_DEPTH = 64
@ -28,8 +28,8 @@ def search_children(statespace, node, start_index=0, depth=0, results=None):
if n_states > start_index: if n_states > start_index:
for j in range(start_index, n_states): for j in range(start_index, n_states):
if node.states[j].get_current_instruction()['opcode'] == 'SSTORE': if node.states[j].get_current_instruction()["opcode"] == "SSTORE":
results.append(node.states[j].get_current_instruction()['address']) results.append(node.states[j].get_current_instruction()["address"])
children = [] children = []
@ -39,7 +39,9 @@ def search_children(statespace, node, start_index=0, depth=0, results=None):
if len(children): if len(children):
for node in children: for node in children:
return search_children(statespace, node, depth=depth + 1, results=results) return search_children(
statespace, node, depth=depth + 1, results=results
)
return results return results
@ -54,13 +56,20 @@ def execute(statespace):
for call in statespace.calls: for call in statespace.calls:
state = call.state state = call.state
address = state.get_current_instruction()['address'] address = state.get_current_instruction()["address"]
if call.type == "CALL": if call.type == "CALL":
logging.info("[EXTERNAL_CALLS] Call to: %s, value = %s, gas = %s" % (str(call.to), str(call.value), str(call.gas))) logging.info(
"[EXTERNAL_CALLS] Call to: %s, value = %s, gas = %s"
% (str(call.to), str(call.value), str(call.gas))
)
if call.to.type == VarType.SYMBOLIC and (call.gas.type == VarType.CONCRETE and call.gas.val > 2300) or (call.gas.type == VarType.SYMBOLIC and "2300" not in str(call.gas)): if (
call.to.type == VarType.SYMBOLIC
and (call.gas.type == VarType.CONCRETE and call.gas.val > 2300)
or (call.gas.type == VarType.SYMBOLIC and "2300" not in str(call.gas))
):
description = "This contract executes a message call to " description = "This contract executes a message call to "
@ -76,59 +85,96 @@ def execute(statespace):
user_supplied = True user_supplied = True
else: else:
m = re.search(r'storage_([a-z0-9_&^]+)', str(call.to)) m = re.search(r"storage_([a-z0-9_&^]+)", str(call.to))
if m: if m:
idx = m.group(1) idx = m.group(1)
func = statespace.find_storage_write(state.environment.active_account.address, idx) func = statespace.find_storage_write(
state.environment.active_account.address, idx
)
if func: if func:
description += \ description += (
"an address found at storage slot " + str(idx) + ". " + \ "an address found at storage slot "
"This storage slot can be written to by calling the function `" + func + "`. " + str(idx)
+ ". "
+ "This storage slot can be written to by calling the function `"
+ func
+ "`. "
)
user_supplied = True user_supplied = True
if user_supplied: if user_supplied:
description += "Generally, it is not recommended to call user-supplied addresses using Solidity's call() construct. " \ description += (
"Note that attackers might leverage reentrancy attacks to exploit race conditions or manipulate this contract's state." "Generally, it is not recommended to call user-supplied addresses using Solidity's call() construct. "
"Note that attackers might leverage reentrancy attacks to exploit race conditions or manipulate this contract's state."
issue = Issue(contract=call.node.contract_name, function=call.node.function_name, )
address=address, title="Message call to external contract", _type="Warning",
description=description, swc_id=REENTRANCY) issue = Issue(
contract=call.node.contract_name,
function=call.node.function_name,
address=address,
title="Message call to external contract",
_type="Warning",
description=description,
swc_id=REENTRANCY,
)
else: else:
description += "to another contract. Make sure that the called contract is trusted and does not execute user-supplied code." description += "to another contract. Make sure that the called contract is trusted and does not execute user-supplied code."
issue = Issue(contract=call.node.contract_name, function=call.node.function_name, address=address, issue = Issue(
title="Message call to external contract", _type="Informational", contract=call.node.contract_name,
description=description, swc_id=REENTRANCY) function=call.node.function_name,
address=address,
title="Message call to external contract",
_type="Informational",
description=description,
swc_id=REENTRANCY,
)
issues.append(issue) issues.append(issue)
if address not in calls_visited: if address not in calls_visited:
calls_visited.append(address) calls_visited.append(address)
logging.debug("[EXTERNAL_CALLS] Checking for state changes starting from " + call.node.function_name) logging.debug(
"[EXTERNAL_CALLS] Checking for state changes starting from "
+ call.node.function_name
)
# Check for SSTORE in remaining instructions in current node & nodes down the CFG # Check for SSTORE in remaining instructions in current node & nodes down the CFG
state_change_addresses = search_children(statespace, call.node, call.state_index + 1, depth=0, results=[]) state_change_addresses = search_children(
statespace, call.node, call.state_index + 1, depth=0, results=[]
)
logging.debug("[EXTERNAL_CALLS] Detected state changes at addresses: " + str(state_change_addresses)) logging.debug(
"[EXTERNAL_CALLS] Detected state changes at addresses: "
+ str(state_change_addresses)
)
if len(state_change_addresses): if len(state_change_addresses):
for address in state_change_addresses: for address in state_change_addresses:
description = "The contract account state is changed after an external call. " \ description = (
"Consider that the called contract could re-enter the function before this " \ "The contract account state is changed after an external call. "
"state change takes place. This can lead to business logic vulnerabilities." "Consider that the called contract could re-enter the function before this "
"state change takes place. This can lead to business logic vulnerabilities."
issue = Issue(contract=call.node.contract_name, function=call.node.function_name, )
address=address, title="State change after external call", _type="Warning",
description=description, swc_id=REENTRANCY) issue = Issue(
contract=call.node.contract_name,
function=call.node.function_name,
address=address,
title="State change after external call",
_type="Warning",
description=description,
swc_id=REENTRANCY,
)
issues.append(issue) issues.append(issue)
return issues return issues

@ -9,13 +9,13 @@ import re
import copy import copy
import logging import logging
''' """
MODULE DESCRIPTION: MODULE DESCRIPTION:
Check for integer underflows. Check for integer underflows.
For every SUB instruction, check if there's a possible state where op1 > op0. For every SUB instruction, check if there's a possible state where op1 > op0.
For every ADD, MUL instruction, check if there's a possible state where op1 + op0 > 2^32 - 1 For every ADD, MUL instruction, check if there's a possible state where op1 + op0 > 2^32 - 1
''' """
def execute(statespace): def execute(statespace):
@ -50,7 +50,7 @@ def _check_integer_overflow(statespace, state, node):
# Check the instruction # Check the instruction
instruction = state.get_current_instruction() instruction = state.get_current_instruction()
if instruction['opcode'] not in ("ADD", "MUL"): if instruction["opcode"] not in ("ADD", "MUL"):
return issues return issues
# Formulate overflow constraints # Formulate overflow constraints
@ -70,7 +70,7 @@ def _check_integer_overflow(statespace, state, node):
op1 = BitVecVal(op1, 256) op1 = BitVecVal(op1, 256)
# Formulate expression # Formulate expression
if instruction['opcode'] == "ADD": if instruction["opcode"] == "ADD":
expr = op0 + op1 expr = op0 + op1
else: else:
expr = op1 * op0 expr = op1 * op0
@ -83,27 +83,42 @@ def _check_integer_overflow(statespace, state, node):
logging.debug("[INTEGER_OVERFLOW] no model found") logging.debug("[INTEGER_OVERFLOW] no model found")
return issues return issues
if not _verify_integer_overflow(statespace, node, expr, state, model, constraint, op0, op1): if not _verify_integer_overflow(
statespace, node, expr, state, model, constraint, op0, op1
):
return issues return issues
# Build issue # Build issue
issue = Issue(contract=node.contract_name, function=node.function_name, address=instruction['address'], issue = Issue(
swc_id=INTEGER_OVERFLOW_AND_UNDERFLOW, title="Integer Overflow", _type="Warning") contract=node.contract_name,
function=node.function_name,
issue.description = "A possible integer overflow exists in the function `{}`.\n" \ address=instruction["address"],
"The addition or multiplication may result in a value higher than the maximum representable integer.".format( swc_id=INTEGER_OVERFLOW_AND_UNDERFLOW,
node.function_name) title="Integer Overflow",
_type="Warning",
)
issue.description = (
"A possible integer overflow exists in the function `{}`.\n"
"The addition or multiplication may result in a value higher than the maximum representable integer.".format(
node.function_name
)
)
issue.debug = solver.pretty_print_model(model) issue.debug = solver.pretty_print_model(model)
issues.append(issue) issues.append(issue)
return issues return issues
def _verify_integer_overflow(statespace, node, expr, state, model, constraint, op0, op1): def _verify_integer_overflow(
statespace, node, expr, state, model, constraint, op0, op1
):
""" Verifies existence of integer overflow """ """ Verifies existence of integer overflow """
# If we get to this point then there has been an integer overflow # If we get to this point then there has been an integer overflow
# Find out if the overflowed value is actually used # Find out if the overflowed value is actually used
interesting_usages = _search_children(statespace, node, expr, constraint=[constraint], index=node.states.index(state)) interesting_usages = _search_children(
statespace, node, expr, constraint=[constraint], index=node.states.index(state)
)
# Stop if it isn't # Stop if it isn't
if len(interesting_usages) == 0: if len(interesting_usages) == 0:
@ -111,6 +126,7 @@ def _verify_integer_overflow(statespace, node, expr, state, model, constraint, o
return _try_constraints(node.constraints, [Not(constraint)]) is not None return _try_constraints(node.constraints, [Not(constraint)]) is not None
def _try_constraints(constraints, new_constraints): def _try_constraints(constraints, new_constraints):
""" """
Tries new constraints Tries new constraints
@ -135,7 +151,7 @@ def _check_integer_underflow(statespace, state, node):
""" """
issues = [] issues = []
instruction = state.get_current_instruction() instruction = state.get_current_instruction()
if instruction['opcode'] == "SUB": if instruction["opcode"] == "SUB":
stack = state.mstate.stack stack = state.mstate.stack
@ -150,15 +166,22 @@ def _check_integer_underflow(statespace, state, node):
# Pattern 2: (256*If(1 & storage_0 == 0, 1, 0)) - 1, this would underlow if storage_0 = 0 # Pattern 2: (256*If(1 & storage_0 == 0, 1, 0)) - 1, this would underlow if storage_0 = 0
if type(op0) == int and type(op1) == int: if type(op0) == int and type(op1) == int:
return [] return []
if re.search(r'calldatasize_', str(op0)): if re.search(r"calldatasize_", str(op0)):
return [] return []
if re.search(r'256\*.*If\(1', str(op0), re.DOTALL) or re.search(r'256\*.*If\(1', str(op1), re.DOTALL): if re.search(r"256\*.*If\(1", str(op0), re.DOTALL) or re.search(
r"256\*.*If\(1", str(op1), re.DOTALL
):
return [] return []
if re.search(r'32 \+.*calldata', str(op0), re.DOTALL) or re.search(r'32 \+.*calldata', str(op1), re.DOTALL): if re.search(r"32 \+.*calldata", str(op0), re.DOTALL) or re.search(
r"32 \+.*calldata", str(op1), re.DOTALL
):
return [] return []
logging.debug("[INTEGER_UNDERFLOW] Checking SUB {0}, {1} at address {2}".format(str(op0), str(op1), logging.debug(
str(instruction['address']))) "[INTEGER_UNDERFLOW] Checking SUB {0}, {1} at address {2}".format(
str(op0), str(op1), str(instruction["address"])
)
)
allowed_types = [int, BitVecRef, BitVecNumRef] allowed_types = [int, BitVecRef, BitVecNumRef]
if type(op0) in allowed_types and type(op1) in allowed_types: if type(op0) in allowed_types and type(op1) in allowed_types:
@ -170,17 +193,29 @@ def _check_integer_underflow(statespace, state, node):
# If we get to this point then there has been an integer overflow # If we get to this point then there has been an integer overflow
# Find out if the overflowed value is actually used # Find out if the overflowed value is actually used
interesting_usages = _search_children(statespace, node, (op0 - op1), index=node.states.index(state)) interesting_usages = _search_children(
statespace, node, (op0 - op1), index=node.states.index(state)
)
# Stop if it isn't # Stop if it isn't
if len(interesting_usages) == 0: if len(interesting_usages) == 0:
return issues return issues
issue = Issue(contract=node.contract_name, function=node.function_name, address=instruction['address'], issue = Issue(
swc_id=INTEGER_OVERFLOW_AND_UNDERFLOW, title="Integer Underflow", _type="Warning") contract=node.contract_name,
function=node.function_name,
issue.description = "A possible integer underflow exists in the function `" + node.function_name + "`.\n" \ address=instruction["address"],
"The subtraction may result in a value < 0." swc_id=INTEGER_OVERFLOW_AND_UNDERFLOW,
title="Integer Underflow",
_type="Warning",
)
issue.description = (
"A possible integer underflow exists in the function `"
+ node.function_name
+ "`.\n"
"The subtraction may result in a value < 0."
)
issue.debug = solver.pretty_print_model(model) issue.debug = solver.pretty_print_model(model)
issues.append(issue) issues.append(issue)
@ -192,29 +227,39 @@ def _check_integer_underflow(statespace, state, node):
def _check_usage(state, taint_result): def _check_usage(state, taint_result):
"""Delegates checks to _check_{instruction_name}()""" """Delegates checks to _check_{instruction_name}()"""
opcode = state.get_current_instruction()['opcode'] opcode = state.get_current_instruction()["opcode"]
if opcode == 'JUMPI': if opcode == "JUMPI":
if _check_jumpi(state, taint_result): if _check_jumpi(state, taint_result):
return [state] return [state]
elif opcode == 'SSTORE': elif opcode == "SSTORE":
if _check_sstore(state, taint_result): if _check_sstore(state, taint_result):
return [state] return [state]
return [] return []
def _check_jumpi(state, taint_result): def _check_jumpi(state, taint_result):
""" Check if conditional jump is dependent on the result of expression""" """ Check if conditional jump is dependent on the result of expression"""
assert state.get_current_instruction()['opcode'] == 'JUMPI' assert state.get_current_instruction()["opcode"] == "JUMPI"
return taint_result.check(state, -2) return taint_result.check(state, -2)
def _check_sstore(state, taint_result): def _check_sstore(state, taint_result):
""" Check if store operation is dependent on the result of expression""" """ Check if store operation is dependent on the result of expression"""
assert state.get_current_instruction()['opcode'] == 'SSTORE' assert state.get_current_instruction()["opcode"] == "SSTORE"
return taint_result.check(state, -2) return taint_result.check(state, -2)
def _search_children(statespace, node, expression, taint_result=None, constraint=None, index=0, depth=0, max_depth=64): def _search_children(
statespace,
node,
expression,
taint_result=None,
constraint=None,
index=0,
depth=0,
max_depth=64,
):
""" """
Checks the statespace for children states, with JUMPI or SSTORE instuctions, Checks the statespace for children states, with JUMPI or SSTORE instuctions,
for dependency on expression for dependency on expression
@ -236,7 +281,9 @@ def _search_children(statespace, node, expression, taint_result=None, constraint
state = node.states[index] state = node.states[index]
taint_stack = [False for _ in state.mstate.stack] taint_stack = [False for _ in state.mstate.stack]
taint_stack[-1] = True taint_stack[-1] = True
taint_result = TaintRunner.execute(statespace, node, state, initial_stack=taint_stack) taint_result = TaintRunner.execute(
statespace, node, state, initial_stack=taint_stack
)
results = [] results = []
@ -247,25 +294,31 @@ def _search_children(statespace, node, expression, taint_result=None, constraint
for j in range(index, len(node.states)): for j in range(index, len(node.states)):
current_state = node.states[j] current_state = node.states[j]
current_instruction = current_state.get_current_instruction() current_instruction = current_state.get_current_instruction()
if current_instruction['opcode'] in ('JUMPI', 'SSTORE'): if current_instruction["opcode"] in ("JUMPI", "SSTORE"):
element = _check_usage(current_state, taint_result) element = _check_usage(current_state, taint_result)
if len(element) < 1: if len(element) < 1:
continue continue
if _check_requires(element[0], node, statespace, constraint): if _check_requires(element[0], node, statespace, constraint):
continue continue
results += element results += element
# Recursively search children # Recursively search children
children = \ children = [
[ statespace.nodes[edge.node_to]
statespace.nodes[edge.node_to] for edge in statespace.edges
for edge in statespace.edges if edge.node_from == node.uid
if edge.node_from == node.uid # and _try_constraints(statespace.nodes[edge.node_to].constraints, constraint) is not None
# and _try_constraints(statespace.nodes[edge.node_to].constraints, constraint) is not None ]
]
for child in children: for child in children:
results += _search_children(statespace, child, expression, taint_result, depth=depth + 1, max_depth=max_depth) results += _search_children(
statespace,
child,
expression,
taint_result,
depth=depth + 1,
max_depth=max_depth,
)
return results return results
@ -273,16 +326,16 @@ def _search_children(statespace, node, expression, taint_result=None, constraint
def _check_requires(state, node, statespace, constraint): def _check_requires(state, node, statespace, constraint):
"""Checks if usage of overflowed statement results in a revert statement""" """Checks if usage of overflowed statement results in a revert statement"""
instruction = state.get_current_instruction() instruction = state.get_current_instruction()
if instruction['opcode'] is not "JUMPI": if instruction["opcode"] is not "JUMPI":
return False return False
children = [ children = [
statespace.nodes[edge.node_to] statespace.nodes[edge.node_to]
for edge in statespace.edges for edge in statespace.edges
if edge.node_from == node.uid if edge.node_from == node.uid
] ]
for child in children: for child in children:
opcodes = [s.get_current_instruction()['opcode'] for s in child.states] opcodes = [s.get_current_instruction()["opcode"] for s in child.states]
if "REVERT" in opcodes or "ASSERT_FAIL" in opcodes: if "REVERT" in opcodes or "ASSERT_FAIL" in opcodes:
return True return True
# I added the following case, bc of false positives if the max depth is not high enough # I added the following case, bc of false positives if the max depth is not high enough

@ -1,6 +1,7 @@
from mythril.analysis.report import Issue from mythril.analysis.report import Issue
from mythril.analysis.swc_data import * from mythril.analysis.swc_data import *
from mythril.laser.ethereum.cfg import JumpType from mythril.laser.ethereum.cfg import JumpType
""" """
MODULE DESCRIPTION: MODULE DESCRIPTION:
@ -21,16 +22,24 @@ def execute(statespace):
if len(findings) > 0: if len(findings) > 0:
node = call.node node = call.node
instruction = call.state.get_current_instruction() instruction = call.state.get_current_instruction()
issue = Issue(contract=node.contract_name, function=node.function_name, address=instruction['address'], issue = Issue(
swc_id=MULTIPLE_SENDS, title="Multiple Calls", _type="Informational") contract=node.contract_name,
function=node.function_name,
issue.description = \ address=instruction["address"],
"Multiple sends exist in one transaction. Try to isolate each external call into its own transaction," \ swc_id=MULTIPLE_SENDS,
title="Multiple Calls",
_type="Informational",
)
issue.description = (
"Multiple sends exist in one transaction. Try to isolate each external call into its own transaction,"
" as external calls can fail accidentally or deliberately.\nConsecutive calls: \n" " as external calls can fail accidentally or deliberately.\nConsecutive calls: \n"
)
for finding in findings: for finding in findings:
issue.description += \ issue.description += "Call at address: {}\n".format(
"Call at address: {}\n".format(finding.state.get_current_instruction()['address']) finding.state.get_current_instruction()["address"]
)
issues.append(issue) issues.append(issue)
return issues return issues
@ -44,15 +53,22 @@ def _explore_nodes(call, statespace):
def _explore_states(call, statespace): def _explore_states(call, statespace):
other_calls = list( other_calls = list(
filter(lambda other: other.node == call.node and other.state_index > call.state_index, statespace.calls) filter(
lambda other: other.node == call.node
and other.state_index > call.state_index,
statespace.calls,
) )
)
return other_calls return other_calls
def _child_nodes(statespace, node): def _child_nodes(statespace, node):
result = [] result = []
children = [statespace.nodes[edge.node_to] for edge in statespace.edges if edge.node_from == node.uid children = [
and edge.type != JumpType.Transaction] statespace.nodes[edge.node_to]
for edge in statespace.edges
if edge.node_from == node.uid and edge.type != JumpType.Transaction
]
for child in children: for child in children:
result.append(child) result.append(child)

@ -6,12 +6,12 @@ from mythril.exceptions import UnsatError
import logging import logging
''' """
MODULE DESCRIPTION: MODULE DESCRIPTION:
Check for SUICIDE instructions that either can be reached by anyone, or where msg.sender is checked against a tainted storage index Check for SUICIDE instructions that either can be reached by anyone, or where msg.sender is checked against a tainted storage index
(i.e. there's a write to that index is unconstrained by msg.sender). (i.e. there's a write to that index is unconstrained by msg.sender).
''' """
def execute(state_space): def execute(state_space):
@ -33,13 +33,15 @@ def _analyze_state(state, node):
issues = [] issues = []
instruction = state.get_current_instruction() instruction = state.get_current_instruction()
if instruction['opcode'] != "SUICIDE": if instruction["opcode"] != "SUICIDE":
return [] return []
to = state.mstate.stack[-1] to = state.mstate.stack[-1]
logging.debug("[UNCHECKED_SUICIDE] suicide in function " + node.function_name) logging.debug("[UNCHECKED_SUICIDE] suicide in function " + node.function_name)
description = "The function `" + node.function_name + "` executes the SUICIDE instruction. " description = (
"The function `" + node.function_name + "` executes the SUICIDE instruction. "
)
if "caller" in str(to): if "caller" in str(to):
description += "The remaining Ether is sent to the caller's address.\n" description += "The remaining Ether is sent to the caller's address.\n"
@ -56,19 +58,30 @@ def _analyze_state(state, node):
if len(state.world_state.transaction_sequence) > 1: if len(state.world_state.transaction_sequence) > 1:
creator = state.world_state.transaction_sequence[0].caller creator = state.world_state.transaction_sequence[0].caller
for transaction in state.world_state.transaction_sequence[1:]: for transaction in state.world_state.transaction_sequence[1:]:
not_creator_constraints.append(Not(Extract(159, 0, transaction.caller) == Extract(159, 0, creator))) not_creator_constraints.append(
not_creator_constraints.append(Not(Extract(159, 0, transaction.caller) == 0)) Not(Extract(159, 0, transaction.caller) == Extract(159, 0, creator))
)
not_creator_constraints.append(
Not(Extract(159, 0, transaction.caller) == 0)
)
try: try:
model = solver.get_model(node.constraints + not_creator_constraints) model = solver.get_model(node.constraints + not_creator_constraints)
debug = "SOLVER OUTPUT:\n" + solver.pretty_print_model(model) debug = "SOLVER OUTPUT:\n" + solver.pretty_print_model(model)
issue = Issue(contract=node.contract_name, function=node.function_name, address=instruction['address'], issue = Issue(
swc_id=UNPROTECTED_SELFDESTRUCT, title="Unchecked SUICIDE", _type="Warning", contract=node.contract_name,
description=description, debug=debug) function=node.function_name,
address=instruction["address"],
swc_id=UNPROTECTED_SELFDESTRUCT,
title="Unchecked SUICIDE",
_type="Warning",
description=description,
debug=debug,
)
issues.append(issue) issues.append(issue)
except UnsatError: except UnsatError:
logging.debug("[UNCHECKED_SUICIDE] no model found") logging.debug("[UNCHECKED_SUICIDE] no model found")
return issues return issues

@ -7,12 +7,12 @@ from mythril.analysis.report import Issue
from mythril.analysis.swc_data import TX_ORDER_DEPENDENCE from mythril.analysis.swc_data import TX_ORDER_DEPENDENCE
from mythril.exceptions import UnsatError from mythril.exceptions import UnsatError
''' """
MODULE DESCRIPTION: MODULE DESCRIPTION:
This module finds the existance of transaction order dependence vulnerabilities. This module finds the existance of transaction order dependence vulnerabilities.
The following webpage contains an extensive description of the vulnerability: The following webpage contains an extensive description of the vulnerability:
https://consensys.github.io/smart-contract-best-practices/known_attacks/#transaction-ordering-dependence-tod-front-running https://consensys.github.io/smart-contract-best-practices/known_attacks/#transaction-ordering-dependence-tod-front-running
''' """
def execute(statespace): def execute(statespace):
@ -24,19 +24,29 @@ def execute(statespace):
for call in statespace.calls: for call in statespace.calls:
# Do analysis # Do analysis
interesting_storages = list(_get_influencing_storages(call)) interesting_storages = list(_get_influencing_storages(call))
changing_sstores = list(_get_influencing_sstores(statespace, interesting_storages)) changing_sstores = list(
_get_influencing_sstores(statespace, interesting_storages)
)
# Build issue if necessary # Build issue if necessary
if len(changing_sstores) > 0: if len(changing_sstores) > 0:
node = call.node node = call.node
instruction = call.state.get_current_instruction() instruction = call.state.get_current_instruction()
issue = Issue(contract=node.contract_name, function=node.function_name, address=instruction['address'], issue = Issue(
title="Transaction order dependence", swc_id=TX_ORDER_DEPENDENCE, _type="Warning") contract=node.contract_name,
function=node.function_name,
issue.description = \ address=instruction["address"],
"A possible transaction order dependence vulnerability exists in function {}. The value or " \ title="Transaction order dependence",
"direction of the call statement is determined from a tainted storage location"\ swc_id=TX_ORDER_DEPENDENCE,
.format(node.function_name) _type="Warning",
)
issue.description = (
"A possible transaction order dependence vulnerability exists in function {}. The value or "
"direction of the call statement is determined from a tainted storage location".format(
node.function_name
)
)
issues.append(issue) issues.append(issue)
return issues return issues
@ -65,7 +75,7 @@ def _get_storage_variable(storage, state):
:param state: state to retrieve the variable from :param state: state to retrieve the variable from
:return: z3 object representing storage :return: z3 object representing storage
""" """
index = int(re.search('[0-9]+', storage).group()) index = int(re.search("[0-9]+", storage).group())
try: try:
return state.environment.active_account.storage[index] return state.environment.active_account.storage[index]
except KeyError: except KeyError:
@ -85,6 +95,7 @@ def _can_change(constraints, variable):
except AttributeError: except AttributeError:
return False return False
def _get_influencing_storages(call): def _get_influencing_storages(call):
""" Examines a Call object and returns an iterator of all storages that influence the call value or direction""" """ Examines a Call object and returns an iterator of all storages that influence the call value or direction"""
state = call.state state = call.state
@ -108,7 +119,7 @@ def _get_influencing_storages(call):
def _get_influencing_sstores(statespace, interesting_storages): def _get_influencing_sstores(statespace, interesting_storages):
""" Gets sstore (state, node) tuples that write to interesting_storages""" """ Gets sstore (state, node) tuples that write to interesting_storages"""
for sstore_state, node in _get_states_with_opcode(statespace, 'SSTORE'): for sstore_state, node in _get_states_with_opcode(statespace, "SSTORE"):
index, value = sstore_state.mstate.stack[-1], sstore_state.mstate.stack[-2] index, value = sstore_state.mstate.stack[-1], sstore_state.mstate.stack[-2]
try: try:
index = util.get_concrete_int(index) index = util.get_concrete_int(index)

@ -6,7 +6,7 @@ import logging
import re import re
''' """
MODULE DESCRIPTION: MODULE DESCRIPTION:
Test whether CALL return value is checked. Test whether CALL return value is checked.
@ -22,7 +22,7 @@ For low-level-calls this check is omitted. E.g.:
c.call.value(0)(bytes4(sha3("ping(uint256)")),1); c.call.value(0)(bytes4(sha3("ping(uint256)")),1);
''' """
def execute(statespace): def execute(statespace):
@ -43,19 +43,27 @@ def execute(statespace):
instr = state.get_current_instruction() instr = state.get_current_instruction()
if instr['opcode'] == 'ISZERO' and re.search(r'retval', str(state.mstate.stack[-1])): if instr["opcode"] == "ISZERO" and re.search(
r"retval", str(state.mstate.stack[-1])
):
retval_checked = True retval_checked = True
break break
if not retval_checked: if not retval_checked:
address = state.get_current_instruction()['address'] address = state.get_current_instruction()["address"]
issue = Issue(contract=node.contract_name, function=node.function_name, address=address, issue = Issue(
title="Unchecked CALL return value", swc_id=UNCHECKED_RET_VAL) contract=node.contract_name,
function=node.function_name,
issue.description = \ address=address,
"The return value of an external call is not checked. " \ title="Unchecked CALL return value",
swc_id=UNCHECKED_RET_VAL,
)
issue.description = (
"The return value of an external call is not checked. "
"Note that execution continue even if the called contract throws." "Note that execution continue even if the called contract throws."
)
issues.append(issue) issues.append(issue)
@ -63,12 +71,14 @@ def execute(statespace):
n_states = len(node.states) n_states = len(node.states)
for idx in range(0, n_states - 1): # Ignore CALLs at last position in a node for idx in range(
0, n_states - 1
): # Ignore CALLs at last position in a node
state = node.states[idx] state = node.states[idx]
instr = state.get_current_instruction() instr = state.get_current_instruction()
if instr['opcode'] == 'CALL': if instr["opcode"] == "CALL":
retval_checked = False retval_checked = False
@ -78,7 +88,9 @@ def execute(statespace):
_state = node.states[_idx] _state = node.states[_idx]
_instr = _state.get_current_instruction() _instr = _state.get_current_instruction()
if _instr['opcode'] == 'ISZERO' and re.search(r'retval', str(_state .mstate.stack[-1])): if _instr["opcode"] == "ISZERO" and re.search(
r"retval", str(_state.mstate.stack[-1])
):
retval_checked = True retval_checked = True
break break
@ -87,13 +99,19 @@ def execute(statespace):
if not retval_checked: if not retval_checked:
address = instr['address'] address = instr["address"]
issue = Issue(contract=node.contract_name, function=node.function_name, issue = Issue(
address=address, title="Unchecked CALL return value", swc_id=UNCHECKED_RET_VAL) contract=node.contract_name,
function=node.function_name,
issue.description = \ address=address,
"The return value of an external call is not checked. " \ title="Unchecked CALL return value",
swc_id=UNCHECKED_RET_VAL,
)
issue.description = (
"The return value of an external call is not checked. "
"Note that execution continue even if the called contract throws." "Note that execution continue even if the called contract throws."
)
issues.append(issue) issues.append(issue)

@ -9,7 +9,6 @@ class VarType(Enum):
class Variable: class Variable:
def __init__(self, val, _type): def __init__(self, val, _type):
self.val = val self.val = val
self.type = _type self.type = _type
@ -26,7 +25,6 @@ def get_variable(i):
class Op: class Op:
def __init__(self, node, state, state_index): def __init__(self, node, state, state_index):
self.node = node self.node = node
self.state = state self.state = state
@ -34,8 +32,17 @@ class Op:
class Call(Op): class Call(Op):
def __init__(
def __init__(self, node, state, state_index, _type, to, gas, value=Variable(0, VarType.CONCRETE), data=None): self,
node,
state,
state_index,
_type,
to,
gas,
value=Variable(0, VarType.CONCRETE),
data=None,
):
super().__init__(node, state, state_index) super().__init__(node, state, state_index)
self.to = to self.to = to
@ -46,7 +53,6 @@ class Call(Op):
class SStore(Op): class SStore(Op):
def __init__(self, node, state, state_index, value): def __init__(self, node, state, state_index, value):
super().__init__(node, state, state_index) super().__init__(node, state, state_index)
self.value = value self.value = value

@ -5,8 +5,17 @@ from jinja2 import PackageLoader, Environment
class Issue: class Issue:
def __init__(
def __init__(self, contract, function, address, swc_id, title, _type="Informational", description="", debug=""): self,
contract,
function,
address,
swc_id,
title,
_type="Informational",
description="",
debug="",
):
self.title = title self.title = title
self.contract = contract self.contract = contract
@ -20,32 +29,43 @@ class Issue:
self.code = None self.code = None
self.lineno = None self.lineno = None
@property @property
def as_dict(self): def as_dict(self):
issue = {'title': self.title, 'swc_id': self.swc_id, 'contract': self.contract, 'description': self.description, issue = {
'function': self.function, 'type': self.type, 'address': self.address, 'debug': self.debug} "title": self.title,
"swc_id": self.swc_id,
"contract": self.contract,
"description": self.description,
"function": self.function,
"type": self.type,
"address": self.address,
"debug": self.debug,
}
if self.filename and self.lineno: if self.filename and self.lineno:
issue['filename'] = self.filename issue["filename"] = self.filename
issue['lineno'] = self.lineno issue["lineno"] = self.lineno
if self.code: if self.code:
issue['code'] = self.code issue["code"] = self.code
return issue return issue
def add_code_info(self, contract): def add_code_info(self, contract):
if self.address: if self.address:
codeinfo = contract.get_source_info(self.address, constructor=(self.function == 'constructor')) codeinfo = contract.get_source_info(
self.address, constructor=(self.function == "constructor")
)
self.filename = codeinfo.filename self.filename = codeinfo.filename
self.code = codeinfo.code self.code = codeinfo.code
self.lineno = codeinfo.lineno self.lineno = codeinfo.lineno
class Report: class Report:
environment = Environment(loader=PackageLoader('mythril.analysis'), trim_blocks=True) environment = Environment(
loader=PackageLoader("mythril.analysis"), trim_blocks=True
)
def __init__(self, verbose=False): def __init__(self, verbose=False):
self.issues = {} self.issues = {}
@ -54,26 +74,30 @@ class Report:
def sorted_issues(self): def sorted_issues(self):
issue_list = [issue.as_dict for key, issue in self.issues.items()] issue_list = [issue.as_dict for key, issue in self.issues.items()]
return sorted(issue_list, key=operator.itemgetter('address', 'title')) return sorted(issue_list, key=operator.itemgetter("address", "title"))
def append_issue(self, issue): def append_issue(self, issue):
m = hashlib.md5() m = hashlib.md5()
m.update((issue.contract + str(issue.address) + issue.title).encode('utf-8')) m.update((issue.contract + str(issue.address) + issue.title).encode("utf-8"))
self.issues[m.digest()] = issue self.issues[m.digest()] = issue
def as_text(self): def as_text(self):
name = self._file_name() name = self._file_name()
template = Report.environment.get_template('report_as_text.jinja2') template = Report.environment.get_template("report_as_text.jinja2")
return template.render(filename=name, issues=self.sorted_issues(), verbose=self.verbose) return template.render(
filename=name, issues=self.sorted_issues(), verbose=self.verbose
)
def as_json(self): def as_json(self):
result = {'success': True, 'error': None, 'issues': self.sorted_issues()} result = {"success": True, "error": None, "issues": self.sorted_issues()}
return json.dumps(result, sort_keys=True) return json.dumps(result, sort_keys=True)
def as_markdown(self): def as_markdown(self):
filename = self._file_name() filename = self._file_name()
template = Report.environment.get_template('report_as_markdown.jinja2') template = Report.environment.get_template("report_as_markdown.jinja2")
return template.render(filename=filename, issues=self.sorted_issues(), verbose=self.verbose) return template.render(
filename=filename, issues=self.sorted_issues(), verbose=self.verbose
)
def _file_name(self): def _file_name(self):
if len(self.issues.values()) > 0: if len(self.issues.values()) > 0:

@ -2,6 +2,7 @@ from z3 import Solver, simplify, sat, unknown
from mythril.exceptions import UnsatError from mythril.exceptions import UnsatError
import logging import logging
def get_model(constraints): def get_model(constraints):
s = Solver() s = Solver()
s.set("timeout", 100000) s.set("timeout", 100000)
@ -27,6 +28,6 @@ def pretty_print_model(model):
except: except:
condition = str(simplify(model[d])) condition = str(simplify(model[d]))
ret += ("%s: %s\n" % (d.name(), condition)) ret += "%s: %s\n" % (d.name(), condition)
return ret return ret

@ -1,25 +1,27 @@
DEFAULT_FUNCTION_VISIBILITY = '100' DEFAULT_FUNCTION_VISIBILITY = "100"
INTEGER_OVERFLOW_AND_UNDERFLOW = '101' INTEGER_OVERFLOW_AND_UNDERFLOW = "101"
OUTDATED_COMPILER_VERSION = '102' OUTDATED_COMPILER_VERSION = "102"
FLOATING_PRAGMA = '103' FLOATING_PRAGMA = "103"
UNCHECKED_RET_VAL = '104' UNCHECKED_RET_VAL = "104"
UNPROTECTED_ETHER_WITHDRAWAL = '105' UNPROTECTED_ETHER_WITHDRAWAL = "105"
UNPROTECTED_SELFDESTRUCT = '106' UNPROTECTED_SELFDESTRUCT = "106"
REENTRANCY = '107' REENTRANCY = "107"
DEFAULT_STATE_VARIABLE_VISIBILITY = '108' DEFAULT_STATE_VARIABLE_VISIBILITY = "108"
UNINITIALIZED_STORAGE_POINTER = '109' UNINITIALIZED_STORAGE_POINTER = "109"
ASSERT_VIOLATION = '110' ASSERT_VIOLATION = "110"
DEPRICATED_FUNCTIONS_USAGE = '111' DEPRICATED_FUNCTIONS_USAGE = "111"
DELEGATECALL_TO_UNTRUSTED_CONTRACT = '112' DELEGATECALL_TO_UNTRUSTED_CONTRACT = "112"
MULTIPLE_SENDS = '113' MULTIPLE_SENDS = "113"
TX_ORDER_DEPENDENCE = '114' TX_ORDER_DEPENDENCE = "114"
TX_ORIGIN_USAGE = '115' TX_ORIGIN_USAGE = "115"
TIMESTAMP_DEPENDENCE = '116' TIMESTAMP_DEPENDENCE = "116"
# TODO: SWC ID 116 is missing, Add it if it's added to the https://github.com/SmartContractSecurity/SWC-registry # TODO: SWC ID 116 is missing, Add it if it's added to the https://github.com/SmartContractSecurity/SWC-registry
INCORRECT_CONSTRUCTOR_NAME = '118' INCORRECT_CONSTRUCTOR_NAME = "118"
SHADOWING_STATE_VARIABLES = '119' SHADOWING_STATE_VARIABLES = "119"
WEAK_RANDOMNESS = '120' WEAK_RANDOMNESS = "120"
SIGNATURE_REPLAY = '121' SIGNATURE_REPLAY = "121"
IMPROPER_VERIFICATION_BASED_ON_MSG_SENDER = '122' IMPROPER_VERIFICATION_BASED_ON_MSG_SENDER = "122"
PREDICTABLE_VARS_DEPENDENCE = 'N/A' # TODO: Add the swc id when this is added to the SWC Registry PREDICTABLE_VARS_DEPENDENCE = (
"N/A"
) # TODO: Add the swc id when this is added to the SWC Registry

@ -4,8 +4,12 @@ from mythril.ether.soliditycontract import SolidityContract
import copy import copy
import logging import logging
from .ops import get_variable, SStore, Call, VarType from .ops import get_variable, SStore, Call, VarType
from mythril.laser.ethereum.strategy.basic import DepthFirstSearchStrategy, BreadthFirstSearchStrategy, \ from mythril.laser.ethereum.strategy.basic import (
ReturnRandomNaivelyStrategy, ReturnWeightedRandomStrategy DepthFirstSearchStrategy,
BreadthFirstSearchStrategy,
ReturnRandomNaivelyStrategy,
ReturnWeightedRandomStrategy,
)
class SymExecWrapper: class SymExecWrapper:
@ -14,31 +18,52 @@ class SymExecWrapper:
Wrapper class for the LASER Symbolic virtual machine. Symbolically executes the code and does a bit of pre-analysis for convenience. Wrapper class for the LASER Symbolic virtual machine. Symbolically executes the code and does a bit of pre-analysis for convenience.
""" """
def __init__(self, contract, address, strategy, dynloader=None, max_depth=22, def __init__(
execution_timeout=None, create_timeout=None, max_transaction_count=3): self,
contract,
if strategy == 'dfs': address,
strategy,
dynloader=None,
max_depth=22,
execution_timeout=None,
create_timeout=None,
max_transaction_count=3,
):
if strategy == "dfs":
s_strategy = DepthFirstSearchStrategy s_strategy = DepthFirstSearchStrategy
elif strategy == 'bfs': elif strategy == "bfs":
s_strategy = BreadthFirstSearchStrategy s_strategy = BreadthFirstSearchStrategy
elif strategy == 'naive-random': elif strategy == "naive-random":
s_strategy = ReturnRandomNaivelyStrategy s_strategy = ReturnRandomNaivelyStrategy
elif strategy == 'weighted-random': elif strategy == "weighted-random":
s_strategy = ReturnWeightedRandomStrategy s_strategy = ReturnWeightedRandomStrategy
else: else:
raise ValueError("Invalid strategy argument supplied") raise ValueError("Invalid strategy argument supplied")
account = Account(address, contract.disassembly, dynamic_loader=dynloader, contract_name=contract.name) account = Account(
address,
contract.disassembly,
dynamic_loader=dynloader,
contract_name=contract.name,
)
self.accounts = {address: account} self.accounts = {address: account}
self.laser = svm.LaserEVM(self.accounts, dynamic_loader=dynloader, max_depth=max_depth, self.laser = svm.LaserEVM(
execution_timeout=execution_timeout, strategy=s_strategy, self.accounts,
create_timeout=create_timeout, dynamic_loader=dynloader,
max_transaction_count=max_transaction_count) max_depth=max_depth,
execution_timeout=execution_timeout,
strategy=s_strategy,
create_timeout=create_timeout,
max_transaction_count=max_transaction_count,
)
if isinstance(contract, SolidityContract): if isinstance(contract, SolidityContract):
self.laser.sym_exec(creation_code=contract.creation_code, contract_name=contract.name) self.laser.sym_exec(
creation_code=contract.creation_code, contract_name=contract.name
)
else: else:
self.laser.sym_exec(address) self.laser.sym_exec(address)
@ -58,31 +83,72 @@ class SymExecWrapper:
instruction = state.get_current_instruction() instruction = state.get_current_instruction()
op = instruction['opcode'] op = instruction["opcode"]
if op in ('CALL', 'CALLCODE', 'DELEGATECALL', 'STATICCALL'): if op in ("CALL", "CALLCODE", "DELEGATECALL", "STATICCALL"):
stack = state.mstate.stack stack = state.mstate.stack
if op in ('CALL', 'CALLCODE'): if op in ("CALL", "CALLCODE"):
gas, to, value, meminstart, meminsz, memoutstart, memoutsz = \ gas, to, value, meminstart, meminsz, memoutstart, memoutsz = (
get_variable(stack[-1]), get_variable(stack[-2]), get_variable(stack[-3]), get_variable(stack[-4]), get_variable(stack[-5]), get_variable(stack[-6]), get_variable(stack[-7]) get_variable(stack[-1]),
get_variable(stack[-2]),
get_variable(stack[-3]),
get_variable(stack[-4]),
get_variable(stack[-5]),
get_variable(stack[-6]),
get_variable(stack[-7]),
)
if to.type == VarType.CONCRETE and to.val < 5: if to.type == VarType.CONCRETE and to.val < 5:
# ignore prebuilts # ignore prebuilts
continue continue
if meminstart.type == VarType.CONCRETE and meminsz.type == VarType.CONCRETE: if (
self.calls.append(Call(self.nodes[key], state, state_index, op, to, gas, value, state.mstate.memory[meminstart.val:meminsz.val * 4])) meminstart.type == VarType.CONCRETE
and meminsz.type == VarType.CONCRETE
):
self.calls.append(
Call(
self.nodes[key],
state,
state_index,
op,
to,
gas,
value,
state.mstate.memory[
meminstart.val : meminsz.val * 4
],
)
)
else: else:
self.calls.append(Call(self.nodes[key], state, state_index, op, to, gas, value)) self.calls.append(
Call(
self.nodes[key],
state,
state_index,
op,
to,
gas,
value,
)
)
else: else:
gas, to, meminstart, meminsz, memoutstart, memoutsz = \ gas, to, meminstart, meminsz, memoutstart, memoutsz = (
get_variable(stack[-1]), get_variable(stack[-2]), get_variable(stack[-3]), get_variable(stack[-4]), get_variable(stack[-5]), get_variable(stack[-6]) get_variable(stack[-1]),
get_variable(stack[-2]),
self.calls.append(Call(self.nodes[key], state, state_index, op, to, gas)) get_variable(stack[-3]),
get_variable(stack[-4]),
elif op == 'SSTORE': get_variable(stack[-5]),
get_variable(stack[-6]),
)
self.calls.append(
Call(self.nodes[key], state, state_index, op, to, gas)
)
elif op == "SSTORE":
stack = copy.deepcopy(state.mstate.stack) stack = copy.deepcopy(state.mstate.stack)
address = state.environment.active_account.address address = state.environment.active_account.address
@ -94,9 +160,13 @@ class SymExecWrapper:
self.sstors[address] = {} self.sstors[address] = {}
try: try:
self.sstors[address][str(index)].append(SStore(self.nodes[key], state, state_index, value)) self.sstors[address][str(index)].append(
SStore(self.nodes[key], state, state_index, value)
)
except KeyError: except KeyError:
self.sstors[address][str(index)] = [SStore(self.nodes[key], state, state_index, value)] self.sstors[address][str(index)] = [
SStore(self.nodes[key], state, state_index, value)
]
state_index += 1 state_index += 1

@ -3,32 +3,64 @@ from mythril.laser.ethereum.svm import NodeFlags
import re import re
colors = [ colors = [
{'border': '#26996f', 'background': '#2f7e5b', 'highlight': {'border': '#fff', 'background': '#28a16f'}}, {
{'border': '#9e42b3', 'background': '#842899', 'highlight': {'border': '#fff', 'background': '#933da6'}}, "border": "#26996f",
{'border': '#b82323', 'background': '#991d1d', 'highlight': {'border': '#fff', 'background': '#a61f1f'}}, "background": "#2f7e5b",
{'border': '#4753bf', 'background': '#3b46a1', 'highlight': {'border': '#fff', 'background': '#424db3'}}, "highlight": {"border": "#fff", "background": "#28a16f"},
{'border': '#26996f', 'background': '#2f7e5b', 'highlight': {'border': '#fff', 'background': '#28a16f'}}, },
{'border': '#9e42b3', 'background': '#842899', 'highlight': {'border': '#fff', 'background': '#933da6'}}, {
{'border': '#b82323', 'background': '#991d1d', 'highlight': {'border': '#fff', 'background': '#a61f1f'}}, "border": "#9e42b3",
{'border': '#4753bf', 'background': '#3b46a1', 'highlight': {'border': '#fff', 'background': '#424db3'}}, "background": "#842899",
"highlight": {"border": "#fff", "background": "#933da6"},
},
{
"border": "#b82323",
"background": "#991d1d",
"highlight": {"border": "#fff", "background": "#a61f1f"},
},
{
"border": "#4753bf",
"background": "#3b46a1",
"highlight": {"border": "#fff", "background": "#424db3"},
},
{
"border": "#26996f",
"background": "#2f7e5b",
"highlight": {"border": "#fff", "background": "#28a16f"},
},
{
"border": "#9e42b3",
"background": "#842899",
"highlight": {"border": "#fff", "background": "#933da6"},
},
{
"border": "#b82323",
"background": "#991d1d",
"highlight": {"border": "#fff", "background": "#a61f1f"},
},
{
"border": "#4753bf",
"background": "#3b46a1",
"highlight": {"border": "#fff", "background": "#424db3"},
},
] ]
def get_serializable_statespace(statespace): def get_serializable_statespace(statespace):
nodes = [] nodes = []
edges = [] edges = []
color_map = {} color_map = {}
i = 0 i = 0
for k in statespace.accounts: for k in statespace.accounts:
color_map[statespace.accounts[k].contract_name] = colors[i] color_map[statespace.accounts[k].contract_name] = colors[i]
i += 1 i += 1
for node_key in statespace.nodes: for node_key in statespace.nodes:
node = statespace.nodes[node_key] node = statespace.nodes[node_key]
code = node.get_cfg_dict()['code'] code = node.get_cfg_dict()["code"]
code = re.sub("([0-9a-f]{8})[0-9a-f]+", lambda m: m.group(1) + "(...)", code) code = re.sub("([0-9a-f]{8})[0-9a-f]+", lambda m: m.group(1) + "(...)", code)
if NodeFlags.FUNC_ENTRY in node.flags: if NodeFlags.FUNC_ENTRY in node.flags:
@ -36,47 +68,51 @@ def get_serializable_statespace(statespace):
code_split = code.split("\\n") code_split = code.split("\\n")
truncated_code = code if (len(code_split) < 7) else "\\n".join(code_split[:6]) + "\\n(click to expand +)" truncated_code = (
code
if (len(code_split) < 7)
else "\\n".join(code_split[:6]) + "\\n(click to expand +)"
)
color = color_map[node.get_cfg_dict()["contract_name"]]
color = color_map[node.get_cfg_dict()['contract_name']]
def get_state_accounts(node_state): def get_state_accounts(node_state):
state_accounts = [] state_accounts = []
for key in node_state.accounts: for key in node_state.accounts:
account = node_state.accounts[key].as_dict account = node_state.accounts[key].as_dict
account.pop('code', None) account.pop("code", None)
account['balance'] = str(account['balance']) account["balance"] = str(account["balance"])
storage = {} storage = {}
for storage_key in account['storage']: for storage_key in account["storage"]:
storage[str(storage_key)] = str(account['storage'][storage_key]) storage[str(storage_key)] = str(account["storage"][storage_key])
state_accounts.append({ state_accounts.append({"address": key, "storage": storage})
'address': key, return state_accounts
'storage': storage
}) states = [
return state_accounts {"machine": x.mstate.as_dict, "accounts": get_state_accounts(x)}
for x in node.states
states = [{'machine': x.mstate.as_dict, 'accounts': get_state_accounts(x)} for x in node.states] ]
for state in states: for state in states:
state['machine']['stack'] = [str(s) for s in state['machine']['stack']] state["machine"]["stack"] = [str(s) for s in state["machine"]["stack"]]
state['machine']['memory'] = [str(m) for m in state['machine']['memory']] state["machine"]["memory"] = [str(m) for m in state["machine"]["memory"]]
truncated_code = truncated_code.replace('\\n', '\n') truncated_code = truncated_code.replace("\\n", "\n")
code = code.replace('\\n', '\n') code = code.replace("\\n", "\n")
s_node = { s_node = {
'id': str(node_key), "id": str(node_key),
'func': str(node.function_name), "func": str(node.function_name),
'label': truncated_code, "label": truncated_code,
'code': code, "code": code,
'truncated': truncated_code, "truncated": truncated_code,
'states': states, "states": states,
'color': color, "color": color,
'instructions': code.split('\n') "instructions": code.split("\n"),
} }
nodes.append(s_node) nodes.append(s_node)
for edge in statespace.edges: for edge in statespace.edges:
@ -90,20 +126,19 @@ def get_serializable_statespace(statespace):
except Z3Exception: except Z3Exception:
label = str(edge.condition).replace("\n", "") label = str(edge.condition).replace("\n", "")
label = re.sub("([^_])([\d]{2}\d+)", lambda m: m.group(1) + hex(int(m.group(2))), label) label = re.sub(
"([^_])([\d]{2}\d+)", lambda m: m.group(1) + hex(int(m.group(2))), label
)
code = re.sub("([0-9a-f]{8})[0-9a-f]+", lambda m: m.group(1) + "(...)", code) code = re.sub("([0-9a-f]{8})[0-9a-f]+", lambda m: m.group(1) + "(...)", code)
s_edge = { s_edge = {
'from': str(edge.as_dict['from']), "from": str(edge.as_dict["from"]),
'to': str(edge.as_dict['to']), "to": str(edge.as_dict["to"]),
'arrows': 'to', "arrows": "to",
'label': label, "label": label,
'smooth': { 'type': "cubicBezier" } "smooth": {"type": "cubicBezier"},
} }
edges.append(s_edge) edges.append(s_edge)
return { return {"edges": edges, "nodes": nodes}
'edges': edges,
'nodes': nodes
}

@ -13,7 +13,8 @@ class Disassembly(object):
- function name to entry point mapping - function name to entry point mapping
- function entry point to function name mapping - function entry point to function name mapping
""" """
def __init__(self, code: str, enable_online_lookup: bool=False):
def __init__(self, code: str, enable_online_lookup: bool = False):
self.bytecode = code self.bytecode = code
self.instruction_list = asm.disassemble(util.safe_decode(code)) self.instruction_list = asm.disassemble(util.safe_decode(code))
@ -52,7 +53,9 @@ class Disassembly(object):
return asm.instruction_list_to_easm(self.instruction_list) return asm.instruction_list_to_easm(self.instruction_list)
def get_function_info(index: int, instruction_list: list, signature_database: SignatureDb) -> (str, int, str): def get_function_info(
index: int, instruction_list: list, signature_database: SignatureDb
) -> (str, int, str):
""" """
Finds the function information for a call table entry Finds the function information for a call table entry
Solidity uses the first 4 bytes of the calldata to indicate which function the message call should execute Solidity uses the first 4 bytes of the calldata to indicate which function the message call should execute
@ -77,9 +80,7 @@ def get_function_info(index: int, instruction_list: list, signature_database: Si
function_names = signature_database.get(function_hash) function_names = signature_database.get(function_hash)
if len(function_names) > 1: if len(function_names) > 1:
# In this case there was an ambiguous result # In this case there was an ambiguous result
function_name = ( function_name = "**ambiguous** {}".format(function_names[0])
"**ambiguous** {}".format(function_names[0])
)
elif len(function_names) == 1: elif len(function_names) == 1:
function_name = function_names[0] function_name = function_names[0]
else: else:

@ -4,11 +4,11 @@ from ethereum.opcodes import opcodes
from mythril.ether import util from mythril.ether import util
regex_PUSH = re.compile('^PUSH(\d*)$') regex_PUSH = re.compile("^PUSH(\d*)$")
# Additional mnemonic to catch failed assertions # Additional mnemonic to catch failed assertions
opcodes[254] = ['ASSERT_FAIL', 0, 0, 0] opcodes[254] = ["ASSERT_FAIL", 0, 0, 0]
def instruction_list_to_easm(instruction_list): def instruction_list_to_easm(instruction_list):
@ -16,10 +16,10 @@ def instruction_list_to_easm(instruction_list):
for instruction in instruction_list: for instruction in instruction_list:
easm += str(instruction['address']) + " " + instruction['opcode'] easm += str(instruction["address"]) + " " + instruction["opcode"]
if 'argument' in instruction: if "argument" in instruction:
easm += " " + instruction['argument'] easm += " " + instruction["argument"]
easm += "\n" easm += "\n"
@ -28,11 +28,11 @@ def instruction_list_to_easm(instruction_list):
def easm_to_instruction_list(easm): def easm_to_instruction_list(easm):
regex_CODELINE = re.compile('^([A-Z0-9]+)(?:\s+([0-9a-fA-Fx]+))?$') regex_CODELINE = re.compile("^([A-Z0-9]+)(?:\s+([0-9a-fA-Fx]+))?$")
instruction_list = [] instruction_list = []
codelines = easm.split('\n') codelines = easm.split("\n")
for line in codelines: for line in codelines:
@ -42,10 +42,10 @@ def easm_to_instruction_list(easm):
# Invalid code line # Invalid code line
continue continue
instruction = {'opcode': m.group(1)} instruction = {"opcode": m.group(1)}
if m.group(2): if m.group(2):
instruction['argument'] = m.group(2)[2:] instruction["argument"] = m.group(2)[2:]
instruction_list.append(instruction) instruction_list.append(instruction)
@ -70,13 +70,13 @@ def find_opcode_sequence(pattern, instruction_list):
for i in range(0, len(instruction_list) - pattern_length + 1): for i in range(0, len(instruction_list) - pattern_length + 1):
if instruction_list[i]['opcode'] in pattern[0]: if instruction_list[i]["opcode"] in pattern[0]:
matched = True matched = True
for j in range(1, len(pattern)): for j in range(1, len(pattern)):
if not (instruction_list[i + j]['opcode'] in pattern[j]): if not (instruction_list[i + j]["opcode"] in pattern[j]):
matched = False matched = False
break break
@ -99,7 +99,7 @@ def disassemble(bytecode):
while addr < length: while addr < length:
instruction = {'address': addr} instruction = {"address": addr}
try: try:
if sys.version_info > (3, 0): if sys.version_info > (3, 0):
@ -110,21 +110,20 @@ def disassemble(bytecode):
except KeyError: except KeyError:
# invalid opcode # invalid opcode
instruction_list.append({'address': addr, 'opcode': "INVALID"}) instruction_list.append({"address": addr, "opcode": "INVALID"})
addr += 1 addr += 1
continue continue
instruction['opcode'] = opcode[0] instruction["opcode"] = opcode[0]
m = re.search(regex_PUSH, opcode[0]) m = re.search(regex_PUSH, opcode[0])
if m: if m:
argument = bytecode[addr+1:addr+1+int(m.group(1))] argument = bytecode[addr + 1 : addr + 1 + int(m.group(1))]
instruction['argument'] = "0x" + argument.hex() instruction["argument"] = "0x" + argument.hex()
addr += int(m.group(1)) addr += int(m.group(1))
instruction_list.append(instruction) instruction_list.append(instruction)
addr += 1 addr += 1
@ -139,14 +138,14 @@ def assemble(instruction_list):
for instruction in instruction_list: for instruction in instruction_list:
try: try:
opcode = get_opcode_from_name(instruction['opcode']) opcode = get_opcode_from_name(instruction["opcode"])
except RuntimeError: except RuntimeError:
opcode = 0xbb opcode = 0xBB
bytecode += opcode.to_bytes(1, byteorder='big') bytecode += opcode.to_bytes(1, byteorder="big")
if 'argument' in instruction: if "argument" in instruction:
bytecode += util.safe_decode(instruction['argument']) bytecode += util.safe_decode(instruction["argument"])
return bytecode return bytecode

@ -5,30 +5,33 @@ import re
class ETHContract(persistent.Persistent): class ETHContract(persistent.Persistent):
def __init__(
self, code, creation_code="", name="Unknown", enable_online_lookup=False
):
def __init__(self, code, creation_code="", name="Unknown", enable_online_lookup=False):
# Workaround: We currently do not support compile-time linking. # Workaround: We currently do not support compile-time linking.
# Dynamic contract addresses of the format __[contract-name]_____________ are replaced with a generic address # Dynamic contract addresses of the format __[contract-name]_____________ are replaced with a generic address
# Apply this for creation_code & code # Apply this for creation_code & code
creation_code = re.sub(r'(_{2}.{38})', 'aa' * 20, creation_code) creation_code = re.sub(r"(_{2}.{38})", "aa" * 20, creation_code)
code = re.sub(r'(_{2}.{38})', 'aa' * 20, code) code = re.sub(r"(_{2}.{38})", "aa" * 20, code)
self.creation_code = creation_code self.creation_code = creation_code
self.name = name self.name = name
self.code = code self.code = code
self.disassembly = Disassembly(code, enable_online_lookup=enable_online_lookup) self.disassembly = Disassembly(code, enable_online_lookup=enable_online_lookup)
self.creation_disassembly = Disassembly(creation_code, enable_online_lookup=enable_online_lookup) self.creation_disassembly = Disassembly(
creation_code, enable_online_lookup=enable_online_lookup
)
def as_dict(self): def as_dict(self):
return { return {
'address': self.address, "address": self.address,
'name': self.name, "name": self.name,
'code': self.code, "code": self.code,
'creation_code': self.creation_code, "creation_code": self.creation_code,
'disassembly': self.disassembly "disassembly": self.disassembly,
} }
def get_easm(self): def get_easm(self):
@ -37,7 +40,7 @@ class ETHContract(persistent.Persistent):
def matches_expression(self, expression): def matches_expression(self, expression):
str_eval = '' str_eval = ""
easm_code = None easm_code = None
tokens = re.split("\s+(and|or|not)\s+", expression, re.IGNORECASE) tokens = re.split("\s+(and|or|not)\s+", expression, re.IGNORECASE)
@ -48,23 +51,23 @@ class ETHContract(persistent.Persistent):
str_eval += " " + token + " " str_eval += " " + token + " "
continue continue
m = re.match(r'^code#([a-zA-Z0-9\s,\[\]]+)#', token) m = re.match(r"^code#([a-zA-Z0-9\s,\[\]]+)#", token)
if m: if m:
if easm_code is None: if easm_code is None:
easm_code = self.get_easm() easm_code = self.get_easm()
code = m.group(1).replace(",", "\\n") code = m.group(1).replace(",", "\\n")
str_eval += "\"" + code + "\" in easm_code" str_eval += '"' + code + '" in easm_code'
continue continue
m = re.match(r'^func#([a-zA-Z0-9\s_,(\\)\[\]]+)#$', token) m = re.match(r"^func#([a-zA-Z0-9\s_,(\\)\[\]]+)#$", token)
if m: if m:
sign_hash = "0x" + utils.sha3(m.group(1))[:4].hex() sign_hash = "0x" + utils.sha3(m.group(1))[:4].hex()
str_eval += "\"" + sign_hash + "\" in self.disassembly.func_hashes" str_eval += '"' + sign_hash + '" in self.disassembly.func_hashes'
continue continue

@ -8,7 +8,12 @@ import re
def trace(code, calldata=""): def trace(code, calldata=""):
log_handlers = ['eth.vm.op', 'eth.vm.op.stack', 'eth.vm.op.memory', 'eth.vm.op.storage'] log_handlers = [
"eth.vm.op",
"eth.vm.op.stack",
"eth.vm.op.memory",
"eth.vm.op.storage",
]
output = StringIO() output = StringIO()
stream_handler = StreamHandler(output) stream_handler = StreamHandler(output)
@ -17,7 +22,7 @@ def trace(code, calldata=""):
log_vm_op.setLevel("TRACE") log_vm_op.setLevel("TRACE")
log_vm_op.addHandler(stream_handler) log_vm_op.addHandler(stream_handler)
addr = bytes.fromhex('0123456789ABCDEF0123456789ABCDEF01234567') addr = bytes.fromhex("0123456789ABCDEF0123456789ABCDEF01234567")
state = State() state = State()
ext = messages.VMExt(state, transactions.Transaction(0, 0, 21000, addr, 0, addr)) ext = messages.VMExt(state, transactions.Transaction(0, 0, 21000, addr, 0, addr))
@ -29,14 +34,14 @@ def trace(code, calldata=""):
state_trace = [] state_trace = []
for line in lines: for line in lines:
m = re.search(r'pc=b\'(\d+)\'.*op=([A-Z0-9]+)', line) m = re.search(r"pc=b\'(\d+)\'.*op=([A-Z0-9]+)", line)
if m: if m:
pc = m.group(1) pc = m.group(1)
op = m.group(2) op = m.group(2)
m = re.match(r'.*stack=(\[.*?\])', line) m = re.match(r".*stack=(\[.*?\])", line)
if m: if m:
stackitems = re.findall(r'b\'(\d+)\'', m.group(1)) stackitems = re.findall(r"b\'(\d+)\'", m.group(1))
stack = "[" stack = "["
if len(stackitems): if len(stackitems):
@ -48,11 +53,13 @@ def trace(code, calldata=""):
else: else:
stack = "[]" stack = "[]"
if re.match(r'^PUSH.*', op): if re.match(r"^PUSH.*", op):
val = re.search(r'pushvalue=(\d+)', line).group(1) val = re.search(r"pushvalue=(\d+)", line).group(1)
pushvalue = hex(int(val)) pushvalue = hex(int(val))
state_trace.append({'pc': pc, 'op': op, 'stack': stack, 'pushvalue': pushvalue}) state_trace.append(
{"pc": pc, "op": op, "stack": stack, "pushvalue": pushvalue}
)
else: else:
state_trace.append({'pc': pc, 'op': op, 'stack': stack}) state_trace.append({"pc": pc, "op": op, "stack": stack})
return state_trace return state_trace

@ -5,7 +5,6 @@ from mythril.exceptions import NoContractFoundError
class SourceMapping: class SourceMapping:
def __init__(self, solidity_file_idx, offset, length, lineno): def __init__(self, solidity_file_idx, offset, length, lineno):
self.solidity_file_idx = solidity_file_idx self.solidity_file_idx = solidity_file_idx
self.offset = offset self.offset = offset
@ -14,14 +13,12 @@ class SourceMapping:
class SolidityFile: class SolidityFile:
def __init__(self, filename, data): def __init__(self, filename, data):
self.filename = filename self.filename = filename
self.data = data self.data = data
class SourceCodeInfo: class SourceCodeInfo:
def __init__(self, filename, lineno, code): def __init__(self, filename, lineno, code):
self.filename = filename self.filename = filename
self.lineno = lineno self.lineno = lineno
@ -30,22 +27,21 @@ class SourceCodeInfo:
def get_contracts_from_file(input_file, solc_args=None): def get_contracts_from_file(input_file, solc_args=None):
data = get_solc_json(input_file, solc_args=solc_args) data = get_solc_json(input_file, solc_args=solc_args)
for key, contract in data['contracts'].items(): for key, contract in data["contracts"].items():
filename, name = key.split(":") filename, name = key.split(":")
if filename == input_file and len(contract['bin-runtime']): if filename == input_file and len(contract["bin-runtime"]):
yield SolidityContract(input_file, name, solc_args) yield SolidityContract(input_file, name, solc_args)
class SolidityContract(ETHContract): class SolidityContract(ETHContract):
def __init__(self, input_file, name=None, solc_args=None): def __init__(self, input_file, name=None, solc_args=None):
data = get_solc_json(input_file, solc_args=solc_args) data = get_solc_json(input_file, solc_args=solc_args)
self.solidity_files = [] self.solidity_files = []
for filename in data['sourceList']: for filename in data["sourceList"]:
with open(filename, 'r', encoding='utf-8') as file: with open(filename, "r", encoding="utf-8") as file:
code = file.read() code = file.read()
self.solidity_files.append(SolidityFile(filename, code)) self.solidity_files.append(SolidityFile(filename, code))
@ -55,28 +51,32 @@ class SolidityContract(ETHContract):
srcmap_constructor = [] srcmap_constructor = []
srcmap = [] srcmap = []
if name: if name:
for key, contract in sorted(data['contracts'].items()): for key, contract in sorted(data["contracts"].items()):
filename, _name = key.split(":") filename, _name = key.split(":")
if filename == input_file and name == _name and len(contract['bin-runtime']): if (
code = contract['bin-runtime'] filename == input_file
creation_code = contract['bin'] and name == _name
srcmap = contract['srcmap-runtime'].split(";") and len(contract["bin-runtime"])
srcmap_constructor = contract['srcmap'].split(";") ):
code = contract["bin-runtime"]
creation_code = contract["bin"]
srcmap = contract["srcmap-runtime"].split(";")
srcmap_constructor = contract["srcmap"].split(";")
has_contract = True has_contract = True
break break
# If no contract name is specified, get the last bytecode entry for the input file # If no contract name is specified, get the last bytecode entry for the input file
else: else:
for key, contract in sorted(data['contracts'].items()): for key, contract in sorted(data["contracts"].items()):
filename, name = key.split(":") filename, name = key.split(":")
if filename == input_file and len(contract['bin-runtime']): if filename == input_file and len(contract["bin-runtime"]):
code = contract['bin-runtime'] code = contract["bin-runtime"]
creation_code = contract['bin'] creation_code = contract["bin"]
srcmap = contract['srcmap-runtime'].split(";") srcmap = contract["srcmap-runtime"].split(";")
srcmap_constructor = contract['srcmap'].split(";") srcmap_constructor = contract["srcmap"].split(";")
has_contract = True has_contract = True
if not has_contract: if not has_contract:
@ -102,7 +102,9 @@ class SolidityContract(ETHContract):
offset = mappings[index].offset offset = mappings[index].offset
length = mappings[index].length length = mappings[index].length
code = solidity_file.data.encode('utf-8')[offset:offset + length].decode('utf-8', errors="ignore") code = solidity_file.data.encode("utf-8")[offset : offset + length].decode(
"utf-8", errors="ignore"
)
lineno = mappings[index].lineno lineno = mappings[index].lineno
return SourceCodeInfo(filename, lineno, code) return SourceCodeInfo(filename, lineno, code)
@ -120,6 +122,11 @@ class SolidityContract(ETHContract):
if len(mapping) > 2 and len(mapping[2]) > 0: if len(mapping) > 2 and len(mapping[2]) > 0:
idx = int(mapping[2]) idx = int(mapping[2])
lineno = self.solidity_files[idx].data.encode('utf-8')[0:offset].count('\n'.encode('utf-8')) + 1 lineno = (
self.solidity_files[idx]
.data.encode("utf-8")[0:offset]
.count("\n".encode("utf-8"))
+ 1
)
mappings.append(SourceMapping(idx, offset, length, lineno)) mappings.append(SourceMapping(idx, offset, length, lineno))

@ -39,9 +39,14 @@ def get_solc_json(file, solc_binary="solc", solc_args=None):
ret = p.returncode ret = p.returncode
if ret != 0: if ret != 0:
raise CompilerError("Solc experienced a fatal error (code %d).\n\n%s" % (ret, stderr.decode('UTF-8'))) raise CompilerError(
"Solc experienced a fatal error (code %d).\n\n%s"
% (ret, stderr.decode("UTF-8"))
)
except FileNotFoundError: except FileNotFoundError:
raise CompilerError("Compiler not found. Make sure that solc is installed and in PATH, or set the SOLC environment variable.") raise CompilerError(
"Compiler not found. Make sure that solc is installed and in PATH, or set the SOLC environment variable."
)
out = stdout.decode("UTF-8") out = stdout.decode("UTF-8")
@ -59,7 +64,7 @@ def encode_calldata(func_name, arg_types, args):
def get_random_address(): def get_random_address():
return binascii.b2a_hex(os.urandom(20)).decode('UTF-8') return binascii.b2a_hex(os.urandom(20)).decode("UTF-8")
def get_indexed_address(index): def get_indexed_address(index):
@ -67,7 +72,9 @@ def get_indexed_address(index):
def solc_exists(version): def solc_exists(version):
solc_binary = os.path.join(os.environ['HOME'], ".py-solc/solc-v" + version, "bin/solc") solc_binary = os.path.join(
os.environ["HOME"], ".py-solc/solc-v" + version, "bin/solc"
)
if os.path.exists(solc_binary): if os.path.exists(solc_binary):
return True return True
else: else:

@ -39,13 +39,13 @@ class ReceiptForStorage(rlp.Serializable):
""" """
fields = [ fields = [
('state_root', binary), ("state_root", binary),
('cumulative_gas_used', big_endian_int), ("cumulative_gas_used", big_endian_int),
('bloom', int256), ("bloom", int256),
('tx_hash', hash32), ("tx_hash", hash32),
('contractAddress', address), ("contractAddress", address),
('logs', CountableList(Log)), ("logs", CountableList(Log)),
('gas_used', big_endian_int) ("gas_used", big_endian_int),
] ]
@ -76,7 +76,9 @@ class AccountIndexer(object):
""" """
Processesing method Processesing method
""" """
logging.debug("Processing blocks %d to %d" % (startblock, startblock + BATCH_SIZE)) logging.debug(
"Processing blocks %d to %d" % (startblock, startblock + BATCH_SIZE)
)
addresses = [] addresses = []
@ -86,7 +88,9 @@ class AccountIndexer(object):
receipts = self.db.reader._get_block_receipts(block_hash, blockNum) receipts = self.db.reader._get_block_receipts(block_hash, blockNum)
for receipt in receipts: for receipt in receipts:
if receipt.contractAddress is not None and not all(b == 0 for b in receipt.contractAddress): if receipt.contractAddress is not None and not all(
b == 0 for b in receipt.contractAddress
):
addresses.append(receipt.contractAddress) addresses.append(receipt.contractAddress)
else: else:
if len(addresses) == 0: if len(addresses) == 0:
@ -112,15 +116,21 @@ class AccountIndexer(object):
# in fast sync head block is at 0 (e.g. in fastSync), we can't use it to determine length # in fast sync head block is at 0 (e.g. in fastSync), we can't use it to determine length
if self.lastBlock is not None and self.lastBlock == 0: if self.lastBlock is not None and self.lastBlock == 0:
self.lastBlock = 2e+9 self.lastBlock = 2e9
if self.lastBlock is None or (self.lastProcessedBlock is not None and self.lastBlock <= self.lastProcessedBlock): if self.lastBlock is None or (
self.lastProcessedBlock is not None
and self.lastBlock <= self.lastProcessedBlock
):
return return
blockNum = 0 blockNum = 0
if self.lastProcessedBlock is not None: if self.lastProcessedBlock is not None:
blockNum = self.lastProcessedBlock + 1 blockNum = self.lastProcessedBlock + 1
print("Updating hash-to-address index from block " + str(self.lastProcessedBlock)) print(
"Updating hash-to-address index from block "
+ str(self.lastProcessedBlock)
)
else: else:
print("Starting hash-to-address index") print("Starting hash-to-address index")
@ -147,7 +157,10 @@ class AccountIndexer(object):
blockNum = min(blockNum + BATCH_SIZE, self.lastBlock + 1) blockNum = min(blockNum + BATCH_SIZE, self.lastBlock + 1)
cost_time = time.time() - ether.start_time cost_time = time.time() - ether.start_time
print("%d blocks processed (in %d seconds), %d unique addresses found, next block: %d" % (processed, cost_time, count, min(self.lastBlock, blockNum))) print(
"%d blocks processed (in %d seconds), %d unique addresses found, next block: %d"
% (processed, cost_time, count, min(self.lastBlock, blockNum))
)
self.lastProcessedBlock = blockNum - 1 self.lastProcessedBlock = blockNum - 1
self.db.writer._set_last_indexed_number(self.lastProcessedBlock) self.db.writer._set_last_indexed_number(self.lastProcessedBlock)

@ -1,7 +1,10 @@
import binascii import binascii
import rlp import rlp
from mythril.ethereum.interface.leveldb.accountindexing import CountableList from mythril.ethereum.interface.leveldb.accountindexing import CountableList
from mythril.ethereum.interface.leveldb.accountindexing import ReceiptForStorage, AccountIndexer from mythril.ethereum.interface.leveldb.accountindexing import (
ReceiptForStorage,
AccountIndexer,
)
import logging import logging
from ethereum import utils from ethereum import utils
from ethereum.block import BlockHeader, Block from ethereum.block import BlockHeader, Block
@ -12,17 +15,19 @@ from mythril.exceptions import AddressNotFoundError
# Per https://github.com/ethereum/go-ethereum/blob/master/core/rawdb/schema.go # Per https://github.com/ethereum/go-ethereum/blob/master/core/rawdb/schema.go
# prefixes and suffixes for keys in geth # prefixes and suffixes for keys in geth
header_prefix = b'h' # header_prefix + num (uint64 big endian) + hash -> header header_prefix = b"h" # header_prefix + num (uint64 big endian) + hash -> header
body_prefix = b'b' # body_prefix + num (uint64 big endian) + hash -> block body body_prefix = b"b" # body_prefix + num (uint64 big endian) + hash -> block body
num_suffix = b'n' # header_prefix + num (uint64 big endian) + num_suffix -> hash num_suffix = b"n" # header_prefix + num (uint64 big endian) + num_suffix -> hash
block_hash_prefix = b'H' # block_hash_prefix + hash -> num (uint64 big endian) block_hash_prefix = b"H" # block_hash_prefix + hash -> num (uint64 big endian)
block_receipts_prefix = b'r' # block_receipts_prefix + num (uint64 big endian) + hash -> block receipts block_receipts_prefix = (
b"r"
) # block_receipts_prefix + num (uint64 big endian) + hash -> block receipts
# known geth keys # known geth keys
head_header_key = b'LastBlock' # head (latest) header hash head_header_key = b"LastBlock" # head (latest) header hash
# custom prefixes # custom prefixes
address_prefix = b'AM' # address_prefix + hash -> address address_prefix = b"AM" # address_prefix + hash -> address
# custom keys # custom keys
address_mapping_head_key = b'accountMapping' # head (latest) number of indexed block address_mapping_head_key = b"accountMapping" # head (latest) number of indexed block
def _format_block_number(number): def _format_block_number(number):
@ -36,7 +41,7 @@ def _encode_hex(v):
""" """
encodes hash as hex encodes hash as hex
""" """
return '0x' + utils.encode_hex(v) return "0x" + utils.encode_hex(v)
class LevelDBReader(object): class LevelDBReader(object):
@ -83,7 +88,10 @@ class LevelDBReader(object):
num = self._get_block_number(block_hash) num = self._get_block_number(block_hash)
self.head_block_header = self._get_block_header(block_hash, num) self.head_block_header = self._get_block_header(block_hash, num)
# find header with valid state # find header with valid state
while not self.db.get(self.head_block_header.state_root) and self.head_block_header.prevhash is not None: while (
not self.db.get(self.head_block_header.state_root)
and self.head_block_header.prevhash is not None
):
block_hash = self.head_block_header.prevhash block_hash = self.head_block_header.prevhash
num = self._get_block_number(block_hash) num = self._get_block_number(block_hash)
self.head_block_header = self._get_block_header(block_hash, num) self.head_block_header = self._get_block_header(block_hash, num)
@ -192,11 +200,11 @@ class EthLevelDB(object):
try: try:
address = _encode_hex(indexer.get_contract_by_hash(address_hash)) address = _encode_hex(indexer.get_contract_by_hash(address_hash))
except AddressNotFoundError: except AddressNotFoundError:
''' """
The hash->address mapping does not exist in our index. If the index is up-to-date, this likely means The hash->address mapping does not exist in our index. If the index is up-to-date, this likely means
that the contract was created by an internal transaction. Skip this contract as right now we don't that the contract was created by an internal transaction. Skip this contract as right now we don't
have a good solution for this. have a good solution for this.
''' """
continue continue
@ -253,4 +261,6 @@ class EthLevelDB(object):
gets account storage data at position gets account storage data at position
""" """
account = self.reader._get_account(address) account = self.reader._get_account(address)
return _encode_hex(utils.zpad(utils.encode_int(account.get_storage_data(position)), 32)) return _encode_hex(
utils.zpad(utils.encode_int(account.get_storage_data(position)), 32)
)

@ -1,24 +1,39 @@
import rlp import rlp
import binascii import binascii
from ethereum.utils import normalize_address, hash32, trie_root, \ from ethereum.utils import (
big_endian_int, address, int256, encode_hex, encode_int, \ normalize_address,
big_endian_to_int, int_to_addr, zpad, parse_as_bin, parse_as_int, \ hash32,
decode_hex, sha3, is_string, is_numeric trie_root,
big_endian_int,
address,
int256,
encode_hex,
encode_int,
big_endian_to_int,
int_to_addr,
zpad,
parse_as_bin,
parse_as_int,
decode_hex,
sha3,
is_string,
is_numeric,
)
from rlp.sedes import big_endian_int, Binary, binary, CountableList from rlp.sedes import big_endian_int, Binary, binary, CountableList
from ethereum import utils from ethereum import utils
from ethereum import trie from ethereum import trie
from ethereum.trie import Trie from ethereum.trie import Trie
from ethereum.securetrie import SecureTrie from ethereum.securetrie import SecureTrie
BLANK_HASH = utils.sha3(b'') BLANK_HASH = utils.sha3(b"")
BLANK_ROOT = utils.sha3rlp(b'') BLANK_ROOT = utils.sha3rlp(b"")
STATE_DEFAULTS = { STATE_DEFAULTS = {
"txindex": 0, "txindex": 0,
"gas_used": 0, "gas_used": 0,
"gas_limit": 3141592, "gas_limit": 3141592,
"block_number": 0, "block_number": 0,
"block_coinbase": '\x00' * 20, "block_coinbase": "\x00" * 20,
"block_difficulty": 1, "block_difficulty": 1,
"timestamp": 0, "timestamp": 0,
"logs": [], "logs": [],
@ -37,10 +52,10 @@ class Account(rlp.Serializable):
""" """
fields = [ fields = [
('nonce', big_endian_int), ("nonce", big_endian_int),
('balance', big_endian_int), ("balance", big_endian_int),
('storage', trie_root), ("storage", trie_root),
('code_hash', hash32) ("code_hash", hash32),
] ]
def __init__(self, nonce, balance, storage, code_hash, db, addr): def __init__(self, nonce, balance, storage, code_hash, db, addr):
@ -69,7 +84,8 @@ class Account(rlp.Serializable):
if key not in self.storage_cache: if key not in self.storage_cache:
v = self.storage_trie.get(utils.encode_int32(key)) v = self.storage_trie.get(utils.encode_int32(key))
self.storage_cache[key] = utils.big_endian_to_int( self.storage_cache[key] = utils.big_endian_to_int(
rlp.decode(v) if v else b'') rlp.decode(v) if v else b""
)
return self.storage_cache[key] return self.storage_cache[key]
@classmethod @classmethod
@ -77,7 +93,7 @@ class Account(rlp.Serializable):
""" """
creates a blank account creates a blank account
""" """
db.put(BLANK_HASH, b'') db.put(BLANK_HASH, b"")
o = cls(initial_nonce, 0, trie.BLANK_ROOT, BLANK_HASH, db, addr) o = cls(initial_nonce, 0, trie.BLANK_ROOT, BLANK_HASH, db, addr)
o.existent_at_start = False o.existent_at_start = False
return o return o
@ -88,6 +104,7 @@ class Account(rlp.Serializable):
""" """
return self.nonce == 0 and self.balance == 0 and self.code_hash == BLANK_HASH return self.nonce == 0 and self.balance == 0 and self.code_hash == BLANK_HASH
class State: class State:
""" """
adjusted state from ethereum.state adjusted state from ethereum.state
@ -106,14 +123,15 @@ class State:
if addr in self.cache: if addr in self.cache:
return self.cache[addr] return self.cache[addr]
rlpdata = self.secure_trie.get(addr) rlpdata = self.secure_trie.get(addr)
if rlpdata == trie.BLANK_NODE and len(addr) == 32: # support for hashed addresses if (
rlpdata == trie.BLANK_NODE and len(addr) == 32
): # support for hashed addresses
rlpdata = self.trie.get(addr) rlpdata = self.trie.get(addr)
if rlpdata != trie.BLANK_NODE: if rlpdata != trie.BLANK_NODE:
o = rlp.decode(rlpdata, Account, db=self.db, address=addr) o = rlp.decode(rlpdata, Account, db=self.db, address=addr)
else: else:
o = Account.blank_account( o = Account.blank_account(self.db, addr, 0)
self.db, addr, 0)
self.cache[addr] = o self.cache[addr] = o
o._mutable = True o._mutable = True
o._cached_rlp = None o._cached_rlp = None

@ -1,4 +1,4 @@
from abc import (abstractmethod) from abc import abstractmethod
from .constants import BLOCK_TAGS, BLOCK_TAG_LATEST from .constants import BLOCK_TAGS, BLOCK_TAG_LATEST
from .utils import hex_to_dec, validate_block from .utils import hex_to_dec, validate_block
@ -8,13 +8,14 @@ ETH_DEFAULT_RPC_PORT = 8545
PARITY_DEFAULT_RPC_PORT = 8545 PARITY_DEFAULT_RPC_PORT = 8545
PYETHAPP_DEFAULT_RPC_PORT = 4000 PYETHAPP_DEFAULT_RPC_PORT = 4000
MAX_RETRIES = 3 MAX_RETRIES = 3
JSON_MEDIA_TYPE = 'application/json' JSON_MEDIA_TYPE = "application/json"
''' """
This code is adapted from: https://github.com/ConsenSys/ethjsonrpc This code is adapted from: https://github.com/ConsenSys/ethjsonrpc
''' """
class BaseClient(object):
class BaseClient(object):
@abstractmethod @abstractmethod
def _call(self, method, params=None, _id=1): def _call(self, method, params=None, _id=1):
pass pass
@ -25,7 +26,7 @@ class BaseClient(object):
TESTED TESTED
""" """
return self._call('eth_coinbase') return self._call("eth_coinbase")
def eth_blockNumber(self): def eth_blockNumber(self):
""" """
@ -33,7 +34,7 @@ class BaseClient(object):
TESTED TESTED
""" """
return hex_to_dec(self._call('eth_blockNumber')) return hex_to_dec(self._call("eth_blockNumber"))
def eth_getBalance(self, address=None, block=BLOCK_TAG_LATEST): def eth_getBalance(self, address=None, block=BLOCK_TAG_LATEST):
""" """
@ -43,7 +44,7 @@ class BaseClient(object):
""" """
address = address or self.eth_coinbase() address = address or self.eth_coinbase()
block = validate_block(block) block = validate_block(block)
return hex_to_dec(self._call('eth_getBalance', [address, block])) return hex_to_dec(self._call("eth_getBalance", [address, block]))
def eth_getStorageAt(self, address=None, position=0, block=BLOCK_TAG_LATEST): def eth_getStorageAt(self, address=None, position=0, block=BLOCK_TAG_LATEST):
""" """
@ -52,7 +53,7 @@ class BaseClient(object):
TESTED TESTED
""" """
block = validate_block(block) block = validate_block(block)
return self._call('eth_getStorageAt', [address, hex(position), block]) return self._call("eth_getStorageAt", [address, hex(position), block])
def eth_getCode(self, address, default_block=BLOCK_TAG_LATEST): def eth_getCode(self, address, default_block=BLOCK_TAG_LATEST):
""" """
@ -63,7 +64,7 @@ class BaseClient(object):
if isinstance(default_block, str): if isinstance(default_block, str):
if default_block not in BLOCK_TAGS: if default_block not in BLOCK_TAGS:
raise ValueError raise ValueError
return self._call('eth_getCode', [address, default_block]) return self._call("eth_getCode", [address, default_block])
def eth_getBlockByNumber(self, block=BLOCK_TAG_LATEST, tx_objects=True): def eth_getBlockByNumber(self, block=BLOCK_TAG_LATEST, tx_objects=True):
""" """
@ -72,7 +73,7 @@ class BaseClient(object):
TESTED TESTED
""" """
block = validate_block(block) block = validate_block(block)
return self._call('eth_getBlockByNumber', [block, tx_objects]) return self._call("eth_getBlockByNumber", [block, tx_objects])
def eth_getTransactionReceipt(self, tx_hash): def eth_getTransactionReceipt(self, tx_hash):
""" """
@ -80,4 +81,4 @@ class BaseClient(object):
TESTED TESTED
""" """
return self._call('eth_getTransactionReceipt', [tx_hash]) return self._call("eth_getTransactionReceipt", [tx_hash])

@ -3,7 +3,12 @@ import logging
import requests import requests
from requests.adapters import HTTPAdapter from requests.adapters import HTTPAdapter
from requests.exceptions import ConnectionError as RequestsConnectionError from requests.exceptions import ConnectionError as RequestsConnectionError
from .exceptions import (ConnectionError, BadStatusCodeError, BadJsonError, BadResponseError) from .exceptions import (
ConnectionError,
BadStatusCodeError,
BadJsonError,
BadResponseError,
)
from .base_client import BaseClient from .base_client import BaseClient
GETH_DEFAULT_RPC_PORT = 8545 GETH_DEFAULT_RPC_PORT = 8545
@ -11,17 +16,19 @@ ETH_DEFAULT_RPC_PORT = 8545
PARITY_DEFAULT_RPC_PORT = 8545 PARITY_DEFAULT_RPC_PORT = 8545
PYETHAPP_DEFAULT_RPC_PORT = 4000 PYETHAPP_DEFAULT_RPC_PORT = 4000
MAX_RETRIES = 3 MAX_RETRIES = 3
JSON_MEDIA_TYPE = 'application/json' JSON_MEDIA_TYPE = "application/json"
''' """
This code is adapted from: https://github.com/ConsenSys/ethjsonrpc This code is adapted from: https://github.com/ConsenSys/ethjsonrpc
''' """
class EthJsonRpc(BaseClient): class EthJsonRpc(BaseClient):
""" """
Ethereum JSON-RPC client class Ethereum JSON-RPC client class
""" """
def __init__(self, host='localhost', port=GETH_DEFAULT_RPC_PORT, tls=False): def __init__(self, host="localhost", port=GETH_DEFAULT_RPC_PORT, tls=False):
self.host = host self.host = host
self.port = port self.port = port
self.tls = tls self.tls = tls
@ -31,17 +38,12 @@ class EthJsonRpc(BaseClient):
def _call(self, method, params=None, _id=1): def _call(self, method, params=None, _id=1):
params = params or [] params = params or []
data = { data = {"jsonrpc": "2.0", "method": method, "params": params, "id": _id}
'jsonrpc': '2.0', scheme = "http"
'method': method,
'params': params,
'id': _id,
}
scheme = 'http'
if self.tls: if self.tls:
scheme += 's' scheme += "s"
url = '{}://{}:{}'.format(scheme, self.host, self.port) url = "{}://{}:{}".format(scheme, self.host, self.port)
headers = {'Content-Type': JSON_MEDIA_TYPE} headers = {"Content-Type": JSON_MEDIA_TYPE}
logging.debug("rpc send: %s" % json.dumps(data)) logging.debug("rpc send: %s" % json.dumps(data))
try: try:
r = self.session.post(url, headers=headers, data=json.dumps(data)) r = self.session.post(url, headers=headers, data=json.dumps(data))
@ -55,7 +57,7 @@ class EthJsonRpc(BaseClient):
except ValueError: except ValueError:
raise BadJsonError(r.text) raise BadJsonError(r.text)
try: try:
return response['result'] return response["result"]
except KeyError: except KeyError:
raise BadResponseError(response) raise BadResponseError(response)

@ -1,8 +1,4 @@
BLOCK_TAG_EARLIEST = 'earliest' BLOCK_TAG_EARLIEST = "earliest"
BLOCK_TAG_LATEST = 'latest' BLOCK_TAG_LATEST = "latest"
BLOCK_TAG_PENDING = 'pending' BLOCK_TAG_PENDING = "pending"
BLOCK_TAGS = ( BLOCK_TAGS = (BLOCK_TAG_EARLIEST, BLOCK_TAG_LATEST, BLOCK_TAG_PENDING)
BLOCK_TAG_EARLIEST,
BLOCK_TAG_LATEST,
BLOCK_TAG_PENDING,
)

@ -13,12 +13,13 @@ def clean_hex(d):
Convert decimal to hex and remove the "L" suffix that is appended to large Convert decimal to hex and remove the "L" suffix that is appended to large
numbers numbers
""" """
return hex(d).rstrip('L') return hex(d).rstrip("L")
def validate_block(block): def validate_block(block):
if isinstance(block, str): if isinstance(block, str):
if block not in BLOCK_TAGS: if block not in BLOCK_TAGS:
raise ValueError('invalid block tag') raise ValueError("invalid block tag")
if isinstance(block, int): if isinstance(block, int):
block = hex(block) block = hex(block)
return block return block
@ -28,11 +29,11 @@ def wei_to_ether(wei):
""" """
Convert wei to ether Convert wei to ether
""" """
return 1.0 * wei / 10**18 return 1.0 * wei / 10 ** 18
def ether_to_wei(ether): def ether_to_wei(ether):
""" """
Convert ether to wei Convert ether to wei
""" """
return ether * 10**18 return ether * 10 ** 18

@ -19,107 +19,233 @@ import mythril.support.signatures as sigs
def exit_with_error(format_, message): def exit_with_error(format_, message):
if format_ == 'text' or format_ == 'markdown': if format_ == "text" or format_ == "markdown":
print(message) print(message)
else: else:
result = {'success': False, 'error': str(message), 'issues': []} result = {"success": False, "error": str(message), "issues": []}
print(json.dumps(result)) print(json.dumps(result))
sys.exit() sys.exit()
def main(): def main():
parser = argparse.ArgumentParser(description='Security analysis of Ethereum smart contracts') parser = argparse.ArgumentParser(
parser.add_argument("solidity_file", nargs='*') description="Security analysis of Ethereum smart contracts"
)
commands = parser.add_argument_group('commands') parser.add_argument("solidity_file", nargs="*")
commands.add_argument('-g', '--graph', help='generate a control flow graph')
commands.add_argument('-V', '--version', action='store_true', commands = parser.add_argument_group("commands")
help='print the Mythril version number and exit') commands.add_argument("-g", "--graph", help="generate a control flow graph")
commands.add_argument('-x', '--fire-lasers', action='store_true', commands.add_argument(
help='detect vulnerabilities, use with -c, -a or solidity file(s)') "-V",
commands.add_argument('-t', '--truffle', action='store_true', "--version",
help='analyze a truffle project (run from project dir)') action="store_true",
commands.add_argument('-d', '--disassemble', action='store_true', help='print disassembly') help="print the Mythril version number and exit",
commands.add_argument('-j', '--statespace-json', help='dumps the statespace json', metavar='OUTPUT_FILE') )
commands.add_argument(
inputs = parser.add_argument_group('input arguments') "-x",
inputs.add_argument('-c', '--code', help='hex-encoded bytecode string ("6060604052...")', metavar='BYTECODE') "--fire-lasers",
inputs.add_argument('-f', '--codefile', help='file containing hex-encoded bytecode string', action="store_true",
metavar='BYTECODEFILE', type=argparse.FileType('r')) help="detect vulnerabilities, use with -c, -a or solidity file(s)",
inputs.add_argument('-a', '--address', help='pull contract from the blockchain', metavar='CONTRACT_ADDRESS') )
inputs.add_argument('-l', '--dynld', action='store_true', help='auto-load dependencies from the blockchain') commands.add_argument(
"-t",
outputs = parser.add_argument_group('output formats') "--truffle",
outputs.add_argument('-o', '--outform', choices=['text', 'markdown', 'json'], default='text', action="store_true",
help='report output format', metavar='<text/markdown/json>') help="analyze a truffle project (run from project dir)",
outputs.add_argument('--verbose-report', action='store_true', help='Include debugging information in report') )
commands.add_argument(
database = parser.add_argument_group('local contracts database') "-d", "--disassemble", action="store_true", help="print disassembly"
database.add_argument('-s', '--search', help='search the contract database', metavar='EXPRESSION') )
database.add_argument('--leveldb-dir', help='specify leveldb directory for search or direct access operations', metavar='LEVELDB_PATH') commands.add_argument(
"-j",
utilities = parser.add_argument_group('utilities') "--statespace-json",
utilities.add_argument('--hash', help='calculate function signature hash', metavar='SIGNATURE') help="dumps the statespace json",
utilities.add_argument('--storage', help='read state variables from storage index, use with -a', metavar="OUTPUT_FILE",
metavar='INDEX,NUM_SLOTS,[array] / mapping,INDEX,[KEY1, KEY2...]') )
utilities.add_argument('--solv',
help='specify solidity compiler version. If not present, will try to install it (Experimental)', inputs = parser.add_argument_group("input arguments")
metavar='SOLV') inputs.add_argument(
utilities.add_argument('--contract-hash-to-address', help='returns corresponding address for a contract address hash', metavar='SHA3_TO_LOOK_FOR') "-c",
"--code",
options = parser.add_argument_group('options') help='hex-encoded bytecode string ("6060604052...")',
options.add_argument('-m', '--modules', help='Comma-separated list of security analysis modules', metavar='MODULES') metavar="BYTECODE",
options.add_argument('--max-depth', type=int, default=22, help='Maximum recursion depth for symbolic execution') )
inputs.add_argument(
options.add_argument('--strategy', choices=['dfs', 'bfs', 'naive-random', 'weighted-random'], "-f",
default='dfs', help='Symbolic execution strategy') "--codefile",
options.add_argument('--max-transaction-count', type=int, default=3, help='Maximum number of transactions issued by laser') help="file containing hex-encoded bytecode string",
metavar="BYTECODEFILE",
options.add_argument('--execution-timeout', type=int, default=600, help="The amount of seconds to spend on symbolic execution") type=argparse.FileType("r"),
options.add_argument('--create-timeout', type=int, default=10, help="The amount of seconds to spend on " )
"the initial contract creation") inputs.add_argument(
options.add_argument('--solc-args', help='Extra arguments for solc') "-a",
options.add_argument('--phrack', action='store_true', help='Phrack-style call graph') "--address",
options.add_argument('--enable-physics', action='store_true', help='enable graph physics simulation') help="pull contract from the blockchain",
options.add_argument('-v', type=int, help='log level (0-2)', metavar='LOG_LEVEL') metavar="CONTRACT_ADDRESS",
options.add_argument('-q', '--query-signature', action='store_true', help='Lookup function signatures through www.4byte.directory') )
inputs.add_argument(
rpc = parser.add_argument_group('RPC options') "-l",
rpc.add_argument('-i', action='store_true', help='Preset: Infura Node service (Mainnet)') "--dynld",
rpc.add_argument('--rpc', help='custom RPC settings', metavar='HOST:PORT / ganache / infura-[network_name]') action="store_true",
rpc.add_argument('--rpctls', type=bool, default=False, help='RPC connection over TLS') help="auto-load dependencies from the blockchain",
)
outputs = parser.add_argument_group("output formats")
outputs.add_argument(
"-o",
"--outform",
choices=["text", "markdown", "json"],
default="text",
help="report output format",
metavar="<text/markdown/json>",
)
outputs.add_argument(
"--verbose-report",
action="store_true",
help="Include debugging information in report",
)
database = parser.add_argument_group("local contracts database")
database.add_argument(
"-s", "--search", help="search the contract database", metavar="EXPRESSION"
)
database.add_argument(
"--leveldb-dir",
help="specify leveldb directory for search or direct access operations",
metavar="LEVELDB_PATH",
)
utilities = parser.add_argument_group("utilities")
utilities.add_argument(
"--hash", help="calculate function signature hash", metavar="SIGNATURE"
)
utilities.add_argument(
"--storage",
help="read state variables from storage index, use with -a",
metavar="INDEX,NUM_SLOTS,[array] / mapping,INDEX,[KEY1, KEY2...]",
)
utilities.add_argument(
"--solv",
help="specify solidity compiler version. If not present, will try to install it (Experimental)",
metavar="SOLV",
)
utilities.add_argument(
"--contract-hash-to-address",
help="returns corresponding address for a contract address hash",
metavar="SHA3_TO_LOOK_FOR",
)
options = parser.add_argument_group("options")
options.add_argument(
"-m",
"--modules",
help="Comma-separated list of security analysis modules",
metavar="MODULES",
)
options.add_argument(
"--max-depth",
type=int,
default=22,
help="Maximum recursion depth for symbolic execution",
)
options.add_argument(
"--strategy",
choices=["dfs", "bfs", "naive-random", "weighted-random"],
default="dfs",
help="Symbolic execution strategy",
)
options.add_argument(
"--max-transaction-count",
type=int,
default=3,
help="Maximum number of transactions issued by laser",
)
options.add_argument(
"--execution-timeout",
type=int,
default=600,
help="The amount of seconds to spend on symbolic execution",
)
options.add_argument(
"--create-timeout",
type=int,
default=10,
help="The amount of seconds to spend on " "the initial contract creation",
)
options.add_argument("--solc-args", help="Extra arguments for solc")
options.add_argument(
"--phrack", action="store_true", help="Phrack-style call graph"
)
options.add_argument(
"--enable-physics", action="store_true", help="enable graph physics simulation"
)
options.add_argument("-v", type=int, help="log level (0-2)", metavar="LOG_LEVEL")
options.add_argument(
"-q",
"--query-signature",
action="store_true",
help="Lookup function signatures through www.4byte.directory",
)
rpc = parser.add_argument_group("RPC options")
rpc.add_argument(
"-i", action="store_true", help="Preset: Infura Node service (Mainnet)"
)
rpc.add_argument(
"--rpc",
help="custom RPC settings",
metavar="HOST:PORT / ganache / infura-[network_name]",
)
rpc.add_argument(
"--rpctls", type=bool, default=False, help="RPC connection over TLS"
)
# Get config values # Get config values
args = parser.parse_args() args = parser.parse_args()
if args.version: if args.version:
if args.outform == 'json': if args.outform == "json":
print(json.dumps({'version_str': VERSION})) print(json.dumps({"version_str": VERSION}))
else: else:
print("Mythril version {}".format(VERSION)) print("Mythril version {}".format(VERSION))
sys.exit() sys.exit()
# Parse cmdline args # Parse cmdline args
if not (args.search or args.hash or args.disassemble or args.graph or args.fire_lasers if not (
or args.storage or args.truffle or args.statespace_json or args.contract_hash_to_address): args.search
or args.hash
or args.disassemble
or args.graph
or args.fire_lasers
or args.storage
or args.truffle
or args.statespace_json
or args.contract_hash_to_address
):
parser.print_help() parser.print_help()
sys.exit() sys.exit()
if args.v: if args.v:
if 0 <= args.v < 3: if 0 <= args.v < 3:
coloredlogs.install( coloredlogs.install(
fmt='%(name)s[%(process)d] %(levelname)s %(message)s', fmt="%(name)s[%(process)d] %(levelname)s %(message)s",
level=[logging.NOTSET, logging.INFO, logging.DEBUG][args.v] level=[logging.NOTSET, logging.INFO, logging.DEBUG][args.v],
) )
else: else:
exit_with_error(args.outform, "Invalid -v value, you can find valid values in usage") exit_with_error(
args.outform, "Invalid -v value, you can find valid values in usage"
)
if args.query_signature: if args.query_signature:
if sigs.ethereum_input_decoder == None: if sigs.ethereum_input_decoder == None:
exit_with_error(args.outform, "The --query-signature function requires the python package ethereum-input-decoder") exit_with_error(
args.outform,
"The --query-signature function requires the python package ethereum-input-decoder",
)
# -- commands -- # -- commands --
if args.hash: if args.hash:
@ -131,9 +257,12 @@ def main():
# infura = None, rpc = None, rpctls = None # infura = None, rpc = None, rpctls = None
# solc_args = None, dynld = None, max_recursion_depth = 12): # solc_args = None, dynld = None, max_recursion_depth = 12):
mythril = Mythril(solv=args.solv, dynld=args.dynld, mythril = Mythril(
solc_args=args.solc_args, solv=args.solv,
enable_online_lookup=args.query_signature) dynld=args.dynld,
solc_args=args.solc_args,
enable_online_lookup=args.query_signature,
)
if args.dynld and not (args.rpc or args.i): if args.dynld and not (args.rpc or args.i):
mythril.set_api_from_config_path() mythril.set_api_from_config_path()
@ -147,7 +276,9 @@ def main():
mythril.set_api_rpc_localhost() mythril.set_api_rpc_localhost()
elif args.search or args.contract_hash_to_address: elif args.search or args.contract_hash_to_address:
# Open LevelDB if necessary # Open LevelDB if necessary
mythril.set_api_leveldb(mythril.leveldb_dir if not args.leveldb_dir else args.leveldb_dir) mythril.set_api_leveldb(
mythril.leveldb_dir if not args.leveldb_dir else args.leveldb_dir
)
if args.search: if args.search:
# Database search ops # Database search ops
@ -169,7 +300,8 @@ def main():
mythril.analyze_truffle_project(args) mythril.analyze_truffle_project(args)
except FileNotFoundError: except FileNotFoundError:
print( print(
"Build directory not found. Make sure that you start the analysis from the project root, and that 'truffle compile' has executed successfully.") "Build directory not found. Make sure that you start the analysis from the project root, and that 'truffle compile' has executed successfully."
)
sys.exit() sys.exit()
# Load / compile input contracts # Load / compile input contracts
@ -179,7 +311,7 @@ def main():
# Load from bytecode # Load from bytecode
address, _ = mythril.load_from_bytecode(args.code) address, _ = mythril.load_from_bytecode(args.code)
elif args.codefile: elif args.codefile:
bytecode = ''.join([l.strip() for l in args.codefile if len(l.strip()) > 0]) bytecode = "".join([l.strip() for l in args.codefile if len(l.strip()) > 0])
address, _ = mythril.load_from_bytecode(bytecode) address, _ = mythril.load_from_bytecode(bytecode)
elif args.address: elif args.address:
# Get bytecode from a contract address # Get bytecode from a contract address
@ -187,37 +319,55 @@ def main():
elif args.solidity_file: elif args.solidity_file:
# Compile Solidity source file(s) # Compile Solidity source file(s)
if args.graph and len(args.solidity_file) > 1: if args.graph and len(args.solidity_file) > 1:
exit_with_error(args.outform, exit_with_error(
"Cannot generate call graphs from multiple input files. Please do it one at a time.") args.outform,
"Cannot generate call graphs from multiple input files. Please do it one at a time.",
)
address, _ = mythril.load_from_solidity(args.solidity_file) # list of files address, _ = mythril.load_from_solidity(args.solidity_file) # list of files
else: else:
exit_with_error(args.outform, exit_with_error(
"No input bytecode. Please provide EVM code via -c BYTECODE, -a ADDRESS, or -i SOLIDITY_FILES") args.outform,
"No input bytecode. Please provide EVM code via -c BYTECODE, -a ADDRESS, or -i SOLIDITY_FILES",
)
# Commands # Commands
if args.storage: if args.storage:
if not args.address: if not args.address:
exit_with_error(args.outform, exit_with_error(
"To read storage, provide the address of a deployed contract with the -a option.") args.outform,
"To read storage, provide the address of a deployed contract with the -a option.",
storage = mythril.get_state_variable_from_storage(address=address, )
params=[a.strip() for a in args.storage.strip().split(",")])
storage = mythril.get_state_variable_from_storage(
address=address,
params=[a.strip() for a in args.storage.strip().split(",")],
)
print(storage) print(storage)
elif args.disassemble: elif args.disassemble:
easm_text = mythril.contracts[0].get_easm() # or mythril.disassemble(mythril.contracts[0]) easm_text = mythril.contracts[
0
].get_easm() # or mythril.disassemble(mythril.contracts[0])
sys.stdout.write(easm_text) sys.stdout.write(easm_text)
elif args.graph or args.fire_lasers: elif args.graph or args.fire_lasers:
if not mythril.contracts: if not mythril.contracts:
exit_with_error(args.outform, "input files do not contain any valid contracts") exit_with_error(
args.outform, "input files do not contain any valid contracts"
)
if args.graph: if args.graph:
html = mythril.graph_html(strategy=args.strategy, contract=mythril.contracts[0], address=address, html = mythril.graph_html(
enable_physics=args.enable_physics, phrackify=args.phrack, strategy=args.strategy,
max_depth=args.max_depth, execution_timeout=args.execution_timeout, contract=mythril.contracts[0],
create_timeout=args.create_timeout) address=address,
enable_physics=args.enable_physics,
phrackify=args.phrack,
max_depth=args.max_depth,
execution_timeout=args.execution_timeout,
create_timeout=args.create_timeout,
)
try: try:
with open(args.graph, "w") as f: with open(args.graph, "w") as f:
@ -226,27 +376,40 @@ def main():
exit_with_error(args.outform, "Error saving graph: " + str(e)) exit_with_error(args.outform, "Error saving graph: " + str(e))
else: else:
report = mythril.fire_lasers(strategy=args.strategy, address=address, report = mythril.fire_lasers(
modules=[m.strip() for m in args.modules.strip().split(",")] if args.modules else [], strategy=args.strategy,
verbose_report=args.verbose_report, address=address,
max_depth=args.max_depth, execution_timeout=args.execution_timeout, modules=[m.strip() for m in args.modules.strip().split(",")]
create_timeout=args.create_timeout, if args.modules
max_transaction_count=args.max_transaction_count) else [],
verbose_report=args.verbose_report,
max_depth=args.max_depth,
execution_timeout=args.execution_timeout,
create_timeout=args.create_timeout,
max_transaction_count=args.max_transaction_count,
)
outputs = { outputs = {
'json': report.as_json(), "json": report.as_json(),
'text': report.as_text(), "text": report.as_text(),
'markdown': report.as_markdown() "markdown": report.as_markdown(),
} }
print(outputs[args.outform]) print(outputs[args.outform])
elif args.statespace_json: elif args.statespace_json:
if not mythril.contracts: if not mythril.contracts:
exit_with_error(args.outform, "input files do not contain any valid contracts") exit_with_error(
args.outform, "input files do not contain any valid contracts"
statespace = mythril.dump_statespace(strategy=args.strategy, contract=mythril.contracts[0], address=address, )
max_depth=args.max_depth, execution_timeout=args.execution_timeout,
create_timeout=args.create_timeout) statespace = mythril.dump_statespace(
strategy=args.strategy,
contract=mythril.contracts[0],
address=address,
max_depth=args.max_depth,
execution_timeout=args.execution_timeout,
create_timeout=args.create_timeout,
)
try: try:
with open(args.statespace_json, "w") as f: with open(args.statespace_json, "w") as f:

@ -11,7 +11,9 @@ to get the necessary elements from the stack and determine the parameters for th
""" """
def get_call_parameters(global_state: GlobalState, dynamic_loader: DynLoader, with_value=False): def get_call_parameters(
global_state: GlobalState, dynamic_loader: DynLoader, with_value=False
):
""" """
Gets call parameters from global state Gets call parameters from global state
Pops the values from the stack and determines output parameters Pops the values from the stack and determines output parameters
@ -22,21 +24,40 @@ def get_call_parameters(global_state: GlobalState, dynamic_loader: DynLoader, wi
""" """
gas, to = global_state.mstate.pop(2) gas, to = global_state.mstate.pop(2)
value = global_state.mstate.pop() if with_value else 0 value = global_state.mstate.pop() if with_value else 0
memory_input_offset, memory_input_size, memory_out_offset, memory_out_size = global_state.mstate.pop(4) memory_input_offset, memory_input_size, memory_out_offset, memory_out_size = global_state.mstate.pop(
4
)
callee_address = get_callee_address(global_state, dynamic_loader, to) callee_address = get_callee_address(global_state, dynamic_loader, to)
callee_account = None callee_account = None
call_data, call_data_type = get_call_data(global_state, memory_input_offset, memory_input_size, False) call_data, call_data_type = get_call_data(
global_state, memory_input_offset, memory_input_size, False
)
if int(callee_address, 16) >= 5 or int(callee_address, 16) == 0: if int(callee_address, 16) >= 5 or int(callee_address, 16) == 0:
call_data, call_data_type = get_call_data(global_state, memory_input_offset, memory_input_size) call_data, call_data_type = get_call_data(
callee_account = get_callee_account(global_state, callee_address, dynamic_loader) global_state, memory_input_offset, memory_input_size
)
return callee_address, callee_account, call_data, value, call_data_type, gas, memory_out_offset, memory_out_size callee_account = get_callee_account(
global_state, callee_address, dynamic_loader
)
def get_callee_address(global_state:GlobalState, dynamic_loader: DynLoader, symbolic_to_address):
return (
callee_address,
callee_account,
call_data,
value,
call_data_type,
gas,
memory_out_offset,
memory_out_size,
)
def get_callee_address(
global_state: GlobalState, dynamic_loader: DynLoader, symbolic_to_address
):
""" """
Gets the address of the callee Gets the address of the callee
:param global_state: state to look in :param global_state: state to look in
@ -51,7 +72,7 @@ def get_callee_address(global_state:GlobalState, dynamic_loader: DynLoader, symb
except TypeError: except TypeError:
logging.debug("Symbolic call encountered") logging.debug("Symbolic call encountered")
match = re.search(r'storage_(\d+)', str(simplify(symbolic_to_address))) match = re.search(r"storage_(\d+)", str(simplify(symbolic_to_address)))
logging.debug("CALL to: " + str(simplify(symbolic_to_address))) logging.debug("CALL to: " + str(simplify(symbolic_to_address)))
if match is None or dynamic_loader is None: if match is None or dynamic_loader is None:
@ -62,7 +83,9 @@ def get_callee_address(global_state:GlobalState, dynamic_loader: DynLoader, symb
# attempt to read the contract address from instance storage # attempt to read the contract address from instance storage
try: try:
callee_address = dynamic_loader.read_storage(environment.active_account.address, index) callee_address = dynamic_loader.read_storage(
environment.active_account.address, index
)
# TODO: verify whether this happens or not # TODO: verify whether this happens or not
except: except:
logging.debug("Error accessing contract storage.") logging.debug("Error accessing contract storage.")
@ -107,7 +130,9 @@ def get_callee_account(global_state, callee_address, dynamic_loader):
raise ValueError() raise ValueError()
logging.debug("Dependency loaded: " + callee_address) logging.debug("Dependency loaded: " + callee_address)
callee_account = Account(callee_address, code, callee_address, dynamic_loader=dynamic_loader) callee_account = Account(
callee_address, code, callee_address, dynamic_loader=dynamic_loader
)
accounts[callee_address] = callee_account accounts[callee_address] = callee_account
return callee_account return callee_account
@ -125,7 +150,11 @@ def get_call_data(global_state, memory_start, memory_size, pad=True):
try: try:
# TODO: This only allows for either fully concrete or fully symbolic calldata. # TODO: This only allows for either fully concrete or fully symbolic calldata.
# Improve management of memory and callata to support a mix between both types. # Improve management of memory and callata to support a mix between both types.
call_data = state.memory[util.get_concrete_int(memory_start):util.get_concrete_int(memory_start + memory_size)] call_data = state.memory[
util.get_concrete_int(memory_start) : util.get_concrete_int(
memory_start + memory_size
)
]
if len(call_data) < 32 and pad: if len(call_data) < 32 and pad:
call_data += [0] * (32 - len(call_data)) call_data += [0] * (32 - len(call_data))
call_data_type = CalldataType.CONCRETE call_data_type = CalldataType.CONCRETE

@ -3,6 +3,7 @@ from enum import Enum
gbl_next_uid = 0 # node counter gbl_next_uid = 0 # node counter
class JumpType(Enum): class JumpType(Enum):
CONDITIONAL = 1 CONDITIONAL = 1
UNCONDITIONAL = 2 UNCONDITIONAL = 2
@ -41,18 +42,24 @@ class Node:
instruction = state.get_current_instruction() instruction = state.get_current_instruction()
code += str(instruction['address']) + " " + instruction['opcode'] code += str(instruction["address"]) + " " + instruction["opcode"]
if instruction['opcode'].startswith("PUSH"): if instruction["opcode"].startswith("PUSH"):
code += " " + instruction['argument'] code += " " + instruction["argument"]
code += "\\n" code += "\\n"
return dict(contract_name=self.contract_name, start_addr=self.start_addr, function_name=self.function_name, return dict(
code=code) contract_name=self.contract_name,
start_addr=self.start_addr,
function_name=self.function_name,
code=code,
)
class Edge: class Edge:
def __init__(self, node_from, node_to, edge_type=JumpType.UNCONDITIONAL, condition=None): def __init__(
self, node_from, node_to, edge_type=JumpType.UNCONDITIONAL, condition=None
):
self.node_from = node_from self.node_from = node_from
self.node_to = node_to self.node_to = node_to
self.type = edge_type self.type = edge_type
@ -63,4 +70,4 @@ class Edge:
@property @property
def as_dict(self): def as_dict(self):
return {"from": self.node_from, 'to': self.node_to} return {"from": self.node_from, "to": self.node_to}

File diff suppressed because it is too large Load Diff

@ -1,5 +1,6 @@
from z3 import ExprRef from z3 import ExprRef
class KeccakFunctionManager: class KeccakFunctionManager:
def __init__(self): def __init__(self):
self.keccak_expression_mapping = {} self.keccak_expression_mapping = {}

@ -15,10 +15,10 @@ class NativeContractException(Exception):
pass pass
def int_to_32bytes(i): # used because int can't fit as bytes function's input def int_to_32bytes(i): # used because int can't fit as bytes function's input
o = [0] * 32 o = [0] * 32
for x in range(32): for x in range(32):
o[31 - x] = i & 0xff o[31 - x] = i & 0xFF
i >>= 8 i >>= 8
return bytes(o) return bytes(o)
@ -26,7 +26,7 @@ def int_to_32bytes(i): # used because int can't fit as bytes function's input
def extract32(data, i): def extract32(data, i):
if i >= len(data): if i >= len(data):
return 0 return 0
o = data[i: min(i + 32, len(data))] o = data[i : min(i + 32, len(data))]
o.extend(bytearray(32 - len(o))) o.extend(bytearray(32 - len(o)))
return bytearray_to_int(o) return bytearray_to_int(o)
@ -41,13 +41,13 @@ def ecrecover(data):
except TypeError: except TypeError:
raise NativeContractException raise NativeContractException
message = b''.join([ALL_BYTES[x] for x in data[0:32]]) message = b"".join([ALL_BYTES[x] for x in data[0:32]])
if r >= secp256k1n or s >= secp256k1n or v < 27 or v > 28: if r >= secp256k1n or s >= secp256k1n or v < 27 or v > 28:
return [] return []
try: try:
pub = ecrecover_to_pub(message, v, r, s) pub = ecrecover_to_pub(message, v, r, s)
except Exception as e: except Exception as e:
logging.info("An error has occured while extracting public key: "+e) logging.info("An error has occured while extracting public key: " + e)
return [] return []
o = [0] * 12 + [x for x in sha3(pub)[-20:]] o = [0] * 12 + [x for x in sha3(pub)[-20:]]
return o return o
@ -66,7 +66,7 @@ def ripemd160(data):
data = bytes(data) data = bytes(data)
except TypeError: except TypeError:
raise NativeContractException raise NativeContractException
return 12*[0]+[i for i in hashlib.new('ripemd160', data).digest()] return 12 * [0] + [i for i in hashlib.new("ripemd160", data).digest()]
def identity(data): def identity(data):
@ -79,4 +79,4 @@ def native_contracts(address, data):
""" """
functions = (ecrecover, sha256, ripemd160, identity) functions = (ecrecover, sha256, ripemd160, identity)
return functions[address-1](data) return functions[address - 1](data)

@ -4,7 +4,10 @@ from copy import copy, deepcopy
from enum import Enum from enum import Enum
from random import randint from random import randint
from mythril.laser.ethereum.evm_exceptions import StackOverflowException, StackUnderflowException from mythril.laser.ethereum.evm_exceptions import (
StackOverflowException,
StackUnderflowException,
)
class CalldataType(Enum): class CalldataType(Enum):
@ -16,6 +19,7 @@ class Storage:
""" """
Storage class represents the storage of an Account Storage class represents the storage of an Account
""" """
def __init__(self, concrete=False, address=None, dynamic_loader=None): def __init__(self, concrete=False, address=None, dynamic_loader=None):
""" """
Constructor for Storage Constructor for Storage
@ -32,7 +36,12 @@ class Storage:
except KeyError: except KeyError:
if self.address and int(self.address[2:], 16) != 0 and self.dynld: if self.address and int(self.address[2:], 16) != 0 and self.dynld:
try: try:
self._storage[item] = int(self.dynld.read_storage(contract_address=self.address, index=int(item)), 16) self._storage[item] = int(
self.dynld.read_storage(
contract_address=self.address, index=int(item)
),
16,
)
return self._storage[item] return self._storage[item]
except ValueError: except ValueError:
pass pass
@ -47,12 +56,21 @@ class Storage:
def keys(self): def keys(self):
return self._storage.keys() return self._storage.keys()
class Account: class Account:
""" """
Account class representing ethereum accounts Account class representing ethereum accounts
""" """
def __init__(self, address, code=None, contract_name="unknown", balance=None, concrete_storage=False,
dynamic_loader=None): def __init__(
self,
address,
code=None,
contract_name="unknown",
balance=None,
concrete_storage=False,
dynamic_loader=None,
):
""" """
Constructor for account Constructor for account
:param address: Address of the account :param address: Address of the account
@ -64,7 +82,9 @@ class Account:
self.nonce = 0 self.nonce = 0
self.code = code or Disassembly("") self.code = code or Disassembly("")
self.balance = balance if balance else BitVec("balance", 256) self.balance = balance if balance else BitVec("balance", 256)
self.storage = Storage(concrete_storage, address=address, dynamic_loader=dynamic_loader) self.storage = Storage(
concrete_storage, address=address, dynamic_loader=dynamic_loader
)
# Metadata # Metadata
self.address = address self.address = address
@ -83,13 +103,19 @@ class Account:
@property @property
def as_dict(self): def as_dict(self):
return {'nonce': self.nonce, 'code': self.code, 'balance': self.balance, 'storage': self.storage} return {
"nonce": self.nonce,
"code": self.code,
"balance": self.balance,
"storage": self.storage,
}
class Environment: class Environment:
""" """
The environment class represents the current execution environment for the symbolic executor The environment class represents the current execution environment for the symbolic executor
""" """
def __init__( def __init__(
self, self,
active_account, active_account,
@ -121,18 +147,24 @@ class Environment:
def __str__(self): def __str__(self):
return str(self.as_dict) return str(self.as_dict)
@property @property
def as_dict(self): def as_dict(self):
return dict(active_account=self.active_account, sender=self.sender, calldata=self.calldata, return dict(
gasprice=self.gasprice, callvalue=self.callvalue, origin=self.origin, active_account=self.active_account,
calldata_type=self.calldata_type) sender=self.sender,
calldata=self.calldata,
gasprice=self.gasprice,
callvalue=self.callvalue,
origin=self.origin,
calldata_type=self.calldata_type,
)
class MachineStack(list): class MachineStack(list):
""" """
Defines EVM stack, overrides the default list to handle overflows Defines EVM stack, overrides the default list to handle overflows
""" """
STACK_LIMIT = 1024 STACK_LIMIT = 1024
def __init__(self, default_list=None): def __init__(self, default_list=None):
@ -146,8 +178,10 @@ class MachineStack(list):
:function: appends the element to list if the size is less than STACK_LIMIT, else throws an error :function: appends the element to list if the size is less than STACK_LIMIT, else throws an error
""" """
if super(MachineStack, self).__len__() >= self.STACK_LIMIT: if super(MachineStack, self).__len__() >= self.STACK_LIMIT:
raise StackOverflowException("Reached the EVM stack limit of {}, you can't append more " raise StackOverflowException(
"elements".format(self.STACK_LIMIT)) "Reached the EVM stack limit of {}, you can't append more "
"elements".format(self.STACK_LIMIT)
)
super(MachineStack, self).append(element) super(MachineStack, self).append(element)
def pop(self, index=-1): def pop(self, index=-1):
@ -166,25 +200,28 @@ class MachineStack(list):
try: try:
return super(MachineStack, self).__getitem__(item) return super(MachineStack, self).__getitem__(item)
except IndexError: except IndexError:
raise StackUnderflowException("Trying to access a stack element which doesn't exist") raise StackUnderflowException(
"Trying to access a stack element which doesn't exist"
)
def __add__(self, other): def __add__(self, other):
""" """
Implement list concatenation if needed Implement list concatenation if needed
""" """
raise NotImplementedError('Implement this if needed') raise NotImplementedError("Implement this if needed")
def __iadd__(self, other): def __iadd__(self, other):
""" """
Implement list concatenation if needed Implement list concatenation if needed
""" """
raise NotImplementedError('Implement this if needed') raise NotImplementedError("Implement this if needed")
class MachineState: class MachineState:
""" """
MachineState represents current machine state also referenced to as \mu MachineState represents current machine state also referenced to as \mu
""" """
def __init__(self, gas): def __init__(self, gas):
""" Constructor for machineState """ """ Constructor for machineState """
self.pc = 0 self.pc = 0
@ -202,13 +239,13 @@ class MachineState:
""" """
if self.memory_size > start + size: if self.memory_size > start + size:
return return
m_extend = (start + size - self.memory_size) m_extend = start + size - self.memory_size
self.memory.extend(bytearray(m_extend)) self.memory.extend(bytearray(m_extend))
def memory_write(self, offset, data): def memory_write(self, offset, data):
""" Writes data to memory starting at offset """ """ Writes data to memory starting at offset """
self.mem_extend(offset, len(data)) self.mem_extend(offset, len(data))
self.memory[offset:offset+len(data)] = data self.memory[offset : offset + len(data)] = data
def pop(self, amount=1): def pop(self, amount=1):
""" Pops amount elements from the stack""" """ Pops amount elements from the stack"""
@ -228,14 +265,29 @@ class MachineState:
@property @property
def as_dict(self): def as_dict(self):
return dict(pc=self.pc, stack=self.stack, memory=self.memory, memsize=self.memory_size, gas=self.gas) return dict(
pc=self.pc,
stack=self.stack,
memory=self.memory,
memsize=self.memory_size,
gas=self.gas,
)
class GlobalState: class GlobalState:
""" """
GlobalState represents the current globalstate GlobalState represents the current globalstate
""" """
def __init__(self, world_state, environment, node, machine_state=None, transaction_stack=None, last_return_data=None):
def __init__(
self,
world_state,
environment,
node,
machine_state=None,
transaction_stack=None,
last_return_data=None,
):
""" Constructor for GlobalState""" """ Constructor for GlobalState"""
self.node = node self.node = node
self.world_state = world_state self.world_state = world_state
@ -250,8 +302,14 @@ class GlobalState:
environment = copy(self.environment) environment = copy(self.environment)
mstate = deepcopy(self.mstate) mstate = deepcopy(self.mstate)
transaction_stack = copy(self.transaction_stack) transaction_stack = copy(self.transaction_stack)
return GlobalState(world_state, environment, self.node, mstate, transaction_stack=transaction_stack, return GlobalState(
last_return_data=self.last_return_data) world_state,
environment,
self.node,
mstate,
transaction_stack=transaction_stack,
last_return_data=self.last_return_data,
)
@property @property
def accounts(self): def accounts(self):
@ -261,7 +319,6 @@ class GlobalState:
def get_current_instruction(self): def get_current_instruction(self):
""" Gets the current instruction for this GlobalState""" """ Gets the current instruction for this GlobalState"""
instructions = self.environment.code.instruction_list instructions = self.environment.code.instruction_list
return instructions[self.mstate.pc] return instructions[self.mstate.pc]
@ -286,6 +343,7 @@ class WorldState:
""" """
The WorldState class represents the world state as described in the yellow paper The WorldState class represents the world state as described in the yellow paper
""" """
def __init__(self, transaction_sequence=None): def __init__(self, transaction_sequence=None):
""" """
Constructor for the world state. Initializes the accounts record Constructor for the world state. Initializes the accounts record
@ -308,7 +366,9 @@ class WorldState:
new_world_state.node = self.node new_world_state.node = self.node
return new_world_state return new_world_state
def create_account(self, balance=0, address=None, concrete_storage=False, dynamic_loader=None): def create_account(
self, balance=0, address=None, concrete_storage=False, dynamic_loader=None
):
""" """
Create non-contract account Create non-contract account
:param address: The account's address :param address: The account's address
@ -318,7 +378,12 @@ class WorldState:
:return: The new account :return: The new account
""" """
address = address if address else self._generate_new_address() address = address if address else self._generate_new_address()
new_account = Account(address, balance=balance, dynamic_loader=dynamic_loader, concrete_storage=concrete_storage) new_account = Account(
address,
balance=balance,
dynamic_loader=dynamic_loader,
concrete_storage=concrete_storage,
)
self._put_account(new_account) self._put_account(new_account)
return new_account return new_account
@ -330,14 +395,16 @@ class WorldState:
:param storage: Initial storage for the contract :param storage: Initial storage for the contract
:return: The new account :return: The new account
""" """
new_account = Account(self._generate_new_address(), code=contract_code, balance=0) new_account = Account(
self._generate_new_address(), code=contract_code, balance=0
)
new_account.storage = storage new_account.storage = storage
self._put_account(new_account) self._put_account(new_account)
def _generate_new_address(self): def _generate_new_address(self):
""" Generates a new address for the global state""" """ Generates a new address for the global state"""
while True: while True:
address = '0x' + ''.join([str(hex(randint(0, 16)))[-1] for _ in range(20)]) address = "0x" + "".join([str(hex(randint(0, 16)))[-1] for _ in range(20)])
if address not in self.accounts.keys(): if address not in self.accounts.keys():
return address return address

@ -2,7 +2,7 @@ from abc import ABC, abstractmethod
class BasicSearchStrategy(ABC): class BasicSearchStrategy(ABC):
__slots__ = 'work_list', 'max_depth' __slots__ = "work_list", "max_depth"
def __init__(self, work_list, max_depth): def __init__(self, work_list, max_depth):
self.work_list = work_list self.work_list = work_list

@ -22,7 +22,11 @@ except ImportError:
if weights is None: if weights is None:
return [population[int(random() * len(population))]] return [population[int(random() * len(population))]]
cum_weights = accumulate(weights) cum_weights = accumulate(weights)
return [population[bisect(cum_weights, random()*cum_weights[-1], 0, len(population)-1)]] return [
population[
bisect(cum_weights, random() * cum_weights[-1], 0, len(population) - 1)
]
]
class DepthFirstSearchStrategy(BasicSearchStrategy): class DepthFirstSearchStrategy(BasicSearchStrategy):
@ -49,6 +53,7 @@ class ReturnRandomNaivelyStrategy(BasicSearchStrategy):
""" """
chooses a random state from the worklist with equal likelihood chooses a random state from the worklist with equal likelihood
""" """
def get_strategic_global_state(self): def get_strategic_global_state(self):
if len(self.work_list) > 0: if len(self.work_list) > 0:
return self.work_list.pop(randrange(len(self.work_list))) return self.work_list.pop(randrange(len(self.work_list)))
@ -62,6 +67,9 @@ class ReturnWeightedRandomStrategy(BasicSearchStrategy):
""" """
def get_strategic_global_state(self): def get_strategic_global_state(self):
probability_distribution = [1/(global_state.mstate.depth+1) for global_state in self.work_list] probability_distribution = [
return self.work_list.pop(choices(range(len(self.work_list)), probability_distribution)[0]) 1 / (global_state.mstate.depth + 1) for global_state in self.work_list
]
return self.work_list.pop(
choices(range(len(self.work_list)), probability_distribution)[0]
)

@ -1,15 +1,21 @@
import logging import logging
from mythril.disassembler.disassembly import Disassembly from mythril.disassembler.disassembly import Disassembly
from mythril.laser.ethereum.state import WorldState from mythril.laser.ethereum.state import WorldState
from mythril.laser.ethereum.transaction import TransactionStartSignal, TransactionEndSignal, \ from mythril.laser.ethereum.transaction import (
ContractCreationTransaction TransactionStartSignal,
TransactionEndSignal,
ContractCreationTransaction,
)
from mythril.laser.ethereum.evm_exceptions import StackUnderflowException from mythril.laser.ethereum.evm_exceptions import StackUnderflowException
from mythril.laser.ethereum.instructions import Instruction from mythril.laser.ethereum.instructions import Instruction
from mythril.laser.ethereum.cfg import NodeFlags, Node, Edge, JumpType from mythril.laser.ethereum.cfg import NodeFlags, Node, Edge, JumpType
from mythril.laser.ethereum.strategy.basic import DepthFirstSearchStrategy from mythril.laser.ethereum.strategy.basic import DepthFirstSearchStrategy
from datetime import datetime, timedelta from datetime import datetime, timedelta
from copy import copy from copy import copy
from mythril.laser.ethereum.transaction import execute_contract_creation, execute_message_call from mythril.laser.ethereum.transaction import (
execute_contract_creation,
execute_message_call,
)
from functools import reduce from functools import reduce
from mythril.laser.ethereum.evm_exceptions import VmException from mythril.laser.ethereum.evm_exceptions import VmException
@ -18,9 +24,9 @@ class SVMError(Exception):
pass pass
''' """
Main symbolic execution engine. Main symbolic execution engine.
''' """
class LaserEVM: class LaserEVM:
@ -28,8 +34,16 @@ class LaserEVM:
Laser EVM class Laser EVM class
""" """
def __init__(self, accounts, dynamic_loader=None, max_depth=float('inf'), execution_timeout=60, create_timeout=10, def __init__(
strategy=DepthFirstSearchStrategy, max_transaction_count=3): self,
accounts,
dynamic_loader=None,
max_depth=float("inf"),
execution_timeout=60,
create_timeout=10,
strategy=DepthFirstSearchStrategy,
max_transaction_count=3,
):
world_state = WorldState() world_state = WorldState()
world_state.accounts = accounts world_state.accounts = accounts
# this sets the initial world state # this sets the initial world state
@ -56,7 +70,9 @@ class LaserEVM:
self.pre_hooks = {} self.pre_hooks = {}
self.post_hooks = {} self.post_hooks = {}
logging.info("LASER EVM initialized with dynamic loader: " + str(dynamic_loader)) logging.info(
"LASER EVM initialized with dynamic loader: " + str(dynamic_loader)
)
@property @property
def accounts(self): def accounts(self):
@ -71,11 +87,19 @@ class LaserEVM:
execute_message_call(self, main_address) execute_message_call(self, main_address)
elif creation_code: elif creation_code:
logging.info("Starting contract creation transaction") logging.info("Starting contract creation transaction")
created_account = execute_contract_creation(self, creation_code, contract_name) created_account = execute_contract_creation(
logging.info("Finished contract creation, found {} open states".format(len(self.open_states))) self, creation_code, contract_name
)
logging.info(
"Finished contract creation, found {} open states".format(
len(self.open_states)
)
)
if len(self.open_states) == 0: if len(self.open_states) == 0:
logging.warning("No contract was created during the execution of contract creation " logging.warning(
"Increase the resources for creation execution (--max-depth or --create-timeout)") "No contract was created during the execution of contract creation "
"Increase the resources for creation execution (--max-depth or --create-timeout)"
)
# Reset code coverage # Reset code coverage
self.coverage = {} self.coverage = {}
@ -83,7 +107,9 @@ class LaserEVM:
initial_coverage = self._get_covered_instructions() initial_coverage = self._get_covered_instructions()
self.time = datetime.now() self.time = datetime.now()
logging.info("Starting message call transaction, iteration: {}".format(i)) logging.info(
"Starting message call transaction, iteration: {}".format(i)
)
execute_message_call(self, created_account.address) execute_message_call(self, created_account.address)
end_coverage = self._get_covered_instructions() end_coverage = self._get_covered_instructions()
@ -91,22 +117,36 @@ class LaserEVM:
break break
logging.info("Finished symbolic execution") logging.info("Finished symbolic execution")
logging.info("%d nodes, %d edges, %d total states", len(self.nodes), len(self.edges), self.total_states) logging.info(
"%d nodes, %d edges, %d total states",
len(self.nodes),
len(self.edges),
self.total_states,
)
for code, coverage in self.coverage.items(): for code, coverage in self.coverage.items():
cov = reduce(lambda sum_, val: sum_ + 1 if val else sum_, coverage[1]) / float(coverage[0]) * 100 cov = (
reduce(lambda sum_, val: sum_ + 1 if val else sum_, coverage[1])
/ float(coverage[0])
* 100
)
logging.info("Achieved {} coverage for code: {}".format(cov, code)) logging.info("Achieved {} coverage for code: {}".format(cov, code))
def _get_covered_instructions(self) -> int: def _get_covered_instructions(self) -> int:
""" Gets the total number of covered instructions for all accounts in the svm""" """ Gets the total number of covered instructions for all accounts in the svm"""
total_covered_instructions = 0 total_covered_instructions = 0
for _, cv in self.coverage.items(): for _, cv in self.coverage.items():
total_covered_instructions += reduce(lambda sum_, val: sum_ + 1 if val else sum_, cv[1]) total_covered_instructions += reduce(
lambda sum_, val: sum_ + 1 if val else sum_, cv[1]
)
return total_covered_instructions return total_covered_instructions
def exec(self, create=False): def exec(self, create=False):
for global_state in self.strategy: for global_state in self.strategy:
if self.execution_timeout and not create: if self.execution_timeout and not create:
if self.time + timedelta(seconds=self.execution_timeout) <= datetime.now(): if (
self.time + timedelta(seconds=self.execution_timeout)
<= datetime.now()
):
return return
elif self.create_timeout and create: elif self.create_timeout and create:
if self.time + timedelta(seconds=self.create_timeout) <= datetime.now(): if self.time + timedelta(seconds=self.create_timeout) <= datetime.now():
@ -126,7 +166,7 @@ class LaserEVM:
def execute_state(self, global_state): def execute_state(self, global_state):
instructions = global_state.environment.code.instruction_list instructions = global_state.environment.code.instruction_list
try: try:
op_code = instructions[global_state.mstate.pc]['opcode'] op_code = instructions[global_state.mstate.pc]["opcode"]
except IndexError: except IndexError:
self.open_states.append(global_state.world_state) self.open_states.append(global_state.world_state)
return [], None return [], None
@ -134,7 +174,9 @@ class LaserEVM:
self._execute_pre_hook(op_code, global_state) self._execute_pre_hook(op_code, global_state)
try: try:
self._measure_coverage(global_state) self._measure_coverage(global_state)
new_global_states = Instruction(op_code, self.dynamic_loader).evaluate(global_state) new_global_states = Instruction(op_code, self.dynamic_loader).evaluate(
global_state
)
except VmException as e: except VmException as e:
transaction, return_global_state = global_state.transaction_stack.pop() transaction, return_global_state = global_state.transaction_stack.pop()
@ -143,29 +185,42 @@ class LaserEVM:
# In this case we don't put an unmodified world state in the open_states list Since in the case of an # In this case we don't put an unmodified world state in the open_states list Since in the case of an
# exceptional halt all changes should be discarded, and this world state would not provide us with a # exceptional halt all changes should be discarded, and this world state would not provide us with a
# previously unseen world state # previously unseen world state
logging.debug("Encountered a VmException, ending path: `{}`".format(str(e))) logging.debug(
"Encountered a VmException, ending path: `{}`".format(str(e))
)
new_global_states = [] new_global_states = []
else: else:
# First execute the post hook for the transaction ending instruction # First execute the post hook for the transaction ending instruction
self._execute_post_hook(op_code, [global_state]) self._execute_post_hook(op_code, [global_state])
new_global_states = self._end_message_call(return_global_state, global_state, new_global_states = self._end_message_call(
revert_changes=True, return_data=None) return_global_state,
global_state,
revert_changes=True,
return_data=None,
)
except TransactionStartSignal as start_signal: except TransactionStartSignal as start_signal:
# Setup new global state # Setup new global state
new_global_state = start_signal.transaction.initial_global_state() new_global_state = start_signal.transaction.initial_global_state()
new_global_state.transaction_stack = copy(global_state.transaction_stack) + [(start_signal.transaction, global_state)] new_global_state.transaction_stack = copy(
global_state.transaction_stack
) + [(start_signal.transaction, global_state)]
new_global_state.node = global_state.node new_global_state.node = global_state.node
new_global_state.mstate.constraints = global_state.mstate.constraints new_global_state.mstate.constraints = global_state.mstate.constraints
return [new_global_state], op_code return [new_global_state], op_code
except TransactionEndSignal as end_signal: except TransactionEndSignal as end_signal:
transaction, return_global_state = end_signal.global_state.transaction_stack.pop() transaction, return_global_state = (
end_signal.global_state.transaction_stack.pop()
)
if return_global_state is None: if return_global_state is None:
if (not isinstance(transaction, ContractCreationTransaction) or transaction.return_data) and not end_signal.revert: if (
not isinstance(transaction, ContractCreationTransaction)
or transaction.return_data
) and not end_signal.revert:
end_signal.global_state.world_state.node = global_state.node end_signal.global_state.world_state.node = global_state.node
self.open_states.append(end_signal.global_state.world_state) self.open_states.append(end_signal.global_state.world_state)
new_global_states = [] new_global_states = []
@ -173,27 +228,37 @@ class LaserEVM:
# First execute the post hook for the transaction ending instruction # First execute the post hook for the transaction ending instruction
self._execute_post_hook(op_code, [end_signal.global_state]) self._execute_post_hook(op_code, [end_signal.global_state])
new_global_states = self._end_message_call(return_global_state, global_state, new_global_states = self._end_message_call(
revert_changes=False or end_signal.revert, return_global_state,
return_data=transaction.return_data) global_state,
revert_changes=False or end_signal.revert,
return_data=transaction.return_data,
)
self._execute_post_hook(op_code, new_global_states) self._execute_post_hook(op_code, new_global_states)
return new_global_states, op_code return new_global_states, op_code
def _end_message_call(self, return_global_state, global_state, revert_changes=False, return_data=None): def _end_message_call(
self, return_global_state, global_state, revert_changes=False, return_data=None
):
# Resume execution of the transaction initializing instruction # Resume execution of the transaction initializing instruction
op_code = return_global_state.environment.code.instruction_list[return_global_state.mstate.pc]['opcode'] op_code = return_global_state.environment.code.instruction_list[
return_global_state.mstate.pc
]["opcode"]
# Set execution result in the return_state # Set execution result in the return_state
return_global_state.last_return_data = return_data return_global_state.last_return_data = return_data
if not revert_changes: if not revert_changes:
return_global_state.world_state = copy(global_state.world_state) return_global_state.world_state = copy(global_state.world_state)
return_global_state.environment.active_account = \ return_global_state.environment.active_account = global_state.accounts[
global_state.accounts[return_global_state.environment.active_account.address] return_global_state.environment.active_account.address
]
# Execute the post instruction handler # Execute the post instruction handler
new_global_states = Instruction(op_code, self.dynamic_loader).evaluate(return_global_state, True) new_global_states = Instruction(op_code, self.dynamic_loader).evaluate(
return_global_state, True
)
# In order to get a nice call graph we need to set the nodes here # In order to get a nice call graph we need to set the nodes here
for state in new_global_states: for state in new_global_states:
@ -207,7 +272,10 @@ class LaserEVM:
instruction_index = global_state.mstate.pc instruction_index = global_state.mstate.pc
if code not in self.coverage.keys(): if code not in self.coverage.keys():
self.coverage[code] = [number_of_instructions, [False]*number_of_instructions] self.coverage[code] = [
number_of_instructions,
[False] * number_of_instructions,
]
self.coverage[code][1][instruction_index] = True self.coverage[code][1][instruction_index] = True
@ -218,19 +286,27 @@ class LaserEVM:
self._new_node_state(state) self._new_node_state(state)
elif opcode == "JUMPI": elif opcode == "JUMPI":
for state in new_states: for state in new_states:
self._new_node_state(state, JumpType.CONDITIONAL, state.mstate.constraints[-1]) self._new_node_state(
state, JumpType.CONDITIONAL, state.mstate.constraints[-1]
)
elif opcode in ("SLOAD", "SSTORE") and len(new_states) > 1: elif opcode in ("SLOAD", "SSTORE") and len(new_states) > 1:
for state in new_states: for state in new_states:
self._new_node_state(state, JumpType.CONDITIONAL, state.mstate.constraints[-1]) self._new_node_state(
state, JumpType.CONDITIONAL, state.mstate.constraints[-1]
)
elif opcode in ("CALL", 'CALLCODE', 'DELEGATECALL', 'STATICCALL'): elif opcode in ("CALL", "CALLCODE", "DELEGATECALL", "STATICCALL"):
assert len(new_states) <= 1 assert len(new_states) <= 1
for state in new_states: for state in new_states:
self._new_node_state(state, JumpType.CALL) self._new_node_state(state, JumpType.CALL)
# Keep track of added contracts so the graph can be generated properly # Keep track of added contracts so the graph can be generated properly
if state.environment.active_account.contract_name not in self.world_state.accounts.keys(): if (
state.environment.active_account.contract_name
not in self.world_state.accounts.keys()
):
self.world_state.accounts[ self.world_state.accounts[
state.environment.active_account.address] = state.environment.active_account state.environment.active_account.address
] = state.environment.active_account
elif opcode == "RETURN": elif opcode == "RETURN":
for state in new_states: for state in new_states:
self._new_node_state(state, JumpType.RETURN) self._new_node_state(state, JumpType.RETURN)
@ -244,29 +320,37 @@ class LaserEVM:
state.node = new_node state.node = new_node
new_node.constraints = state.mstate.constraints new_node.constraints = state.mstate.constraints
self.nodes[new_node.uid] = new_node self.nodes[new_node.uid] = new_node
self.edges.append(Edge(old_node.uid, new_node.uid, edge_type=edge_type, condition=condition)) self.edges.append(
Edge(old_node.uid, new_node.uid, edge_type=edge_type, condition=condition)
)
if edge_type == JumpType.RETURN: if edge_type == JumpType.RETURN:
new_node.flags |= NodeFlags.CALL_RETURN new_node.flags |= NodeFlags.CALL_RETURN
elif edge_type == JumpType.CALL: elif edge_type == JumpType.CALL:
try: try:
if 'retval' in str(state.mstate.stack[-1]): if "retval" in str(state.mstate.stack[-1]):
new_node.flags |= NodeFlags.CALL_RETURN new_node.flags |= NodeFlags.CALL_RETURN
else: else:
new_node.flags |= NodeFlags.FUNC_ENTRY new_node.flags |= NodeFlags.FUNC_ENTRY
except StackUnderflowException: except StackUnderflowException:
new_node.flags |= NodeFlags.FUNC_ENTRY new_node.flags |= NodeFlags.FUNC_ENTRY
address = state.environment.code.instruction_list[state.mstate.pc]['address'] address = state.environment.code.instruction_list[state.mstate.pc]["address"]
environment = state.environment environment = state.environment
disassembly = environment.code disassembly = environment.code
if address in disassembly.address_to_function_name: if address in disassembly.address_to_function_name:
# Enter a new function # Enter a new function
environment.active_function_name = disassembly.address_to_function_name[address] environment.active_function_name = disassembly.address_to_function_name[
address
]
new_node.flags |= NodeFlags.FUNC_ENTRY new_node.flags |= NodeFlags.FUNC_ENTRY
logging.debug( logging.debug(
"- Entering function " + environment.active_account.contract_name + ":" + new_node.function_name) "- Entering function "
+ environment.active_account.contract_name
+ ":"
+ new_node.function_name
)
elif address == 0: elif address == 0:
environment.active_function_name = "fallback" environment.active_function_name = "fallback"

@ -2,6 +2,7 @@ import logging, copy
import mythril.laser.ethereum.util as helper import mythril.laser.ethereum.util as helper
from mythril.laser.ethereum.cfg import JumpType from mythril.laser.ethereum.cfg import JumpType
class TaintRecord: class TaintRecord:
""" """
TaintRecord contains tainting information for a specific (state, node) TaintRecord contains tainting information for a specific (state, node)
@ -109,22 +110,36 @@ class TaintRunner:
records = TaintRunner.execute_node(node, record, index) records = TaintRunner.execute_node(node, record, index)
result.add_records(records) result.add_records(records)
if len(records) == 0: # continue if there is no record to work on if len(records) == 0: # continue if there is no record to work on
continue continue
children = TaintRunner.children(node, statespace, environment, transaction_stack_length) children = TaintRunner.children(
node, statespace, environment, transaction_stack_length
)
for child in children: for child in children:
current_nodes.append((child, records[-1], 0)) current_nodes.append((child, records[-1], 0))
return result return result
@staticmethod @staticmethod
def children(node, statespace, environment, transaction_stack_length): def children(node, statespace, environment, transaction_stack_length):
direct_children = [statespace.nodes[edge.node_to] for edge in statespace.edges if edge.node_from == node.uid and edge.type != JumpType.Transaction] direct_children = [
statespace.nodes[edge.node_to]
for edge in statespace.edges
if edge.node_from == node.uid and edge.type != JumpType.Transaction
]
children = [] children = []
for child in direct_children: for child in direct_children:
if all(len(state.transaction_stack) == transaction_stack_length for state in child.states): if all(
len(state.transaction_stack) == transaction_stack_length
for state in child.states
):
children.append(child) children.append(child)
elif all(len(state.transaction_stack) > transaction_stack_length for state in child.states): elif all(
children += TaintRunner.children(child, statespace, environment, transaction_stack_length) len(state.transaction_stack) > transaction_stack_length
for state in child.states
):
children += TaintRunner.children(
child, statespace, environment, transaction_stack_length
)
return children return children
@staticmethod @staticmethod
@ -150,7 +165,7 @@ class TaintRunner:
new_record = record.clone() new_record = record.clone()
# Apply Change # Apply Change
op = state.get_current_instruction()['opcode'] op = state.get_current_instruction()["opcode"]
if op in TaintRunner.stack_taint_table.keys(): if op in TaintRunner.stack_taint_table.keys():
mutator = TaintRunner.stack_taint_table[op] mutator = TaintRunner.stack_taint_table[op]
@ -171,7 +186,7 @@ class TaintRunner:
TaintRunner.mutate_sstore(new_record, state.mstate.stack[-1]) TaintRunner.mutate_sstore(new_record, state.mstate.stack[-1])
elif op.startswith("LOG"): elif op.startswith("LOG"):
TaintRunner.mutate_log(new_record, op) TaintRunner.mutate_log(new_record, op)
elif op in ('CALL', 'CALLCODE', 'DELEGATECALL', 'STATICCALL'): elif op in ("CALL", "CALLCODE", "DELEGATECALL", "STATICCALL"):
TaintRunner.mutate_call(new_record, op) TaintRunner.mutate_call(new_record, op)
else: else:
logging.debug("Unknown operation encountered: {}".format(op)) logging.debug("Unknown operation encountered: {}".format(op))
@ -263,7 +278,7 @@ class TaintRunner:
@staticmethod @staticmethod
def mutate_call(record, op): def mutate_call(record, op):
pops = 6 pops = 6
if op in ('CALL', 'CALLCODE'): if op in ("CALL", "CALLCODE"):
pops += 1 pops += 1
for _ in range(pops): for _ in range(pops):
record.stack.pop() record.stack.pop()
@ -272,55 +287,55 @@ class TaintRunner:
stack_taint_table = { stack_taint_table = {
# instruction: (taint source, taint target) # instruction: (taint source, taint target)
'POP': (1, 0), "POP": (1, 0),
'ADD': (2, 1), "ADD": (2, 1),
'MUL': (2, 1), "MUL": (2, 1),
'SUB': (2, 1), "SUB": (2, 1),
'AND': (2, 1), "AND": (2, 1),
'OR': (2, 1), "OR": (2, 1),
'XOR': (2, 1), "XOR": (2, 1),
'NOT': (1, 1), "NOT": (1, 1),
'BYTE': (2, 1), "BYTE": (2, 1),
'DIV': (2, 1), "DIV": (2, 1),
'MOD': (2, 1), "MOD": (2, 1),
'SDIV': (2, 1), "SDIV": (2, 1),
'SMOD': (2, 1), "SMOD": (2, 1),
'ADDMOD': (3, 1), "ADDMOD": (3, 1),
'MULMOD': (3, 1), "MULMOD": (3, 1),
'EXP': (2, 1), "EXP": (2, 1),
'SIGNEXTEND': (2, 1), "SIGNEXTEND": (2, 1),
'LT': (2, 1), "LT": (2, 1),
'GT': (2, 1), "GT": (2, 1),
'SLT': (2, 1), "SLT": (2, 1),
'SGT': (2, 1), "SGT": (2, 1),
'EQ': (2, 1), "EQ": (2, 1),
'ISZERO': (1, 1), "ISZERO": (1, 1),
'CALLVALUE': (0, 1), "CALLVALUE": (0, 1),
'CALLDATALOAD': (1, 1), "CALLDATALOAD": (1, 1),
'CALLDATACOPY': (3, 0), #todo "CALLDATACOPY": (3, 0), # todo
'CALLDATASIZE': (0, 1), "CALLDATASIZE": (0, 1),
'ADDRESS': (0, 1), "ADDRESS": (0, 1),
'BALANCE': (1, 1), "BALANCE": (1, 1),
'ORIGIN': (0, 1), "ORIGIN": (0, 1),
'CALLER': (0, 1), "CALLER": (0, 1),
'CODESIZE': (0, 1), "CODESIZE": (0, 1),
'SHA3': (2, 1), "SHA3": (2, 1),
'GASPRICE': (0, 1), "GASPRICE": (0, 1),
'CODECOPY': (3, 0), "CODECOPY": (3, 0),
'EXTCODESIZE': (1, 1), "EXTCODESIZE": (1, 1),
'EXTCODECOPY': (4, 0), "EXTCODECOPY": (4, 0),
'RETURNDATASIZE': (0, 1), "RETURNDATASIZE": (0, 1),
'BLOCKHASH': (1, 1), "BLOCKHASH": (1, 1),
'COINBASE': (0, 1), "COINBASE": (0, 1),
'TIMESTAMP': (0, 1), "TIMESTAMP": (0, 1),
'NUMBER': (0, 1), "NUMBER": (0, 1),
'DIFFICULTY': (0, 1), "DIFFICULTY": (0, 1),
'GASLIMIT': (0, 1), "GASLIMIT": (0, 1),
'JUMP': (1, 0), "JUMP": (1, 0),
'JUMPI': (2, 0), "JUMPI": (2, 0),
'PC': (0, 1), "PC": (0, 1),
'MSIZE': (0, 1), "MSIZE": (0, 1),
'GAS': (0, 1), "GAS": (0, 1),
'CREATE': (3, 1), "CREATE": (3, 1),
'RETURN': (2, 0) "RETURN": (2, 0),
} }

@ -1,2 +1,5 @@
from mythril.laser.ethereum.transaction.transaction_models import * from mythril.laser.ethereum.transaction.transaction_models import *
from mythril.laser.ethereum.transaction.symbolic import execute_message_call, execute_contract_creation from mythril.laser.ethereum.transaction.symbolic import (
execute_message_call,
execute_contract_creation,
)

@ -1,11 +1,31 @@
from mythril.laser.ethereum.transaction.transaction_models import MessageCallTransaction, ContractCreationTransaction, get_next_transaction_id from mythril.laser.ethereum.transaction.transaction_models import (
MessageCallTransaction,
ContractCreationTransaction,
get_next_transaction_id,
)
from z3 import BitVec from z3 import BitVec
from mythril.laser.ethereum.state import GlobalState, Environment, CalldataType, Account, WorldState from mythril.laser.ethereum.state import (
GlobalState,
Environment,
CalldataType,
Account,
WorldState,
)
from mythril.disassembler.disassembly import Disassembly from mythril.disassembler.disassembly import Disassembly
from mythril.laser.ethereum.cfg import Node, Edge, JumpType from mythril.laser.ethereum.cfg import Node, Edge, JumpType
def execute_message_call(laser_evm, callee_address, caller_address, origin_address, code, data, gas, gas_price, value): def execute_message_call(
laser_evm,
callee_address,
caller_address,
origin_address,
code,
data,
gas,
gas_price,
value,
):
""" Executes a message call transaction from all open states """ """ Executes a message call transaction from all open states """
open_states = laser_evm.open_states[:] open_states = laser_evm.open_states[:]
del laser_evm.open_states[:] del laser_evm.open_states[:]
@ -21,7 +41,7 @@ def execute_message_call(laser_evm, callee_address, caller_address, origin_addre
call_value=value, call_value=value,
origin=origin_address, origin=origin_address,
call_data_type=CalldataType.SYMBOLIC, call_data_type=CalldataType.SYMBOLIC,
code=Disassembly(code) code=Disassembly(code),
) )
_setup_global_state_for_execution(laser_evm, transaction) _setup_global_state_for_execution(laser_evm, transaction)
@ -38,8 +58,14 @@ def _setup_global_state_for_execution(laser_evm, transaction):
laser_evm.nodes[new_node.uid] = new_node laser_evm.nodes[new_node.uid] = new_node
if transaction.world_state.node: if transaction.world_state.node:
laser_evm.edges.append(Edge(transaction.world_state.node.uid, new_node.uid, edge_type=JumpType.Transaction, laser_evm.edges.append(
condition=None)) Edge(
transaction.world_state.node.uid,
new_node.uid,
edge_type=JumpType.Transaction,
condition=None,
)
)
global_state.node = new_node global_state.node = new_node
new_node.states.append(global_state) new_node.states.append(global_state)
laser_evm.work_list.append(global_state) laser_evm.work_list.append(global_state)

@ -4,8 +4,12 @@ from logging import debug
from mythril.disassembler.disassembly import Disassembly from mythril.disassembler.disassembly import Disassembly
from mythril.laser.ethereum.cfg import Node, Edge, JumpType from mythril.laser.ethereum.cfg import Node, Edge, JumpType
from mythril.laser.ethereum.state import CalldataType from mythril.laser.ethereum.state import CalldataType
from mythril.laser.ethereum.transaction.transaction_models import MessageCallTransaction, ContractCreationTransaction,\ from mythril.laser.ethereum.transaction.transaction_models import (
get_next_transaction_id MessageCallTransaction,
ContractCreationTransaction,
get_next_transaction_id,
)
def execute_message_call(laser_evm, callee_address): def execute_message_call(laser_evm, callee_address):
""" Executes a message call transaction from all open states """ """ Executes a message call transaction from all open states """
@ -34,12 +38,16 @@ def execute_message_call(laser_evm, callee_address):
laser_evm.exec() laser_evm.exec()
def execute_contract_creation(laser_evm, contract_initialization_code, contract_name=None): def execute_contract_creation(
laser_evm, contract_initialization_code, contract_name=None
):
""" Executes a contract creation transaction from all open states""" """ Executes a contract creation transaction from all open states"""
open_states = laser_evm.open_states[:] open_states = laser_evm.open_states[:]
del laser_evm.open_states[:] del laser_evm.open_states[:]
new_account = laser_evm.world_state.create_account(0, concrete_storage=True, dynamic_loader=None) new_account = laser_evm.world_state.create_account(
0, concrete_storage=True, dynamic_loader=None
)
if contract_name: if contract_name:
new_account.contract_name = contract_name new_account.contract_name = contract_name
@ -55,7 +63,7 @@ def execute_contract_creation(laser_evm, contract_initialization_code, contract_
BitVec("gas_price{}".format(next_transaction_id), 256), BitVec("gas_price{}".format(next_transaction_id), 256),
BitVec("call_value{}".format(next_transaction_id), 256), BitVec("call_value{}".format(next_transaction_id), 256),
BitVec("origin{}".format(next_transaction_id), 256), BitVec("origin{}".format(next_transaction_id), 256),
CalldataType.SYMBOLIC CalldataType.SYMBOLIC,
) )
_setup_global_state_for_execution(laser_evm, transaction) _setup_global_state_for_execution(laser_evm, transaction)
laser_evm.exec(True) laser_evm.exec(True)
@ -72,8 +80,14 @@ def _setup_global_state_for_execution(laser_evm, transaction):
laser_evm.nodes[new_node.uid] = new_node laser_evm.nodes[new_node.uid] = new_node
if transaction.world_state.node: if transaction.world_state.node:
laser_evm.edges.append(Edge(transaction.world_state.node.uid, new_node.uid, edge_type=JumpType.Transaction, laser_evm.edges.append(
condition=None)) Edge(
transaction.world_state.node.uid,
new_node.uid,
edge_type=JumpType.Transaction,
condition=None,
)
)
global_state.mstate.constraints = transaction.world_state.node.constraints global_state.mstate.constraints = transaction.world_state.node.constraints
new_node.constraints = global_state.mstate.constraints new_node.constraints = global_state.mstate.constraints

@ -15,6 +15,7 @@ def get_next_transaction_id():
class TransactionEndSignal(Exception): class TransactionEndSignal(Exception):
""" Exception raised when a transaction is finalized""" """ Exception raised when a transaction is finalized"""
def __init__(self, global_state, revert=False): def __init__(self, global_state, revert=False):
self.global_state = global_state self.global_state = global_state
self.revert = revert self.revert = revert
@ -22,6 +23,7 @@ class TransactionEndSignal(Exception):
class TransactionStartSignal(Exception): class TransactionStartSignal(Exception):
""" Exception raised when a new transaction is started""" """ Exception raised when a new transaction is started"""
def __init__(self, transaction, op_code): def __init__(self, transaction, op_code):
self.transaction = transaction self.transaction = transaction
self.op_code = op_code self.op_code = op_code
@ -29,28 +31,44 @@ class TransactionStartSignal(Exception):
class MessageCallTransaction: class MessageCallTransaction:
""" Transaction object models an transaction""" """ Transaction object models an transaction"""
def __init__(self,
world_state, def __init__(
callee_account, self,
caller, world_state,
call_data=(), callee_account,
identifier=None, caller,
gas_price=None, call_data=(),
call_value=None, identifier=None,
origin=None, gas_price=None,
call_data_type=None, call_value=None,
code=None origin=None,
): call_data_type=None,
code=None,
):
assert isinstance(world_state, WorldState) assert isinstance(world_state, WorldState)
self.id = identifier or get_next_transaction_id() self.id = identifier or get_next_transaction_id()
self.world_state = world_state self.world_state = world_state
self.callee_account = callee_account self.callee_account = callee_account
self.caller = caller self.caller = caller
self.call_data = call_data self.call_data = call_data
self.gas_price = BitVec("gasprice{}".format(identifier), 256) if gas_price is None else gas_price self.gas_price = (
self.call_value = BitVec("callvalue{}".format(identifier), 256) if call_value is None else call_value BitVec("gasprice{}".format(identifier), 256)
self.origin = BitVec("origin{}".format(identifier), 256) if origin is None else origin if gas_price is None
self.call_data_type = BitVec("call_data_type{}".format(identifier), 256) if call_data_type is None else call_data_type else gas_price
)
self.call_value = (
BitVec("callvalue{}".format(identifier), 256)
if call_value is None
else call_value
)
self.origin = (
BitVec("origin{}".format(identifier), 256) if origin is None else origin
)
self.call_data_type = (
BitVec("call_data_type{}".format(identifier), 256)
if call_data_type is None
else call_data_type
)
self.code = code self.code = code
self.return_data = None self.return_data = None
@ -68,7 +86,7 @@ class MessageCallTransaction:
) )
global_state = GlobalState(self.world_state, environment, None) global_state = GlobalState(self.world_state, environment, None)
global_state.environment.active_function_name = 'fallback' global_state.environment.active_function_name = "fallback"
return global_state return global_state
@ -79,30 +97,50 @@ class MessageCallTransaction:
class ContractCreationTransaction: class ContractCreationTransaction:
""" Transaction object models an transaction""" """ Transaction object models an transaction"""
def __init__(self,
world_state, def __init__(
caller, self,
identifier=None, world_state,
callee_account=None, caller,
code=None, identifier=None,
call_data=(), callee_account=None,
gas_price=None, code=None,
call_value=None, call_data=(),
origin=None, gas_price=None,
call_data_type=None, call_value=None,
): origin=None,
call_data_type=None,
):
assert isinstance(world_state, WorldState) assert isinstance(world_state, WorldState)
self.id = identifier or get_next_transaction_id() self.id = identifier or get_next_transaction_id()
self.world_state = world_state self.world_state = world_state
# TODO: set correct balance for new account # TODO: set correct balance for new account
self.callee_account = callee_account if callee_account else world_state.create_account(0, concrete_storage=True) self.callee_account = (
callee_account
if callee_account
else world_state.create_account(0, concrete_storage=True)
)
self.caller = caller self.caller = caller
self.gas_price = BitVec("gasprice{}".format(identifier), 256) if gas_price is None else gas_price self.gas_price = (
self.call_value = BitVec("callvalue{}".format(identifier), 256) if call_value is None else call_value BitVec("gasprice{}".format(identifier), 256)
self.origin = BitVec("origin{}".format(identifier), 256) if origin is None else origin if gas_price is None
self.call_data_type = BitVec("call_data_type{}".format(identifier), 256) if call_data_type is None else call_data_type else gas_price
)
self.call_value = (
BitVec("callvalue{}".format(identifier), 256)
if call_value is None
else call_value
)
self.origin = (
BitVec("origin{}".format(identifier), 256) if origin is None else origin
)
self.call_data_type = (
BitVec("call_data_type{}".format(identifier), 256)
if call_data_type is None
else call_data_type
)
self.call_data = call_data self.call_data = call_data
self.origin = origin self.origin = origin
@ -123,22 +161,23 @@ class ContractCreationTransaction:
) )
global_state = GlobalState(self.world_state, environment, None) global_state = GlobalState(self.world_state, environment, None)
global_state.environment.active_function_name = 'constructor' global_state.environment.active_function_name = "constructor"
return global_state return global_state
def end(self, global_state, return_data=None, revert=False): def end(self, global_state, return_data=None, revert=False):
if not all([isinstance(element, int) for element in return_data]) or len(return_data) == 0: if (
not all([isinstance(element, int) for element in return_data])
or len(return_data) == 0
):
self.return_data = None self.return_data = None
raise TransactionEndSignal(global_state) raise TransactionEndSignal(global_state)
contract_code = bytes.hex(array.array('B', return_data).tostring()) contract_code = bytes.hex(array.array("B", return_data).tostring())
global_state.environment.active_account.code = Disassembly(contract_code) global_state.environment.active_account.code = Disassembly(contract_code)
self.return_data = global_state.environment.active_account.address self.return_data = global_state.environment.active_account.address
assert global_state.environment.active_account.code.instruction_list != [] assert global_state.environment.active_account.code.instruction_list != []
raise TransactionEndSignal(global_state, revert=revert) raise TransactionEndSignal(global_state, revert=revert)

@ -10,8 +10,6 @@ TT256M1 = 2 ** 256 - 1
TT255 = 2 ** 255 TT255 = 2 ** 255
def sha3(seed): def sha3(seed):
return _sha3.keccak_256(bytes(seed)).digest() return _sha3.keccak_256(bytes(seed)).digest()
@ -33,7 +31,7 @@ def get_instruction_index(instruction_list, address):
index = 0 index = 0
for instr in instruction_list: for instr in instruction_list:
if instr['address'] == address: if instr["address"] == address:
return index return index
index += 1 index += 1
@ -48,7 +46,7 @@ def get_trace_line(instr, state):
# stack = re.sub("(\d+)", lambda m: hex(int(m.group(1))), stack) # stack = re.sub("(\d+)", lambda m: hex(int(m.group(1))), stack)
stack = re.sub("\n", "", stack) stack = re.sub("\n", "", stack)
return str(instr['address']) + " " + instr['opcode'] + "\tSTACK: " + stack return str(instr["address"]) + " " + instr["opcode"] + "\tSTACK: " + stack
def pop_bitvec(state): def pop_bitvec(state):
@ -93,9 +91,9 @@ def get_concrete_int(item):
def concrete_int_from_bytes(_bytes, start_index): def concrete_int_from_bytes(_bytes, start_index):
# logging.debug("-- concrete_int_from_bytes: " + str(_bytes[start_index:start_index+32])) # logging.debug("-- concrete_int_from_bytes: " + str(_bytes[start_index:start_index+32]))
b = _bytes[start_index:start_index+32] b = _bytes[start_index : start_index + 32]
val = int.from_bytes(b, byteorder='big') val = int.from_bytes(b, byteorder="big")
return val return val
@ -105,9 +103,9 @@ def concrete_int_to_bytes(val):
# logging.debug("concrete_int_to_bytes " + str(val)) # logging.debug("concrete_int_to_bytes " + str(val))
if type(val) == int: if type(val) == int:
return val.to_bytes(32, byteorder='big') return val.to_bytes(32, byteorder="big")
return (simplify(val).as_long()).to_bytes(32, byteorder='big') return (simplify(val).as_long()).to_bytes(32, byteorder="big")
def bytearray_to_int(arr): def bytearray_to_int(arr):
@ -115,4 +113,3 @@ def bytearray_to_int(arr):
for a in arr: for a in arr:
o = (o << 8) + a o = (o << 8) + a
return o return o

@ -35,6 +35,7 @@ from mythril.ethereum.interface.leveldb.client import EthLevelDB
# logging.basicConfig(level=logging.DEBUG) # logging.basicConfig(level=logging.DEBUG)
class Mythril(object): class Mythril(object):
""" """
Mythril main interface class. Mythril main interface class.
@ -75,9 +76,10 @@ class Mythril(object):
mythril.get_state_variable_from_storage(args) mythril.get_state_variable_from_storage(args)
""" """
def __init__(self, solv=None,
solc_args=None, dynld=False, def __init__(
enable_online_lookup=False): self, solv=None, solc_args=None, dynld=False, enable_online_lookup=False
):
self.solv = solv self.solv = solv
self.solc_args = solc_args self.solc_args = solc_args
@ -86,31 +88,41 @@ class Mythril(object):
self.mythril_dir = self._init_mythril_dir() self.mythril_dir = self._init_mythril_dir()
self.sigs = signatures.SignatureDb(enable_online_lookup=self.enable_online_lookup) self.sigs = signatures.SignatureDb(
enable_online_lookup=self.enable_online_lookup
)
try: try:
self.sigs.open() # tries mythril_dir/signatures.json by default (provide path= arg to make this configurable) self.sigs.open() # tries mythril_dir/signatures.json by default (provide path= arg to make this configurable)
except FileNotFoundError: except FileNotFoundError:
logging.info( logging.info(
"No signature database found. Creating database if sigs are loaded in: " + self.sigs.signatures_file + "\n" + "No signature database found. Creating database if sigs are loaded in: "
"Consider replacing it with the pre-initialized database at https://raw.githubusercontent.com/ConsenSys/mythril/master/signatures.json") + self.sigs.signatures_file
+ "\n"
+ "Consider replacing it with the pre-initialized database at https://raw.githubusercontent.com/ConsenSys/mythril/master/signatures.json"
)
except json.JSONDecodeError as jde: except json.JSONDecodeError as jde:
raise CriticalError("Invalid JSON in signatures file " + self.sigs.signatures_file + "\n" + str(jde)) raise CriticalError(
"Invalid JSON in signatures file "
+ self.sigs.signatures_file
+ "\n"
+ str(jde)
)
self.solc_binary = self._init_solc_binary(solv) self.solc_binary = self._init_solc_binary(solv)
self.config_path = os.path.join(self.mythril_dir, 'config.ini') self.config_path = os.path.join(self.mythril_dir, "config.ini")
self.leveldb_dir = self._init_config() self.leveldb_dir = self._init_config()
self.eth = None # ethereum API client self.eth = None # ethereum API client
self.eth_db = None # ethereum LevelDB client self.eth_db = None # ethereum LevelDB client
self.contracts = [] # loaded contracts self.contracts = [] # loaded contracts
@staticmethod @staticmethod
def _init_mythril_dir(): def _init_mythril_dir():
try: try:
mythril_dir = os.environ['MYTHRIL_DIR'] mythril_dir = os.environ["MYTHRIL_DIR"]
except KeyError: except KeyError:
mythril_dir = os.path.join(os.path.expanduser('~'), ".mythril") mythril_dir = os.path.join(os.path.expanduser("~"), ".mythril")
# Initialize data directory and signature database # Initialize data directory and signature database
@ -128,59 +140,75 @@ class Mythril(object):
""" """
system = platform.system().lower() system = platform.system().lower()
leveldb_fallback_dir = os.path.expanduser('~') leveldb_fallback_dir = os.path.expanduser("~")
if system.startswith("darwin"): if system.startswith("darwin"):
leveldb_fallback_dir = os.path.join(leveldb_fallback_dir, "Library", "Ethereum") leveldb_fallback_dir = os.path.join(
leveldb_fallback_dir, "Library", "Ethereum"
)
elif system.startswith("windows"): elif system.startswith("windows"):
leveldb_fallback_dir = os.path.join(leveldb_fallback_dir, "AppData", "Roaming", "Ethereum") leveldb_fallback_dir = os.path.join(
leveldb_fallback_dir, "AppData", "Roaming", "Ethereum"
)
else: else:
leveldb_fallback_dir = os.path.join(leveldb_fallback_dir, ".ethereum") leveldb_fallback_dir = os.path.join(leveldb_fallback_dir, ".ethereum")
leveldb_fallback_dir = os.path.join(leveldb_fallback_dir, "geth", "chaindata") leveldb_fallback_dir = os.path.join(leveldb_fallback_dir, "geth", "chaindata")
if not os.path.exists(self.config_path): if not os.path.exists(self.config_path):
logging.info("No config file found. Creating default: " + self.config_path) logging.info("No config file found. Creating default: " + self.config_path)
open(self.config_path, 'a').close() open(self.config_path, "a").close()
config = ConfigParser(allow_no_value=True) config = ConfigParser(allow_no_value=True)
config.optionxform = str config.optionxform = str
config.read(self.config_path, 'utf-8') config.read(self.config_path, "utf-8")
if 'defaults' not in config.sections(): if "defaults" not in config.sections():
self._add_default_options(config) self._add_default_options(config)
if not config.has_option('defaults', 'leveldb_dir'): if not config.has_option("defaults", "leveldb_dir"):
self._add_leveldb_option(config, leveldb_fallback_dir) self._add_leveldb_option(config, leveldb_fallback_dir)
if not config.has_option('defaults', 'dynamic_loading'): if not config.has_option("defaults", "dynamic_loading"):
self._add_dynamic_loading_option(config) self._add_dynamic_loading_option(config)
with codecs.open(self.config_path, 'w', 'utf-8') as fp: with codecs.open(self.config_path, "w", "utf-8") as fp:
config.write(fp) config.write(fp)
leveldb_dir = config.get('defaults', 'leveldb_dir', fallback=leveldb_fallback_dir) leveldb_dir = config.get(
"defaults", "leveldb_dir", fallback=leveldb_fallback_dir
)
return os.path.expanduser(leveldb_dir) return os.path.expanduser(leveldb_dir)
@staticmethod @staticmethod
def _add_default_options(config): def _add_default_options(config):
config.add_section('defaults') config.add_section("defaults")
@staticmethod @staticmethod
def _add_leveldb_option(config, leveldb_fallback_dir): def _add_leveldb_option(config, leveldb_fallback_dir):
config.set('defaults', "#Default chaindata locations:") config.set("defaults", "#Default chaindata locations:")
config.set('defaults', "#– Mac: ~/Library/Ethereum/geth/chaindata") config.set("defaults", "#– Mac: ~/Library/Ethereum/geth/chaindata")
config.set('defaults', "#– Linux: ~/.ethereum/geth/chaindata") config.set("defaults", "#– Linux: ~/.ethereum/geth/chaindata")
config.set('defaults', "#– Windows: %USERPROFILE%\\AppData\\Roaming\\Ethereum\\geth\\chaindata") config.set(
config.set('defaults', 'leveldb_dir', leveldb_fallback_dir) "defaults",
"#– Windows: %USERPROFILE%\\AppData\\Roaming\\Ethereum\\geth\\chaindata",
)
config.set("defaults", "leveldb_dir", leveldb_fallback_dir)
@staticmethod @staticmethod
def _add_dynamic_loading_option(config): def _add_dynamic_loading_option(config):
config.set('defaults', '#– To connect to Infura use dynamic_loading: infura') config.set("defaults", "#– To connect to Infura use dynamic_loading: infura")
config.set('defaults', '#– To connect to Rpc use ' config.set(
'dynamic_loading: HOST:PORT / ganache / infura-[network_name]') "defaults",
config.set('defaults', '#– To connect to local host use dynamic_loading: localhost') "#– To connect to Rpc use "
config.set('defaults', 'dynamic_loading', 'infura') "dynamic_loading: HOST:PORT / ganache / infura-[network_name]",
)
config.set(
"defaults", "#– To connect to local host use dynamic_loading: localhost"
)
config.set("defaults", "dynamic_loading", "infura")
def analyze_truffle_project(self, *args, **kwargs): def analyze_truffle_project(self, *args, **kwargs):
return analyze_truffle_project(self.sigs, *args, **kwargs) # just passthru by passing signatures for now return analyze_truffle_project(
self.sigs, *args, **kwargs
) # just passthru by passing signatures for now
@staticmethod @staticmethod
def _init_solc_binary(version): def _init_solc_binary(version):
@ -190,27 +218,31 @@ class Mythril(object):
if version: if version:
# tried converting input to semver, seemed not necessary so just slicing for now # tried converting input to semver, seemed not necessary so just slicing for now
if version == str(solc.main.get_solc_version())[:6]: if version == str(solc.main.get_solc_version())[:6]:
logging.info('Given version matches installed version') logging.info("Given version matches installed version")
try: try:
solc_binary = os.environ['SOLC'] solc_binary = os.environ["SOLC"]
except KeyError: except KeyError:
solc_binary = 'solc' solc_binary = "solc"
else: else:
if util.solc_exists(version): if util.solc_exists(version):
logging.info('Given version is already installed') logging.info("Given version is already installed")
else: else:
try: try:
solc.install_solc('v' + version) solc.install_solc("v" + version)
except SolcError: except SolcError:
raise CriticalError("There was an error when trying to install the specified solc version") raise CriticalError(
"There was an error when trying to install the specified solc version"
)
solc_binary = os.path.join(os.environ['HOME'], ".py-solc/solc-v" + version, "bin/solc") solc_binary = os.path.join(
os.environ["HOME"], ".py-solc/solc-v" + version, "bin/solc"
)
logging.info("Setting the compiler to " + str(solc_binary)) logging.info("Setting the compiler to " + str(solc_binary))
else: else:
try: try:
solc_binary = os.environ['SOLC'] solc_binary = os.environ["SOLC"]
except KeyError: except KeyError:
solc_binary = 'solc' solc_binary = "solc"
return solc_binary return solc_binary
def set_api_leveldb(self, leveldb): def set_api_leveldb(self, leveldb):
@ -219,22 +251,24 @@ class Mythril(object):
return self.eth return self.eth
def set_api_rpc_infura(self): def set_api_rpc_infura(self):
self.eth = EthJsonRpc('mainnet.infura.io', 443, True) self.eth = EthJsonRpc("mainnet.infura.io", 443, True)
logging.info("Using INFURA for RPC queries") logging.info("Using INFURA for RPC queries")
def set_api_rpc(self, rpc=None, rpctls=False): def set_api_rpc(self, rpc=None, rpctls=False):
if rpc == 'ganache': if rpc == "ganache":
rpcconfig = ('localhost', 8545, False) rpcconfig = ("localhost", 8545, False)
else: else:
m = re.match(r'infura-(.*)', rpc) m = re.match(r"infura-(.*)", rpc)
if m and m.group(1) in ['mainnet', 'rinkeby', 'kovan', 'ropsten']: if m and m.group(1) in ["mainnet", "rinkeby", "kovan", "ropsten"]:
rpcconfig = (m.group(1) + '.infura.io', 443, True) rpcconfig = (m.group(1) + ".infura.io", 443, True)
else: else:
try: try:
host, port = rpc.split(":") host, port = rpc.split(":")
rpcconfig = (host, int(port), rpctls) rpcconfig = (host, int(port), rpctls)
except ValueError: except ValueError:
raise CriticalError("Invalid RPC argument, use 'ganache', 'infura-[network]' or 'HOST:PORT'") raise CriticalError(
"Invalid RPC argument, use 'ganache', 'infura-[network]' or 'HOST:PORT'"
)
if rpcconfig: if rpcconfig:
self.eth = EthJsonRpc(rpcconfig[0], int(rpcconfig[1]), rpcconfig[2]) self.eth = EthJsonRpc(rpcconfig[0], int(rpcconfig[1]), rpcconfig[2])
@ -243,26 +277,25 @@ class Mythril(object):
raise CriticalError("Invalid RPC settings, check help for details.") raise CriticalError("Invalid RPC settings, check help for details.")
def set_api_rpc_localhost(self): def set_api_rpc_localhost(self):
self.eth = EthJsonRpc('localhost', 8545) self.eth = EthJsonRpc("localhost", 8545)
logging.info("Using default RPC settings: http://localhost:8545") logging.info("Using default RPC settings: http://localhost:8545")
def set_api_from_config_path(self): def set_api_from_config_path(self):
config = ConfigParser(allow_no_value=False) config = ConfigParser(allow_no_value=False)
config.optionxform = str config.optionxform = str
config.read(self.config_path, 'utf-8') config.read(self.config_path, "utf-8")
if config.has_option('defaults', 'dynamic_loading'): if config.has_option("defaults", "dynamic_loading"):
dynamic_loading = config.get('defaults', 'dynamic_loading') dynamic_loading = config.get("defaults", "dynamic_loading")
else: else:
dynamic_loading = 'infura' dynamic_loading = "infura"
if dynamic_loading == 'infura': if dynamic_loading == "infura":
self.set_api_rpc_infura() self.set_api_rpc_infura()
elif dynamic_loading == 'localhost': elif dynamic_loading == "localhost":
self.set_api_rpc_localhost() self.set_api_rpc_localhost()
else: else:
self.set_api_rpc(dynamic_loading) self.set_api_rpc(dynamic_loading)
def search_db(self, search): def search_db(self, search):
def search_callback(_, address, balance): def search_callback(_, address, balance):
print("Address: " + address + ", balance: " + str(balance)) print("Address: " + address + ", balance: " + str(balance))
@ -273,33 +306,47 @@ class Mythril(object):
raise CriticalError("Syntax error in search expression.") raise CriticalError("Syntax error in search expression.")
def contract_hash_to_address(self, hash): def contract_hash_to_address(self, hash):
if not re.match(r'0x[a-fA-F0-9]{64}', hash): if not re.match(r"0x[a-fA-F0-9]{64}", hash):
raise CriticalError("Invalid address hash. Expected format is '0x...'.") raise CriticalError("Invalid address hash. Expected format is '0x...'.")
print(self.eth_db.contract_hash_to_address(hash)) print(self.eth_db.contract_hash_to_address(hash))
def load_from_bytecode(self, code): def load_from_bytecode(self, code):
address = util.get_indexed_address(0) address = util.get_indexed_address(0)
self.contracts.append(ETHContract(code, name="MAIN", enable_online_lookup=self.enable_online_lookup)) self.contracts.append(
ETHContract(
code, name="MAIN", enable_online_lookup=self.enable_online_lookup
)
)
return address, self.contracts[-1] # return address and contract object return address, self.contracts[-1] # return address and contract object
def load_from_address(self, address): def load_from_address(self, address):
if not re.match(r'0x[a-fA-F0-9]{40}', address): if not re.match(r"0x[a-fA-F0-9]{40}", address):
raise CriticalError("Invalid contract address. Expected format is '0x...'.") raise CriticalError("Invalid contract address. Expected format is '0x...'.")
try: try:
code = self.eth.eth_getCode(address) code = self.eth.eth_getCode(address)
except FileNotFoundError as e: except FileNotFoundError as e:
raise CriticalError("IPC error: " + str(e)) raise CriticalError("IPC error: " + str(e))
except ConnectionError: except ConnectionError:
raise CriticalError("Could not connect to RPC server. Make sure that your node is running and that RPC parameters are set correctly.") raise CriticalError(
"Could not connect to RPC server. Make sure that your node is running and that RPC parameters are set correctly."
)
except Exception as e: except Exception as e:
raise CriticalError("IPC / RPC error: " + str(e)) raise CriticalError("IPC / RPC error: " + str(e))
else: else:
if code == "0x" or code == "0x0": if code == "0x" or code == "0x0":
raise CriticalError("Received an empty response from eth_getCode. Check the contract address and verify that you are on the correct chain.") raise CriticalError(
"Received an empty response from eth_getCode. Check the contract address and verify that you are on the correct chain."
)
else: else:
self.contracts.append(ETHContract(code, name=address, enable_online_lookup=self.enable_online_lookup)) self.contracts.append(
ETHContract(
code,
name=address,
enable_online_lookup=self.enable_online_lookup,
)
)
return address, self.contracts[-1] # return address and contract object return address, self.contracts[-1] # return address and contract object
def load_from_solidity(self, solidity_files): def load_from_solidity(self, solidity_files):
@ -320,57 +367,105 @@ class Mythril(object):
try: try:
# import signatures from solidity source # import signatures from solidity source
self.sigs.import_from_solidity_source(file, solc_binary=self.solc_binary, solc_args=self.solc_args) self.sigs.import_from_solidity_source(
file, solc_binary=self.solc_binary, solc_args=self.solc_args
)
# Save updated function signatures # Save updated function signatures
self.sigs.write() # dump signatures to disk (previously opened file or default location) self.sigs.write() # dump signatures to disk (previously opened file or default location)
if contract_name is not None: if contract_name is not None:
contract = SolidityContract(file, contract_name, solc_args=self.solc_args) contract = SolidityContract(
file, contract_name, solc_args=self.solc_args
)
self.contracts.append(contract) self.contracts.append(contract)
contracts.append(contract) contracts.append(contract)
else: else:
for contract in get_contracts_from_file(file, solc_args=self.solc_args): for contract in get_contracts_from_file(
file, solc_args=self.solc_args
):
self.contracts.append(contract) self.contracts.append(contract)
contracts.append(contract) contracts.append(contract)
except FileNotFoundError: except FileNotFoundError:
raise CriticalError("Input file not found: " + file) raise CriticalError("Input file not found: " + file)
except CompilerError as e: except CompilerError as e:
raise CriticalError(e) raise CriticalError(e)
except NoContractFoundError: except NoContractFoundError:
logging.info("The file " + file + " does not contain a compilable contract.") logging.info(
"The file " + file + " does not contain a compilable contract."
)
return address, contracts return address, contracts
def dump_statespace(self, strategy, contract, address=None, max_depth=None, def dump_statespace(
execution_timeout=None, create_timeout=None): self,
strategy,
sym = SymExecWrapper(contract, address, strategy, contract,
dynloader=DynLoader(self.eth) if self.dynld else None, address=None,
max_depth=max_depth, execution_timeout=execution_timeout, create_timeout=create_timeout) max_depth=None,
execution_timeout=None,
create_timeout=None,
):
sym = SymExecWrapper(
contract,
address,
strategy,
dynloader=DynLoader(self.eth) if self.dynld else None,
max_depth=max_depth,
execution_timeout=execution_timeout,
create_timeout=create_timeout,
)
return get_serializable_statespace(sym) return get_serializable_statespace(sym)
def graph_html(self, strategy, contract, address, max_depth=None, enable_physics=False, def graph_html(
phrackify=False, execution_timeout=None, create_timeout=None): self,
sym = SymExecWrapper(contract, address, strategy, strategy,
dynloader=DynLoader(self.eth) if self.dynld else None, contract,
max_depth=max_depth, execution_timeout=execution_timeout, create_timeout=create_timeout) address,
max_depth=None,
enable_physics=False,
phrackify=False,
execution_timeout=None,
create_timeout=None,
):
sym = SymExecWrapper(
contract,
address,
strategy,
dynloader=DynLoader(self.eth) if self.dynld else None,
max_depth=max_depth,
execution_timeout=execution_timeout,
create_timeout=create_timeout,
)
return generate_graph(sym, physics=enable_physics, phrackify=phrackify) return generate_graph(sym, physics=enable_physics, phrackify=phrackify)
def fire_lasers(self, strategy, contracts=None, address=None, def fire_lasers(
modules=None, verbose_report=False, max_depth=None, execution_timeout=None, create_timeout=None, self,
max_transaction_count=None): strategy,
contracts=None,
address=None,
modules=None,
verbose_report=False,
max_depth=None,
execution_timeout=None,
create_timeout=None,
max_transaction_count=None,
):
all_issues = [] all_issues = []
for contract in (contracts or self.contracts): for contract in contracts or self.contracts:
sym = SymExecWrapper(contract, address, strategy, sym = SymExecWrapper(
dynloader=DynLoader(self.eth) if self.dynld else None, contract,
max_depth=max_depth, execution_timeout=execution_timeout, address,
create_timeout=create_timeout, strategy,
max_transaction_count=max_transaction_count) dynloader=DynLoader(self.eth) if self.dynld else None,
max_depth=max_depth,
execution_timeout=execution_timeout,
create_timeout=create_timeout,
max_transaction_count=max_transaction_count,
)
issues = fire_lasers(sym, modules) issues = fire_lasers(sym, modules)
@ -394,13 +489,18 @@ class Mythril(object):
try: try:
if params[0] == "mapping": if params[0] == "mapping":
if len(params) < 3: if len(params) < 3:
raise CriticalError("Invalid number of parameters.") raise CriticalError("Invalid number of parameters.")
position = int(params[1]) position = int(params[1])
position_formatted = utils.zpad(utils.int_to_big_endian(position), 32) position_formatted = utils.zpad(utils.int_to_big_endian(position), 32)
for i in range(2, len(params)): for i in range(2, len(params)):
key = bytes(params[i], 'utf8') key = bytes(params[i], "utf8")
key_formatted = utils.rzpad(key, 32) key_formatted = utils.rzpad(key, 32)
mappings.append(int.from_bytes(utils.sha3(key_formatted + position_formatted), byteorder='big')) mappings.append(
int.from_bytes(
utils.sha3(key_formatted + position_formatted),
byteorder="big",
)
)
length = len(mappings) length = len(mappings)
if length == 1: if length == 1:
@ -408,37 +508,58 @@ class Mythril(object):
else: else:
if len(params) >= 4: if len(params) >= 4:
raise CriticalError("Invalid number of parameters.") raise CriticalError("Invalid number of parameters.")
if len(params) >= 1: if len(params) >= 1:
position = int(params[0]) position = int(params[0])
if len(params) >= 2: if len(params) >= 2:
length = int(params[1]) length = int(params[1])
if len(params) == 3 and params[2] == "array": if len(params) == 3 and params[2] == "array":
position_formatted = utils.zpad(utils.int_to_big_endian(position), 32) position_formatted = utils.zpad(
position = int.from_bytes(utils.sha3(position_formatted), byteorder='big') utils.int_to_big_endian(position), 32
)
position = int.from_bytes(
utils.sha3(position_formatted), byteorder="big"
)
except ValueError: except ValueError:
raise CriticalError("Invalid storage index. Please provide a numeric value.") raise CriticalError(
"Invalid storage index. Please provide a numeric value."
)
outtxt = [] outtxt = []
try: try:
if length == 1: if length == 1:
outtxt.append("{}: {}".format(position, self.eth.eth_getStorageAt(address, position))) outtxt.append(
"{}: {}".format(
position, self.eth.eth_getStorageAt(address, position)
)
)
else: else:
if len(mappings) > 0: if len(mappings) > 0:
for i in range(0, len(mappings)): for i in range(0, len(mappings)):
position = mappings[i] position = mappings[i]
outtxt.append("{}: {}".format(hex(position), self.eth.eth_getStorageAt(address, position))) outtxt.append(
"{}: {}".format(
hex(position),
self.eth.eth_getStorageAt(address, position),
)
)
else: else:
for i in range(position, position + length): for i in range(position, position + length):
outtxt.append("{}: {}".format(hex(i), self.eth.eth_getStorageAt(address, i))) outtxt.append(
"{}: {}".format(
hex(i), self.eth.eth_getStorageAt(address, i)
)
)
except FileNotFoundError as e: except FileNotFoundError as e:
raise CriticalError("IPC error: " + str(e)) raise CriticalError("IPC error: " + str(e))
except ConnectionError: except ConnectionError:
raise CriticalError("Could not connect to RPC server. Make sure that your node is running and that RPC parameters are set correctly.") raise CriticalError(
return '\n'.join(outtxt) "Could not connect to RPC server. Make sure that your node is running and that RPC parameters are set correctly."
)
return "\n".join(outtxt)
@staticmethod @staticmethod
def disassemble(contract): def disassemble(contract):

@ -4,7 +4,6 @@ import re
class DynLoader: class DynLoader:
def __init__(self, eth): def __init__(self, eth):
self.eth = eth self.eth = eth
self.storage_cache = {} self.storage_cache = {}
@ -19,13 +18,17 @@ class DynLoader:
self.storage_cache[contract_address] = {} self.storage_cache[contract_address] = {}
data = self.eth.eth_getStorageAt(contract_address, position=index, block='latest') data = self.eth.eth_getStorageAt(
contract_address, position=index, block="latest"
)
self.storage_cache[contract_address][index] = data self.storage_cache[contract_address][index] = data
except IndexError: except IndexError:
data = self.eth.eth_getStorageAt(contract_address, position=index, block='latest') data = self.eth.eth_getStorageAt(
contract_address, position=index, block="latest"
)
self.storage_cache[contract_address][index] = data self.storage_cache[contract_address][index] = data
@ -33,9 +36,11 @@ class DynLoader:
def dynld(self, contract_address, dependency_address): def dynld(self, contract_address, dependency_address):
logging.info("Dynld at contract " + contract_address + ": " + dependency_address) logging.info(
"Dynld at contract " + contract_address + ": " + dependency_address
)
m = re.match(r'^(0x[0-9a-fA-F]{40})$', dependency_address) m = re.match(r"^(0x[0-9a-fA-F]{40})$", dependency_address)
if m: if m:
dependency_address = m.group(1) dependency_address = m.group(1)

@ -26,14 +26,15 @@ try:
import fcntl import fcntl
def lock_file(f, exclusive=False): def lock_file(f, exclusive=False):
if f.mode == 'r' and exclusive: if f.mode == "r" and exclusive:
raise Exception('Please use non exclusive mode for reading') raise Exception("Please use non exclusive mode for reading")
flag = fcntl.LOCK_EX if exclusive else fcntl.LOCK_SH flag = fcntl.LOCK_EX if exclusive else fcntl.LOCK_SH
fcntl.lockf(f, flag) fcntl.lockf(f, flag)
def unlock_file(f): def unlock_file(f):
return return
except ImportError: except ImportError:
# Windows file locking # Windows file locking
# TODO: confirm the existence or non existence of shared locks in windows msvcrt and make changes based on that # TODO: confirm the existence or non existence of shared locks in windows msvcrt and make changes based on that
@ -43,8 +44,8 @@ except ImportError:
return os.path.getsize(os.path.realpath(f.name)) return os.path.getsize(os.path.realpath(f.name))
def lock_file(f, exclusive=False): def lock_file(f, exclusive=False):
if f.mode == 'r' and exclusive: if f.mode == "r" and exclusive:
raise Exception('Please use non exclusive mode for reading') raise Exception("Please use non exclusive mode for reading")
msvcrt.locking(f.fileno(), msvcrt.LK_RLCK, file_size(f)) msvcrt.locking(f.fileno(), msvcrt.LK_RLCK, file_size(f))
def unlock_file(f): def unlock_file(f):
@ -52,7 +53,6 @@ except ImportError:
class SignatureDb(object): class SignatureDb(object):
def __init__(self, enable_online_lookup=False): def __init__(self, enable_online_lookup=False):
""" """
Constr Constr
@ -60,9 +60,15 @@ class SignatureDb(object):
""" """
self.signatures = {} # signatures in-mem cache self.signatures = {} # signatures in-mem cache
self.signatures_file = None self.signatures_file = None
self.enable_online_lookup = enable_online_lookup # enable online funcsig resolving self.enable_online_lookup = (
self.online_lookup_miss = set() # temporarily track misses from onlinedb to avoid requesting the same non-existent sighash multiple times enable_online_lookup
self.online_directory_unavailable_until = 0 # flag the online directory as unavailable for some time ) # enable online funcsig resolving
self.online_lookup_miss = (
set()
) # temporarily track misses from onlinedb to avoid requesting the same non-existent sighash multiple times
self.online_directory_unavailable_until = (
0
) # flag the online directory as unavailable for some time
def open(self, path=None): def open(self, path=None):
""" """
@ -74,15 +80,19 @@ class SignatureDb(object):
if not path: if not path:
# try default locations # try default locations
try: try:
mythril_dir = os.environ['MYTHRIL_DIR'] mythril_dir = os.environ["MYTHRIL_DIR"]
except KeyError: except KeyError:
mythril_dir = os.path.join(os.path.expanduser('~'), ".mythril") mythril_dir = os.path.join(os.path.expanduser("~"), ".mythril")
path = os.path.join(mythril_dir, 'signatures.json') path = os.path.join(mythril_dir, "signatures.json")
self.signatures_file = path # store early to allow error handling to access the place we tried to load the file self.signatures_file = (
path
) # store early to allow error handling to access the place we tried to load the file
if not os.path.exists(path): if not os.path.exists(path):
logging.debug("Signatures: file not found: %s" % path) logging.debug("Signatures: file not found: %s" % path)
raise FileNotFoundError("Missing function signature file. Resolving of function names disabled.") raise FileNotFoundError(
"Missing function signature file. Resolving of function names disabled."
)
with open(path, "r") as f: with open(path, "r") as f:
lock_file(f) lock_file(f)
@ -121,16 +131,18 @@ class SignatureDb(object):
finally: finally:
unlock_file(f) unlock_file(f)
sigs.update(self.signatures) # reload file and merge cached sigs into what we load from file sigs.update(
self.signatures
) # reload file and merge cached sigs into what we load from file
self.signatures = sigs self.signatures = sigs
if directory and not os.path.exists(directory): if directory and not os.path.exists(directory):
os.makedirs(directory) # create folder structure if not existS os.makedirs(directory) # create folder structure if not existS
if not os.path.exists(path): # creates signatures.json file if it doesn't exist if not os.path.exists(path): # creates signatures.json file if it doesn't exist
open(path, "w").close() open(path, "w").close()
with open(path, "r+") as f: # placing 'w+' here will result in race conditions with open(path, "r+") as f: # placing 'w+' here will result in race conditions
lock_file(f, exclusive=True) lock_file(f, exclusive=True)
try: try:
json.dump(self.signatures, f) json.dump(self.signatures, f)
@ -150,11 +162,20 @@ class SignatureDb(object):
""" """
if not sighash.startswith("0x"): if not sighash.startswith("0x"):
sighash = "0x%s" % sighash # normalize sighash format sighash = "0x%s" % sighash # normalize sighash format
if self.enable_online_lookup and not self.signatures.get(sighash) and sighash not in self.online_lookup_miss and time.time() > self.online_directory_unavailable_until: if (
self.enable_online_lookup
and not self.signatures.get(sighash)
and sighash not in self.online_lookup_miss
and time.time() > self.online_directory_unavailable_until
):
# online lookup enabled, and signature not in cache, sighash was not a miss earlier, and online directory not down # online lookup enabled, and signature not in cache, sighash was not a miss earlier, and online directory not down
logging.debug("Signatures: performing online lookup for sighash %r" % sighash) logging.debug(
"Signatures: performing online lookup for sighash %r" % sighash
)
try: try:
funcsigs = SignatureDb.lookup_online(sighash, timeout=timeout) # might return multiple sigs funcsigs = SignatureDb.lookup_online(
sighash, timeout=timeout
) # might return multiple sigs
if funcsigs: if funcsigs:
# only store if we get at least one result # only store if we get at least one result
self.signatures[sighash] = funcsigs self.signatures[sighash] = funcsigs
@ -162,8 +183,13 @@ class SignatureDb(object):
# miss # miss
self.online_lookup_miss.add(sighash) self.online_lookup_miss.add(sighash)
except FourByteDirectoryOnlineLookupError as fbdole: except FourByteDirectoryOnlineLookupError as fbdole:
self.online_directory_unavailable_until = time.time() + 2 * 60 # wait at least 2 mins to try again self.online_directory_unavailable_until = (
logging.warning("online function signature lookup not available. will not try to lookup hash for the next 2 minutes. exception: %r" % fbdole) time.time() + 2 * 60
) # wait at least 2 mins to try again
logging.warning(
"online function signature lookup not available. will not try to lookup hash for the next 2 minutes. exception: %r"
% fbdole
)
if sighash not in self.signatures: if sighash not in self.signatures:
return [] return []
@ -179,13 +205,19 @@ class SignatureDb(object):
""" """
return self.get(sighash=item) return self.get(sighash=item)
def import_from_solidity_source(self, file_path, solc_binary="solc", solc_args=None): def import_from_solidity_source(
self, file_path, solc_binary="solc", solc_args=None
):
""" """
Import Function Signatures from solidity source files Import Function Signatures from solidity source files
:param file_path: solidity source code file path :param file_path: solidity source code file path
:return: self :return: self
""" """
self.signatures.update(SignatureDb.get_sigs_from_file(file_path, solc_binary=solc_binary, solc_args=solc_args)) self.signatures.update(
SignatureDb.get_sigs_from_file(
file_path, solc_binary=solc_binary, solc_args=solc_args
)
)
return self return self
@staticmethod @staticmethod
@ -203,9 +235,11 @@ class SignatureDb(object):
""" """
if not ethereum_input_decoder: if not ethereum_input_decoder:
return None return None
return list(ethereum_input_decoder.decoder.FourByteDirectory.lookup_signatures(sighash, return list(
timeout=timeout, ethereum_input_decoder.decoder.FourByteDirectory.lookup_signatures(
proxies=proxies)) sighash, timeout=timeout, proxies=proxies
)
)
@staticmethod @staticmethod
def get_sigs_from_file(file_name, solc_binary="solc", solc_args=None): def get_sigs_from_file(file_name, solc_binary="solc", solc_args=None):
@ -223,13 +257,19 @@ class SignatureDb(object):
ret = p.returncode ret = p.returncode
if ret != 0: if ret != 0:
raise CompilerError("Solc experienced a fatal error (code %d).\n\n%s" % (ret, stderr.decode('UTF-8'))) raise CompilerError(
"Solc experienced a fatal error (code %d).\n\n%s"
% (ret, stderr.decode("UTF-8"))
)
except FileNotFoundError: except FileNotFoundError:
raise CompilerError( raise CompilerError(
"Compiler not found. Make sure that solc is installed and in PATH, or set the SOLC environment variable.") "Compiler not found. Make sure that solc is installed and in PATH, or set the SOLC environment variable."
stdout = stdout.decode('unicode_escape').split('\n') )
stdout = stdout.decode("unicode_escape").split("\n")
for line in stdout: for line in stdout:
if '(' in line and ')' in line and ":" in line: # the ':' need not be checked but just to be sure if (
sigs["0x"+line.split(':')[0]] = [line.split(":")[1].strip()] "(" in line and ")" in line and ":" in line
): # the ':' need not be checked but just to be sure
sigs["0x" + line.split(":")[0]] = [line.split(":")[1].strip()]
logging.debug("Signatures: found %d signatures after parsing" % len(sigs)) logging.debug("Signatures: found %d signatures after parsing" % len(sigs))
return sigs return sigs

@ -25,36 +25,49 @@ def analyze_truffle_project(sigs, args):
for filename in files: for filename in files:
if re.match(r'.*\.json$', filename) and filename != "Migrations.json": if re.match(r".*\.json$", filename) and filename != "Migrations.json":
with open(os.path.join(build_dir, filename)) as cf: with open(os.path.join(build_dir, filename)) as cf:
contractdata = json.load(cf) contractdata = json.load(cf)
try: try:
name = contractdata['contractName'] name = contractdata["contractName"]
bytecode = contractdata['deployedBytecode'] bytecode = contractdata["deployedBytecode"]
filename = PurePath(contractdata['sourcePath']).name filename = PurePath(contractdata["sourcePath"]).name
except KeyError: except KeyError:
print("Unable to parse contract data. Please use Truffle 4 to compile your project.") print(
"Unable to parse contract data. Please use Truffle 4 to compile your project."
)
sys.exit() sys.exit()
if len(bytecode) < 4: if len(bytecode) < 4:
continue continue
sigs.import_from_solidity_source(contractdata['sourcePath'], solc_args=args.solc_args) sigs.import_from_solidity_source(
contractdata["sourcePath"], solc_args=args.solc_args
)
sigs.write() sigs.write()
ethcontract = ETHContract(bytecode, name=name) ethcontract = ETHContract(bytecode, name=name)
address = util.get_indexed_address(0) address = util.get_indexed_address(0)
sym = SymExecWrapper(ethcontract, address, args.strategy, max_depth=args.max_depth, sym = SymExecWrapper(
create_timeout=args.create_timeout, execution_timeout=args.execution_timeout) ethcontract,
address,
args.strategy,
max_depth=args.max_depth,
create_timeout=args.create_timeout,
execution_timeout=args.execution_timeout,
)
issues = fire_lasers(sym) issues = fire_lasers(sym)
if not len(issues): if not len(issues):
if args.outform == 'text' or args.outform == 'markdown': if args.outform == "text" or args.outform == "markdown":
print("# Analysis result for " + name + "\n\nNo issues found.") print("# Analysis result for " + name + "\n\nNo issues found.")
else: else:
result = {'contract': name, 'result': {'success': True, 'error': None, 'issues': []}} result = {
"contract": name,
"result": {"success": True, "error": None, "issues": []},
}
print(json.dumps(result)) print(json.dumps(result))
else: else:
@ -62,9 +75,9 @@ def analyze_truffle_project(sigs, args):
# augment with source code # augment with source code
disassembly = ethcontract.disassembly disassembly = ethcontract.disassembly
source = contractdata['source'] source = contractdata["source"]
deployed_source_map = contractdata['deployedSourceMap'].split(";") deployed_source_map = contractdata["deployedSourceMap"].split(";")
mappings = [] mappings = []
@ -80,34 +93,49 @@ def analyze_truffle_project(sigs, args):
if len(mapping) > 2 and len(mapping[2]) > 0: if len(mapping) > 2 and len(mapping[2]) > 0:
idx = int(mapping[2]) idx = int(mapping[2])
lineno = source.encode('utf-8')[0:offset].count('\n'.encode('utf-8')) + 1 lineno = (
source.encode("utf-8")[0:offset].count("\n".encode("utf-8")) + 1
)
mappings.append(SourceMapping(idx, offset, length, lineno)) mappings.append(SourceMapping(idx, offset, length, lineno))
for issue in issues: for issue in issues:
index = get_instruction_index(disassembly.instruction_list, issue.address) index = get_instruction_index(
disassembly.instruction_list, issue.address
)
if index: if index:
try: try:
offset = mappings[index].offset offset = mappings[index].offset
length = mappings[index].length length = mappings[index].length
issue.filename = filename issue.filename = filename
issue.code = source.encode('utf-8')[offset:offset + length].decode('utf-8') issue.code = source.encode("utf-8")[
issue.lineno = mappings[index].lineno offset : offset + length
except IndexError: ].decode("utf-8")
logging.debug("No code mapping at index %d", index) issue.lineno = mappings[index].lineno
except IndexError:
logging.debug("No code mapping at index %d", index)
report.append_issue(issue) report.append_issue(issue)
if args.outform == 'json': if args.outform == "json":
result = {'contract': name, 'result': {'success': True, 'error': None, 'issues': list(map(lambda x: x.as_dict, issues))}} result = {
"contract": name,
"result": {
"success": True,
"error": None,
"issues": list(map(lambda x: x.as_dict, issues)),
},
}
print(json.dumps(result)) print(json.dumps(result))
else: else:
if args.outform == 'text': if args.outform == "text":
print("# Analysis result for " + name + ":\n\n" + report.as_text()) print(
elif args.outform == 'markdown': "# Analysis result for " + name + ":\n\n" + report.as_text()
)
elif args.outform == "markdown":
print(report.as_markdown()) print(report.as_markdown())

@ -1,3 +1,3 @@
# This file is suitable for sourcing inside POSIX shell, e.g. bash as # This file is suitable for sourcing inside POSIX shell, e.g. bash as
# well as for importing into Python # well as for importing into Python
VERSION="v0.18.12" # NOQA VERSION = "v0.18.12" # NOQA

@ -22,19 +22,22 @@ VERSION = None
# Package version (vX.Y.Z). It must match git tag being used for CircleCI # Package version (vX.Y.Z). It must match git tag being used for CircleCI
# deployment; otherwise the build will failed. # deployment; otherwise the build will failed.
version_path = (Path(__file__).parent / 'mythril' / 'version.py').absolute() version_path = (Path(__file__).parent / "mythril" / "version.py").absolute()
exec(open(str(version_path), 'r').read()) exec(open(str(version_path), "r").read())
class VerifyVersionCommand(install): class VerifyVersionCommand(install):
"""Custom command to verify that the git tag matches our version""" """Custom command to verify that the git tag matches our version"""
description = 'verify that the git tag matches our version'
description = "verify that the git tag matches our version"
def run(self): def run(self):
tag = os.getenv('CIRCLE_TAG') tag = os.getenv("CIRCLE_TAG")
if tag != VERSION: if tag != VERSION:
info = "Git tag: {0} does not match the version of this app: {1}".format(tag, VERSION) info = "Git tag: {0} does not match the version of this app: {1}".format(
tag, VERSION
)
sys.exit(info) sys.exit(info)
@ -44,92 +47,62 @@ def read_file(fname):
:param fname: path relative to setup.py :param fname: path relative to setup.py
:return: file contents :return: file contents
""" """
with open(os.path.join(os.path.dirname(__file__), fname), 'r') as fd: with open(os.path.join(os.path.dirname(__file__), fname), "r") as fd:
return fd.read() return fd.read()
setup( setup(
name='mythril', name="mythril",
version=VERSION[1:], version=VERSION[1:],
description="Security analysis tool for Ethereum smart contracts",
description='Security analysis tool for Ethereum smart contracts',
long_description=read_file("README.md") if os.path.isfile("README.md") else "", long_description=read_file("README.md") if os.path.isfile("README.md") else "",
long_description_content_type='text/markdown', # requires twine and recent setuptools long_description_content_type="text/markdown", # requires twine and recent setuptools
url="https://github.com/b-mueller/mythril",
url='https://github.com/b-mueller/mythril', author="Bernhard Mueller",
author_email="bernhard.mueller11@gmail.com",
author='Bernhard Mueller', license="MIT",
author_email='bernhard.mueller11@gmail.com',
license='MIT',
classifiers=[ classifiers=[
'Development Status :: 3 - Alpha', "Development Status :: 3 - Alpha",
"Intended Audience :: Science/Research",
'Intended Audience :: Science/Research', "Topic :: Software Development :: Disassemblers",
'Topic :: Software Development :: Disassemblers', "License :: OSI Approved :: MIT License",
"Programming Language :: Python :: 3.5",
'License :: OSI Approved :: MIT License', "Programming Language :: Python :: 3.6",
"Programming Language :: Python :: 3.7",
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
], ],
keywords="hacking disassembler security ethereum",
keywords='hacking disassembler security ethereum', packages=find_packages(exclude=["contrib", "docs", "tests"]),
packages=find_packages(exclude=['contrib', 'docs', 'tests']),
install_requires=[ install_requires=[
'coloredlogs>=10.0', "coloredlogs>=10.0",
'ethereum>=2.3.2', "ethereum>=2.3.2",
'z3-solver>=4.5', "z3-solver>=4.5",
'requests', "requests",
'py-solc', "py-solc",
'plyvel', "plyvel",
'eth_abi>=1.0.0', "eth_abi>=1.0.0",
'eth-utils>=1.0.1', "eth-utils>=1.0.1",
'eth-account>=0.1.0a2', "eth-account>=0.1.0a2",
'eth-hash>=0.1.0', "eth-hash>=0.1.0",
'eth-keyfile>=0.5.1', "eth-keyfile>=0.5.1",
'eth-keys>=0.2.0b3', "eth-keys>=0.2.0b3",
'eth-rlp>=0.1.0', "eth-rlp>=0.1.0",
'eth-tester>=0.1.0b21', "eth-tester>=0.1.0b21",
'eth-typing>=1.3.0,<2.0.0', "eth-typing>=1.3.0,<2.0.0",
'coverage', "coverage",
'jinja2>=2.9', "jinja2>=2.9",
'rlp>=1.0.1', "rlp>=1.0.1",
'transaction>=2.2.1', "transaction>=2.2.1",
'py-flags', "py-flags",
'mock', "mock",
'configparser>=3.5.0', "configparser>=3.5.0",
'persistent>=4.2.0', "persistent>=4.2.0",
'ethereum-input-decoder>=0.2.2' "ethereum-input-decoder>=0.2.2",
], ],
tests_require=["pytest>=3.6.0", "pytest_mock", "pytest-cov"],
tests_require=[ python_requires=">=3.5",
'pytest>=3.6.0', extras_require={},
'pytest_mock', package_data={"mythril.analysis.templates": ["*"]},
'pytest-cov'
],
python_requires='>=3.5',
extras_require={
},
package_data={
'mythril.analysis.templates': ['*']
},
include_package_data=True, include_package_data=True,
entry_points={"console_scripts": ["myth=mythril.interfaces.cli:main"]},
entry_points={ cmdclass={"verify": VerifyVersionCommand},
'console_scripts': ["myth=mythril.interfaces.cli:main"],
},
cmdclass={
'verify': VerifyVersionCommand,
}
) )

@ -16,15 +16,17 @@ MYTHRIL_DIR = TESTS_DIR / "mythril_dir"
class BaseTestCase(TestCase): class BaseTestCase(TestCase):
def setUp(self): def setUp(self):
self.changed_files = [] self.changed_files = []
self.ori_mythril_dir = getattr(os.environ, 'MYTHRIL_DIR', '') self.ori_mythril_dir = getattr(os.environ, "MYTHRIL_DIR", "")
os.environ['MYTHRIL_DIR'] = str(MYTHRIL_DIR) os.environ["MYTHRIL_DIR"] = str(MYTHRIL_DIR)
shutil.copyfile(str(MYTHRIL_DIR / "signatures.json.example"), str(MYTHRIL_DIR / "signatures.json")) shutil.copyfile(
str(MYTHRIL_DIR / "signatures.json.example"),
str(MYTHRIL_DIR / "signatures.json"),
)
def tearDown(self): def tearDown(self):
os.environ['MYTHRIL_DIR'] = self.ori_mythril_dir os.environ["MYTHRIL_DIR"] = self.ori_mythril_dir
os.remove(str(MYTHRIL_DIR / "signatures.json")) os.remove(str(MYTHRIL_DIR / "signatures.json"))
def compare_files_error_message(self): def compare_files_error_message(self):
@ -41,4 +43,6 @@ class BaseTestCase(TestCase):
self.changed_files.append((input_file, output_expected, output_current)) self.changed_files.append((input_file, output_expected, output_current))
def assert_and_show_changed_files(self): def assert_and_show_changed_files(self):
self.assertEqual(0, len(self.changed_files), msg=self.compare_files_error_message()) self.assertEqual(
0, len(self.changed_files), msg=self.compare_files_error_message()
)

@ -1,4 +1,8 @@
from mythril.analysis.modules.delegatecall import execute, _concrete_call, _symbolic_call from mythril.analysis.modules.delegatecall import (
execute,
_concrete_call,
_symbolic_call,
)
from mythril.analysis.ops import Call, Variable, VarType from mythril.analysis.ops import Call, Variable, VarType
from mythril.analysis.symbolic import SymExecWrapper from mythril.analysis.symbolic import SymExecWrapper
from mythril.laser.ethereum.cfg import Node from mythril.laser.ethereum.cfg import Node
@ -32,11 +36,14 @@ def test_concrete_call():
assert issue.contract == node.contract_name assert issue.contract == node.contract_name
assert issue.function == node.function_name assert issue.function == node.function_name
assert issue.title == "Call data forwarded with delegatecall()" assert issue.title == "Call data forwarded with delegatecall()"
assert issue.type == 'Informational' assert issue.type == "Informational"
assert issue.description == "This contract forwards its call data via DELEGATECALL in its fallback function." \ assert (
" This means that any function in the called contract can be executed." \ issue.description
" Note that the callee contract will have access to the storage of the " \ == "This contract forwards its call data via DELEGATECALL in its fallback function."
"calling contract.\n DELEGATECALL target: 0x1" " This means that any function in the called contract can be executed."
" Note that the callee contract will have access to the storage of the "
"calling contract.\n DELEGATECALL target: 0x1"
)
def test_concrete_call_symbolic_to(): def test_concrete_call_symbolic_to():
@ -63,11 +70,14 @@ def test_concrete_call_symbolic_to():
assert issue.contract == node.contract_name assert issue.contract == node.contract_name
assert issue.function == node.function_name assert issue.function == node.function_name
assert issue.title == "Call data forwarded with delegatecall()" assert issue.title == "Call data forwarded with delegatecall()"
assert issue.type == 'Informational' assert issue.type == "Informational"
assert issue.description == "This contract forwards its call data via DELEGATECALL in its fallback function." \ assert (
" This means that any function in the called contract can be executed." \ issue.description
" Note that the callee contract will have access to the storage of the " \ == "This contract forwards its call data via DELEGATECALL in its fallback function."
"calling contract.\n DELEGATECALL target: calldata_3" " This means that any function in the called contract can be executed."
" Note that the callee contract will have access to the storage of the "
"calling contract.\n DELEGATECALL target: calldata_3"
)
def test_concrete_call_not_calldata(): def test_concrete_call_not_calldata():
@ -92,7 +102,6 @@ def test_symbolic_call_storage_to(mocker):
state = GlobalState(None, environment, None) state = GlobalState(None, environment, None)
state.mstate.memory = ["placeholder", "calldata_bling_0"] state.mstate.memory = ["placeholder", "calldata_bling_0"]
node = Node("example") node = Node("example")
node.contract_name = "the contract name" node.contract_name = "the contract name"
node.function_name = "the function name" node.function_name = "the function name"
@ -100,14 +109,12 @@ def test_symbolic_call_storage_to(mocker):
to = Variable("storage_1", VarType.SYMBOLIC) to = Variable("storage_1", VarType.SYMBOLIC)
call = Call(node, state, None, "Type: ", to, None) call = Call(node, state, None, "Type: ", to, None)
mocker.patch.object(SymExecWrapper, "__init__", lambda x, y: None) mocker.patch.object(SymExecWrapper, "__init__", lambda x, y: None)
statespace = SymExecWrapper(1) statespace = SymExecWrapper(1)
mocker.patch.object(statespace, 'find_storage_write') mocker.patch.object(statespace, "find_storage_write")
statespace.find_storage_write.return_value = "Function name" statespace.find_storage_write.return_value = "Function name"
# act # act
issues = _symbolic_call(call, state, address, statespace) issues = _symbolic_call(call, state, address, statespace)
@ -116,11 +123,14 @@ def test_symbolic_call_storage_to(mocker):
assert issue.address == address assert issue.address == address
assert issue.contract == node.contract_name assert issue.contract == node.contract_name
assert issue.function == node.function_name assert issue.function == node.function_name
assert issue.title == 'Type: to a user-supplied address' assert issue.title == "Type: to a user-supplied address"
assert issue.type == 'Informational' assert issue.type == "Informational"
assert issue.description == 'This contract delegates execution to a contract address in storage slot 1.' \ assert (
' This storage slot can be written to by calling the function `Function name`. ' \ issue.description
'Be aware that the called contract gets unrestricted access to this contract\'s state.' == "This contract delegates execution to a contract address in storage slot 1."
" This storage slot can be written to by calling the function `Function name`. "
"Be aware that the called contract gets unrestricted access to this contract's state."
)
def test_symbolic_call_calldata_to(mocker): def test_symbolic_call_calldata_to(mocker):
@ -130,7 +140,6 @@ def test_symbolic_call_calldata_to(mocker):
state = GlobalState(None, None, None) state = GlobalState(None, None, None)
state.mstate.memory = ["placeholder", "calldata_bling_0"] state.mstate.memory = ["placeholder", "calldata_bling_0"]
node = Node("example") node = Node("example")
node.contract_name = "the contract name" node.contract_name = "the contract name"
node.function_name = "the function name" node.function_name = "the function name"
@ -138,14 +147,12 @@ def test_symbolic_call_calldata_to(mocker):
to = Variable("calldata", VarType.SYMBOLIC) to = Variable("calldata", VarType.SYMBOLIC)
call = Call(node, state, None, "Type: ", to, None) call = Call(node, state, None, "Type: ", to, None)
mocker.patch.object(SymExecWrapper, "__init__", lambda x, y: None) mocker.patch.object(SymExecWrapper, "__init__", lambda x, y: None)
statespace = SymExecWrapper(1) statespace = SymExecWrapper(1)
mocker.patch.object(statespace, 'find_storage_write') mocker.patch.object(statespace, "find_storage_write")
statespace.find_storage_write.return_value = "Function name" statespace.find_storage_write.return_value = "Function name"
# act # act
issues = _symbolic_call(call, state, address, statespace) issues = _symbolic_call(call, state, address, statespace)
@ -154,29 +161,32 @@ def test_symbolic_call_calldata_to(mocker):
assert issue.address == address assert issue.address == address
assert issue.contract == node.contract_name assert issue.contract == node.contract_name
assert issue.function == node.function_name assert issue.function == node.function_name
assert issue.title == 'Type: to a user-supplied address' assert issue.title == "Type: to a user-supplied address"
assert issue.type == 'Informational' assert issue.type == "Informational"
assert issue.description == 'This contract delegates execution to a contract address obtained from calldata. ' \ assert (
'Be aware that the called contract gets unrestricted access to this contract\'s state.' issue.description
== "This contract delegates execution to a contract address obtained from calldata. "
"Be aware that the called contract gets unrestricted access to this contract's state."
@patch('mythril.laser.ethereum.state.GlobalState.get_current_instruction') )
@patch('mythril.analysis.modules.delegatecall._concrete_call')
@patch('mythril.analysis.modules.delegatecall._symbolic_call')
@patch("mythril.laser.ethereum.state.GlobalState.get_current_instruction")
@patch("mythril.analysis.modules.delegatecall._concrete_call")
@patch("mythril.analysis.modules.delegatecall._symbolic_call")
def test_delegate_call(sym_mock, concrete_mock, curr_instruction): def test_delegate_call(sym_mock, concrete_mock, curr_instruction):
# arrange # arrange
# sym_mock = mocker.patch.object(delegatecall, "_symbolic_call") # sym_mock = mocker.patch.object(delegatecall, "_symbolic_call")
# concrete_mock = mocker.patch.object(delegatecall, "_concrete_call") # concrete_mock = mocker.patch.object(delegatecall, "_concrete_call")
sym_mock.return_value = [] sym_mock.return_value = []
concrete_mock.return_value = [] concrete_mock.return_value = []
curr_instruction.return_value = {'address': '0x10'} curr_instruction.return_value = {"address": "0x10"}
active_account = Account('0x10') active_account = Account("0x10")
environment = Environment(active_account, None, None, None, None, None) environment = Environment(active_account, None, None, None, None, None)
state = GlobalState(None, environment, Node) state = GlobalState(None, environment, Node)
state.mstate.memory = ["placeholder", "calldata_bling_0"] state.mstate.memory = ["placeholder", "calldata_bling_0"]
state.mstate.stack = [1, 2, 3] state.mstate.stack = [1, 2, 3]
assert state.get_current_instruction() == {'address': '0x10'} assert state.get_current_instruction() == {"address": "0x10"}
node = Node("example") node = Node("example")
node.contract_name = "the contract name" node.contract_name = "the contract name"
@ -196,8 +206,8 @@ def test_delegate_call(sym_mock, concrete_mock, curr_instruction):
assert sym_mock.call_count == 1 assert sym_mock.call_count == 1
@patch('mythril.analysis.modules.delegatecall._concrete_call') @patch("mythril.analysis.modules.delegatecall._concrete_call")
@patch('mythril.analysis.modules.delegatecall._symbolic_call') @patch("mythril.analysis.modules.delegatecall._symbolic_call")
def test_delegate_call_not_delegate(sym_mock, concrete_mock): def test_delegate_call_not_delegate(sym_mock, concrete_mock):
# arrange # arrange
# sym_mock = mocker.patch.object(delegatecall, "_symbolic_call") # sym_mock = mocker.patch.object(delegatecall, "_symbolic_call")
@ -223,8 +233,8 @@ def test_delegate_call_not_delegate(sym_mock, concrete_mock):
assert sym_mock.call_count == 0 assert sym_mock.call_count == 0
@patch('mythril.analysis.modules.delegatecall._concrete_call') @patch("mythril.analysis.modules.delegatecall._concrete_call")
@patch('mythril.analysis.modules.delegatecall._symbolic_call') @patch("mythril.analysis.modules.delegatecall._symbolic_call")
def test_delegate_call_not_fallback(sym_mock, concrete_mock): def test_delegate_call_not_fallback(sym_mock, concrete_mock):
# arrange # arrange
# sym_mock = mocker.patch.object(delegatecall, "_symbolic_call") # sym_mock = mocker.patch.object(delegatecall, "_symbolic_call")

@ -3,50 +3,64 @@ from tests import *
MYTH = str(PROJECT_DIR / "myth") MYTH = str(PROJECT_DIR / "myth")
def output_of(command): def output_of(command):
return check_output(command, shell=True).decode("UTF-8") return check_output(command, shell=True).decode("UTF-8")
class CommandLineToolTestCase(BaseTestCase):
class CommandLineToolTestCase(BaseTestCase):
def test_disassemble_code_correctly(self): def test_disassemble_code_correctly(self):
command = "python3 {} MYTH -d -c 0x5050".format(MYTH) command = "python3 {} MYTH -d -c 0x5050".format(MYTH)
self.assertEqual('0 POP\n1 POP\n', output_of(command)) self.assertEqual("0 POP\n1 POP\n", output_of(command))
def test_disassemble_solidity_file_correctly(self): def test_disassemble_solidity_file_correctly(self):
solidity_file = str(TESTDATA / 'input_contracts'/ 'metacoin.sol') solidity_file = str(TESTDATA / "input_contracts" / "metacoin.sol")
command = "python3 {} -d {}".format(MYTH, solidity_file) command = "python3 {} -d {}".format(MYTH, solidity_file)
self.assertIn('2 PUSH1 0x40\n4 MSTORE', output_of(command)) self.assertIn("2 PUSH1 0x40\n4 MSTORE", output_of(command))
def test_hash_a_function_correctly(self): def test_hash_a_function_correctly(self):
command = "python3 {} --hash 'setOwner(address)'".format(MYTH) command = "python3 {} --hash 'setOwner(address)'".format(MYTH)
self.assertEqual('0x13af4035\n', output_of(command)) self.assertEqual("0x13af4035\n", output_of(command))
class TruffleTestCase(BaseTestCase):
class TruffleTestCase(BaseTestCase):
def test_analysis_truffle_project(self): def test_analysis_truffle_project(self):
truffle_project_root = str(TESTS_DIR / "truffle_project") truffle_project_root = str(TESTS_DIR / "truffle_project")
command = "cd {}; truffle compile; python3 {} --truffle".format(truffle_project_root, MYTH) command = "cd {}; truffle compile; python3 {} --truffle".format(
self.assertIn("In the function `withdrawfunds()` a non-zero amount of Ether is sent to msg.sender.", output_of(command)) truffle_project_root, MYTH
)
self.assertIn(
"In the function `withdrawfunds()` a non-zero amount of Ether is sent to msg.sender.",
output_of(command),
)
class InfuraTestCase(BaseTestCase):
class InfuraTestCase(BaseTestCase):
def test_infura_mainnet(self): def test_infura_mainnet(self):
command = "python3 {} --rpc infura-mainnet -d -a 0x2a0c0dbecc7e4d658f48e01e3fa353f44050c208".format(MYTH) command = "python3 {} --rpc infura-mainnet -d -a 0x2a0c0dbecc7e4d658f48e01e3fa353f44050c208".format(
MYTH
)
output = output_of(command) output = output_of(command)
self.assertIn("0 PUSH1 0x60\n2 PUSH1 0x40\n4 MSTORE", output) self.assertIn("0 PUSH1 0x60\n2 PUSH1 0x40\n4 MSTORE", output)
self.assertIn("7278 POP\n7279 POP\n7280 JUMP\n7281 STOP", output) self.assertIn("7278 POP\n7279 POP\n7280 JUMP\n7281 STOP", output)
def test_infura_rinkeby(self): def test_infura_rinkeby(self):
command = "python3 {} --rpc infura-rinkeby -d -a 0xB6f2bFED892a662bBF26258ceDD443f50Fa307F5".format(MYTH) command = "python3 {} --rpc infura-rinkeby -d -a 0xB6f2bFED892a662bBF26258ceDD443f50Fa307F5".format(
MYTH
)
output = output_of(command) output = output_of(command)
self.assertIn("34 JUMPDEST\n35 CALLVALUE", output) self.assertIn("34 JUMPDEST\n35 CALLVALUE", output)
def test_infura_kovan(self): def test_infura_kovan(self):
command = "python3 {} --rpc infura-kovan -d -a 0xE6bBF9B5A3451242F82f8cd458675092617a1235".format(MYTH) command = "python3 {} --rpc infura-kovan -d -a 0xE6bBF9B5A3451242F82f8cd458675092617a1235".format(
MYTH
)
output = output_of(command) output = output_of(command)
self.assertIn("9999 PUSH1 0x00\n10001 NOT\n10002 AND\n10003 PUSH1 0x00", output) self.assertIn("9999 PUSH1 0x00\n10001 NOT\n10002 AND\n10003 PUSH1 0x00", output)
def test_infura_ropsten(self): def test_infura_ropsten(self):
command = "python3 {} --rpc infura-ropsten -d -a 0x6e0E0e02377Bc1d90E8a7c21f12BA385C2C35f78".format(MYTH) command = "python3 {} --rpc infura-ropsten -d -a 0x6e0E0e02377Bc1d90E8a7c21f12BA385C2C35f78".format(
MYTH
)
output = output_of(command) output = output_of(command)
self.assertIn("1821 PUSH1 0x01\n1823 PUSH2 0x070c", output) self.assertIn("1821 PUSH1 0x01\n1823 PUSH2 0x070c", output)

File diff suppressed because one or more lines are too long

@ -3,33 +3,45 @@ from mythril.ether.ethcontract import ETHContract
class ETHContractTestCase(unittest.TestCase): class ETHContractTestCase(unittest.TestCase):
def setUp(self): def setUp(self):
self.code = "0x60606040525b603c5b60006010603e565b9050593681016040523660008237602060003683856040603f5a0204f41560545760206000f35bfe5b50565b005b73c3b2ae46792547a96b9f84405e36d0e07edcd05c5b905600a165627a7a7230582062a884f947232ada573f95940cce9c8bfb7e4e14e21df5af4e884941afb55e590029" self.code = "0x60606040525b603c5b60006010603e565b9050593681016040523660008237602060003683856040603f5a0204f41560545760206000f35bfe5b50565b005b73c3b2ae46792547a96b9f84405e36d0e07edcd05c5b905600a165627a7a7230582062a884f947232ada573f95940cce9c8bfb7e4e14e21df5af4e884941afb55e590029"
self.creation_code = "0x60606040525b603c5b60006010603e565b9050593681016040523660008237602060003683856040603f5a0204f41560545760206000f35bfe5b50565b005b73c3b2ae46792547a96b9f84405e36d0e07edcd05c5b905600a165627a7a7230582062a884f947232ada573f95940cce9c8bfb7e4e14e21df5af4e884941afb55e590029" self.creation_code = "0x60606040525b603c5b60006010603e565b9050593681016040523660008237602060003683856040603f5a0204f41560545760206000f35bfe5b50565b005b73c3b2ae46792547a96b9f84405e36d0e07edcd05c5b905600a165627a7a7230582062a884f947232ada573f95940cce9c8bfb7e4e14e21df5af4e884941afb55e590029"
class Getinstruction_listTestCase(ETHContractTestCase):
class Getinstruction_listTestCase(ETHContractTestCase):
def runTest(self): def runTest(self):
contract = ETHContract(self.code, self.creation_code) contract = ETHContract(self.code, self.creation_code)
disassembly = contract.disassembly disassembly = contract.disassembly
self.assertEqual(len(disassembly.instruction_list), 53, 'Error disassembling code using ETHContract.get_instruction_list()') self.assertEqual(
len(disassembly.instruction_list),
53,
"Error disassembling code using ETHContract.get_instruction_list()",
)
class GetEASMTestCase(ETHContractTestCase):
class GetEASMTestCase(ETHContractTestCase):
def runTest(self): def runTest(self):
contract = ETHContract(self.code) contract = ETHContract(self.code)
instruction_list = contract.get_easm() instruction_list = contract.get_easm()
self.assertTrue("PUSH1 0x60" in instruction_list, 'Error obtaining EASM code through ETHContract.get_easm()') self.assertTrue(
"PUSH1 0x60" in instruction_list,
"Error obtaining EASM code through ETHContract.get_easm()",
)
class MatchesExpressionTestCase(ETHContractTestCase):
class MatchesExpressionTestCase(ETHContractTestCase):
def runTest(self): def runTest(self):
contract = ETHContract(self.code) contract = ETHContract(self.code)
self.assertTrue(contract.matches_expression("code#PUSH1# or code#PUSH1#"), 'Unexpected result in expression matching') self.assertTrue(
self.assertFalse(contract.matches_expression("func#abcdef#"), 'Unexpected result in expression matching') contract.matches_expression("code#PUSH1# or code#PUSH1#"),
"Unexpected result in expression matching",
)
self.assertFalse(
contract.matches_expression("func#abcdef#"),
"Unexpected result in expression matching",
)

@ -5,23 +5,31 @@ from mythril.ether.soliditycontract import ETHContract
from tests import * from tests import *
import re import re
class GraphTest(BaseTestCase):
class GraphTest(BaseTestCase):
def test_generate_graph(self): def test_generate_graph(self):
for input_file in TESTDATA_INPUTS.iterdir(): for input_file in TESTDATA_INPUTS.iterdir():
output_expected = TESTDATA_OUTPUTS_EXPECTED / (input_file.name + ".graph.html") output_expected = TESTDATA_OUTPUTS_EXPECTED / (
output_current = TESTDATA_OUTPUTS_CURRENT / (input_file.name + ".graph.html") input_file.name + ".graph.html"
)
output_current = TESTDATA_OUTPUTS_CURRENT / (
input_file.name + ".graph.html"
)
contract = ETHContract(input_file.read_text()) contract = ETHContract(input_file.read_text())
sym = SymExecWrapper(contract, address=(util.get_indexed_address(0)), strategy="dfs") sym = SymExecWrapper(
contract, address=(util.get_indexed_address(0)), strategy="dfs"
)
html = generate_graph(sym) html = generate_graph(sym)
output_current.write_text(html) output_current.write_text(html)
lines_expected = re.findall(r"'label': '.*'", str(output_current.read_text())) lines_expected = re.findall(
lines_found = re.findall(r"'label': '.*'", str(output_current.read_text())) r"'label': '.*'", str(output_current.read_text())
)
lines_found = re.findall(r"'label': '.*'", str(output_current.read_text()))
if not (lines_expected == lines_found): if not (lines_expected == lines_found):
self.found_changed_files(input_file, output_expected, output_current) self.found_changed_files(input_file, output_expected, output_current)

@ -5,7 +5,7 @@ from mythril.laser.ethereum.instructions import Instruction
def test_codecopy_concrete(): def test_codecopy_concrete():
# Arrange # Arrange
active_account = Account("0x0", code= Disassembly("60606040")) active_account = Account("0x0", code=Disassembly("60606040"))
environment = Environment(active_account, None, None, None, None, None) environment = Environment(active_account, None, None, None, None, None)
og_state = GlobalState(None, environment, None, MachineState(gas=10000000)) og_state = GlobalState(None, environment, None, MachineState(gas=10000000))

@ -10,9 +10,14 @@ import json
from pathlib import Path from pathlib import Path
import pytest import pytest
evm_test_dir = Path(__file__).parent / 'VMTests' evm_test_dir = Path(__file__).parent / "VMTests"
test_types = ['vmArithmeticTest', 'vmBitwiseLogicOperation', 'vmPushDupSwapTest', 'vmTests'] test_types = [
"vmArithmeticTest",
"vmBitwiseLogicOperation",
"vmPushDupSwapTest",
"vmTests",
]
def load_test_data(designations): def load_test_data(designations):
@ -24,27 +29,33 @@ def load_test_data(designations):
top_level = json.load(file) top_level = json.load(file)
for test_name, data in top_level.items(): for test_name, data in top_level.items():
pre_condition = data['pre'] pre_condition = data["pre"]
action = data['exec'] action = data["exec"]
post_condition = data.get('post', {}) post_condition = data.get("post", {})
return_data.append((test_name, pre_condition, action, post_condition)) return_data.append(
(test_name, pre_condition, action, post_condition)
)
return return_data return return_data
@pytest.mark.parametrize("test_name, pre_condition, action, post_condition", load_test_data(test_types)) @pytest.mark.parametrize(
def test_vmtest(test_name: str, pre_condition: dict, action: dict, post_condition: dict) -> None: "test_name, pre_condition, action, post_condition", load_test_data(test_types)
)
def test_vmtest(
test_name: str, pre_condition: dict, action: dict, post_condition: dict
) -> None:
# Arrange # Arrange
accounts = {} accounts = {}
for address, details in pre_condition.items(): for address, details in pre_condition.items():
account = Account(address) account = Account(address)
account.code = Disassembly(details['code'][2:]) account.code = Disassembly(details["code"][2:])
account.balance = int(details['balance'], 16) account.balance = int(details["balance"], 16)
account.nonce = int(details['nonce'], 16) account.nonce = int(details["nonce"], 16)
accounts[address] = account accounts[address] = account
@ -54,14 +65,14 @@ def test_vmtest(test_name: str, pre_condition: dict, action: dict, post_conditio
laser_evm.time = datetime.now() laser_evm.time = datetime.now()
execute_message_call( execute_message_call(
laser_evm, laser_evm,
callee_address=action['address'], callee_address=action["address"],
caller_address=action['caller'], caller_address=action["caller"],
origin_address=action['origin'], origin_address=action["origin"],
code=action['code'][2:], code=action["code"][2:],
gas=action['gas'], gas=action["gas"],
data=binascii.a2b_hex(action['data'][2:]), data=binascii.a2b_hex(action["data"][2:]),
gas_price=int(action['gasPrice'], 16), gas_price=int(action["gasPrice"], 16),
value=int(action['value'], 16) value=int(action["value"], 16),
) )
# Assert # Assert
@ -76,10 +87,10 @@ def test_vmtest(test_name: str, pre_condition: dict, action: dict, post_conditio
for address, details in post_condition.items(): for address, details in post_condition.items():
account = world_state[address] account = world_state[address]
assert account.nonce == int(details['nonce'], 16) assert account.nonce == int(details["nonce"], 16)
assert account.code.bytecode == details['code'][2:] assert account.code.bytecode == details["code"][2:]
for index, value in details['storage'].items(): for index, value in details["storage"].items():
expected = int(value, 16) expected = int(value, 16)
actual = get_concrete_int(account.storage[int(index, 16)]) actual = get_concrete_int(account.storage[int(index, 16)])
assert actual == expected assert actual == expected

@ -6,11 +6,10 @@ from tests import BaseTestCase
class MachineStackTest(BaseTestCase): class MachineStackTest(BaseTestCase):
@staticmethod @staticmethod
def test_mstack_constructor(): def test_mstack_constructor():
mstack = MachineStack([1, 2]) mstack = MachineStack([1, 2])
assert(mstack == [1, 2]) assert mstack == [1, 2]
@staticmethod @staticmethod
def test_mstack_append_single_element(): def test_mstack_append_single_element():
@ -18,7 +17,7 @@ class MachineStackTest(BaseTestCase):
mstack.append(0) mstack.append(0)
assert(mstack == [0]) assert mstack == [0]
@staticmethod @staticmethod
def test_mstack_append_multiple_elements(): def test_mstack_append_multiple_elements():
@ -53,4 +52,3 @@ class MachineStackTest(BaseTestCase):
with pytest.raises(NotImplementedError): with pytest.raises(NotImplementedError):
mstack += mstack mstack += mstack

@ -2,14 +2,12 @@ import pytest
from mythril.laser.ethereum.state import MachineState from mythril.laser.ethereum.state import MachineState
from mythril.laser.ethereum.evm_exceptions import StackUnderflowException from mythril.laser.ethereum.evm_exceptions import StackUnderflowException
memory_extension_test_data = [ memory_extension_test_data = [(0, 0, 10), (0, 30, 10), (100, 22, 8)]
(0, 0, 10),
(0, 30, 10),
(100, 22, 8)
]
@pytest.mark.parametrize("initial_size,start,extension_size", memory_extension_test_data) @pytest.mark.parametrize(
"initial_size,start,extension_size", memory_extension_test_data
)
def test_memory_extension(initial_size, start, extension_size): def test_memory_extension(initial_size, start, extension_size):
# Arrange # Arrange
machine_state = MachineState(0) machine_state = MachineState(0)
@ -23,12 +21,7 @@ def test_memory_extension(initial_size, start, extension_size):
assert machine_state.memory_size == max(initial_size, start + extension_size) assert machine_state.memory_size == max(initial_size, start + extension_size)
stack_pop_too_many_test_data = [ stack_pop_too_many_test_data = [(0, 1), (0, 2), (5, 1), (5, 10)]
(0, 1),
(0, 2),
(5, 1),
(5, 10)
]
@pytest.mark.parametrize("initial_size,overflow", stack_pop_too_many_test_data) @pytest.mark.parametrize("initial_size,overflow", stack_pop_too_many_test_data)
@ -44,7 +37,7 @@ def test_stack_pop_too_many(initial_size, overflow):
stack_pop_test_data = [ stack_pop_test_data = [
([1, 2, 3], 2, [3, 2]), ([1, 2, 3], 2, [3, 2]),
([1, 3, 4, 7, 7, 1, 2], 5, [2, 1, 7, 7, 4]) ([1, 3, 4, 7, 7, 1, 2], 5, [2, 1, 7, 7, 4]),
] ]
@ -79,7 +72,7 @@ def test_stack_multiple_pop_():
def test_stack_single_pop(): def test_stack_single_pop():
# Arrange # Arrange
machine_state = MachineState(0) machine_state = MachineState(0)
machine_state.stack = [1,2,3] machine_state.stack = [1, 2, 3]
# Act # Act
result = machine_state.pop() result = machine_state.pop()
@ -88,22 +81,18 @@ def test_stack_single_pop():
assert isinstance(result, int) assert isinstance(result, int)
memory_write_test_data = [ memory_write_test_data = [(5, 10, [1, 2, 3]), (0, 0, [3, 4]), (20, 1, [2, 4, 10])]
(5, 10, [1, 2, 3]),
(0, 0, [3, 4]),
(20, 1, [2, 4, 10])
]
@pytest.mark.parametrize("initial_size, memory_offset, data", memory_write_test_data) @pytest.mark.parametrize("initial_size, memory_offset, data", memory_write_test_data)
def test_memory_write(initial_size, memory_offset, data): def test_memory_write(initial_size, memory_offset, data):
# Arrange # Arrange
machine_state = MachineState(0) machine_state = MachineState(0)
machine_state.memory = [0]*initial_size machine_state.memory = [0] * initial_size
# Act # Act
machine_state.memory_write(memory_offset, data) machine_state.memory_write(memory_offset, data)
# Assert # Assert
assert len(machine_state.memory) == max(initial_size, memory_offset+len(data)) assert len(machine_state.memory) == max(initial_size, memory_offset + len(data))
assert machine_state.memory[memory_offset:memory_offset+len(data)] == data assert machine_state.memory[memory_offset : memory_offset + len(data)] == data

@ -2,11 +2,7 @@ import pytest
from mythril.laser.ethereum.state import Storage from mythril.laser.ethereum.state import Storage
from z3 import ExprRef from z3 import ExprRef
storage_uninitialized_test_data = [ storage_uninitialized_test_data = [({}, 1), ({1: 5}, 2), ({1: 5, 3: 10}, 2)]
({}, 1),
({1: 5}, 2),
({1: 5, 3: 10}, 2)
]
@pytest.mark.parametrize("initial_storage,key", storage_uninitialized_test_data) @pytest.mark.parametrize("initial_storage,key", storage_uninitialized_test_data)

@ -8,19 +8,20 @@ def test_intercontract_call():
# Arrange # Arrange
cfg.gbl_next_uid = 0 cfg.gbl_next_uid = 0
caller_code = Disassembly("6080604052348015600f57600080fd5b5073deadbeefdeadbeefdeadbeefdeadbeefdeadbeef73ffffffffffffffffffffffffffffffffffffffff166389627e13336040518263ffffffff167c0100000000000000000000000000000000000000000000000000000000028152600401808273ffffffffffffffffffffffffffffffffffffffff1673ffffffffffffffffffffffffffffffffffffffff168152602001915050602060405180830381600087803b15801560be57600080fd5b505af115801560d1573d6000803e3d6000fd5b505050506040513d602081101560e657600080fd5b8101908080519060200190929190505050500000a165627a7a72305820fdb1e90f0d9775c94820e516970e0d41380a94624fa963c556145e8fb645d4c90029") caller_code = Disassembly(
"6080604052348015600f57600080fd5b5073deadbeefdeadbeefdeadbeefdeadbeefdeadbeef73ffffffffffffffffffffffffffffffffffffffff166389627e13336040518263ffffffff167c0100000000000000000000000000000000000000000000000000000000028152600401808273ffffffffffffffffffffffffffffffffffffffff1673ffffffffffffffffffffffffffffffffffffffff168152602001915050602060405180830381600087803b15801560be57600080fd5b505af115801560d1573d6000803e3d6000fd5b505050506040513d602081101560e657600080fd5b8101908080519060200190929190505050500000a165627a7a72305820fdb1e90f0d9775c94820e516970e0d41380a94624fa963c556145e8fb645d4c90029"
)
caller_address = "0xaffeaffeaffeaffeaffeaffeaffeaffeaffeaffe" caller_address = "0xaffeaffeaffeaffeaffeaffeaffeaffeaffeaffe"
callee_code = Disassembly("608060405260043610603f576000357c0100000000000000000000000000000000000000000000000000000000900463ffffffff16806389627e13146044575b600080fd5b348015604f57600080fd5b506082600480360381019080803573ffffffffffffffffffffffffffffffffffffffff1690602001909291905050506084565b005b8073ffffffffffffffffffffffffffffffffffffffff166108fc3073ffffffffffffffffffffffffffffffffffffffff16319081150290604051600060405180830381858888f1935050505015801560e0573d6000803e3d6000fd5b50505600a165627a7a72305820a6b1335d6f994632bc9a7092d0eaa425de3dea05e015af8a94ad70b3969e117a0029") callee_code = Disassembly(
"608060405260043610603f576000357c0100000000000000000000000000000000000000000000000000000000900463ffffffff16806389627e13146044575b600080fd5b348015604f57600080fd5b506082600480360381019080803573ffffffffffffffffffffffffffffffffffffffff1690602001909291905050506084565b005b8073ffffffffffffffffffffffffffffffffffffffff166108fc3073ffffffffffffffffffffffffffffffffffffffff16319081150290604051600060405180830381858888f1935050505015801560e0573d6000803e3d6000fd5b50505600a165627a7a72305820a6b1335d6f994632bc9a7092d0eaa425de3dea05e015af8a94ad70b3969e117a0029"
)
callee_address = "0xdeadbeefdeadbeefdeadbeefdeadbeefdeadbeef" callee_address = "0xdeadbeefdeadbeefdeadbeefdeadbeefdeadbeef"
caller_account = Account(caller_address, caller_code, contract_name="Caller") caller_account = Account(caller_address, caller_code, contract_name="Caller")
callee_account = Account(callee_address, callee_code, contract_name="Callee") callee_account = Account(callee_address, callee_code, contract_name="Callee")
accounts = { accounts = {caller_address: caller_account, callee_address: callee_account}
caller_address: caller_account,
callee_address: callee_account
}
laser = svm.LaserEVM(accounts) laser = svm.LaserEVM(accounts)
@ -30,11 +31,11 @@ def test_intercontract_call():
# Assert # Assert
# Initial node starts in contract caller # Initial node starts in contract caller
assert len(laser.nodes.keys()) > 0 assert len(laser.nodes.keys()) > 0
assert laser.nodes[0].contract_name == 'Caller' assert laser.nodes[0].contract_name == "Caller"
# At one point we call into contract callee # At one point we call into contract callee
for node in laser.nodes.values(): for node in laser.nodes.values():
if node.contract_name == 'Callee': if node.contract_name == "Callee":
assert len(node.states[0].transaction_stack) > 1 assert len(node.states[0].transaction_stack) > 1
return return

@ -10,7 +10,7 @@ from mythril.analysis.symbolic import SymExecWrapper
def test_create(): def test_create():
contract = SolidityContract(str(tests.TESTDATA_INPUTS_CONTRACTS / 'calls.sol')) contract = SolidityContract(str(tests.TESTDATA_INPUTS_CONTRACTS / "calls.sol"))
laser_evm = svm.LaserEVM({}) laser_evm = svm.LaserEVM({})
@ -27,12 +27,15 @@ def test_create():
found_instruction = created_account_code.instruction_list[i] found_instruction = created_account_code.instruction_list[i]
actual_instruction = actual_code.instruction_list[i] actual_instruction = actual_code.instruction_list[i]
assert found_instruction['opcode'] == actual_instruction['opcode'] assert found_instruction["opcode"] == actual_instruction["opcode"]
def test_sym_exec(): def test_sym_exec():
contract = SolidityContract(str(tests.TESTDATA_INPUTS_CONTRACTS / 'calls.sol')) contract = SolidityContract(str(tests.TESTDATA_INPUTS_CONTRACTS / "calls.sol"))
sym = SymExecWrapper(contract, address=(util.get_indexed_address(0)), strategy="dfs") sym = SymExecWrapper(
contract, address=(util.get_indexed_address(0)), strategy="dfs"
)
issues = fire_lasers(sym) issues = fire_lasers(sym)
assert len(issues) != 0 assert len(issues) != 0

@ -1,5 +1,11 @@
from mythril.laser.ethereum.transaction.symbolic import execute_message_call, execute_contract_creation from mythril.laser.ethereum.transaction.symbolic import (
from mythril.laser.ethereum.transaction import MessageCallTransaction, ContractCreationTransaction execute_message_call,
execute_contract_creation,
)
from mythril.laser.ethereum.transaction import (
MessageCallTransaction,
ContractCreationTransaction,
)
from mythril.laser.ethereum.svm import LaserEVM from mythril.laser.ethereum.svm import LaserEVM
from mythril.laser.ethereum.state import WorldState, Account from mythril.laser.ethereum.state import WorldState, Account
import unittest.mock as mock import unittest.mock as mock
@ -14,7 +20,9 @@ def _is_contract_creation(_, transaction):
assert isinstance(transaction, ContractCreationTransaction) assert isinstance(transaction, ContractCreationTransaction)
@mock.patch("mythril.laser.ethereum.transaction.symbolic._setup_global_state_for_execution") @mock.patch(
"mythril.laser.ethereum.transaction.symbolic._setup_global_state_for_execution"
)
def test_execute_message_call(mocked_setup: MagicMock): def test_execute_message_call(mocked_setup: MagicMock):
# Arrange # Arrange
laser_evm = LaserEVM({}) laser_evm = LaserEVM({})
@ -39,7 +47,9 @@ def test_execute_message_call(mocked_setup: MagicMock):
assert len(laser_evm.open_states) == 0 assert len(laser_evm.open_states) == 0
@mock.patch("mythril.laser.ethereum.transaction.symbolic._setup_global_state_for_execution") @mock.patch(
"mythril.laser.ethereum.transaction.symbolic._setup_global_state_for_execution"
)
def test_execute_contract_creation(mocked_setup: MagicMock): def test_execute_contract_creation(mocked_setup: MagicMock):
# Arrange # Arrange
laser_evm = LaserEVM({}) laser_evm = LaserEVM({})
@ -57,4 +67,3 @@ def test_execute_contract_creation(mocked_setup: MagicMock):
# laser_evm.exec.assert_called_once() # laser_evm.exec.assert_called_once()
assert laser_evm.exec.call_count == 1 assert laser_evm.exec.call_count == 1
assert len(laser_evm.open_states) == 0 assert len(laser_evm.open_states) == 0

@ -14,7 +14,10 @@ ECRECOVER_TEST = [(0, False) for _ in range(9)]
IDENTITY_TEST = [(0, False) for _ in range(4)] IDENTITY_TEST = [(0, False) for _ in range(4)]
SHA256_TEST[0] = (5555555555555555, True) #These are Random numbers to check whether the 'if condition' is entered or not(True means entered) SHA256_TEST[0] = (
5555555555555555,
True,
) # These are Random numbers to check whether the 'if condition' is entered or not(True means entered)
SHA256_TEST[1] = (323232325445454546, True) SHA256_TEST[1] = (323232325445454546, True)
SHA256_TEST[2] = (34756834765834658, False) SHA256_TEST[2] = (34756834765834658, False)
SHA256_TEST[3] = (8756476956956795876987, True) SHA256_TEST[3] = (8756476956956795876987, True)
@ -45,12 +48,13 @@ IDENTITY_TEST[1] = (476934798798347, False)
IDENTITY_TEST[2] = (7346948379483769, True) IDENTITY_TEST[2] = (7346948379483769, True)
IDENTITY_TEST[3] = (83269476937987, False) IDENTITY_TEST[3] = (83269476937987, False)
def _all_info(laser): def _all_info(laser):
accounts = {} accounts = {}
for address, _account in laser.world_state.accounts.items(): for address, _account in laser.world_state.accounts.items():
account = _account.as_dict account = _account.as_dict
account["code"] = account["code"].instruction_list account["code"] = account["code"].instruction_list
account['balance'] = str(account['balance']) account["balance"] = str(account["balance"])
accounts[address] = account accounts[address] = account
nodes = {} nodes = {}
@ -62,56 +66,58 @@ def _all_info(laser):
elif isinstance(state, GlobalState): elif isinstance(state, GlobalState):
environment = state.environment.as_dict environment = state.environment.as_dict
environment["active_account"] = environment["active_account"].address environment["active_account"] = environment["active_account"].address
states.append({ states.append(
'accounts': state.accounts.keys(), {
'environment': environment, "accounts": state.accounts.keys(),
'mstate': state.mstate.as_dict "environment": environment,
}) "mstate": state.mstate.as_dict,
}
)
nodes[uid] = { nodes[uid] = {
'uid': node.uid, "uid": node.uid,
'contract_name': node.contract_name, "contract_name": node.contract_name,
'start_addr': node.start_addr, "start_addr": node.start_addr,
'states': states, "states": states,
'constraints': node.constraints, "constraints": node.constraints,
'function_name': node.function_name, "function_name": node.function_name,
'flags': str(node.flags) "flags": str(node.flags),
} }
edges = [edge.as_dict for edge in laser.edges] edges = [edge.as_dict for edge in laser.edges]
return { return {
'accounts': accounts, "accounts": accounts,
'nodes': nodes, "nodes": nodes,
'edges': edges, "edges": edges,
'total_states': laser.total_states, "total_states": laser.total_states,
'max_depth': laser.max_depth "max_depth": laser.max_depth,
} }
def _test_natives(laser_info, test_list, test_name): def _test_natives(laser_info, test_list, test_name):
success = 0 success = 0
for i, j in test_list: for i, j in test_list:
if (str(i) in laser_info) == j: if (str(i) in laser_info) == j:
success += 1 success += 1
else: else:
print("Failed: "+str(i)+" "+str(j)) print("Failed: " + str(i) + " " + str(j))
assert(success == len(test_list)) assert success == len(test_list)
class NativeTests(BaseTestCase): class NativeTests(BaseTestCase):
@staticmethod @staticmethod
def runTest(): def runTest():
disassembly = SolidityContract('./tests/native_tests.sol').disassembly disassembly = SolidityContract("./tests/native_tests.sol").disassembly
account = Account("0x0000000000000000000000000000000000000000", disassembly) account = Account("0x0000000000000000000000000000000000000000", disassembly)
accounts = {account.address: account} accounts = {account.address: account}
laser = svm.LaserEVM(accounts, max_depth = 100) laser = svm.LaserEVM(accounts, max_depth=100)
laser.sym_exec(account.address) laser.sym_exec(account.address)
laser_info = str(_all_info(laser)) laser_info = str(_all_info(laser))
print('\n') print("\n")
_test_natives(laser_info, SHA256_TEST, 'SHA256')
_test_natives(laser_info, RIPEMD160_TEST, 'RIPEMD160')
_test_natives(laser_info, ECRECOVER_TEST, 'ECRECOVER')
_test_natives(laser_info, IDENTITY_TEST, 'IDENTITY')
_test_natives(laser_info, SHA256_TEST, "SHA256")
_test_natives(laser_info, RIPEMD160_TEST, "RIPEMD160")
_test_natives(laser_info, ECRECOVER_TEST, "ECRECOVER")
_test_natives(laser_info, IDENTITY_TEST, "IDENTITY")

@ -24,7 +24,12 @@ def _fix_debug_data(json_str):
def _generate_report(input_file): def _generate_report(input_file):
contract = ETHContract(input_file.read_text(), enable_online_lookup=False) contract = ETHContract(input_file.read_text(), enable_online_lookup=False)
sym = SymExecWrapper(contract, address=(util.get_indexed_address(0)), strategy="dfs", execution_timeout=30) sym = SymExecWrapper(
contract,
address=(util.get_indexed_address(0)),
strategy="dfs",
execution_timeout=30,
)
issues = fire_lasers(sym) issues = fire_lasers(sym)
report = Report() report = Report()
@ -34,7 +39,7 @@ def _generate_report(input_file):
return report, input_file return report, input_file
@pytest.fixture(scope='module') @pytest.fixture(scope="module")
def reports(): def reports():
""" Fixture that analyses all reports""" """ Fixture that analyses all reports"""
pool = Pool(cpu_count()) pool = Pool(cpu_count())
@ -48,14 +53,25 @@ def _assert_empty(changed_files, postfix):
""" Asserts there are no changed files and otherwise builds error message""" """ Asserts there are no changed files and otherwise builds error message"""
message = "" message = ""
for input_file in changed_files: for input_file in changed_files:
output_expected = (TESTDATA_OUTPUTS_EXPECTED / (input_file.name + postfix)).read_text().splitlines(1) output_expected = (
output_current = (TESTDATA_OUTPUTS_CURRENT / (input_file.name + postfix)).read_text().splitlines(1) (TESTDATA_OUTPUTS_EXPECTED / (input_file.name + postfix))
.read_text()
difference = ''.join(difflib.unified_diff(output_expected, output_current)) .splitlines(1)
message += "Found differing file for input: {} \n Difference: \n {} \n".format(str(input_file), str(difference)) )
output_current = (
(TESTDATA_OUTPUTS_CURRENT / (input_file.name + postfix))
.read_text()
.splitlines(1)
)
difference = "".join(difflib.unified_diff(output_expected, output_current))
message += "Found differing file for input: {} \n Difference: \n {} \n".format(
str(input_file), str(difference)
)
assert message == "", message assert message == "", message
def _assert_empty_json(changed_files): def _assert_empty_json(changed_files):
""" Asserts there are no changed files and otherwise builds error message""" """ Asserts there are no changed files and otherwise builds error message"""
postfix = ".json" postfix = ".json"
@ -71,15 +87,20 @@ def _assert_empty_json(changed_files):
return obj return obj
for input_file in changed_files: for input_file in changed_files:
output_expected = json.loads((TESTDATA_OUTPUTS_EXPECTED / (input_file.name + postfix)).read_text()) output_expected = json.loads(
output_current = json.loads((TESTDATA_OUTPUTS_CURRENT / (input_file.name + postfix)).read_text()) (TESTDATA_OUTPUTS_EXPECTED / (input_file.name + postfix)).read_text()
)
if not ordered(output_expected.items()) == ordered(output_current.items()): output_current = json.loads(
(TESTDATA_OUTPUTS_CURRENT / (input_file.name + postfix)).read_text()
)
if not ordered(output_expected.items()) == ordered(output_current.items()):
expected.append(output_expected) expected.append(output_expected)
actual.append(output_current) actual.append(output_current)
assert expected == actual assert expected == actual
def _get_changed_files(postfix, report_builder, reports): def _get_changed_files(postfix, report_builder, reports):
""" """
Returns a generator for all unexpected changes in generated reports Returns a generator for all unexpected changes in generated reports
@ -99,6 +120,7 @@ def _get_changed_files(postfix, report_builder, reports):
def _get_changed_files_json(report_builder, reports): def _get_changed_files_json(report_builder, reports):
postfix = ".json" postfix = ".json"
def ordered(obj): def ordered(obj):
if isinstance(obj, dict): if isinstance(obj, dict):
return sorted((k, ordered(v)) for k, v in obj.items()) return sorted((k, ordered(v)) for k, v in obj.items())
@ -112,17 +134,33 @@ def _get_changed_files_json(report_builder, reports):
output_current = TESTDATA_OUTPUTS_CURRENT / (input_file.name + postfix) output_current = TESTDATA_OUTPUTS_CURRENT / (input_file.name + postfix)
output_current.write_text(report_builder(report)) output_current.write_text(report_builder(report))
if not ordered(json.loads(output_expected.read_text())) == ordered(json.loads(output_current.read_text())): if not ordered(json.loads(output_expected.read_text())) == ordered(
json.loads(output_current.read_text())
):
yield input_file yield input_file
def test_json_report(reports): def test_json_report(reports):
_assert_empty_json(_get_changed_files_json(lambda report: _fix_path(_fix_debug_data(report.as_json())).strip(), reports)) _assert_empty_json(
_get_changed_files_json(
lambda report: _fix_path(_fix_debug_data(report.as_json())).strip(), reports
)
)
def test_markdown_report(reports): def test_markdown_report(reports):
_assert_empty(_get_changed_files('.markdown', lambda report: _fix_path(report.as_markdown()), reports), '.markdown') _assert_empty(
_get_changed_files(
".markdown", lambda report: _fix_path(report.as_markdown()), reports
),
".markdown",
)
def test_text_report(reports): def test_text_report(reports):
_assert_empty(_get_changed_files('.text', lambda report: _fix_path(report.as_text()), reports), '.text') _assert_empty(
_get_changed_files(
".text", lambda report: _fix_path(report.as_text()), reports
),
".text",
)

@ -2,6 +2,7 @@ from unittest import TestCase
from mythril.ethereum.interface.rpc.client import EthJsonRpc from mythril.ethereum.interface.rpc.client import EthJsonRpc
class RpcTest(TestCase): class RpcTest(TestCase):
client = None client = None
@ -18,26 +19,49 @@ class RpcTest(TestCase):
def test_eth_blockNumber(self): def test_eth_blockNumber(self):
block_number = self.client.eth_blockNumber() block_number = self.client.eth_blockNumber()
self.assertGreater(block_number, 0, "we have made sure the blockNumber is > 0 for testing") self.assertGreater(
block_number, 0, "we have made sure the blockNumber is > 0 for testing"
)
def test_eth_getBalance(self): def test_eth_getBalance(self):
balance = self.client.eth_getBalance(address="0x0000000000000000000000000000000000000000") balance = self.client.eth_getBalance(
self.assertGreater(balance, 10000000, "specified address should have a lot of balance") address="0x0000000000000000000000000000000000000000"
)
self.assertGreater(
balance, 10000000, "specified address should have a lot of balance"
)
def test_eth_getStorageAt(self): def test_eth_getStorageAt(self):
storage = self.client.eth_getStorageAt(address="0x0000000000000000000000000000000000000000") storage = self.client.eth_getStorageAt(
self.assertEqual(storage, '0x0000000000000000000000000000000000000000000000000000000000000000') address="0x0000000000000000000000000000000000000000"
)
self.assertEqual(
storage,
"0x0000000000000000000000000000000000000000000000000000000000000000",
)
def test_eth_getBlockByNumber(self): def test_eth_getBlockByNumber(self):
block = self.client.eth_getBlockByNumber(0) block = self.client.eth_getBlockByNumber(0)
self.assertEqual(block["extraData"], "0x11bbe8db4e347b4e8c937c1c8370e4b5ed33adb3db69cbdb7a38e1e50b1b82fa", "the data of the first block should be right") self.assertEqual(
block["extraData"],
"0x11bbe8db4e347b4e8c937c1c8370e4b5ed33adb3db69cbdb7a38e1e50b1b82fa",
"the data of the first block should be right",
)
def test_eth_getCode(self): def test_eth_getCode(self):
# TODO: can't find a proper address for getting code # TODO: can't find a proper address for getting code
code = self.client.eth_getCode(address="0x0000000000000000000000000000000000000001") code = self.client.eth_getCode(
address="0x0000000000000000000000000000000000000001"
)
self.assertEqual(code, "0x") self.assertEqual(code, "0x")
def test_eth_getTransactionReceipt(self): def test_eth_getTransactionReceipt(self):
transaction = self.client.eth_getTransactionReceipt(tx_hash="0xe363505adc6b2996111f8bd774f8653a61d244cc6567b5372c2e781c6c63b737") transaction = self.client.eth_getTransactionReceipt(
self.assertEqual(transaction["from"], "0x22f2dcff5ad78c3eb6850b5cb951127b659522e6") tx_hash="0xe363505adc6b2996111f8bd774f8653a61d244cc6567b5372c2e781c6c63b737"
self.assertEqual(transaction["to"], "0x0000000000000000000000000000000000000000") )
self.assertEqual(
transaction["from"], "0x22f2dcff5ad78c3eb6850b5cb951127b659522e6"
)
self.assertEqual(
transaction["to"], "0x0000000000000000000000000000000000000000"
)

@ -5,8 +5,8 @@ from tests import BaseTestCase
TEST_FILES = Path(__file__).parent / "testdata/input_contracts" TEST_FILES = Path(__file__).parent / "testdata/input_contracts"
class SolidityContractTest(BaseTestCase):
class SolidityContractTest(BaseTestCase):
def test_get_source_info_without_name_gets_latest_contract_info(self): def test_get_source_info_without_name_gets_latest_contract_info(self):
input_file = TEST_FILES / "multi_contracts.sol" input_file = TEST_FILES / "multi_contracts.sol"
contract = SolidityContract(str(input_file)) contract = SolidityContract(str(input_file))
@ -36,4 +36,3 @@ class SolidityContractTest(BaseTestCase):
self.assertEqual(code_info.filename, str(input_file)) self.assertEqual(code_info.filename, str(input_file))
self.assertEqual(code_info.lineno, 6) self.assertEqual(code_info.lineno, 6)
self.assertEqual(code_info.code, "assert(var1>0)") self.assertEqual(code_info.code, "assert(var1>0)")

@ -21,7 +21,7 @@ def _all_info(laser):
for address, _account in laser.world_state.accounts.items(): for address, _account in laser.world_state.accounts.items():
account = _account.as_dict account = _account.as_dict
account["code"] = account["code"].instruction_list account["code"] = account["code"].instruction_list
account['balance'] = str(account['balance']) account["balance"] = str(account["balance"])
accounts[address] = account accounts[address] = account
nodes = {} nodes = {}
@ -33,35 +33,36 @@ def _all_info(laser):
elif isinstance(state, GlobalState): elif isinstance(state, GlobalState):
environment = state.environment.as_dict environment = state.environment.as_dict
environment["active_account"] = environment["active_account"].address environment["active_account"] = environment["active_account"].address
states.append({ states.append(
'accounts': state.accounts.keys(), {
'environment': environment, "accounts": state.accounts.keys(),
'mstate': state.mstate.as_dict "environment": environment,
}) "mstate": state.mstate.as_dict,
}
)
nodes[uid] = { nodes[uid] = {
'uid': node.uid, "uid": node.uid,
'contract_name': node.contract_name, "contract_name": node.contract_name,
'start_addr': node.start_addr, "start_addr": node.start_addr,
'states': states, "states": states,
'constraints': node.constraints, "constraints": node.constraints,
'function_name': node.function_name, "function_name": node.function_name,
'flags': str(node.flags) "flags": str(node.flags),
} }
edges = [edge.as_dict for edge in laser.edges] edges = [edge.as_dict for edge in laser.edges]
return { return {
'accounts': accounts, "accounts": accounts,
'nodes': nodes, "nodes": nodes,
'edges': edges, "edges": edges,
'total_states': laser.total_states, "total_states": laser.total_states,
'max_depth': laser.max_depth "max_depth": laser.max_depth,
} }
class SVMTestCase(BaseTestCase): class SVMTestCase(BaseTestCase):
def setUp(self): def setUp(self):
super(SVMTestCase, self).setUp() super(SVMTestCase, self).setUp()
svm.gbl_next_uid = 0 svm.gbl_next_uid = 0
@ -70,8 +71,12 @@ class SVMTestCase(BaseTestCase):
for input_file in TESTDATA_INPUTS_CONTRACTS.iterdir(): for input_file in TESTDATA_INPUTS_CONTRACTS.iterdir():
if input_file.name == "weak_random.sol": if input_file.name == "weak_random.sol":
continue continue
output_expected = TESTDATA_OUTPUTS_EXPECTED_LASER_RESULT / (input_file.name + ".json") output_expected = TESTDATA_OUTPUTS_EXPECTED_LASER_RESULT / (
output_current = TESTDATA_OUTPUTS_CURRENT_LASER_RESULT / (input_file.name + ".json") input_file.name + ".json"
)
output_current = TESTDATA_OUTPUTS_CURRENT_LASER_RESULT / (
input_file.name + ".json"
)
disassembly = SolidityContract(str(input_file)).disassembly disassembly = SolidityContract(str(input_file)).disassembly
account = Account("0x0000000000000000000000000000000000000000", disassembly) account = Account("0x0000000000000000000000000000000000000000", disassembly)
@ -81,7 +86,9 @@ class SVMTestCase(BaseTestCase):
laser.sym_exec(account.address) laser.sym_exec(account.address)
laser_info = _all_info(laser) laser_info = _all_info(laser)
output_current.write_text(json.dumps(laser_info, cls=LaserEncoder, indent=4)) output_current.write_text(
json.dumps(laser_info, cls=LaserEncoder, indent=4)
)
if not (output_expected.read_text() == output_expected.read_text()): if not (output_expected.read_text() == output_expected.read_text()):
self.found_changed_files(input_file, output_expected, output_current) self.found_changed_files(input_file, output_expected, output_current)

@ -1,12 +1,13 @@
from mythril.laser.ethereum.taint_analysis import * from mythril.laser.ethereum.taint_analysis import *
def test_mutate_not_tainted(): def test_mutate_not_tainted():
# Arrange # Arrange
record = TaintRecord() record = TaintRecord()
record.stack = [True, False, False] record.stack = [True, False, False]
# Act # Act
TaintRunner.mutate_stack(record, (2,1)) TaintRunner.mutate_stack(record, (2, 1))
# Assert # Assert
assert record.stack_tainted(0) assert record.stack_tainted(0)

@ -7,7 +7,7 @@ def test_result_state():
taint_result = TaintResult() taint_result = TaintResult()
record = TaintRecord() record = TaintRecord()
state = GlobalState(2, None, None) state = GlobalState(2, None, None)
state.mstate.stack = [1,2,3] state.mstate.stack = [1, 2, 3]
record.add_state(state) record.add_state(state)
record.stack = [False, False, False] record.stack = [False, False, False]
# act # act
@ -24,8 +24,7 @@ def test_result_no_state():
taint_result = TaintResult() taint_result = TaintResult()
record = TaintRecord() record = TaintRecord()
state = GlobalState(2, None, None) state = GlobalState(2, None, None)
state.mstate.stack = [1,2,3] state.mstate.stack = [1, 2, 3]
# act # act
taint_result.add_records([record]) taint_result.add_records([record])

@ -13,7 +13,7 @@ def test_execute_state(mocker):
state = GlobalState(None, None, None) state = GlobalState(None, None, None)
state.mstate.stack = [1, 2, 3] state.mstate.stack = [1, 2, 3]
mocker.patch.object(state, 'get_current_instruction') mocker.patch.object(state, "get_current_instruction")
state.get_current_instruction.return_value = {"opcode": "ADD"} state.get_current_instruction.return_value = {"opcode": "ADD"}
# Act # Act
@ -31,12 +31,12 @@ def test_execute_node(mocker):
state_1 = GlobalState(None, None, None) state_1 = GlobalState(None, None, None)
state_1.mstate.stack = [1, 2, 3, 1] state_1.mstate.stack = [1, 2, 3, 1]
state_1.mstate.pc = 1 state_1.mstate.pc = 1
mocker.patch.object(state_1, 'get_current_instruction') mocker.patch.object(state_1, "get_current_instruction")
state_1.get_current_instruction.return_value = {"opcode": "SWAP1"} state_1.get_current_instruction.return_value = {"opcode": "SWAP1"}
state_2 = GlobalState(None, 1, None) state_2 = GlobalState(None, 1, None)
state_2.mstate.stack = [1, 2, 4, 1] state_2.mstate.stack = [1, 2, 4, 1]
mocker.patch.object(state_2, 'get_current_instruction') mocker.patch.object(state_2, "get_current_instruction")
state_2.get_current_instruction.return_value = {"opcode": "ADD"} state_2.get_current_instruction.return_value = {"opcode": "ADD"}
node = Node("Test contract") node = Node("Test contract")
@ -56,16 +56,16 @@ def test_execute_node(mocker):
def test_execute(mocker): def test_execute(mocker):
active_account = Account('0x00') active_account = Account("0x00")
environment = Environment(active_account, None, None, None, None, None) environment = Environment(active_account, None, None, None, None, None)
state_1 = GlobalState(None, environment, None, MachineState(gas=10000000)) state_1 = GlobalState(None, environment, None, MachineState(gas=10000000))
state_1.mstate.stack = [1, 2] state_1.mstate.stack = [1, 2]
mocker.patch.object(state_1, 'get_current_instruction') mocker.patch.object(state_1, "get_current_instruction")
state_1.get_current_instruction.return_value = {"opcode": "PUSH"} state_1.get_current_instruction.return_value = {"opcode": "PUSH"}
state_2 = GlobalState(None, environment, None, MachineState(gas=10000000)) state_2 = GlobalState(None, environment, None, MachineState(gas=10000000))
state_2.mstate.stack = [1, 2, 3] state_2.mstate.stack = [1, 2, 3]
mocker.patch.object(state_2, 'get_current_instruction') mocker.patch.object(state_2, "get_current_instruction")
state_2.get_current_instruction.return_value = {"opcode": "ADD"} state_2.get_current_instruction.return_value = {"opcode": "ADD"}
node_1 = Node("Test contract") node_1 = Node("Test contract")
@ -73,7 +73,7 @@ def test_execute(mocker):
state_3 = GlobalState(None, environment, None, MachineState(gas=10000000)) state_3 = GlobalState(None, environment, None, MachineState(gas=10000000))
state_3.mstate.stack = [1, 2] state_3.mstate.stack = [1, 2]
mocker.patch.object(state_3, 'get_current_instruction') mocker.patch.object(state_3, "get_current_instruction")
state_3.get_current_instruction.return_value = {"opcode": "ADD"} state_3.get_current_instruction.return_value = {"opcode": "ADD"}
node_2 = Node("Test contract") node_2 = Node("Test contract")

@ -4,22 +4,23 @@ import json
import sys import sys
def test_version_opt(capsys): def test_version_opt(capsys):
# Check that "myth --version" returns a string with the word # Check that "myth --version" returns a string with the word
# "version" in it # "version" in it
sys.argv = ['mythril', '--version'] sys.argv = ["mythril", "--version"]
with pytest.raises(SystemExit) as pytest_wrapped_e: with pytest.raises(SystemExit) as pytest_wrapped_e:
main() main()
assert pytest_wrapped_e.type == SystemExit assert pytest_wrapped_e.type == SystemExit
captured = capsys.readouterr() captured = capsys.readouterr()
assert captured.out.find(' version ') >= 1 assert captured.out.find(" version ") >= 1
# Check that "myth --version -o json" returns a JSON object # Check that "myth --version -o json" returns a JSON object
sys.argv = ['mythril', '--version', '-o', 'json'] sys.argv = ["mythril", "--version", "-o", "json"]
with pytest.raises(SystemExit) as pytest_wrapped_e: with pytest.raises(SystemExit) as pytest_wrapped_e:
main() main()
assert pytest_wrapped_e.type == SystemExit assert pytest_wrapped_e.type == SystemExit
captured = capsys.readouterr() captured = capsys.readouterr()
d = json.loads(captured.out) d = json.loads(captured.out)
assert isinstance(d, dict) assert isinstance(d, dict)
assert d['version_str'] assert d["version_str"]

@ -4,12 +4,12 @@ from mythril.ether.soliditycontract import SolidityContract
# Recompiles all the to be tested contracts # Recompiles all the to be tested contracts
root = Path(__file__).parent root = Path(__file__).parent
input = root / 'input_contracts' input = root / "input_contracts"
output = root / 'inputs' output = root / "inputs"
for contract in input.iterdir(): for contract in input.iterdir():
sol = SolidityContract(str(contract)) sol = SolidityContract(str(contract))
code = sol.code code = sol.code
output_file = (output / "{}.o".format(contract.name)) output_file = output / "{}.o".format(contract.name)
output_file.write_text(code) output_file.write_text(code)

Loading…
Cancel
Save