Adapt tests from byline: Lint; Use assert from chai; Local paths for test files

pull/5/head
eliot-akira 3 years ago
parent 575f46c6ce
commit 225fe0fa3b
  1. 14
      package-lock.json
  2. 207
      test/byline.test.js
  3. 214
      test/byline/tests.js

14
package-lock.json generated

@ -11,7 +11,6 @@
"dependencies": {
"@seald-io/binary-search-tree": "^1.0.2",
"async": "0.2.10",
"byline": "^5.0.0",
"localforage": "^1.9.0"
},
"devDependencies": {
@ -787,14 +786,6 @@
"integrity": "sha512-MQcXEUbCKtEo7bhqEs6560Hyd4XaovZlO/k9V3hjVUF/zwW7KBVdSK4gIt/bzwS9MbR5qob+F5jusZsb0YQK2A==",
"dev": true
},
"node_modules/byline": {
"version": "5.0.0",
"resolved": "https://registry.npmjs.org/byline/-/byline-5.0.0.tgz",
"integrity": "sha1-dBxSFkaOrcRXsDQQEYrXfejB3bE=",
"engines": {
"node": ">=0.10.0"
}
},
"node_modules/bytes": {
"version": "3.1.0",
"resolved": "https://registry.npmjs.org/bytes/-/bytes-3.1.0.tgz",
@ -6256,11 +6247,6 @@
"integrity": "sha512-MQcXEUbCKtEo7bhqEs6560Hyd4XaovZlO/k9V3hjVUF/zwW7KBVdSK4gIt/bzwS9MbR5qob+F5jusZsb0YQK2A==",
"dev": true
},
"byline": {
"version": "5.0.0",
"resolved": "https://registry.npmjs.org/byline/-/byline-5.0.0.tgz",
"integrity": "sha1-dBxSFkaOrcRXsDQQEYrXfejB3bE="
},
"bytes": {
"version": "3.1.0",
"resolved": "https://registry.npmjs.org/bytes/-/bytes-3.1.0.tgz",

@ -0,0 +1,207 @@
/* eslint-env mocha */
// Copyright (C) 2013-2015 John Hewson
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to
// deal in the Software without restriction, including without limitation the
// rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
// sell copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
// FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
// IN THE SOFTWARE.
const chai = require('chai')
const fs = require('fs')
const path = require('path')
const byline = require('../lib/byline')
const { assert } = chai
const regEx = /\r\n|[\n\v\f\r\x85\u2028\u2029]/g
const localPath = file => path.join(__dirname, file)
describe('byline', function () {
it('should pipe a small file', function (done) {
const input = fs.createReadStream(localPath('byline/empty.txt'))
const lineStream = byline(input) // convinience API
const output = fs.createWriteStream(localPath('byline/test.txt'))
lineStream.pipe(output)
output.on('close', function () {
const out = fs.readFileSync(localPath('byline/test.txt'), 'utf8')
const in_ = fs.readFileSync(localPath('byline/empty.txt'), 'utf8').replace(/\n/g, '')
assert.equal(in_, out)
fs.unlinkSync(localPath('byline/test.txt'))
done()
})
})
it('should work with streams2 API', function (done) {
let stream = fs.createReadStream(localPath('byline/empty.txt'))
stream = byline.createStream(stream)
stream.on('readable', function () {
while (stream.read() !== null) {
// eslint-ignore-line no-empty
}
})
stream.on('end', function () {
done()
})
})
it('should ignore empty lines by default', function (done) {
const input = fs.createReadStream(localPath('byline/empty.txt'))
const lineStream = byline(input)
lineStream.setEncoding('utf8')
const lines1 = []
lineStream.on('data', function (line) {
lines1.push(line)
})
lineStream.on('end', function () {
let lines2 = fs.readFileSync(localPath('byline/empty.txt'), 'utf8').split(regEx)
lines2 = lines2.filter(function (line) {
return line.length > 0
})
assert.deepEqual(lines2, lines1)
done()
})
})
it('should keep empty lines when keepEmptyLines is true', function (done) {
const input = fs.createReadStream(localPath('byline/empty.txt'))
const lineStream = byline(input, { keepEmptyLines: true })
lineStream.setEncoding('utf8')
const lines = []
lineStream.on('data', function (line) {
lines.push(line)
})
lineStream.on('end', function () {
assert.deepEqual(['', '', '', '', '', 'Line 6'], lines)
done()
})
})
it('should not split a CRLF which spans two chunks', function (done) {
const input = fs.createReadStream(localPath('byline/CRLF.txt'))
const lineStream = byline(input, { keepEmptyLines: true })
lineStream.setEncoding('utf8')
const lines = []
lineStream.on('data', function (line) {
lines.push(line)
})
lineStream.on('end', function () {
assert.equal(2, lines.length)
done()
})
})
it('should read a large file', function (done) {
readFile(localPath('byline/rfc.txt'), done)
})
it('should read a huge file', function (done) {
// Readable highWaterMark is 16384, so we test a file with more lines than this
readFile(localPath('byline/rfc_huge.txt'), done)
})
function readFile (filename, done) {
const input = fs.createReadStream(filename)
const lineStream = byline(input)
lineStream.setEncoding('utf8')
let lines2 = fs.readFileSync(filename, 'utf8').split(regEx)
lines2 = lines2.filter(function (line) {
return line.length > 0
})
const lines1 = []
let i = 0
lineStream.on('data', function (line) {
lines1.push(line)
if (line !== lines2[i]) {
console.log('EXPECTED:', lines2[i])
console.log(' GOT:', line)
assert.fail(null, null, 'difference at line ' + (i + 1))
}
i++
})
lineStream.on('end', function () {
assert.equal(lines2.length, lines1.length)
assert.deepEqual(lines2, lines1)
done()
})
}
it('should handle encodings like fs', function (done) {
areStreamsEqualTypes(undefined, function () {
areStreamsEqualTypes({ encoding: 'utf8' }, function () {
done()
})
})
})
it('should pause() and resume() with a huge file', function (done) {
const input = fs.createReadStream(localPath('byline/rfc_huge.txt'))
const lineStream = byline(input)
lineStream.setEncoding('utf8')
let lines2 = fs.readFileSync(localPath('byline/rfc_huge.txt'), 'utf8').split(regEx)
lines2 = lines2.filter(function (line) {
return line.length > 0
})
const lines1 = []
let i = 0
lineStream.on('data', function (line) {
lines1.push(line)
if (line !== lines2[i]) {
console.log('EXPECTED:', lines2[i])
console.log(' GOT:', line)
assert.fail(null, null, 'difference at line ' + (i + 1))
}
i++
// pause/resume
lineStream.pause()
setImmediate(function () {
lineStream.resume()
})
})
lineStream.on('end', function () {
assert.equal(lines2.length, lines1.length)
assert.deepEqual(lines2, lines1)
done()
})
})
function areStreamsEqualTypes (options, callback) {
const fsStream = fs.createReadStream(localPath('byline/empty.txt'), options)
const lineStream = byline(fs.createReadStream(localPath('byline/empty.txt'), options))
fsStream.on('data', function (data1) {
lineStream.on('data', function (data2) {
assert.equal(Buffer.isBuffer(data1), Buffer.isBuffer(data2))
})
lineStream.on('end', function () {
callback()
})
})
}
})

@ -1,214 +0,0 @@
// Copyright (C) 2013-2015 John Hewson
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to
// deal in the Software without restriction, including without limitation the
// rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
// sell copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in
// all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
// FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
// IN THE SOFTWARE.
var assert = require("assert"),
fs = require('fs'),
byline = require('../lib/byline'),
request = require('request');
var regEx = /\r\n|[\n\v\f\r\x85\u2028\u2029]/g;
describe('byline', function() {
it('should pipe a small file', function(done) {
var input = fs.createReadStream('LICENSE');
var lineStream = byline(input); // convinience API
var output = fs.createWriteStream('test.txt');
lineStream.pipe(output);
output.on('close', function() {
var out = fs.readFileSync('test.txt', 'utf8');
var in_ = fs.readFileSync('LICENSE', 'utf8').replace(/\n/g, '');
assert.equal(in_, out);
fs.unlinkSync('test.txt');
done();
});
});
it('should work with streams2 API', function(done) {
var stream = fs.createReadStream('LICENSE');
stream = byline.createStream(stream);
stream.on('readable', function() {
var line;
while (null !== (line = stream.read())) {
}
});
stream.on('end', function() {
done();
});
});
it('should ignore empty lines by default', function(done) {
var input = fs.createReadStream('test/empty.txt');
var lineStream = byline(input);
lineStream.setEncoding('utf8');
var lines1 = [];
lineStream.on('data', function(line) {
lines1.push(line);
});
lineStream.on('end', function() {
var lines2 = fs.readFileSync('test/empty.txt', 'utf8').split(regEx);
lines2 = lines2.filter(function(line) {
return line.length > 0;
});
assert.deepEqual(lines2, lines1);
done();
});
});
it('should keep empty lines when keepEmptyLines is true', function(done) {
var input = fs.createReadStream('test/empty.txt');
var lineStream = byline(input, { keepEmptyLines: true });
lineStream.setEncoding('utf8');
var lines = [];
lineStream.on('data', function(line) {
lines.push(line);
});
lineStream.on('end', function() {
assert.deepEqual([ '', '', '', '', '', 'Line 6' ], lines);
done();
});
});
it('should not split a CRLF which spans two chunks', function(done) {
var input = fs.createReadStream('test/CRLF.txt');
var lineStream = byline(input, { keepEmptyLines: true });
lineStream.setEncoding('utf8');
var lines = [];
lineStream.on('data', function(line) {
lines.push(line);
});
lineStream.on('end', function() {
assert.equal(2, lines.length);
done();
});
});
it('should read a large file', function(done) {
readFile('test/rfc.txt', done);
});
it('should read a huge file', function(done) {
// Readable highWaterMark is 16384, so we test a file with more lines than this
readFile('test/rfc_huge.txt', done);
});
function readFile(filename, done) {
var input = fs.createReadStream(filename);
var lineStream = byline(input);
lineStream.setEncoding('utf8');
var lines2 = fs.readFileSync(filename, 'utf8').split(regEx);
lines2 = lines2.filter(function(line) {
return line.length > 0;
});
var lines1 = [];
var i = 0;
lineStream.on('data', function(line) {
lines1.push(line);
if (line != lines2[i]) {
console.log('EXPECTED:', lines2[i]);
console.log(' GOT:', line);
assert.fail(null, null, 'difference at line ' + (i + 1));
}
i++;
});
lineStream.on('end', function() {
assert.equal(lines2.length, lines1.length);
assert.deepEqual(lines2, lines1);
done();
});
}
it('should handle encodings like fs', function(done) {
areStreamsEqualTypes(undefined, function() {
areStreamsEqualTypes({ encoding: 'utf8' }, function() {
done();
});
});
});
it('should work with old-style streams', function(done) {
var stream = byline(request.get('http://www.google.com'));
stream.on('data',function (data) {
});
stream.on('end',function () {
done();
});
});
it('should pause() and resume() with a huge file', function(done) {
var input = fs.createReadStream('test/rfc_huge.txt');
var lineStream = byline(input);
lineStream.setEncoding('utf8');
var lines2 = fs.readFileSync('test/rfc_huge.txt', 'utf8').split(regEx);
lines2 = lines2.filter(function(line) {
return line.length > 0;
});
var lines1 = [];
var i = 0;
lineStream.on('data', function(line) {
lines1.push(line);
if (line != lines2[i]) {
console.log('EXPECTED:', lines2[i]);
console.log(' GOT:', line);
assert.fail(null, null, 'difference at line ' + (i + 1));
}
i++;
// pause/resume
lineStream.pause();
setTimeout(function() {
lineStream.resume();
}, 0);
});
lineStream.on('end', function() {
assert.equal(lines2.length, lines1.length);
assert.deepEqual(lines2, lines1);
done();
});
});
function areStreamsEqualTypes(options, callback) {
var fsStream = fs.createReadStream('LICENSE', options);
var lineStream = byline(fs.createReadStream('LICENSE', options));
fsStream.on('data', function(data1) {
lineStream.on('data', function(data2) {
assert.equal(Buffer.isBuffer(data1), Buffer.isBuffer(data2));
});
lineStream.on('end', function() {
callback();
});
});
}
});
Loading…
Cancel
Save