Merge pull request #11997 from opf/bug/45945-file-linking-modal-bahaves-bad-on-group-folders

[#45945] File linking modal bahaves bad on group folders

frontend/src/app/shared/components/storages/file-picker-modal/file-picker-modal.component.ts

@@ -149,6 +149,7 @@ export class FilePickerModalComponent extends FilePickerBaseModalComponent {
       this.isAlreadyLinked(file),
       index === 0,
       this.enterDirectoryCallback(file),
+      false,
       this.tooltip(file),
       {
         selected: this.selection.has(file.id as string),

frontend/src/app/shared/components/storages/location-picker-modal/location-picker-modal.component.ts

@@ -113,11 +113,16 @@ export class LocationPickerModalComponent extends FilePickerBaseModalComponent {
       !isDirectory(file),
       index === 0,
       this.enterDirectoryCallback(file),
+      this.isConstrained(file),
       this.tooltip(file),
       undefined,
     );
   }
 
+  private isConstrained(file:IStorageFile):boolean {
+    return !file.permissions.some((permission) => permission === 'writeable');
+  }
+
   private tooltip(file:IStorageFile):string|undefined {
     if (isDirectory(file)) {
       return file.permissions.some((permission) => permission === 'writeable')

frontend/src/app/shared/components/storages/storage-file-list-item/storage-file-list-item.html

@@ -13,7 +13,7 @@
     data-qa-selector="op-files-picker-modal--list-item"
     [ngClass]="{
       'spot-list--item-action_disabled': content.disabled,
-      'op-file-list--item-action_view-not-allowed': !content.isWriteable
+      'op-file-list--item-action_view-not-allowed': content.isConstrained
     }"
   >
     <spot-checkbox

frontend/src/app/shared/components/storages/storage-file-list-item/storage-file-list-item.ts

@@ -63,20 +63,13 @@ export class StorageFileListItem {
     return isDirectory(this.storageFile);
   }
 
-  get isWriteable():boolean {
-    return this.storageFile.permissions.some((permission) => permission === 'writeable');
-  }
-
-  get isReadable():boolean {
-    return this.storageFile.permissions.some((permission) => permission === 'readable');
-  }
-
   constructor(
     private readonly timezoneService:TimezoneService,
     private readonly storageFile:IStorageFile,
     public readonly disabled:boolean,
     public readonly isFirst:boolean,
     public readonly enterDirectory:() => void,
+    public readonly isConstrained:boolean,
     public readonly tooltip?:string,
     public readonly checkbox?:StorageFileListItemCheckbox,
   ) {}