[#41851] Blank Email reminders page when creating account manually

bug/41851-blank-email-reminders-page-when-creating-account-manually
Dmitrii 2 years ago
parent 4016bba93b
commit 0708687ad5
  1. 19
      app/controllers/account_controller.rb
  2. 1
      spec/controllers/account_controller_spec.rb

@ -299,20 +299,19 @@ class AccountController < ApplicationController
def registration_through_invitation! def registration_through_invitation!
session[:auth_source_registration] = nil session[:auth_source_registration] = nil
if @user.nil? @user = Users::SetAttributesService.new(
@user = User.new(language: Setting.default_language) model: @user || User.new, user: current_user,
elsif user_with_placeholder_name?(@user) contract_class: @user.nil? ? Users::CreateContract : Users::UpdateContract
# force user to give their name ).call(@user.nil? ? { language: Setting.default_language } : { firstname: nil, lastname: nil })
@user.firstname = nil .result
@user.lastname = nil
end
end end
def self_registration! def self_registration!
if @user.nil? if @user.nil?
@user = User.new @user = Users::SetAttributesService
@user.admin = false .new(model: User.new, user: current_user, contract_class: Users::CreateContract)
@user.register .call(admin: false, status: User.statuses[:registered])
.result
end end
return if enforce_activation_user_limit(user: user_with_email(@user)) return if enforce_activation_user_limit(user: user_with_email(@user))

@ -562,6 +562,7 @@ describe AccountController, type: :controller do
expect(subject).to respond_with :success expect(subject).to respond_with :success
expect(response).to render_template :register expect(response).to render_template :register
expect(assigns[:user]).not_to be_nil expect(assigns[:user]).not_to be_nil
expect(assigns[:user].notification_settings.size).to eq(1)
end end
end end

Loading…
Cancel
Save