version view check for defining project

frontend/app/services/version-service.js

@@ -29,6 +29,8 @@
 module.exports = function($http, PathHelper) {
 
   var VersionService = {
+
+    // TODO: check if code invoked anywere
     getVersions: function(projectIdentifier) {
       var url;
 
@@ -46,6 +48,12 @@ module.exports = function($http, PathHelper) {
         .then(function(response){
           return _.sortBy(response.data.versions, 'name');
         });
+    },
+
+    isVersionFieldViewable: function (workPackage, fieldName) {
+      return workPackage.links[fieldName].fetch().then(function(response) {
+        return response.links.definingProject && response.links.definingProject.href;
+      });
     }
   };
 

frontend/app/templates/components/inplace_editor/display/user.html

@@ -1 +1,2 @@
-<user-field user="readValue"></user-field>
+<span ng-if="!readValue.props">{{ readValue }}</span>
+<user-field ng-if="readValue.props" user="readValue"></user-field>

frontend/app/templates/components/inplace_editor/display/version.html

@@ -1,8 +1,9 @@
-<span ng-if="entity.links.version.href">
+<span ng-if="!readValue.props">{{ readValue }}</span>
-  <a href="{{pathHelper.versionPath(entity.embedded.version.props.id)}}">
+<span ng-if="readValue.props && isVersionFieldViewable">
-    {{entity.links.version.props.title}}
+  <a href="{{pathHelper.versionPath(readValue.props.id)}}">
+    {{readValue.props.name}}
   </a>
 </span>
-<span ng-if="!entity.links.version.href">
+<span ng-if="readValue.props && !isVersionFieldViewable">
-  {{readValue}}
+  {{readValue.props.name}}
 </span>

frontend/app/ui_components/index.js

@@ -81,7 +81,14 @@ angular.module('openproject.uiComponents')
       'OverviewTabInplaceEditorConfig',
       require('./inplace-editor-directive')
   ])
-  .service('InplaceEditorDispatcher', require('./inplace-editor-dispatcher'))
+  .service('InplaceEditorDispatcher', [
+    '$sce',
+    '$http',
+    '$timeout',
+    'AutoCompleteHelper',
+    'TextileService',
+    'VersionService',
+    require('./inplace-editor-dispatcher')])
   .directive('modal', [require('./modal-directive')])
   .directive('modalLoading', ['I18n', require('./modal-loading-directive')])
   .directive('progressBar', ['I18n', require('./progress-bar-directive')])

frontend/app/ui_components/inplace-editor-dispatcher.js

@@ -26,7 +26,7 @@
 // See doc/COPYRIGHT.rdoc for more details.
 //++
 
-module.exports = function($sce, $http, $timeout, AutoCompleteHelper, TextileService) {
+module.exports = function($sce, $http, $timeout, AutoCompleteHelper, TextileService, VersionService) {
 
   function enableAutoCompletion(element) {
     var textarea = element.find('.inplace-edit--write-value input, .inplace-edit--write-value textarea');
@@ -214,8 +214,13 @@ module.exports = function($sce, $http, $timeout, AutoCompleteHelper, TextileServ
         if ($scope.isEditable && isOptionListEmbedded($scope)) {
           this._setEmbeddedOptions($scope);
         }
-        if ($scope.displayStrategy == 'user' || $scope.displayStrategy == 'version') {
+        if ($scope.displayStrategy === 'user' || $scope.displayStrategy === 'version') {
           $scope.readValue = $scope.entity.embedded[$scope.attribute];
+          if ($scope.displayStrategy === 'version') {
+            VersionService.isVersionFieldViewable($scope.entity, getAttribute($scope)).then(function(isViewable) {
+              $scope.isVersionFieldViewable = isViewable;
+            });
+          }
         } else {
           $scope.readValue = this._getReadAttributeValue($scope);
         }