Merge pull request #71 from oliverguenther/fix/hide_menu_item_anonymous

Hide cost reports from anonymous users when authentication is required
9 years ago · 3632b91247
parent ba9b7ea3b9 465aa19f90
commit 3632b91247
1 changed files with 7 additions and 5 deletions
--- a/lib/open_project/reporting/engine.rb
+++ b/lib/open_project/reporting/engine.rb
@ -48,7 +48,9 @@ module OpenProject::Reporting
      menu :top_menu, :cost_reports_global, {controller: '/cost_reports', action: 'index', project_id: nil},
        caption: :cost_reports_title,
        if: Proc.new {
-          ( User.current.allowed_to?(:view_time_entries, nil, global: true) ||
+          (User.current.logged? || !Setting.login_required?) &&
+            (
+              User.current.allowed_to?(:view_time_entries, nil, global: true) ||
              User.current.allowed_to?(:view_own_time_entries, nil, global: true) ||
              User.current.allowed_to?(:view_cost_entries, nil, global: true) ||
              User.current.allowed_to?(:view_own_cost_entries, nil, global: true)