Merge pull request #6897 from opf/fix/filter-alignment

[29126] Advanced filters alignment
pull/6906/head
Henriette Dinger 6 years ago committed by GitHub
commit 3aeada9a0e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 15
      app/assets/stylesheets/content/_advanced_filters.sass
  2. 3
      app/assets/stylesheets/content/_projects_list.sass
  3. 2
      app/assets/stylesheets/content/_simple_filters.sass
  4. 2
      app/views/projects/filters/_form.html.erb

@ -28,7 +28,7 @@
.advanced-filters--container .advanced-filters--container
@extend %filters--container @extend %filters--container
padding: rem-calc(10px) padding: 1rem
max-height: 50vh max-height: 50vh
overflow-y: auto overflow-y: auto
position: relative position: relative
@ -47,11 +47,11 @@
list-style-type: none list-style-type: none
margin: 20px 0 0 0 margin: 20px 0 0 0
> li > li:not(.advanced-filters--controls)
display: grid display: grid
// Filters will not span the whole width, // Filters will not span the whole width,
// but have an orientation to the left side // but have an orientation to the left side
grid-template-columns: 20% 20% 25% grid-template-columns: 20% 20% 25% 50px
grid-gap: 10px grid-gap: 10px
align-items: center align-items: center
margin-bottom: 10px margin-bottom: 10px
@ -89,7 +89,6 @@
@extend .advanced-filters--affix, .tooltip--right @extend .advanced-filters--affix, .tooltip--right
.advanced-filters--remove-filter .advanced-filters--remove-filter
grid-column: -1
text-align: right text-align: right
a a
@ -129,9 +128,15 @@ fieldset#date-range p
grid-gap: 0 10px grid-gap: 0 10px
.advanced-filters--filter-name, .advanced-filters--filter-name,
.advanced-filters--add-filter-label .advanced-filters--add-filter-label,
.advanced-filters--add-filter-value
// Span over entire width
grid-column: 1 / -1 grid-column: 1 / -1
.advanced-filters--remove-filter
// Align at the end of the container
grid-column: -1
.advanced-filters--filter-operator, .advanced-filters--filter-operator,
.advanced-filters--filter-value .advanced-filters--filter-value
grid-column: span 2 grid-column: span 2

@ -80,10 +80,7 @@ form.project-filters
max-width: 10rem max-width: 10rem
.advanced-filters--controls .advanced-filters--controls
margin-left: 1rem
margin-right: 1rem
margin-top: 1rem margin-top: 1rem
margin-bottom: 1rem
.projects-table--hierarchy-icon .projects-table--hierarchy-icon
display: none display: none

@ -80,7 +80,7 @@ $filters--border-color: $gray !default
.simple-filters--controls .simple-filters--controls
grid-column: 1 / -1 grid-column: 1 / -1
margin-top: 10px margin-top: 1rem
.simple-filters--filter-name .simple-filters--filter-name
@include text-shortener @include text-shortener

@ -88,7 +88,7 @@
<% end %> <% end %>
</li> </li>
<li class="advanced-filters--controls"> <li class="advanced-filters--controls">
<%= submit_tag t('button_apply'), class: 'button -highlight', name: nil %> <%= submit_tag t('button_apply'), class: 'button -small -highlight', name: nil %>
</li> </li>
</ul> </ul>
</fieldset> </fieldset>

Loading…
Cancel
Save