Merge pull request #2231 from opf/fix/17403_implement_collection_specification
17403 implement collection specificationpull/2242/head
ulferts
10 years ago
commit
8c9cfd3383
@ -1,21 +1,4 @@ |
||||
RSpec.shared_examples 'status collection representer' do |
||||
RSpec.shared_context 'status collection representer' do |self_link| |
||||
let(:statuses) { FactoryGirl.build_list(:status, 3) } |
||||
let(:representer) { described_class.new(statuses) } |
||||
|
||||
context 'generation' do |
||||
subject(:generated) { representer.to_json } |
||||
|
||||
it { should include_json('Statuses'.to_json).at_path('_type') } |
||||
|
||||
it { should have_json_type(Object).at_path('_links') } |
||||
it 'should link to self' do |
||||
expect(subject).to have_json_path('_links/self/href') |
||||
end |
||||
|
||||
describe 'statuses' do |
||||
it { should have_json_path('_embedded/statuses') } |
||||
it { should have_json_size(3).at_path('_embedded/statuses') } |
||||
it { should have_json_path('_embedded/statuses/2/name') } |
||||
end |
||||
end |
||||
let(:representer) { described_class.new(statuses, 42, self_link) } |
||||
end |
||||
|
||||
@ -1,98 +0,0 @@ |
||||
#-- encoding: UTF-8 |
||||
#-- copyright |
||||
# OpenProject is a project management system. |
||||
# Copyright (C) 2012-2014 the OpenProject Foundation (OPF) |
||||
# |
||||
# This program is free software; you can redistribute it and/or |
||||
# modify it under the terms of the GNU General Public License version 3. |
||||
# |
||||
# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows: |
||||
# Copyright (C) 2006-2013 Jean-Philippe Lang |
||||
# Copyright (C) 2010-2013 the ChiliProject Team |
||||
# |
||||
# This program is free software; you can redistribute it and/or |
||||
# modify it under the terms of the GNU General Public License |
||||
# as published by the Free Software Foundation; either version 2 |
||||
# of the License, or (at your option) any later version. |
||||
# |
||||
# This program is distributed in the hope that it will be useful, |
||||
# but WITHOUT ANY WARRANTY; without even the implied warranty of |
||||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
||||
# GNU General Public License for more details. |
||||
# |
||||
# You should have received a copy of the GNU General Public License |
||||
# along with this program; if not, write to the Free Software |
||||
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. |
||||
# |
||||
# See doc/COPYRIGHT.rdoc for more details. |
||||
#++ |
||||
|
||||
require 'spec_helper' |
||||
require 'rack/test' |
||||
|
||||
describe API::V3::WorkPackages::StatusesAPI do |
||||
include Rack::Test::Methods |
||||
|
||||
def app |
||||
API::V3::Root |
||||
end |
||||
|
||||
let(:authorized_user) do |
||||
FactoryGirl.create(:user, member_in_project: project, |
||||
member_through_role: authorized_role) |
||||
end |
||||
|
||||
let(:unauthorized_user) do |
||||
FactoryGirl.create(:user, member_in_project: project, |
||||
member_through_role: unauthorized_role) |
||||
end |
||||
let(:authorized_role) { FactoryGirl.create(:role, permissions: [:edit_work_packages]) } |
||||
let(:unauthorized_role) { FactoryGirl.create(:role, permissions: []) } |
||||
let(:project) { FactoryGirl.create(:valid_project, is_public: false) } |
||||
let(:work_package) do |
||||
FactoryGirl.create(:work_package, project: project) |
||||
end |
||||
let(:status) do |
||||
FactoryGirl.create(:status) |
||||
end |
||||
|
||||
describe '#get work_packages/:id/available_statuses' do |
||||
let(:get_path) { "/api/v3/work_packages/#{work_package.id}/available_statuses" } |
||||
subject(:response) { last_response } |
||||
|
||||
context 'permitted user' do |
||||
let(:new_type) { project.types.first } |
||||
let(:new_status) { Status.where("id NOT IN (#{work_package.status.id})").first } |
||||
before do |
||||
allow(User).to receive(:current).and_return authorized_user |
||||
|
||||
FactoryGirl.create(:workflow, old_status: work_package.status, |
||||
new_status: new_status, |
||||
role: authorized_role, |
||||
type_id: new_type.id) |
||||
|
||||
get get_path, type: new_type.name |
||||
end |
||||
|
||||
it 'should respond with 200' do |
||||
expect(subject.status).to eql(200) |
||||
end |
||||
|
||||
it 'should return a json collection of all statuses' do |
||||
expect(parse_json(response.body, '_embedded/statuses/0/name')).to eql(new_status.name) |
||||
end |
||||
end |
||||
|
||||
context 'unauthorized user' do |
||||
before do |
||||
allow(User).to receive(:current).and_return unauthorized_user |
||||
|
||||
get get_path |
||||
end |
||||
|
||||
it 'should respond with 403' do |
||||
expect(subject.status).to eql(403) |
||||
end |
||||
end |
||||
end |
||||
end |
||||
Loading…
Reference in new issue